[dpdk-dev] [PATCH v9 0/7] export PMD infos

2016-07-04 Thread Thomas Monjalon
2016-07-04 12:41, Neil Horman: > On Mon, Jul 04, 2016 at 03:10:14PM +0200, Thomas Monjalon wrote: > > Hi Neil, > > > > I don't really understand why you don't accept I contribute to this > > patchset. More details below. > > > I don't object to your contribution to this patchset. What I object t

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 06:20:42PM +0530, Jerin Jacob wrote: > > > The former case will have issue as "hw" been used in "if" with > > > vtpci_with_feature. > > > > Oh, my bad. I overlooked it. Sorry for that! > > > > > OR > > > > > > if you meant just floating "struct virtio_hw *hw" without >

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 05:45:57PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote: > > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > > > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > > > > On Mon, Jul 04, 2016 at 02:06:27PM

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

2016-07-04 Thread Shreyansh jain
On Monday 04 July 2016 06:34 PM, Jan Viktorin wrote: > On Wed, 29 Jun 2016 15:12:07 +0530 > Shreyansh jain wrote: > >> Hi Jan, >> >> On Friday 06 May 2016 07:18 PM, Jan Viktorin wrote: >>> Signed-off-by: Jan Viktorin >>> --- >>> lib/librte_ether/rte_ethdev.c | 127 >>> +

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > > > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > > > > On Fri, Jul 01, 2016 at 04:46:36PM

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 08:26:30PM +0800, Yuanhan Liu wrote: > On Mon, Jul 04, 2016 at 05:45:57PM +0530, Jerin Jacob wrote: > > On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote: > > > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > > > > On Mon, Jul 04, 2016 at 04:42:32PM

[dpdk-dev] [PATCH] mbuf: make rearm_data address naturally aligned

2016-07-04 Thread Jerin Jacob
On Mon, May 23, 2016 at 01:19:46PM +0200, Olivier Matz wrote: > Hi, > > On 05/19/2016 05:50 PM, Thomas Monjalon wrote: > > 2016-05-19 19:05, Jerin Jacob: > >> On Thu, May 19, 2016 at 12:18:57PM +, Ananyev, Konstantin wrote: > On Thu, May 19, 2016 at 12:20:16AM +0530, Jerin Jacob wrote: >

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote: > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > > > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > > > > On Mon, Jul 04, 2016 at 03:36:48PM

[dpdk-dev] [PATCH v3 5/6] ena: fix memory management issue

2016-07-04 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 05:04:58PM +0200, Jan Medala wrote: > After allocating memzone it's required to zeroize memory in it. > Freeing memzone with function dedicated for memoryzones. > Can you provide a fixes line for this patch? > Signed-off-by: Alexander Matushevsky > Signed-off-by: Jakub P

[dpdk-dev] [PATCH] pdump: close client socket

2016-07-04 Thread Reshma Pattan
Close the client socket before returning on error. Coverity issue: 127555 Fixes: f3c1829130ac ("pdump: check missing home environment variable") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pdump/

[dpdk-dev] [PATCH v3 16/16] vfio: change VFIO init to be extendable

2016-07-04 Thread Jan Viktorin
We can now just OR the vfio_enabled sequentially and so adding new VFIO subsystems (vfio_platform) is possible. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/li

[dpdk-dev] [PATCH v3 15/16] vfio: initialize vfio out of the PCI subsystem

2016-07-04 Thread Jan Viktorin
The VFIO does not depend on the PCI anymore so it can be initialized out of the PCI subsystem. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal.c | 31 ++ lib/librte_eal/linuxapp/eal/eal_pci.c | 17 +--- lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v3 14/16] vfio: rename and generalize eal_pci_vfio_mp_sync

2016-07-04 Thread Jan Viktorin
The module eal_pci_vfio_mp_sync is quite generic so it shouldn't contain the "pci" string in its name. The internal functions don't need the pci_* prefix. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/Makefile | 4 ++-- lib/librte_eal/linuxapp/eal/eal_p

[dpdk-dev] [PATCH v3 13/16] vfio: make vfio_*_dma_map and iommu_types private

2016-07-04 Thread Jan Viktorin
There is no more reason to expose those definitions as nobody uses them. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 15 +-- lib/librte_eal/linuxapp/eal/eal_vfio.h | 11 --- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/libr

[dpdk-dev] [PATCH v3 12/16] vfio: fix typo in doc for vfio_setup_device

2016-07-04 Thread Jan Viktorin
Signed-off-by: Jan Viktorin Suggested-by: Anatoly Burakov Acked-by: John McNamara --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.h b/lib/librte_eal/linuxapp/eal/eal_vfio.h index d4532a5..4ca0fa

[dpdk-dev] [PATCH v3 11/16] vfio: move global vfio_cfg to eal_vfio.c

2016-07-04 Thread Jan Viktorin
The vfio_cfg is a module-global variable and so together with this variable, it is necessary to move functions: * pci_vfio_get_group_fd - renamed to vfio_get_group_fd - pci_* version removed (no other call in EAL) * pci_vfio_setup_device - renamed as vfio_setup_device * pci_vfio_enable -

[dpdk-dev] [PATCH v3 10/16] vfio: extract setup logic out of pci_vfio_map_resource

2016-07-04 Thread Jan Viktorin
The setup logic access the global vfio_cfg variable that will be moved in the following commits. We need to separate all accesses to this variable to a general code. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 85 +- 1 file changed, 49

[dpdk-dev] [PATCH v3 09/16] vfio: generalize pci_vfio_get_group_no

2016-07-04 Thread Jan Viktorin
Generalize the pci_vfio_get_group_no to not be PCI-specific. Move the general implementation to the eal_vfio.c as vfio_get_group_no and leave the original pci_vfio_get_group_no being a wrapper around this to preserve compilation issues. The pci_vfio_get_group_no function will be removed later. Sig

[dpdk-dev] [PATCH v3 08/16] vfio: generalize pci_vfio_get_container_fd

2016-07-04 Thread Jan Viktorin
The pci_vfio_get_container_fd is not PCI-specific. Move the implementation to the eal_vfio.c as vfio_get_container_fd. No other code seems to call this function. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - lib/librte_eal/linuxapp/eal/eal_pci_vfio.c

[dpdk-dev] [PATCH v3 07/16] vfio: move vfio-specific SOCKET_* constants

2016-07-04 Thread Jan Viktorin
The constants are not PCI-specific. Move them into the eal_vfio.h. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 7 --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 6 ++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v3 06/16] vfio: generalize pci_vfio_has_supported_extensions

2016-07-04 Thread Jan Viktorin
The pci_vfio_has_supported_extensions is not PCI-specific and it is a private function of the eal_pci_vfio.c. We just rename the function and make it available even for non-PCI devices. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36 +-

[dpdk-dev] [PATCH v3 05/16] vfio: generalize pci_vfio_set_iommu_type

2016-07-04 Thread Jan Viktorin
The pci_vfio_set_iommu_type is not PCI-specific and it is a private function of the eal_pci_vfio.c. We just rename the function and make it available even for non-PCI devices. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 25 + lib/librte_ea

[dpdk-dev] [PATCH v3 04/16] vfio: move vfio_iommu_type and dma_map functions to eal_vfio

2016-07-04 Thread Jan Viktorin
We make the iommu_types public temporarily here until the depending stuff is refactored. The iommu_types and dma_map functions will be changed to be private inside the eal_vfio module later. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/Makefile | 1 + lib/librte_eal/linuxap

[dpdk-dev] [PATCH v3 03/16] vfio: move common vfio constants to eal_vfio.h

2016-07-04 Thread Jan Viktorin
Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 7 --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c i

[dpdk-dev] [PATCH v3 02/16] vfio: move VFIO-specific stuff to eal_vfio.h

2016-07-04 Thread Jan Viktorin
The common VFIO definitions should be separated from the PCI-specific parts. Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 28 lib/librte_eal/linuxapp/eal/eal_vfio.h | 28 2 files changed, 28 insertions(

[dpdk-dev] [PATCH v3 01/16] vfio: fix include of eal_private.h to be local

2016-07-04 Thread Jan Viktorin
Signed-off-by: Jan Viktorin --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c index f91b924..8b7d53f 100644 --- a/lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH v3 00/16] Make VFIO support less dependent on PCI

2016-07-04 Thread Jan Viktorin
Hello, I've rebased the v2 of this patch set on top of the current master. It builds well for my setup (both VFIO enabled and disabled). Regards Jan v3: * 0012: Acked-by: John McNamara Jan Viktorin (16): vfio: fix include of eal_private.h to be local vfio: move VFIO-specific stuff to eal_

[dpdk-dev] [PATCH v2 3/3] virtio: add neon support

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 02:25:55PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 03:53:22PM +0800, Yuanhan Liu wrote: > > On Fri, Jul 01, 2016 at 04:46:38PM +0530, Jerin Jacob wrote: > > > Added neon based Rx vector implementation. > > > Selection of the new handler based neon availability at

[dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h to be local

2016-07-04 Thread Jan Viktorin
On Mon, 4 Jul 2016 10:22:08 + "Burakov, Anatoly" wrote: [...] > There's no patch cover letter so I'll reply to the first patch. I've done > some cursory testing with a NIC, nothing seems to be broken and the code > looks OK to me. So, once this patchset is rebased on latest master (patche

[dpdk-dev] [PATCH] examples/vm_power_manager: remove dependency on internal header file

2016-07-04 Thread Marvin Liu
Macro CHANNEL_CMDS_MAX_CPUS stand for the maximum number of cores controlled by virtual channels. This macro only be used in the example, so remove it from library to example header file. Signed-off-by: Marvin Liu diff --git a/examples/vm_power_manager/channel_manager.h b/examples/vm_power_mana

[dpdk-dev] [PATCH v3 3/6] ena: disable readless communication regarding to HW revision

2016-07-04 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 05:04:56PM +0200, Jan Medala wrote: > Depending on HW revision readless communcation between host and device > may be unavailable. > In that case prevent PMD of seting up readless communication mechanism. > The idea of readless communication is a strange one. Can you provid

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > > > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > > > { > > > uint8_t vtpci_qu

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

2016-07-04 Thread Jan Viktorin
On Mon, 4 Jul 2016 19:57:18 +0530 Shreyansh jain wrote: [...] > >>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct > >>> rte_eth_dev_info *dev_info) > >>> > >>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); > >>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); > >>

[dpdk-dev] [PATCH] pdump: close client socket

2016-07-04 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Monday, July 4, 2016 5:17 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH] pdump: close client socket > > Close the client socket before returning on error. > >

[dpdk-dev] [PATCH v9 0/7] export PMD infos

2016-07-04 Thread Bruce Richardson
On Mon, Jul 04, 2016 at 03:13:58AM +0200, Thomas Monjalon wrote: > This is a respin of the series from Neil. > It was planned to be integrated in 16.07-rc1 but the discovered issues > make a new revision needed. > There are still few things which could be improved but it is not mandatory > to fix t

[dpdk-dev] [PATCH v3] hash: new function to retrieve a key given its position

2016-07-04 Thread Yari Adan Petralanda
Sorry, didn't mentioned the changes introduced in v3: *) solves some tabs for whitespaces issues *) references the right DPDK version *) reduces the size of the rte_hash_create() argument in the unit tests Thanks!! On 07/04/2016 10:59 AM, Yari Adan Petralanda wrote: > The function rte_hash_get_k

[dpdk-dev] [PATCH v2 3/3] virtio: add neon support

2016-07-04 Thread Yuanhan Liu
On Fri, Jul 01, 2016 at 04:46:38PM +0530, Jerin Jacob wrote: > Added neon based Rx vector implementation. > Selection of the new handler based neon availability at runtime. > Updated the release notes and MAINTAINERS file. > > Signed-off-by: Jerin Jacob > --- > MAINTAINERS

[dpdk-dev] [PATCH] net/fm10k: fix Rx descriptor read timing

2016-07-04 Thread Wang Xiao W
We find that when traffic is light, a few amount of packets will be wrongly parsed (e.g. packet type), however this issue will not happen when traffic is heavy. The root cause is some fields in fm10k_rx_desc are read at wrong timing. When the input speed is slower than software's capability, fm10k

[dpdk-dev] [PATCH] doc: announce API change for virtual device initialization

2016-07-04 Thread Pablo de Lara
In order to create a virtual device, user needs to call rte_eal_vdev_init generally, but this function returns 0 on success or negative number if error. Instead, something more useful would be to return the port or device id of the device created, so the user can call rte_eal_vdev_init function and

[dpdk-dev] [PATCH v6 0/4] support reset of VF link

2016-07-04 Thread Luca Boccassi
On Mon, 2016-06-20 at 14:24 +0800, Wenzhuo Lu wrote: > If the PF link is down and up, VF link will not work accordingly. > This patch set addes the support of VF link reset. So, when VF > receices the messges of physical link down/up. APP can reset the > VF link and let it recover. > > PS: This pa

[dpdk-dev] [PATCH v2 2/3] virtio: move SSE based Rx implementation to separate file

2016-07-04 Thread Yuanhan Liu
On Fri, Jul 01, 2016 at 04:46:37PM +0530, Jerin Jacob wrote: > * Introduced cpuflag based run-time detection to > select the SSE based simple Rx handler > * Split out SSE instruction based virtio simple Rx > implementation to a separate file As your commit log says, it does two things, therefore,

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > { > uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX; > > -#ifdef RTE_MACHINE_CPUFLAG_SSSE3 > - struct virtio_hw *hw = dev->data->dev_p

[dpdk-dev] [PATCH v3 00/16] Make VFIO support less dependent on PCI

2016-07-04 Thread Burakov, Anatoly
> From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Monday, July 4, 2016 4:17 PM > To: dev at dpdk.org > Cc: Jan Viktorin ; Burakov, Anatoly > ; David Marchand > ; Wiles, Keith ; > Santosh Shukla ; Stephen Hemminger > ; Shreyansh Jain > > Subject: [PATCH v3 00/16] Make VFIO support le

[dpdk-dev] [PATCH v1 02/28] eal: extract function eal_parse_sysfs_valuef

2016-07-04 Thread Jan Viktorin
Hello Shreyansh, On Thu, 16 Jun 2016 11:47:29 + Shreyansh Jain wrote: > Sorry, didn't notice this email earlier... > Comments inline > > > -Original Message- > > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > > Sent: Wednesday, June 15, 2016 3:26 PM > > To: Shreyansh Jain

[dpdk-dev] [PATCH v9 0/7] export PMD infos

2016-07-04 Thread Thomas Monjalon
Hi Neil, I don't really understand why you don't accept I contribute to this patchset. More details below. 2016-07-04 08:34, Neil Horman: > On Mon, Jul 04, 2016 at 03:13:58AM +0200, Thomas Monjalon wrote: > > This is a respin of the series from Neil. > > It was planned to be integrated in 16.07-r

[dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h to be local

2016-07-04 Thread Burakov, Anatoly
> -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Monday, July 4, 2016 4:01 PM > To: Burakov, Anatoly > Cc: dev at dpdk.org; David Marchand ; Wiles, > Keith ; Santosh Shukla ; > Stephen Hemminger ; Shreyansh Jain > > Subject: Re: [PATCH v2 01/16] vfio:

[dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver

2016-07-04 Thread Jan Viktorin
On Wed, 29 Jun 2016 15:12:07 +0530 Shreyansh jain wrote: > Hi Jan, > > On Friday 06 May 2016 07:18 PM, Jan Viktorin wrote: > > Signed-off-by: Jan Viktorin > > --- > > lib/librte_ether/rte_ethdev.c | 127 > > +- > > lib/librte_ether/rte_ethdev.h | 31 ++

[dpdk-dev] [PATCH] mbuf: make rearm_data address naturally aligned

2016-07-04 Thread Olivier MATZ
Hi Jerin, On 07/04/2016 02:45 PM, Jerin Jacob wrote: > On Mon, May 23, 2016 at 01:19:46PM +0200, Olivier Matz wrote: >> Hi, >> >> On 05/19/2016 05:50 PM, Thomas Monjalon wrote: >>> 2016-05-19 19:05, Jerin Jacob: On Thu, May 19, 2016 at 12:18:57PM +, Ananyev, Konstantin wrote: >> On Th

[dpdk-dev] [PATCH 0/4] i40e: fix coverity defects

2016-07-04 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 03:34:16PM +0800, Beilei Xing wrote: > Fix some open coverity defects. > > Beilei Xing (4): > i40e: fix wrong operator > i40e: fix dereference before null check > i40e: fix out-of-bounds access > examples/tep_term: fix out-of-bounds access > > drivers/net/i40e/i40

[dpdk-dev] [PATCH v3] i40e: fix VLAN filter in promiscuous mode

2016-07-04 Thread Bruce Richardson
On Mon, Jul 04, 2016 at 06:33:30AM +, Zhang, Helin wrote: > > > > -Original Message- > > From: Wu, Jingjing > > Sent: Thursday, June 30, 2016 9:26 AM > > To: Zhang, Helin > > Cc: dev at dpdk.org; Wu, Jingjing; Yigit, Ferruh > > Subject: [PATCH v3] i40e: fix VLAN filter in promiscuous

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > > > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > > > > @@ -494,9 +486,6 @@ virtio_dev_tx_q

[dpdk-dev] Low packet generation rate of 526kpps using pktgen-dpdk from inside VM

2016-07-04 Thread Wiles, Keith
-Original Message- From: dev on behalf of Abhishek Mahajan Date: Monday, July 4, 2016 at 7:27 AM To: "dev at dpdk.org" Cc: "Addepalli, Srinivasa R" , "Shivastava, RakeshX" Subject: [dpdk-dev] Low packet generation rate of 526kpps using pktgen-dpdk from inside VM Hi, With pktgen-dpd

[dpdk-dev] [PATCH] bnx2x: Call bnx2x_init_rte() later

2016-07-04 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 08:01:24PM +, Rasesh Mody wrote: > > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > > Sent: Wednesday, June 29, 2016 3:59 AM > > > > On Tue, Jun 28, 2016 at 12:14:50PM -0400, Chas Williams wrote: > > > We need sc->igu_sb_cnt determined before calculatin

[dpdk-dev] [PATCH v2 3/3] virtio: add neon support

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 03:53:22PM +0800, Yuanhan Liu wrote: > On Fri, Jul 01, 2016 at 04:46:38PM +0530, Jerin Jacob wrote: > > Added neon based Rx vector implementation. > > Selection of the new handler based neon availability at runtime. > > Updated the release notes and MAINTAINERS file. > > >

[dpdk-dev] [PATCH v6 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params

2016-07-04 Thread Remy Horton
On 04/07/2016 12:36, Zyta Szpak wrote: > From: Zyta Szpak > > This change deals with hard-coded register width. > The app was allocating too little space for 64-bit registers > which resulted in memory corruption. This commit resolves > this by getting the number of registers and size of register

[dpdk-dev] [PATCH v6 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Remy Horton
On 04/07/2016 12:36, Zyta Szpak wrote: > From: Zyta Szpak > > Removes hard-coded assumption that device registers > are always 32 bits wide. The rte_eth_dev_get_reg_length > and rte_eth_dev_get_reg_info callbacks did not > provide register size to the app in any way while is > needed to allocate

[dpdk-dev] [PATCH] bnx2x: set random MAC address if one isn't assigned

2016-07-04 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 07:50:55PM +, Rasesh Mody wrote: > > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > > Sent: Wednesday, June 29, 2016 3:56 AM > > > > On Tue, Jun 21, 2016 at 08:18:46AM -0400, Chas Williams wrote: > > > If the PF hasn't assigned an address, assign one ra

[dpdk-dev] [PATCH v2 2/3] virtio: move SSE based Rx implementation to separate file

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 03:42:47PM +0800, Yuanhan Liu wrote: > On Fri, Jul 01, 2016 at 04:46:37PM +0530, Jerin Jacob wrote: > > * Introduced cpuflag based run-time detection to > > select the SSE based simple Rx handler > > * Split out SSE instruction based virtio simple Rx > > implementation to a

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > > { > > uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX; > > > > -#ifdef RT

[dpdk-dev] [PATCH] bnxt: Fix a bug in broadcast/multicast setting

2016-07-04 Thread Ajit Khaparde
Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous and multicast promiscuous settings from working correctly. This patch fixes it. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +--

[dpdk-dev] [PATCH v6 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params

2016-07-04 Thread Zyta Szpak
From: Zyta Szpak This change deals with hard-coded register width. The app was allocating too little space for 64-bit registers which resulted in memory corruption. This commit resolves this by getting the number of registers and size of register by rte_eth_dev_get_reg_info function called first

[dpdk-dev] [PATCH v6 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Zyta Szpak
From: Zyta Szpak Removes hard-coded assumption that device registers are always 32 bits wide. The rte_eth_dev_get_reg_length and rte_eth_dev_get_reg_info callbacks did not provide register size to the app in any way while is needed to allocate correct number of bytes before retrieving registers u

[dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Zyta Szpak
Very good point.. this one and the other :) THere comes fixed version. 2016-07-04 12:38 GMT+02:00 Remy Horton : > > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c >> @@ -934,7 +934,15 @@ static int cxgbe_get_regs(struct rte_eth_dev >> *eth_dev, >> struct port_info *pi = (struct port_info >> *)(et

[dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h to be local

2016-07-04 Thread Jan Viktorin
On Mon, 4 Jul 2016 10:22:08 + "Burakov, Anatoly" wrote: > > -Original Message- > > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > > Sent: Monday, June 13, 2016 2:02 PM > > To: dev at dpdk.org > > Cc: Jan Viktorin ; Burakov, Anatoly > > ; David Marchand > > ; Wiles, Keith ; >

[dpdk-dev] [PATCH] net/thunderx: fix start/stop with different queue size

2016-07-04 Thread Jerin Jacob
From: Kamil Rytarowski Allocate maximum supported hardware ring hardware descriptors memory on the first rte_eth_dma_zone_reserve call in-order to get sufficient hardware ring buffer space on subsequent queue setup request with different queue size. Fixes: aa0d976e501d ("net/thunderx: add Rx que

[dpdk-dev] [PATCH v9 0/7] export PMD infos

2016-07-04 Thread Neil Horman
On Mon, Jul 04, 2016 at 03:10:14PM +0200, Thomas Monjalon wrote: > Hi Neil, > > I don't really understand why you don't accept I contribute to this > patchset. More details below. > I don't object to your contribution to this patchset. What I object to is you making changes contrary to what I ju

[dpdk-dev] Low packet generation rate of 526kpps using pktgen-dpdk from inside VM

2016-07-04 Thread Abhishek Mahajan
Hi, With pktgen-dpdk inside VM, it is observed that packet TX rate (526Kpps with 64byte size) is very low. How can higher packet rates be achieved ? On enabling logs of virtio pmd in DPDK, getting following logs in syslogs: PMD: virtio_xmit_pkts() tx: No free tx descriptors to transmit Two PC s

[dpdk-dev] [PATCH v5 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params

2016-07-04 Thread Remy Horton
On 04/07/2016 07:51, Zyta Szpak wrote: > From: Zyta Szpak > > Version 4 of fixing the fixed register width assumption. > The app was allocating too little space for 64-bit registers > which resulted in memory corruption. This commit resolves > this by getting the number of registers and size of r

[dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Remy Horton
> +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > @@ -934,7 +934,15 @@ static int cxgbe_get_regs(struct rte_eth_dev *eth_dev, > struct port_info *pi = (struct port_info *)(eth_dev->data->dev_private); > struct adapter *adapter = pi->adapter; > > - regs->length = cxgbe_get_regs_len(eth_dev

[dpdk-dev] Redirect all packets to a specific VM pool

2016-07-04 Thread Mauricio Vásquez
Hello, I have a setup with SR-IOV where I want to forward all the packets to a specific VM pool. I found that in some Intel NICs it is possible to set a field called default pool. (Flag DEF_PL within the PFVTCTL register). In order to setup this using DPDK, I used the default_pool field in the rt

[dpdk-dev] [PATCH] examples/vhost: fix failure without hints

2016-07-04 Thread Yuanhan Liu
On Fri, Jul 01, 2016 at 08:50:31AM +, Jianfeng Tan wrote: > When the specified cores and memory lie on different numa socket with > physical NIC, vhost fails to set up rx queue, and exits without any > hints. This could leads to confusion of users. > > This patch fixes it by adding some error

[dpdk-dev] [PATCH v3] hash: new function to retrieve a key given its position

2016-07-04 Thread Yari Adan Petralanda
The function rte_hash_get_key_with_position is added in this patch. As the position returned when adding a key is frequently used as an offset into an array of user data, this function performs the operation of retrieving a key given this offset. A possible use case would be to delete a key from t

[dpdk-dev] [PATCH v3] doc: virtio PMD Rx/Tx callbacks

2016-07-04 Thread Yuanhan Liu
On Thu, Jun 30, 2016 at 11:28:01PM -0400, Zhihong Wang wrote: > This patch explains current virtio PMD Rx/Tx callbacks, to help understand > what's the difference, and how to enable the right ones. > > Signed-off-by: Zhihong Wang > Acked-by: John McNamara Applied to dpdk-next-virtio. > ---

[dpdk-dev] [PATCH] vhost: reset queue state in destroy_device

2016-07-04 Thread Yuanhan Liu
On Fri, Jul 01, 2016 at 09:31:12AM -0700, Rich Lane wrote: > Fixes a bug where rte_eth_vhost_get_queue_event would not return enabled > queues > after a guest application restart. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > Signed-off-by: Rich Lane Acked-by: Yuanhan Li

[dpdk-dev] [PATCH 3/3] net/mlx4: add link up/down callback function

2016-07-04 Thread Olivier Matz
From: Guo Fengtian Implement dev_set_link_up and dev_set_link_down device operations. Code is inspired from mlx5. Signed-off-by: Guo Fengtian --- drivers/net/mlx4/mlx4.c | 86 + 1 file changed, 86 insertions(+) diff --git a/drivers/net/mlx4/mlx4

[dpdk-dev] [PATCH 2/3] net/mlx5: fix api comment of link set function

2016-07-04 Thread Olivier Matz
Fixes: 62072098b54e ("mlx5: support setting link up or down") Signed-off-by: Olivier Matz --- drivers/net/mlx5/mlx5_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 6fef902..130e15d 100644 --- a/dri

[dpdk-dev] [PATCH 1/3] net/mlx: fix setting of interface flags

2016-07-04 Thread Olivier Matz
According to the documentation, the function priv_set_flags(priv, keep, flags) should not modify the flags in "keep" mask. So 'flags' argument should be masked with '~keep' before ORing it with the previous flags value. This avoids to mess the kernel interface flags when calling priv_set_flags(pr

[dpdk-dev] [PATCH 0/3] net/mlx: fix link state modification

2016-07-04 Thread Olivier Matz
This series adds a missing device operation in mlx4 to set the link state. It also fixes the function to set the flags on the kernel interface in both mlx4 and mlx5. Guo Fengtian (1): net/mlx4: add link up/down callback function Olivier Matz (2): net/mlx: fix setting of interface flags net/

[dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h to be local

2016-07-04 Thread Burakov, Anatoly
> -Original Message- > From: Jan Viktorin [mailto:viktorin at rehivetech.com] > Sent: Monday, June 13, 2016 2:02 PM > To: dev at dpdk.org > Cc: Jan Viktorin ; Burakov, Anatoly > ; David Marchand > ; Wiles, Keith ; > Santosh Shukla ; Stephen Hemminger > ; Shreyansh Jain > > Subject: [PATCH

[dpdk-dev] [PATCH v3] hash: new function to retrieve a key given its position

2016-07-04 Thread De Lara Guarch, Pablo
Hi Yari, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yari Adan > Petralanda > Sent: Monday, July 04, 2016 10:00 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3] hash: new function to retrieve a key given its > position > > The function rte_hash_

[dpdk-dev] [PATCH v5 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params

2016-07-04 Thread Zyta Szpak
From: Zyta Szpak Version 4 of fixing the fixed register width assumption. The app was allocating too little space for 64-bit registers which resulted in memory corruption. This commit resolves this by getting the number of registers and size of register by rte_eth_dev_get_reg_info function called

[dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Zyta Szpak
From: Zyta Szpak Removes hard-coded assumption that device registers are always 32 bits wide. The rte_eth_dev_get_reg_length and rte_eth_dev_get_reg_info callbacks did not provide register size to the app in any way while is needed to allocate correct number of bytes before retrieving registers u

[dpdk-dev] [PATCH v9 0/7] export PMD infos

2016-07-04 Thread Neil Horman
On Mon, Jul 04, 2016 at 03:13:58AM +0200, Thomas Monjalon wrote: > This is a respin of the series from Neil. > It was planned to be integrated in 16.07-rc1 but the discovered issues > make a new revision needed. > There are still few things which could be improved but it is not mandatory > to fix t

[dpdk-dev] [PATCH v3] i40e: fix VLAN filter in promiscuous mode

2016-07-04 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, June 30, 2016 9:26 AM > To: Zhang, Helin > Cc: dev at dpdk.org; Wu, Jingjing; Yigit, Ferruh > Subject: [PATCH v3] i40e: fix VLAN filter in promiscuous mode > > For VLAN filtering VLAN table should be enabled. > But VLAN table is

[dpdk-dev] [dpdk-announce] release candidate 16.07-rc1

2016-07-04 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v16.07-rc1 It is the first release candidate for DPDK 16.07. This version must be released before the end of July. Therefore we have 3 weeks to make the validation and fixes. The current release notes s

[dpdk-dev] [PATCH v9 7/7] tools: query binaries for support information

2016-07-04 Thread Thomas Monjalon
From: Neil Horman This tool searches for the primer string PMD_INFO_STRING= in any ELF binary, and, if found parses the remainder of the string as a json encoded string, outputting the results in either a human readable or raw, script parseable format. Note that, in the case of dynamically linke

[dpdk-dev] [PATCH v9 6/7] eal: export default plugin path to external tools

2016-07-04 Thread Thomas Monjalon
From: Neil Horman Export a symbol containing the string: DPDK_PLUGIN_PATH="$(CONFIG_RTE_EAL_PMD_PATH)" Where the latter half of the string is set at build time to a location from which autoloaded DSO's will be found. This string is used by dpdk-pmdinfo in 'plugin' mode, whereby a user can speci

[dpdk-dev] [PATCH v9 5/7] mk: link infos generated by pmdinfogen

2016-07-04 Thread Thomas Monjalon
Generate informations to export from objects which register a driver. The C code generated by dpdk-pmdinfogen is compiled and linked into the original object file. This effectively just adds the JSON string into the string table of the object that defines the PMD to the outside world. Signed-off-b

[dpdk-dev] [PATCH v9 4/7] pmdinfogen: parse driver to generate code to export

2016-07-04 Thread Thomas Monjalon
From: Neil Horman dpdk-pmdinfogen is a tool used to parse object files and build JSON strings for use in later determining hardware support in a DSO or application binary. dpdk-pmdinfogen looks for the non-exported symbol names rte_pmd_name (where n is a integer counter) and _pci_table_export. It

[dpdk-dev] [PATCH v9 3/7] mk: refresh recipe for any host application

2016-07-04 Thread Thomas Monjalon
Make the recipe simpler to use and build in configurable directory. HOSTAPP_DIR must be set before including rte.hostapp.mk. Remove LDLIBS_FILES as libraries should not be used in an hostapp. Remove the "INSTALL-HOSTAPP" and build directly in the right directory. Signed-off-by: Thomas Monjalon -

[dpdk-dev] [PATCH v9 2/7] mk: remove recipe for tool library

2016-07-04 Thread Thomas Monjalon
It is difficult to imagine why it could be needed to build a library for the build environment. If building a tool, rte.hostapp.mk should be sufficient. Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/dev_kit_build_system.rst | 2 - mk/rte.hostlib.mk | 116

[dpdk-dev] [PATCH v9 1/7] drivers: export infos as string symbols

2016-07-04 Thread Thomas Monjalon
From: Neil Horman Modify the PMD_REGISTER_DRIVER macro, adding a name argument to it. The addition of a name argument creates a token that can be used for subsequent macros in the creation of unique symbol names to export additional bits of information for use by the dpdk-pmdinfogen tool. For e

[dpdk-dev] [PATCH v9 0/7] export PMD infos

2016-07-04 Thread Thomas Monjalon
This is a respin of the series from Neil. It was planned to be integrated in 16.07-rc1 but the discovered issues make a new revision needed. There are still few things which could be improved but it is not mandatory to fix them for an integration in 16.07-rc2: - fix make clean after pmdinfogen

[dpdk-dev] [PATCH v3] doc: virtio PMD Rx/Tx callbacks

2016-07-04 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, July 4, 2016 10:57 AM > To: Wang, Zhihong > Cc: dev at dpdk.org; Richardson, Bruce ; > Mcnamara, > John > Subject: Re: [PATCH v3] doc: virtio PMD Rx/Tx callbacks > > On Thu, Jun 30, 2016 a