Hi Ethan,
Great work! There are still several comments below that need to be addressed,
but I am confident we can close on them quickly. Thank you!
Please rebase the next version on top of the latest code on master branch.
Please also update librte_port/rte_port_version.map file.
> -Origi
Looking a bit more into librte_ivshmem, the documentation says we need
a Qemu patch but the URL doesn't exist anymore:
https://01.org/packet-processing/intel%C2%AE-ovdk
-> 404 Oops, we couldn't find that page
I've never understood why we should keep this wart and now I'm going
to b
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> Sent: Thursday, June 9, 2016 6:47 PM
> To: dev at dpdk.org
> Cc: Neil Horman ; Richardson, Bruce
> ; Thomas Monjalon 6wind.com>;
> Stephen Hemminger ; Panu Matilainen
>
> Subject: [dpdk-dev] [PATC
> -Original Message-
> From: Aaron Conole [mailto:aconole at redhat.com]
> Sent: Thursday, June 09, 2016 6:24 PM
> To: Ananyev, Konstantin
> Cc: Pattan, Reshma; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library for
> packet capturing support
>
>
On Thu, Jun 09, 2016 at 02:18:57PM +0100, Hunt, David wrote:
>
>
> > > > As I mentioned earlier, My take is not to create the separate API's for
> > > > external mempool handlers.In my view, It's same, just that sepreate
> > > > mempool handler through function pointers.
> > > >
> > > > To keep
> -Original Message-
> From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com]
> Sent: Thursday, June 09, 2016 8:45 AM
> To: Thomas Monjalon
> Cc: dev at dpdk.org; Olivier Matz ; Adrien
> Mazarguil ; Zhang, Helin intel.com>
> Subject: Re: [dpdk-dev] [PATCH] mbuf: remove incon
On Thu, Jun 09, 2016 at 11:49:44AM +, Shreyansh Jain wrote:
> Hi Jerin,
Hi Shreyansh,
>
> > > Yes, this would simplify somewhat the creation of a pktmbuf pool, in that
> > it
> > > replaces
> > > the rte_mempool_set_ops_byname with a flag bit. However, I'm not sure we
> > > want
> > > to int
>
> This patch set include below changes
>
> 1)Changes to librte_ether.
> 2)A new library librte_pdump added for packet capture framework.
> 3)A new app/pdump tool added for packet capturing.
> 4)Test pmd changes done to initialize packet capture framework.
> 5)Documentation update.
>
> 1)librte
2016-06-09 13:21, Ananyev, Konstantin:
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> > Today:
> >
> > /* allowed */
> > m = rte_pktmbuf_alloc();
> > rte_pktmbuf_free(m);
> >
> > /* not allowed */
> > m = rte_mbuf_raw_alloc();
> > __rte_mbuf_raw_free(m);
> >
> > /* we sh
2016-06-09 16:54, Nikita Kozlov:
> On 06/ 9/16 02:58 AM, Stephen Hemminger wrote:
> > Please don't copy a header file which is available already on both BSD and
> > Linux.
> >
> I was quite hesitant on how to handle it. I had the feeling that dpdk
> wanted to avoid external dependency so I copied
Added programmers guide for librte_pdump.
Added sample application guide for app/pdump application.
Updated release note for packet capture framework changes.
Signed-off-by: Reshma Pattan
Acked-by: John McNamara
---
MAINTAINERS | 3 +
doc/guides/prog_guide/index.rs
Call rte_pdump_init and rte_pdump_uninit for packet
capturing initialization and uninitialization.
Signed-off-by: Reshma Pattan
---
app/test-pmd/testpmd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index dd6b046..f6089fa 100644
--- a
New tool added for packet capturing on dpdk.
This tool supports command line options.
This tool runs as secondary process by default.
Command line supports various parameters to capture
the packets.
User should pass on a)port and queue (or) b)pci address
and queue (or) c)device name and queue to
Added new library for packet capturing support.
Added public api rte_pdump_init, applications should call
this as part of their application setup to have packet
capturing framework ready.
Added public api rte_pdump_uninit to uninitialize the packet
capturing framework.
Added public apis rte_pdum
Converted rte_eth_dev_get_port_by_name to a public API.
Converted rte_eth_dev_get_name_by_port to a public API.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 4 ++--
lib/librte_ether/rte_ethdev.h | 29 +
lib/librte_ether/rte_ether
New fields nb_rx_queues and nb_tx_queues are added to
rte_eth_dev_info structure.
Changes to API rte_eth_dev_info_get() are done to update
these new fields to rte_eth_dev_info object.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 2 ++
lib/librte_ether/rte_ethdev.h
Added new public api rte_eth_add_first_rx_callback to add given
callback as head of list.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 35 ++
lib/librte_ether/rte_ethdev.h | 28 +++
lib/librte_ether/rte
Added spinlocks around add/remove logic of rxtx callbacks to
avoid corruption of callback lists in multithreaded context.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 82 +--
1 file changed, 40 insertions(+), 42 deletions(-)
diff --git
This patch set include below changes
1)Changes to librte_ether.
2)A new library librte_pdump added for packet capture framework.
3)A new app/pdump tool added for packet capturing.
4)Test pmd changes done to initialize packet capture framework.
5)Documentation update.
1)librte_pdump
==
> Just to confirm, should I do anything before it gets merged?
No. Looks good to me. Now you just need to wait. :-)
John.
On Wed, May 25, 2016 at 07:45:00PM -0700, John Daley wrote:
> If device configuration failed due to a lack of resources, like if
> there were more queues requested than available, the queue release
> function is called with NULL pointers which were being dereferenced.
>
> Skip releasing queues if
The log history uses rte_mempool. In order to remove the mempool
dependency in EAL (and improve the build), this feature is deprecated.
The ABI is kept but the behaviour is now voided because it seems this
function was not used. The history can be read from syslog.
When enabling the log history, a
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Thursday, June 9, 2016 4:45 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Doherty, Declan
> ; De Lara Guarch, Pablo
>
> Subject: [PATCH] doc: fix wrong supported feature table
>
> Some crypto PMDs that support symmetric crypto w
On Thu, May 26, 2016 at 11:01:57AM -0400, John W. Linville wrote:
> On Thu, May 26, 2016 at 03:47:59PM +0100, Ferruh Yigit wrote:
> > On 5/25/2016 10:03 PM, Rich Lane wrote:
> > > Signed-off-by: Rich Lane
> >
> > Reviewed-by: Ferruh Yigit
>
> Acked-by: John W. Linville
>
Applied to dpdk-next-
Hi,
in I totally like it - thanks Thomas for picking that up.
I just wanted to mention that the Makefile still refers to mempool, but
David beat me in time and Detail a lot.
I'll certainly try to follow and help the bit I can.
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
2016-06-09 16:45, David Marchand:
> On Thu, Jun 9, 2016 at 4:09 PM, Thomas Monjalon
> wrote:
> > The log history uses rte_mempool. In order to remove the mempool
> > dependency in EAL (and improve the build), this feature is deprecated.
> > The ABI is kept but the behaviour is now voided because i
The libraries rte_mempool and rte_ring are not used in EAL,
except rte_ring for the ivshmem part (CONFIG_RTE_LIBRTE_IVSHMEM).
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 --
lib/librte_eal/linuxapp/eal/eal_ivshmem.c| 1 -
2 files changed, 3 deletions(-
On Wed, May 25, 2016 at 01:28:06AM +0800, Zhe Tao wrote:
> To enable this feature, the user should pass a devargs parameter to the EAL
> like "-w 84:00.0,enable_floating=1", and the application will make sure the
> PMD
> will use the floating VEB feature for all the VFs created by this PF device.
On Wed, May 25, 2016 at 01:28:05AM +0800, Zhe Tao wrote:
> This patch add the support for floating VEB in i40e.
> All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or
> the floating VEB. When connect to the floating VEB a new floating VEB is
> created. Now all the VFs need to co
On 06/ 9/16 02:58 AM, Stephen Hemminger wrote:
> On Thu, 9 Jun 2016 02:53:53 +0200
> Nikita Kozlov wrote:
>
>> This structure is used inside the rte_lpm6 lib for storing added rules.
>> It's imported from FreeBSD-10.3 from /usr/include/sys/tree.h, another
>> solution could have been to use on Lin
On Wed, May 25, 2016 at 01:28:04AM +0800, Zhe Tao wrote:
> Add the new floating related argument option in the devarg.
> Using this parameter, all the samples can decide whether to use legacy
> VEB/VEPA
> or floating VEB.
> To enable this feature, the user should pass a devargs parameter to the EA
Thomas,
On Thu, Jun 9, 2016 at 4:09 PM, Thomas Monjalon
wrote:
> The log history uses rte_mempool. In order to remove the mempool
> dependency in EAL (and improve the build), this feature is deprecated.
> The ABI is kept but the behaviour is now voided because it seems this
> function was not use
Some crypto PMDs that support symmetric crypto were not marked
as supported in the supported feature flags table.
Fixes: 2373c0661b2f0 ("doc: add cryptodevs guide overview")
Signed-off-by: Pablo de Lara
---
doc/guides/cryptodevs/overview.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Fri, Jun 03, 2016 at 07:19:09AM +, Azarewicz, PiotrX T wrote:
> Hi,
>
> > --- a/drivers/net/i40e/i40e_rxtx_vec.c
> > +++ b/drivers/net/i40e/i40e_rxtx_vec.c
> > @@ -149,7 +149,7 @@ desc_to_olflags_v(__m128i descs[4], struct rte_mbuf
> > **rx_pkts)
> >
> > /* mask everything except rss an
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, June 9, 2016 4:45 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Doherty, Declan
> ; De Lara Guarch, Pablo
>
> Subject: [dpdk-dev] [PATCH] doc: fix wrong supported feature tabl
On Wed, Jun 08, 2016 at 04:08:37PM +0100, Bruce Richardson wrote:
> On Wed, Jun 08, 2016 at 03:42:14PM +0200, Thomas Monjalon wrote:
> > 2016-06-08 18:13, Jerin Jacob:
> > > On Wed, Jun 08, 2016 at 01:30:28PM +0100, Ferruh Yigit wrote:
> > > > Hi Jerin,
> > > >
> > > > In patch subject, as tag, ot
On Fri, May 20, 2016 at 03:03:36PM +0200, Slawomir Mrozowicz wrote:
> Suspicious implicit sign extension: pf->fdir.match_counter_index
> with type unsigned short (16 bits, unsigned) is promoted in
> pf->fdir.match_counter_index << 20 to type int (32 bits, signed),
> then sign-extended to type unsig
The log history uses rte_mempool. In order to remove the mempool
dependency in EAL (and improve the build), this feature is deprecated.
The ABI is kept but the behaviour is now voided because it seems this
function was not used. The history can be read from syslog.
Signed-off-by: Thomas Monjalon
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Aaron Conole
> Sent: Thursday, June 09, 2016 4:59 PM
> To: Pattan, Reshma
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library for
> packet capturing support
>
> Re
2016-06-09 16:19, Jerin Jacob:
> On Wed, Jun 08, 2016 at 04:08:37PM +0100, Bruce Richardson wrote:
> > On Wed, Jun 08, 2016 at 03:42:14PM +0200, Thomas Monjalon wrote:
> > > 2016-06-08 18:13, Jerin Jacob:
> > > > On Wed, Jun 08, 2016 at 01:30:28PM +0100, Ferruh Yigit wrote:
> > > > > Hi Jerin,
> >
On Thu, Jun 09, 2016 at 10:39:46AM +0100, Hunt, David wrote:
> Hi Shreyansh,
>
> On 8/6/2016 2:48 PM, Shreyansh Jain wrote:
> > Hi David,
> >
> > Thanks for explanation. I have some comments inline...
> >
> > > -Original Message-
> > > From: Hunt, David [mailto:david.hunt at intel.com]
>
"Ananyev, Konstantin" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:aconole at redhat.com]
>> Sent: Thursday, June 09, 2016 6:24 PM
>> To: Ananyev, Konstantin
>> Cc: Pattan, Reshma; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new
>> librar
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, June 09, 2016 4:28 PM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org; Olivier Matz; Adrien Mazarguil; Zhang, Helin
> Subject: Re: [dpdk-dev] [PATCH] mbuf: remove inconsistent assert statem
On Mon, May 23, 2016 at 01:33:42AM +, Wu, Jingjing wrote:
>
>
> > -Original Message-
> > From: Xing, Beilei
> > Sent: Friday, May 20, 2016 11:17 PM
> > To: Wu, Jingjing
> > Cc: dev at dpdk.org; Xing, Beilei
> > Subject: [PATCH v4] i40e: configure MTU
> >
> > This patch enables config
On Thu, Jun 09, 2016 at 01:21:18PM +, Ananyev, Konstantin wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> > Sent: Thursday, June 09, 2016 8:47 AM
> > To: Ananyev, Konstantin; dev at dpdk.org; Adrien Mazarguil
> > Subject: Re: [d
On Thu, Jun 09, 2016 at 04:02:17PM +0200, Thomas Monjalon wrote:
> 2016-06-09 16:19, Jerin Jacob:
> > On Wed, Jun 08, 2016 at 04:08:37PM +0100, Bruce Richardson wrote:
> > > On Wed, Jun 08, 2016 at 03:42:14PM +0200, Thomas Monjalon wrote:
> > > > 2016-06-08 18:13, Jerin Jacob:
> > > > > On Wed, Jun
On Thu, 9 Jun 2016 10:39:46 +0100
"Hunt, David" wrote:
> Hi Shreyansh,
>
> On 8/6/2016 2:48 PM, Shreyansh Jain wrote:
> > Hi David,
> >
> > Thanks for explanation. I have some comments inline...
> >
> >> -Original Message-
> >> From: Hunt, David [mailto:david.hunt at intel.com]
> >> Se
On 9/6/2016 1:30 PM, Jerin Jacob wrote:
> On Thu, Jun 09, 2016 at 11:49:44AM +, Shreyansh Jain wrote:
>> Hi Jerin,
> Hi Shreyansh,
>
Yes, this would simplify somewhat the creation of a pktmbuf pool, in that
>>> it
replaces
the rte_mempool_set_ops_byname with a flag bit. However
On 6/9/2016 11:10 AM, Thomas Monjalon wrote:
> Hi Ferruh,
>
> 2016-05-27 17:48, Ferruh Yigit:
>> Replace --no-as-needed linker flag with --as-needed flag, which will
>> only link libraries directly called by application. This requires inter
>> library dependencies resolved correctly.
>>
>> Not lin
On 9/6/2016 12:41 PM, Shreyansh Jain wrote:
> Hi David,
>
>> -Original Message-
>> From: Hunt, David [mailto:david.hunt at intel.com]
>> Sent: Thursday, June 09, 2016 3:10 PM
>> To: Shreyansh Jain ; dev at dpdk.org
>> Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com;
>> jerin.jac
Information on pmdinfogen may be useful to 3rd party driver developers.
Include documentation on what it does
Signed-off-by: Neil Horman
CC: Bruce Richardson
CC: Thomas Monjalon
CC: Stephen Hemminger
CC: Panu Matilainen
---
doc/guides/prog_guide/dev_kit_build_system.rst | 43
This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary,
and, if found parses the remainder of the string as a json encoded string,
outputting the results in either a human readable or raw, script parseable
format
Note that, in the case of dynamically linked applications, pmdinf
Modify the compilation makefile to identify C files that export PMD
information, and use that to trigger execution of the pmdinfo binary. If
the execution of pmdinfo is successful, compile the output C file to an
object, and use the linker to do relocatable linking on the resultant
object file int
Export a symbol containing the string:
DPDK_PLUGIN_PATH="$(CONFIG_RTE_EAL_PMD_PATH)"
Where the latter half of the string is set at build time to a location from
which autoloaded DSO's will be found. This string is used by pmdinfo in
'plugin' mode, whereby a user can specify a dpdk installation di
Modify the PMD_REGISTER_DRIVER macro, adding a name argument to it. The
addition of a name argument creates a token that can be used for subsequent
macros in the creation of unique symbol names to export additional bits of
information for use by the pmdinfogen tool. For example:
PMD_REGISTER_DRI
pmdinfogen is a tool used to parse object files and build json strings for
use in later determining hardware support in a dso or application binary.
pmdinfo looks for the non-exported symbol names this_pmd_name and
this_pmd_tbl (where n is a integer counter). It records the name of
each of these t
Hey all-
So heres attempt number 2 at a method for exporting PMD hardware support
information. As we discussed previously, the consensus seems to be that pmd
information should be:
1) Able to be interrogated on any ELF binary (application binary or individual
DSO)
2) Equally functional on
This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8
examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function
'app_pipeline_track_pktq_out_to_link':
examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error:
'reader' may be used uninitialized in this functi
On Wed, Jun 08, 2016 at 05:14:05PM +, Mcnamara, John wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> > Sent: Tuesday, May 31, 2016 2:58 PM
> > To: dev at dpdk.org
> > Cc: Neil Horman ; Richardson, Bruce
> > ; Thomas Monjalon > 6wi
"Ananyev, Konstantin" writes:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Aaron Conole
>> Sent: Thursday, June 09, 2016 4:59 PM
>> To: Pattan, Reshma
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new
> library f
Hi Olivier,
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Thursday, June 09, 2016 8:47 AM
> To: Ananyev, Konstantin; dev at dpdk.org; Adrien Mazarguil
> Subject: Re: [dpdk-dev] [PATCH] mbuf: remove inconsistent assert statements
>
> Hi Konstantin,
>
DPDK/app/test/test_cryptodev.c: In function ?create_snow3g_cipher_operation
_oop.clone.15?: DPDK/x86_64-native-linuxapp-gcc/include/rte_memcpy.h:796:14
error: array subscript is above array bounds.
In test_cryptodev.c:
2429rte_memcpy(sym_op->cipher.iv.data, iv, iv_len);
When iv_len is declare
Hi Jerin,
> -Original Message-
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Thursday, June 09, 2016 6:01 PM
> To: Shreyansh Jain
> Cc: Hunt, David ; dev at dpdk.org; olivier.matz at
> 6wind.com;
> viktorin at rehivetech.com
> Subject: Re: [dpdk-dev] [PATCH v8 1/
> -Original Message-
> From: Richardson, Bruce
> Sent: Thursday, June 9, 2016 1:53 PM
> To: Mcnamara, John ; Wang, Zhihong
> ; dev at dpdk.org
> Cc: Wang, Zhihong
> Subject: RE: [dpdk-dev] [PATCH] doc: virtio pmd versions
>
> > -Original Message-
> > From: dev [mailto:dev-bounces
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhihong Wang
> > +
> > +Virtio PMD Versions
> > +---
> > +
> > +Virtio driver has 3
On Wed, Jun 08, 2016 at 02:51:33PM -0700, Rich Lane wrote:
> On Mon, Jun 6, 2016 at 8:51 PM, Yuanhan Liu
> wrote:
>
> @@ -248,14 +248,9 @@ new_device(struct virtio_net *dev)
> ? ? ? ? internal = eth_dev->data->dev_private;
>
> ?#ifdef RTE_LIBRTE_VHOST_NUMA
> -? ? ? ?ret? = get_me
On Thu, Jun 09, 2016 at 09:57:28AM +0200, Olivier Matz wrote:
> Hi Konstantin,
>
> On 04/29/2016 06:03 PM, Ananyev, Konstantin wrote:
> >> The following commit introduces a function to list the supported
> >> packet types of a device:
> >>
> >> http://dpdk.org/browse/dpdk/commit/?id=78a38edf66
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhihong Wang
> Sent: Thursday, April 21, 2016 4:55 AM
> To: dev at dpdk.org
> Cc: Wang, Zhihong
> Subject: [dpdk-dev] [PATCH] doc: virtio pmd versions
>
> This patch explains all the versions of current virtio
Hi Ferruh,
2016-05-27 17:48, Ferruh Yigit:
> Replace --no-as-needed linker flag with --as-needed flag, which will
> only link libraries directly called by application. This requires inter
> library dependencies resolved correctly.
>
> Not linking all libraries cause a compile error for lpcap and
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, May 6, 2016 3:04 PM
> To: dev at dpdk.org
> Cc: Doherty, Declan ; De Lara Guarch, Pablo
>
> Subject: [dpdk-dev] [PATCH 2/8] doc: update build instructions for
> libsso_snow3g
>
>
On 9/6/2016 11:31 AM, Jerin Jacob wrote:
> On Thu, Jun 09, 2016 at 10:39:46AM +0100, Hunt, David wrote:
>> Hi Shreyansh,
>>
>> On 8/6/2016 2:48 PM, Shreyansh Jain wrote:
>>> Hi David,
>>>
>>> Thanks for explanation. I have some comments inline...
>>>
-Original Message-
From: Hun
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex Wang
> Sent: Saturday, May 21, 2016 8:59 AM
> To: dev at dpdk.org
> Cc: Yigit, Ferruh ; Alex Wang
>
> Subject: [dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool
> capacity
>
> From: Alex Wan
Reshma Pattan writes:
> Added new library for packet capturing support.
>
> Added public api rte_pdump_init, applications should call
> this as part of their application setup to have packet
> capturing framework ready.
>
> Added public api rte_pdump_uninit to uninitialize the packet
> capturing
> -Original Message-
> From: Gonzalez Monroy, Sergio
> Sent: Thursday, June 09, 2016 9:43 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo; Mcnamara, John
> Subject: [PATCH v3 0/9] IPSec Enhancements
>
> Update IPSec sample app with IPv6 and Transport mode support.
>
> The series co
If configuration fails due to lack of resources, be more specific
about which resources are lacking - work queues, read queues or
completion queues.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: John Daley
---
v3: Log messages fix in separate patch. Log errors
for all lacking resources,
If device configuration failed due to a lack of resources, such as
if more queues are requested than are available, the queue release
function is called with NULL pointers which were being dereferenced.
Skip releasing queues if they are NULL pointers.
Fixes: fefed3d1e62c ("enic: new driver")
Sign
Patch broken into separate patches for fixing seg fault and improving
log messages.
John Daley (2):
enic: fix seg fault when releasing queues
enic: more specific out of resources error messages
drivers/net/enic/enic_main.c | 24 +---
1 file changed, 17 insertions(+), 7 de
Hi Jerin,
> -Original Message-
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Thursday, June 09, 2016 4:02 PM
> To: Hunt, David
> Cc: Shreyansh Jain ; dev at dpdk.org;
> olivier.matz at 6wind.com; viktorin at rehivetech.com
> Subject: Re: [dpdk-dev] [PATCH v8 1/3]
Hi David,
> -Original Message-
> From: Hunt, David [mailto:david.hunt at intel.com]
> Sent: Thursday, June 09, 2016 3:10 PM
> To: Shreyansh Jain ; dev at dpdk.org
> Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com;
> jerin.jacob at caviumnetworks.com
> Subject: Re: [dpdk-dev] [PAT
> > Up to now dependencies between DPDK internal libraries have been
> > untracked at shared library level, requiring applications to know
> > about library internal dependencies and often consequently overlinking.
> >
> > Since the dependencies are already recorded for build ordering in the
> > ma
Hi Olivier,
On 8/6/2016 1:13 PM, Olivier Matz wrote:
> Hi David,
>
> Please find some comments below.
>
> On 06/03/2016 04:58 PM, David Hunt wrote:
>
>> --- a/lib/librte_mempool/rte_mempool.h
>> +++ b/lib/librte_mempool/rte_mempool.h
>> +/**
>> + * Prototype for implementation specific data provis
These changes don't break the tests on my systems and reduce
execution time to ~2[s]. I tried "faking" CPU clock frequency but
in some cases it leads to intermittent test fails.
Tomasz
'red_autotest' changed to run only functional tests without test #4 which was
taking ~53 seconds. 'red_autotest'
> -Original Message-
> From: Gonzalez Monroy, Sergio
> Sent: Thursday, June 9, 2016 9:43 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo ; Mcnamara, John
>
> Subject: [PATCH v3 9/9] doc: update ipsec sample guide
>
> Signed-off-by: Sergio Gonzalez Monroy
>
> ...
>
> Configurations
> -Original Message-
> From: Mrzyglod, DanielX T
> Sent: Thursday, June 9, 2016 12:39 PM
> To: Singh, Jasvinder ; Dumitrescu, Cristian
>
> Cc: dev at dpdk.org; Mrzyglod, DanielX T
> Subject: [PATCH] examples/ip_pipeline: fix build error for gcc 4.8
>
> This patch fixes a maybe-uninitia
On Thu, Jun 02, 2016 at 03:30:57AM +0800, Zhe Tao wrote:
> On Thu, May 12, 2016 at 04:11:40PM +0800, Jingjing Wu wrote:
> > When setting up flexible payload selection rules, it is allowed
> > that setting value to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF).
> > However, MK_FLX_PIT macro is al
Hi Shreyansh,
On 8/6/2016 2:48 PM, Shreyansh Jain wrote:
> Hi David,
>
> Thanks for explanation. I have some comments inline...
>
>> -Original Message-
>> From: Hunt, David [mailto:david.hunt at intel.com]
>> Sent: Tuesday, June 07, 2016 2:56 PM
>> To: Shreyansh Jain ; dev at dpdk.org
>> C
On 06/09/2016 10:19 AM, Sergio Gonzalez Monroy wrote:
> The mempool local cache was not initialized properly leading to
> undefined behavior in cases where the allocated memory was used
> previously and left with data.
>
> Fixes: 213af31e0960 ("mempool: reduce structure size if no cache needed")
Just to confirm, should I do anything before it gets merged?
On Thu, Jun 9, 2016 at 5:03 AM, Mcnamara, John
wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex Wang
> > Sent: Saturday, May 21, 2016 8:59 AM
> > To: dev at dpdk.org
> > Cc: Yigit,
Hi Sergio,
On 06/09/2016 09:57 AM, Sergio Gonzalez Monroy wrote:
> Hi Olivier,
>
> On 08/06/2016 20:14, Olivier Matz wrote:
>> Hi Sergio,
>>
>> Good catch, thanks. The patch looks ok, just few comments
>> on the commit log:
>>
>> On 06/08/2016 05:10 PM, Sergio Gonzalez Monroy wrote:
>>> The mempo
Hi Konstantin,
On 04/29/2016 06:03 PM, Ananyev, Konstantin wrote:
>> The following commit introduces a function to list the supported
>> packet types of a device:
>>
>> http://dpdk.org/browse/dpdk/commit/?id=78a38edf66
>>
>> I would like to know what does "supported" precisely mean.
>> Is it:
>>
Hi,
On 06/08/2016 09:34 AM, Lu, Wenzhuo wrote:
> Hi Stephen,
>
>
>> -Original Message-
>> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
>> Sent: Wednesday, June 8, 2016 10:16 AM
>> To: Lu, Wenzhuo
>> Cc: dev at dpdk.org; Tao, Zhe
>> Subject: Re: [dpdk-dev] [PATCH 2/8] li
Added programmers guide for librte_pdump.
Added sample application guide for app/pdump application.
Updated release note for packet capture framework changes.
Signed-off-by: Reshma Pattan
Acked-by: John McNamara
---
MAINTAINERS | 3 +
doc/guides/prog_guide/index.rs
Call rte_pdump_init and rte_pdump_uninit for packet
capturing initialization and uninitialization.
Signed-off-by: Reshma Pattan
---
app/test-pmd/testpmd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index dd6b046..f6089fa 100644
--- a
New tool added for packet capturing on dpdk.
This tool supports command line options.
This tool runs as secondary process by default.
Command line supports various parameters to capture
the packets.
User should pass on a)port and queue (or) b)pci address
and queue (or) c)device name and queue to
Added new library for packet capturing support.
Added public api rte_pdump_init, applications should call
this as part of their application setup to have packet
capturing framework ready.
Added public api rte_pdump_uninit to uninitialize the packet
capturing framework.
Added public apis rte_pdum
Converted rte_eth_dev_get_port_by_name to a public API.
Converted rte_eth_dev_get_name_by_port to a public API.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 4 ++--
lib/librte_ether/rte_ethdev.h | 29 +
lib/librte_ether/rte_ether
New fields nb_rx_queues and nb_tx_queues are added to
rte_eth_dev_info structure.
Changes to API rte_eth_dev_info_get() are done to update
these new fields to rte_eth_dev_info object.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 2 ++
lib/librte_ether/rte_ethdev.h
Added new public api rte_eth_add_first_rx_callback to add given
callback as head of list.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 35 ++
lib/librte_ether/rte_ethdev.h | 27 ++
lib/librte_ether/rte_
Added spinlocks around add/remove logic of rxtx callbacks to
avoid corruption of callback lists in multithreaded context.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 82 +--
1 file changed, 40 insertions(+), 42 deletions(-)
diff --git
This patch set include below changes
1)Changes to librte_ether.
2)A new library librte_pdump added for packet capture framework.
3)A new app/pdump tool added for packet capturing.
4)Test pmd changes done to initialize packet capture framework.
5)Documentation update.
1)librte_pdump
==
1 - 100 of 121 matches
Mail list logo
