On Wed, May 25, 2016 at 01:28:04AM +0800, Zhe Tao wrote: > Add the new floating related argument option in the devarg. > Using this parameter, all the samples can decide whether to use legacy > VEB/VEPA > or floating VEB. > To enable this feature, the user should pass a devargs parameter to the EAL > like "-w 84:00.0,enable_floating=1", and the application will make sure the > PMD > will use the floating VEB feature for all the VFs created by this PF device. > > Signed-off-by: Zhe Tao <zhe.tao at intel.com> > --- > drivers/net/i40e/i40e_ethdev.c | 44 > ++++++++++++++++++++++++++++++++++++++++++ > drivers/net/i40e/i40e_ethdev.h | 6 ++++++ > 2 files changed, 50 insertions(+)
I don't think we should ever use the word "floating" in this context without the word "VEB" on it as well, because it's really meaningless - being an adjective, it always requires a noun will it. This applies both to cmdline arguments and to commit messages. Secondly, these patches really could do with an explanation of what a floating VEB is and what it can do vs a non-floating VEB. I know that in the second patch you refer to standards which define VEBs, but: a) why is that reference not in patch 1? b) when I tried looking it up the spec requires a login for the IEEE site, and a google search for "floating VEB" only brings up links to these patches in patchwork. Regards, /Bruce
