v3 changes:
change log message to tell user that the virtio device is skipped
due to it is managed by kernel driver, instead of asking user to
unbind it from kernel driver.
v2 changes:
change LOG level from ERR to INFO
virtio PMD could use IO port to configure the virtio device without
using ui
v2 changes:
Remove unnecessary assignment of NULL to dev->data->mac_addrs
Ajust one comment's position
if virtio_resource_init fails, cleanup the resource and return 1 to
tell the upper layer we don't take over this device. -1 means error
which will cause DPDK to exit.
Signed-off-by: Huawei Xie
Use RTE_KDRV_NONE to indicate that kernel driver isn't manipulating
the device.
Signed-off-by: Huawei Xie
Acked-by: David Marchand
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
b/lib/librte_ea
positive return of rte_eal_pci_probe_one_driver means the driver doesn't
support the device.
Signed-off-by: Huawei Xie
---
lib/librte_eal/common/eal_common_pci.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c
b/lib/librte_eal/
v3 changes:
change log message to tell user that the virtio device is skipped
due to it is managed by kernel driver, instead of asking user to
unbind it from kernel driver.
v2 changes:
Remove unnecessary assignment of NULL to dev->data->mac_addrs
Ajust one comment's position
change LOG level f
> Remove unnecessary type casting in functions.
>
> Tested on Ubuntu (14.04 x86_64) with "make test".
> "make test" results match the results with baseline.
> "Memcpy perf" results match the results with baseline.
>
> Signed-off-by: Ravi Kerur
> Acked-by: Stephen Hemminger
>
> ---
> .../common
On Thu, Jan 21, 2016 at 3:56 PM, Santosh Shukla wrote:
> Introducing below api for pci bar space rd/wr. Currently used for
> pci iobar rd/wr.
>
> Api's are:
> - rte_eal_pci_read_bar
> - rte_eal_pci_write_bar
>
> virtio when used for vfio-mode then virtio driver will use these api
> to do rd/wr ope
If virtio interface attached to vfio driver then do not parse for virtio
resource. Instead exit with return 0;
Note: Applicable for virtio spec 0.95.
Signed-off-by: Santosh Shukla
---
v5-->v6:
- Replaced pci_dev->kdrv check from __noiommu to default;
This is because patch [1] in v5 series not
If virtio interface attached to vfio-noiommu driver then
do not parse for virtio resource. Instead exit with return 0;
Note: Applicable for virtio spec 0.95.
Signed-off-by: Santosh Shukla
---
v5-->v6:
- Replaced pci_dev->kdrv check from __noiommu to default;
This is because patch [1] in v5 ser
On Wed, Jan 27, 2016 at 9:26 PM, Santosh Shukla wrote:
> On Wed, Jan 27, 2016 at 9:09 PM, Thomas Monjalon
> wrote:
>> 2016-01-27 21:02, Santosh Shukla:
>>> 1. virtio currently works for vfio+noiommu and likely will work for
>>> vfio+iommu in near future.
>>> 2. So remove __noiommu suffix and alwa
> diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcmp.h b/lib
> /librte_eal/common/include/arch/x86/rte_memcmp.h
[...]
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +/**
> + * Compare bytes between two locations. The locations must not overlap.
> + *
Parameter names should be
v3 changes:
remove other extra parentheses in 'return (logical expressions)'
which checkpatch doesn't report as error
remove extra parentheses in return statement which crosses
multiple line
fix the document
v2 changes:
add missed commit message in v1
fix the error reported by checkpatch:
"
Hi Przemek,
Thanks for the quick response. Now able to get the DHCP ip's for 2
vhostuser instances and able to ping each other. Isssue was a bug in
cirros 0.3.0 images which we were using in openstack after using 0.3.1
image as given in the URL(
https://www.redhat.com/archives/rhos-list/2013-A
On Wed, Jan 27, 2016 at 9:09 PM, Thomas Monjalon
wrote:
> 2016-01-27 21:02, Santosh Shukla:
>> 1. virtio currently works for vfio+noiommu and likely will work for
>> vfio+iommu in near future.
>> 2. So remove __noiommu suffix and always use default.
>> 3. Introduce vfio resource parsing global fun
2016-01-27 18:48, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> >
> > > Zhihong Wang (5):
> > > lib/librte_eal: Identify AVX512 CPU flag
> > > mk: Predefine AVX512 macro for compiler
> > > lib/librte_eal: Optimize memcpy for AVX512 platforms
> > > app
In order to better compare the drivers and check what is missing
for a common baseline, we need to fill a matrix.
A CSS trick is used to fit the HTML page.
The PDF output needs some LaTeX wizardry.
Signed-off-by: Thomas Monjalon
---
v2: add vector PMDs
---
doc/guides/nics/index.rst| 1 +
On Wed, Jan 27, 2016 at 4:11 PM, Santosh Shukla wrote:
> On Tue, Jan 26, 2016 at 9:51 PM, Santosh Shukla wrote:
>> On Tue, Jan 26, 2016 at 7:58 PM, Thomas Monjalon
>> wrote:
>>> 2016-01-26 19:35, Santosh Shukla:
On Tue, Jan 26, 2016 at 6:30 PM, Thomas Monjalon
wrote:
> 2016-01-26
This patch fixes syntax errors from tools/setup.sh during binding ethernet
device
on systems where Python 3 is default. Backward compability with Python 2 is
preserved.
Signed-off-by: Dawid Jurczak
---
tools/dpdk_nic_bind.py | 74 +-
1 file chang
Any clues or hint on how to debug this kind of problem on SR-IOV? Only
primary can send packet but secondary process couldn't. I have verified
host's qprc and qptc counters on PF and they do increment.
SR-IOV with DPDK seems more challenging than PCI pass through of whole NIC.
Saurabh
On Jan 26,
Hi Neil,
On 1/26/2016 10:19 PM, Neil Horman wrote:
> On Tue, Jan 26, 2016 at 10:22:18AM +0800, Tan, Jianfeng wrote:
>> Hi Neil,
>>
>> On 1/25/2016 9:46 PM, Neil Horman wrote:
>>> On Mon, Jan 25, 2016 at 02:49:53AM +0800, Jianfeng Tan wrote:
>> ...
--
2.1.4
>>> This doesn't mak
2016-01-27 01:26, Huawei Xie:
> v2 changes:
> add missed commit message in v1
>
> fix the error reported by checkpatch:
> "ERROR: return is not a function, parentheses are not required"
>
> also removed other extra parentheses like:
> "return val == 0"
> "return (rte_mempool_lookup(...))"
Ho
On Wed, Jan 27, 2016 at 6:51 PM, Burakov, Anatoly
wrote:
> Hi Alex,
>
>> On 01/23/2016 04:23 AM, Alex Williamson wrote:
>> > Using iommu_present() to determine whether an IOMMU group is real or
>> > fake has some problems. First, apparently Power systems don't
>> > register an IOMMU on the device
2016-01-25 10:01, Ferruh Yigit:
> Remove "extern" keywords in header files, the ones for function
> prototypes
I've seen a lot of other extern keywords. Why not removing all?
> -extern int rte_eth_dev_configure(uint8_t port_id,
> - uint16_t nb_rx_queue,
> -
2015-11-10 10:02, Ferruh Yigit:
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -133,5 +133,6 @@ DPDK_2.2 {
> global:
>
> rte_intr_cap_multiple;
> + cpu_feature_table;
As it is now an exported symbol, it should
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, January 27, 2016 3:31 PM
> To: Richardson, Bruce; Ananyev, Konstantin
> Cc: dev at dpdk.org; Wang, Zhihong
> Subject: Re: [dpdk-dev] [PATCH v2 0/5] Optimize memcpy for AVX512 pl
2016-01-27 16:50, Anatoly Burakov:
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +int vfio_type1_dma_map(int);
> +int vfio_noiommu_dma_map(int);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
I agree with checkpatch, they shou
Looks like bnx2x has link problem?sometime it sees link up and most of the
time it see link down even though the RX/TX counters are going up.
Has anybody seen this type of problem? If I don't use DPDK then I don't see
this type of link related problem.
The counter shows that it?s receiving and tr
This patch add packet dumping feature to ip_pipeline. Output port type
SINK now supports dumping packets to PCAP file before releasing mbuf back
to mempool. This feature can be applied by specifying parameters in
configuration file as shown below:
[PIPELINE1]
type = PASS-THROUGH
core = 1
pktq_in =
Originally, sink ports in librte_port releases received mbufs back to
mempool. This patch adds optional packet dumping to PCAP feature in sink
port: the packets will be dumped to user defined PCAP file for storage or
debugging. The user may also choose the sink port's activity: either it
continuous
This patch add PCAP file support to ip_pipeline. Input port type SOURCE
now supports loading specific PCAP file and sends the packets in it to
pipeline instance. The packets are then released by SINK output port. This
feature can be applied by specifying parameters in configuration file as
shown be
Originally, source ports in librte_port is an input port used as packet
generator. Similar to Linux kernel /dev/zero character device, it
generates null packets. This patch adds optional PCAP file support to
source port: instead of sending NULL packets, the source port generates
packets copied from
This patchset adds feature to source and sink type port in librte_port
library, and to examples/ip_pipline. Originally, source/sink ports act
as input and output of NULL packets generator. This patchset enables
them read from and write to specific PCAP file, to generate and dump
packets.
Acked-by:
This patch adds idle cycle (or headroom) rate display CLI command to
packet framework. The CLI command format is shown as following:
t headroom
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
examples/ip_pipeline/thread_fe.c | 114 +++
examples/i
This patch adds CPU utilization measurement and rate computation to
packet framework. The measurement is done by measuring the cycles
spent while a thread pulls zero packet from RX queue. These cycles are
treated as idle cycles (or headroom). The idle thread rate is updated once
per second.
Signed
This patchset adds CPU utilization rate computation and CLI command
support to packet framework. The thread idle rate is updated once per
second. User can use thread CLI command to display it.
Fan Zhang (2):
examples/ip_pipeline: CPU utilization measurement and rate computation
examples/ip_pip
2015-12-30 16:59, Zhihong Wang:
> Zhihong Wang (3):
> app/test-pmd: Handle SIGINT and SIGTERM in testpmd
> examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd
> examples/l3fwd: Handle SIGINT and SIGTERM in l3fwd
Applied, thanks
This commit is adding a generic mechanism to support multiple IOMMU
types. For now, it's only type 1 (x86 IOMMU) and no-IOMMU (a special
VFIO mode that doesn't use IOMMU at all), but it's easily extended
by adding necessary DMA mapping functions to eal_pci_vfio.c.
Since type 1 IOMMU module is no l
2016-01-27 14:32, Anatoly Burakov:
> +/* DMA mapping function prototype.
> + * Takes VFIO container fd as a parameter.
> + * Returns 0 on success, -1 on error.
> + * */
> +typedef int (*vfio_dma_func_t)(int);
> +
> +struct vfio_iommu_type {
> + int type_id;
> + const char *name;
> + vf
On 1/21/2016 7:09 PM, Tetsuya Mukawa wrote:
> +qtest_find_pci_device(struct qtest_session *s, uint16_t bus, uint8_t device)
> +{
> + struct qtest_pci_device *dev;
> + uint32_t val;
> +
> + val = qtest_pci_inl(s, bus, device, 0, 0);
> + TAILQ_FOREACH(dev, &s->head, next) {
> +
2016-01-27 21:02, Santosh Shukla:
> 1. virtio currently works for vfio+noiommu and likely will work for
> vfio+iommu in near future.
> 2. So remove __noiommu suffix and always use default.
> 3. Introduce vfio resource parsing global function, That function
> suppose to do parsing for default vfio c
Fixed issue of byte order in ethdev library that the structure
for setting fdir's mask and flow entry is inconsist and made
inputs of mask be in big endian.
fixes: 76c6f89e80d4 ("ixgbe: support new flow director masks")
2d4c1a9ea2ac ("ethdev: add new flow director masks")
Reported-by: Yaac
This patch provides slow data path communication to the Linux kernel.
Patch is based on librte_kni, and heavily re-uses it.
The main difference is librte_kni library converted into a PMD, to
provide ease of use for applications.
Now any application can use slow path communication without any upda
This kernel module is based on KNI module, but this one is stripped
version of it and only for data messages, no control functionality
provided.
FIFO implementation of the KNI is kept exact same, but ethtool related
code removed and virtual network management related code simplified.
This module
This is slow data path communication implementation based on existing KNI.
Difference is: librte_kni converted into a PMD, kdp kernel module is almost
same except all control path functionality removed and some simplification done.
Motivation is to simplify slow path data communication.
Now any a
> Zhihong Wang (5):
> lib/librte_eal: Identify AVX512 CPU flag
> mk: Predefine AVX512 macro for compiler
> lib/librte_eal: Optimize memcpy for AVX512 platforms
> app/test: Adjust alignment unit for memcpy perf test
> lib/librte_eal: Tune memcpy for prior platforms
>
> app/test/test_memc
Hi Thomas,
> > Is it possible (is it better) to declare these functions with
> > vfio_dma_func_t?
>
> Yeah, sure. Or maybe the other way around - maybe we could do away with
> the typedef. I'll go for the former though.
No, we can't declare the functions with a function pointer. At least I don'
Control interface APIs added into the sample application.
To have the support corresponding kernel module (KCP) needs to be inserted.
If kernel module is not there, application will run as it is without
kernel control path support.
When KCP module inserted, running application creates a virtual L
This library gets control messages form kernelspace and forwards them to
librte_ether and returns response back to the kernelspace.
Library does:
1) Trigger Linux virtual interface creation
2) Initialize the netlink socket communication
3) Provides process() API to the application that does proces
This kernel module is based on KNI module, but this one is stripped
version of it and only for control messages, no data transfer
functionality provided.
This Linux kernel module helps userspace application create virtual
interfaces and when a control command issued into that virtual
interface, mo
This work is to make DPDK ports more visible and to enable using common
Linux tools to configure DPDK ports.
Patch is based on KNI but contains only control functionality of it,
also this patch does not include any Linux kernel network driver as
part of it.
Basically with the help of a kernel mod
2016-01-17 22:05, Zhihong Wang:
> This patch set optimizes DPDK memcpy for AVX512 platforms, to make full
> utilization of hardware resources and deliver high performance.
On a related note, your expertise would be very valuable to review
these patches please:
(memcpy) http://dpdk.org/dev/patchwor
On Tue, Jan 26, 2016 at 9:51 PM, Santosh Shukla wrote:
> On Tue, Jan 26, 2016 at 7:58 PM, Thomas Monjalon
> wrote:
>> 2016-01-26 19:35, Santosh Shukla:
>>> On Tue, Jan 26, 2016 at 6:30 PM, Thomas Monjalon
>>> wrote:
>>> > 2016-01-26 15:56, Santosh Shukla:
>>> >> In my observation, currently virt
2016-01-22 15:06, David Marchand:
> It was first a preparation step for future patchsets, but I am not sure what
> will become of them, so sending this anyway since it does not hurt to clean
> this now.
>
> Changes since v1:
> - rebased on HEAD (previous patchset was based on another patch I sent
Ping?
On Tue, Jan 19, 2016 at 5:16 PM, Santosh Shukla wrote:
> For non-x86 arch, Compiler will throw build error for in/out apis. Including
> dummy api function so to pass build.
>
> Note that: For virtio to work for non-x86 arch - RTE_EAL_VFIO is the only
> supported method. RTE_EAL_IGB_UIO is n
Hi Thomas,
> > +/* DMA mapping function prototype.
> > + * Takes VFIO container fd as a parameter.
> > + * Returns 0 on success, -1 on error.
> > + * */
> > +typedef int (*vfio_dma_func_t)(int);
> > +
> > +struct vfio_iommu_type {
> > + int type_id;
> > + const char *name;
> > + vfio_dma_fu
On 1/21/2016 7:09 PM, Tetsuya Mukawa wrote:
[snip]
> +
> +static int
> +qtest_raw_recv(int fd, char *buf, size_t count)
> +{
> + size_t len = count;
> + size_t total_len = 0;
> + int ret = 0;
> +
> + while (len > 0) {
> + ret = read(fd, buf, len);
> + if (ret
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, January 27, 2016 2:38 PM
> To: Kerlin, MarcinX ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job
>
> On 01/26/2016 06:15 PM, Mar
On 01/26/2016 07:03 PM, Huawei Xie wrote:
> v6 changes:
> reflect the changes in release notes and library version map file
> revise our duff's code style a bit to make it more readable
>
> v5 changes:
> add comment about duff's device and our variant implementation
>
> v3 changes:
> move w
Laurent, have you resolved this problem?
I'm using the same NIC as yours (i.e. Intel 82598EB 10G NIC) and faced the
same problem as you.
Here is parts of my log and it says that PMD cannot enable RX queue for my
NIC.
I'm using DPDK 2.2.0 and used 'null' for the 4th parameter in calling
rte_eth_rx_q
On 01/26/2016 06:15 PM, Marcin Kerlin wrote:
> This patch adds new function rte_jobstats_abort. It marks *job* as finished
> and time of this work will be add to management time instead of execution
> time.
> This function should be used instead of rte_jobstats_finish if condition
> occure,
> con
2016-01-21 12:23, David Marchand:
> free() already handles NULL pointer.
>
> Signed-off-by: David Marchand
Applied, thanks
2016-01-20 21:15, Matthew Hall:
> On 1/20/16 7:27 AM, Thomas Monjalon wrote:
> > Hi Matthew,
> >
> > RTE_SDK_BIN is an internal variable and should not be overriden.
> >
> > Have you installed DPDK somewhere? Example:
> > make install O=mybuild DESTDIR=mylocalinstall
> >
> > Then you should bu
On Wed, Jan 27, 2016 at 06:16:37AM +, Xie, Huawei wrote:
> On 1/27/2016 2:02 PM, Yuanhan Liu wrote:
> > On Wed, Jan 27, 2016 at 05:56:56AM +, Xie, Huawei wrote:
> >> On 1/27/2016 11:22 AM, Yuanhan Liu wrote:
> >>> On Wed, Jan 27, 2016 at 02:46:39AM +, Xie, Huawei wrote:
> On 12/3/2
This commit is adding a generic mechanism to support multiple IOMMU
types. For now, it's only type 1 (x86 IOMMU) and no-IOMMU (a special
VFIO mode that doesn't use IOMMU at all), but it's easily extended
by adding necessary definitions into eal_pci_init.h and a DMA
mapping function to eal_pci_vfio.
Apologies, lost the signoff from Santosh Shukla and also the commit message
still mentions the file that is now non-existent, so I'll submit a v4.
Thanks,
Anatoly
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Wednesday, January 27
On Wed, Jan 27, 2016 at 06:12:22AM +, Xie, Huawei wrote:
> On 1/27/2016 11:26 AM, Yuanhan Liu wrote:
> > On Tue, Jan 26, 2016 at 10:30:12AM +, Xie, Huawei wrote:
> >> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:
> >>> Signed-off-by: Yuanhan Liu
> >>> ---
> >>> lib/librte_vhost/vhost_rxtx.c |
On Fri, Jan 22, 2016 at 4:27 PM, David Marchand
wrote:
> The 4th patch introduces a change in linux eal.
> Before, if a pci device was bound to no kernel driver, eal would set kdrv
> to "unknown". With this change, kdrv is set to "none".
> This might make it possible to avoid the old issue of virt
This commit is adding a generic mechanism to support multiple IOMMU
types. For now, it's only type 1 (x86 IOMMU) and no-IOMMU (a special
VFIO mode that doesn't use IOMMU at all), but it's easily extended
by adding necessary definitions into eal_pci_init.h and a DMA
mapping function to eal_pci_vfio_
On Wed, Jan 27, 2016 at 05:56:56AM +, Xie, Huawei wrote:
> On 1/27/2016 11:22 AM, Yuanhan Liu wrote:
> > On Wed, Jan 27, 2016 at 02:46:39AM +, Xie, Huawei wrote:
> >> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:
> >>> + if (vq->vhost_hlen == sizeof(struct virtio_net_hdr_mrg_rxbuf)) {
> >>> +
2016-01-07 16:17, Panu Matilainen:
> On 01/03/2016 07:56 PM, Huawei Xie wrote:
> > v2 changes:
> > change LOG level from ERR to INFO
> >
> > virtio PMD could use IO port to configure the virtio device without
> > using uio driver.
> >
> > There are two issues with previous implementation:
> > 1)
Hi Alex,
> On 01/23/2016 04:23 AM, Alex Williamson wrote:
> > Using iommu_present() to determine whether an IOMMU group is real or
> > fake has some problems. First, apparently Power systems don't
> > register an IOMMU on the device bus, so the groups and containers get
> > marked as noiommu and
On Wed, Jan 27, 2016 at 08:02:27PM +0800, Tan, Jianfeng wrote:
> Hi Neil,
>
> On 1/26/2016 10:19 PM, Neil Horman wrote:
> >On Tue, Jan 26, 2016 at 10:22:18AM +0800, Tan, Jianfeng wrote:
> >>Hi Neil,
> >>
> >>On 1/25/2016 9:46 PM, Neil Horman wrote:
> >>>On Mon, Jan 25, 2016 at 02:49:53AM +0800, Ji
Some cleanups to better reflect the code that was actually pushed out to
the upstream Linux community.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.h | 7 --
drivers/net/fm10k/base/fm10k_pf.h | 4 --
drivers/net/fm10k/base/fm10k_type.h | 132
The upstream Linux kernel community prefers constants are to the right of
binary operators.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base/fm10k
Per comments from an upstream patch, and looking at how TLV LE_STRUCT
code works, we actually want these structures to be 4byte aligned, not
1byte aligned. In practice, 1byte alignment has worked so far because
all our structures end up being a multiple of 4. But if a future TLV
structure were adde
The comment here was changed during review of upstream patch, and the
new wording is slightly more clear. Re-write the comment in SHARED code
based on this new wording.
Fix a number of mailbox comment issues with function header comments,
lower-case acronyms (i.e. FIFO, TLV), incorrect function na
The vid variable name is shorthand for VLAN ID, so we should use this in
comments explaining what is happening.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/d
The Linux Kernel provides the OS a call "pcie_get_minimum_link" which
can crawl the PCIe tree and determine the actual minimum link speed of a
device which is a more general check than provided by
is_slot_appropriate. Thus, the upstream driver does not use or want the
is_slot_appropriate function c
Use memcpy instead of copying MAC address byte-by-byte.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_pf.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/fm10k/base/fm10k_pf.c
b/drivers/net/fm10k/base/fm10k_pf.c
index 7d48210..a1469aa 100644
The upstream Linux kernel community prefers avoiding CamelCase in
variables, function names, etc.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_type.h | 14 +++---
drivers/net/fm10k/fm10k_ethdev.c| 24
2 files changed, 19 insertions(+), 19 delet
The upstream Linux kernel community prefers using the BIT macro over
bit-shifting a 1. Similar to how this is handled in the i40e shared code,
define a macro for OSes that do not already have it and wrap all that in
LINUX_MACROS so that it can be stripped from the Linux driver.
The upstream Linux
Cleanup lines over 80 characters.
Cleanup useless else, checkpatch warns that else is not generally
useful after a break or return.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_mbx.c | 2 +-
drivers/net/fm10k/base/fm10k_pf.c | 19 ++-
2 files changed, 11 insertio
Add comments which properly explain the undocumented use of bits in
TDLEN register prior to VF initializing it to the correct value. Note
that the mechanism is entirely software-defined and explain its purpose
to help reduce confusion in the future.
Signed-off-by: Wang Xiao W
---
drivers/net/fm1
VF drivers must detect how many queues are available. Previously, the
driver assumed that each VF has at minimum 1 queue. This assumption is
incorrect, since it is possible that the PF has not yet assigned the
queues to the VF by the time the VF checks. To resolve this, we added a
check first to en
Upstream community wishes us to use bitshift instead of a divisor,
because this is faster, and prevents any need for a '0' check. In our
case, this even works out because default Gen3 will be 0.
Because of this, we are also able to remove the check for non-zero value
in the vf code path since that
Correct typecast in fm10k_update_xc_addr_pf.
Make functions that are only referenced locally static.
And fix the function header comment for fm10k_tlv_attr_nest_stop() while
we're at it.
Wrap fm10k_msg_data fm10k_iov_msg_data_pf[] in the new ifndef
NO_DEFAULT_SRIOV_MSG_HANDLERS so that drivers w
Some macros such as FM10K_RXINT_TIMER_SHIFT are removed in the share
code drop, but they are needed in dpdk/fm10k. This patch put all these
necessary macros into fm10k_osdep.h
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/base/fm10k_osdep.h | 30 ++
1 file changed,
The new share code makes fm10k_msg_update_pvid_pf function static, so we can
not refer to it now in fm10k_ethdev.c. The registered pf handler is almost the
same as the default pf handler, removing it has no impact on mailbox.
Signed-off-by: Wang Xiao W
---
drivers/net/fm10k/fm10k_ethdev.c | 17 +
v2:
* Put the two extra fix patches ahead of the base code patches.
Wang Xiao W (16):
fm10k: use default mailbox message handler for pf
fm10k/base: add macro definitions that are needed
fm10k/base: cleanup namespace pollution and correct typecast
fm10k/base: use bitshift for itr_scale
fm
On Thu, Jan 21, 2016 at 12:37:42PM +0100, Thomas Monjalon wrote:
> 2016-01-19 16:12, Yuanhan Liu:
> > +#define IO_READ_DEF(nr_bits, type) \
> > +static inline type \
> > +io_read##nr_bits(type *addr) \
> > +{
This patch fixes the socket-id error in ip_pipeline sample
application running over uni-processor systems.
Signed-off-by: Jasvinder Singh
Acked-by: Cristian Dumitrescu
---
v2:
- used SOCKET_ID_ANY instead of -1
examples/ip_pipeline/init.c | 14 +++---
1 file changed, 11 insertions(+),
On Thu, Jan 21, 2016 at 12:49:10PM +0100, Thomas Monjalon wrote:
> 2016-01-19 16:12, Yuanhan Liu:
> > int
> > vtpci_init(struct rte_pci_device *dev, struct virtio_hw *hw)
> > {
> > - hw->vtpci_ops = &legacy_ops;
> > + hw->dev = dev;
> > +
> > + /*
> > +* Try if we can s
Hi Abhijeet,
It seems you are almost there!
When booting the VM?s do you request hugepage memory for them (by setting
hw:mem_page_size=large in flavor extra_spec)?
If not then please do, if yes then please look into libvirt logfiles for the
VM?s (in /var/log/libvirt/qemu/instance-xxx), I think
On Thu, Jan 21, 2016 at 02:50:01PM +0100, J?r?me Jutteau wrote:
> Hi Yuanhan,
>
> 2015-12-14 2:47 GMT+01:00 Yuanhan Liu :
> > Right, I should move it in the beginning of this function.
>
> Any news about this refactoring ?
Hi J?r?me,
Thanks for showing interests in this patch set; I was waiting
On Tue, Jan 26, 2016 at 10:30:12AM +, Xie, Huawei wrote:
> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:
> > Signed-off-by: Yuanhan Liu
> > ---
> > lib/librte_vhost/vhost_rxtx.c | 287
> > +-
> > 1 file changed, 113 insertions(+), 174 deletions(-)
>
> Pref
On Wed, Jan 27, 2016 at 11:12 AM, Thomas Monjalon
wrote:
> 2016-01-27 10:08, Burakov, Anatoly:
>> > Why a new file for these functions?
>>
>> Well, my thought was to make future extensions easier by way of avoiding
>> mixing irrelevant and/or general code with driver-specific code. I can
>> chan
On Wed, Jan 27, 2016 at 02:46:39AM +, Xie, Huawei wrote:
> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:
> > + if (vq->vhost_hlen == sizeof(struct virtio_net_hdr_mrg_rxbuf)) {
> > + *(struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr = hdr;
> > + } else {
> > + *(struct
2016-01-27 10:08, Burakov, Anatoly:
> > Why a new file for these functions?
>
> Well, my thought was to make future extensions easier by way of avoiding
> mixing irrelevant and/or general code with driver-specific code. I can change
> it back if that's not OK.
No strong opinion here.
David?
On Wed, 2016-01-27 at 07:32 +, Harish Patil wrote:
> >
> >I have to practically identical systems, same hypervisor on each
> (Centos
> >7.x).??In one, I have a 57800 card which works fine with DPDK with
> >SRIOV.??In the other, I have a 57810 card which doesn't work with
> SRIOV.
> >
> >For the
On Tue, Jan 26, 2016 at 4:50 PM, Jan Viktorin
wrote:
> What about the RTE_VERIFY? I think, it's more appropriate here.
Well, here, I am removing useless checks in static functions.
But for the rest of ethdev api, I agree we could add some RTE_VERIFY.
> Otherwise, feel free to add:
>
> Reviewed
1 - 100 of 136 matches
Mail list logo
