On 1/4/16, 9:15 PM, "Stephen Hemminger" wrote:
>On Mon, 4 Jan 2016 18:28:18 -0800
>Yong Wang wrote:
>
>> +/* The number of descriptors that are needed for a packet. */
>> +static unsigned
>> +txd_estimate(const struct rte_mbuf *m)
>> +{
>> +return m->nb_segs;
>> +}
>> +
>
>A wrapper funct
On 1/4/16, 9:14 PM, "Stephen Hemminger" wrote:
>On Mon, 4 Jan 2016 18:28:18 -0800
>Yong Wang wrote:
>
>> +mbuf = txq->cmd_ring.buf_info[eop_idx].m;
>> +if (unlikely(mbuf == NULL))
>> +rte_panic("EOP desc does not point to a valid mbuf");
>> +else
>
>The unlikely is rea
On 1/4/16, 9:16 PM, "Stephen Hemminger" wrote:
>On Mon, 4 Jan 2016 18:28:16 -0800
>Yong Wang wrote:
>
>> Tx data ring support was removed in a previous change
>> to add multi-seg transmit. This change adds it back.
>>
>> Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
>>
>> Si
Add a brief introduction on FTAG, describes what's FTAG and how it works
in forwarding, introduction on how to run fm10k with FTAG is also included.
Signed-off-by: Wang Xiao W
---
doc/guides/nics/fm10k.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/doc/guides/nics/fm10k.r
This patch adds a unit test case for FTAG functional test. Before running
the test, set PORT0_GLORT and PORT1_GLORT environment variables, and ensure
two fm10k ports are used for dpdk, glort info for each port can be shown in
TestPoint. In the unit test, a packet will be forwarded to the target por
This patch enables reading sglort info into mbuf for RX and inserting
an FTAG at the beginning of the packet for TX. The vlan_tci_outer field
selected from rte_mbuf structure for sglort is not used in fm10k now.
In FTAG based forwarding mode, the switch will forward packets according
to glort info
This is a RFC patch set for FTAG based forwarding feature of RRC.
Wang Xiao W (3):
fm10k: enable FTAG based forwarding
fm10k: add a unit test for FTAG based forwarding
doc: add introduction for fm10k FTAG based forwarding
app/test/Makefile | 1 +
app/test/test_fm10k_ftag
Signed-off-by: David Marchand
---
drivers/net/mlx5/mlx5.c |1 +
drivers/net/mlx5/mlx5.h |1 +
drivers/net/mlx5/mlx5_mac.c | 16
3 files changed, 18 insertions(+)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 821ee0f..30d88b5 100644
--- a/
Signed-off-by: David Marchand
---
drivers/net/mlx4/mlx4.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index 207bfe2..acc76d7 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -4432,6 +4432,22 @@ end
Hi Michael:
Seems the examples makefile seems to be broken, easy to reproduce on
master branch, below is the outputs on Ubuntu 14.04 amd64 version:
~/work/dpdk$ export RTE_SDK=/home/steeven/work/dpdk
~/work/dpdk$ cd /home/steeven/work/dpdk/examples/helloworld/
~/work/dpdk/examples/helloworld$ exp
On Tue, Jan 05, 2016 at 11:08:04AM +0800, Tan, Jianfeng wrote:
>
>
> On 1/4/2016 7:11 PM, Adrien Mazarguil wrote:
> >Hi Jianfeng,
> >
> >I'm only commenting the mlx4/mlx5 bits in this message, see below.
> >
> >On Thu, Dec 31, 2015 at 02:53:15PM +0800, Jianfeng Tan wrote:
> >>Signed-off-by: Jianf
On Mon, Jan 04, 2016 at 02:36:14PM +, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil
> > Sent: Monday, January 04, 2016 11:38 AM
> > To: Tan, Jianfeng
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev
>
>The mbuf_alloc_size is leftover from BSD or some other code base.
>It is set but never used in DPDK driver. After that the related defines
>can also be eliminated.
>
>Signed-off-by: Stephen Hemminger
>---
> drivers/net/bnx2x/bnx2x.c | 9 -
> drivers/net/bnx2x/bnx2x.h | 18 -
On Tue, 5 Jan 2016 16:12:58 -0800
Yong Wang wrote:
>
> /* return 0 means link status changed, -1 means not changed */
> @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev,
> uint16_t vid, int on)
> else
> VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, v
On Tue, 5 Jan 2016 16:12:56 -0800
Yong Wang wrote:
> - if (txq->shared->ctrl.txNumDeferred >= txq->shared->ctrl.txThreshold) {
> + PMD_TX_LOG(DEBUG, "vmxnet3 txThreshold: %u",
> rte_le_to_cpu_32(txq_ctrl->txThreshold));
For bisection, it would be good to split the byte-order fixes from
Hi Neilo,
> -Original Message-
> From: N?lio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com]
> Sent: Tuesday, January 05, 2016 4:14 PM
> To: Tan, Jianfeng
> Cc: Adrien Mazarguil; Ananyev, Konstantin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if
Hi Jianfeng,
> > >
> > > +static int
> > > +check_packet_type_ok(int portid)
> > > +{
> > > + int i;
> > > + int ret;
> > > + uint32_t ptypes[RTE_PTYPE_L3_MAX_NUM];
> > > + int ptype_l3_ipv4 = 0, ptype_l3_ipv6 = 0;
> > > +
> > > + ret = rte_eth_dev_get_ptype_info(portid, RTE_PTYPE_L3_MASK,
> > pty
On Tue, 5 Jan 2016 16:12:55 -0800
Yong Wang wrote:
> @@ -365,6 +366,14 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf
> **tx_pkts,
> break;
> }
>
> + if (rte_pktmbuf_pkt_len(txm) <= VMXNET3_HDR_COPY_SIZE) {
> + struct V
On 01/04/2016 11:02 AM, Xie, Huawei wrote:
> On 12/25/2015 6:33 PM, Xie, Huawei wrote:
>> virtio PMD could use IO port to configure the virtio device without
>> using uio driver.
>>
>> There are two issues with previous implementation:
>> 1) virtio PMD will take over each virtio device blindly even
User should be able to configure ethdev with zero rx/tx queues, but both should
not be zero.
After above change, rte_eth_dev_tx_queue_config, rte_eth_dev_rx_queue_config
should
allocate memory for rx/tx queues only when number of rx/tx queues are nonzero.
Signed-off-by: Reshma Pattan
---
lib/l
Macro RTE_PROC_PRIMARY_OR_ERR_RET blocking the secondary process from API usage.
API access should be given to both secondary and primary.
Signed-off-by: Reshma Pattan
---
lib/librte_cryptodev/rte_cryptodev.c | 42 --
1 files changed, 0 insertions(+), 42 deletio
Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET
are blocking the secondary process from using the APIs.
API access should be given to both secondary and primary.
Reported-by: Sean Harte
Signed-off-by: Reshma Pattan
---
v3:
* Removed checkpatch fixes of lib/librte_ether/rte_ethdev.
From: reshmapa
Patches 1 and 2 removes RTE_PROC_PRIMARY_OR_ERR_RET and
RTE_PROC_PRIMARY_OR_RET macro usage from rte_ether and rte_cryptodev libraries
to allow API
access to secondary process.
Patch 3 allows users to configure ethdev with zero rx/tx queues, but both
should not be zero.
Fix rte_
On 1/5/2016 6:22 PM, Mcnamara, John wrote:
>> -Original Message-
>> From: Tan, Jianfeng
>> Sent: Tuesday, January 5, 2016 2:21 AM
>> To: Xie, Huawei; dev at dpdk.org
>> Cc: Mcnamara, John; Stephen Hemminger; Yuanhan Liu
>> Subject: RE: [PATCH] fix checkpatch errors
>>
>>
>>
>>> -Origina
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index c363bf6..8a40127 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethd
This commit adds vmxnet3 TSO support.
Verified with test-pmd (set fwd csum) that both tso and
non-tso pkts can be successfully transmitted and all
segmentes for a tso pkt are correct on the receiver side.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +
drivers/net/vmx
Support TCP/UDP checksum offload.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 39 +++-
2 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b/do
Tx data ring support was removed in a previous change
to add multi-seg transmit. This change adds it back.
According to the original commit (2e849373), 64B pkt
rate with l2fwd improved by ~20% on an Ivy Bridge
server at which point we start to hit some bottleneck
on the rx side.
I also re-did th
v3:
* fixed comments from Stephen
* added performance number for tx data ring
v2:
* fixed some logging issues when debug option turned on
* updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
One of the use cases for thes
Fix memory leak when detaching virtual device. Set dev_flags to
RTE_ETH_DEV_DETACHABLE and implement pmd_af_packet_drv.uninit method.
Copy device name to ethdev->data to make it compatibile with
rte_eth_dev_allocated().
Signed-off-by: Wojciech Zmuda
---
drivers/net/af_packet/rte_eth_af_packet.c
The common vhost code only supported a single mmap per device. vhost-user
worked around this by saving the address/length/fd of each mmap after the end
of the rte_virtio_memory struct. This only works if the vhost-user code frees
dev->mem, since the common code is unaware of the extra info. The
VHO
On 04/12/15 17:14, Stephen Hemminger wrote:
> From: Eric Kinzie
>
> The current code for detecting link during slave addition can cause a
> slave interface to be activated twice -- once during slave_configure()
> and again at the end of __eth_bond_slave_add_lock_free(). This will
> either cause t
On 04/12/15 19:18, Eric Kinzie wrote:
> On Fri Dec 04 19:36:09 +0100 2015, Andriy Berestovskyy wrote:
>> Hi guys,
>> I'm not quite sure if we can support less TX queues on a slave that easy:
>>
>>> queue_id = bond_slave_txqid(internals, i, bd_tx_q->queue_id);
>>> num_tx_slave = rte_eth_tx_burst(sla
On 04/12/15 17:14, Stephen Hemminger wrote:
> From: Eric Kinzie
>
> If the link state of a slave is "up" when added, it is added to the list
> of active slaves but, even if it is the only slave, is not selected as
> the primary interface. Generally, handling of link state interrupts
> selects an
On 04/12/15 17:14, Stephen Hemminger wrote:
> From: Eric Kinzie
>
> Provide functions to allow an external 802.3ad state machine to transmit
> and recieve LACPDUs and to set the collection/distribution flags on
> slave interfaces.
>
> Signed-off-by: Eric Kinzie
> Signed-off-by: Stephen Hemminger
On 04/12/15 17:14, Stephen Hemminger wrote:
> From: Eric Kinzie
>
> The bonding PMD in mode 4 puts all enslaved interfaces into promiscuous
> mode in order to receive LACPDUs and must filter unwanted packets
> after the traffic has been "collected". Allow broadcast and multicast
> through so that
On 04/12/15 17:14, Stephen Hemminger wrote:
> From: Eric Kinzie
>
> Copy all needed fields from the mode8023ad_private structure in
> bond_mode_8023ad_conf_get(). This help ensure that a subsequent call
> to rte_eth_bond_8023ad_setup() is not passed uninitialized data that
> would result in eithe
On 04/12/15 17:14, Stephen Hemminger wrote:
> From: Eric Kinzie
>
> This solves issues when an active device is added to a bond.
>
> If a device to be enslaved already has transmit and/or receive queues
> allocated, use those and then create any additional queues that are
> necessary.
>
> Signed-o
Hi Hanoch,
On 01/05/2016 12:11 PM, Hanoch Haim (hhaim) wrote:
> Hi Oliver,
> Thank you for the fast response and it would be great to open a discussion on
> that.
> In general our project can leverage your optimization and I think it is great
> (we should have thought about it) . We can use it u
Hi Hanoch,
On 01/04/2016 03:43 PM, Hanoch Haim (hhaim) wrote:
> Hi Oliver,
>
> Let's take your drawing as a reference and add my question
> The use case is sending a duplicate multicast packet by many threads.
> I can split it to x threads to do the job and with atomic-ref (my multicast
> not mbu
Has anyone looked at getting rid of rte_pci_dev_ids.h?
The current method with #ifdef's and putting all devices in one file
really doesn't scale well. Something more like other OS's where
the data is only in each device driver would be better.
Hi Oliver,
Thank you for the fast response and it would be great to open a discussion on
that.
In general our project can leverage your optimization and I think it is great
(we should have thought about it) . We can use it using the workaround I
described.
However, for me it seems odd that rt
On 1/4/2016 7:11 PM, Adrien Mazarguil wrote:
> Hi Jianfeng,
>
> I'm only commenting the mlx4/mlx5 bits in this message, see below.
>
> On Thu, Dec 31, 2015 at 02:53:15PM +0800, Jianfeng Tan wrote:
>> Signed-off-by: Jianfeng Tan
>> ---
>> drivers/net/mlx4/mlx4.c | 27 +++
Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET
are blocking the secondary process from using the APIs.
API access should be given to both secondary and primary.
Reported-by: Sean Harte
Signed-off-by: Reshma Pattan
---
v2:
* Removed checkpatch fixes of lib/librte_ether/rte_ethdev.
with only one hugepage or already sorted hugepage addresses, the sort
function called memcpy with same src and dst pointer. Debugging with
valgrind will issue a warning about overlapping area. This patch
changes the sort method to qsort to avoid this behavior, according to
original patch from Jay R
Hi again,
I forgot to correctly set the commit title, so this is v3.
Best Regards,
Ralf
---
Ralf Hoffmann (1):
change hugepage sorting to avoid overlapping memcpy
lib/librte_eal/linuxapp/eal/eal_memory.c | 60
1 file changed, 14 insertions(+), 46 deletions(-
On Tue, Jan 05, 2016 at 02:21:12AM +, Tan, Jianfeng wrote:
>
>
> > -Original Message-
> > From: Xie, Huawei
> > Sent: Monday, January 4, 2016 9:52 AM
> > To: dev at dpdk.org
> > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
> > Subject: [PATCH] fix checkpatch errors
> >
> > Signed-o
with only one hugepage or already sorted hugepage addresses, the sort
function called memcpy with same src and dst pointer. Debugging with
valgrind will issue a warning about overlapping area. This patch
changes the sort method to qsort to avoid this behavior, according to
original patch from Jay R
Hi,
I want to catch up with the patch about the overlapping memory
areas/hugepage sorting. I have incorporated the qsort patch from Jay
and made the suggested changes. So this fixes both the valgrind
warning about the overlapping memcpy and possible performance problems
due to the bubblesort.
Bes
> -Original Message-
> From: Tan, Jianfeng
> Sent: Tuesday, January 5, 2016 2:21 AM
> To: Xie, Huawei; dev at dpdk.org
> Cc: Mcnamara, John; Stephen Hemminger; Yuanhan Liu
> Subject: RE: [PATCH] fix checkpatch errors
>
>
>
> > -Original Message-
> > From: Xie, Huawei
> > Sent: Mo
Hi Uday,
>
> Thanks Jasvinder , I am running the below command
>
> ./build/qos_sched -c 0xe -n 1 -- --pfc "0,1,3,2" --cfg ./profile.cfg
>
> Bound two 1G physical ports to DPDK , and started running the above
> command with the default profile mentioned in profile.cfg .
> I am using lcore 3 and
On Mon, Jan 04, 2016 at 05:56:49PM +, Xie, Huawei wrote:
> On 1/5/2016 1:24 AM, Stephen Hemminger wrote:
> > On Mon, 4 Jan 2016 01:56:13 +0800
> > Huawei Xie wrote:
> >
> >> + if (pci_dev->kdrv != RTE_KDRV_NONE) {
> >> + PMD_INIT_LOG(INFO,
> >> + "kernel driver is m
On 1/5/2016 2:12 AM, Ananyev, Konstantin wrote:
>
>> -Original Message-
>> From: Tan, Jianfeng
>> Sent: Thursday, December 31, 2015 6:53 AM
>> To: dev at dpdk.org
>> Cc: Zhang, Helin; Ananyev, Konstantin; Tan, Jianfeng
>> Subject: [PATCH 07/12] pmd/ixgbe: add dev_ptype_info_get implementa
Fix the issue that virtio device cannot be started after stopped.
The field, hw->started, should be changed by virtio_dev_start/stop instead
of virtio_dev_close.
Signed-off-by: Jianfeng Tan
---
drivers/net/virtio/virtio_ethdev.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-
The mbuf_alloc_size is leftover from BSD or some other code base.
It is set but never used in DPDK driver. After that the related defines
can also be eliminated.
Signed-off-by: Stephen Hemminger
---
drivers/net/bnx2x/bnx2x.c | 9 -
drivers/net/bnx2x/bnx2x.h | 18 --
2 f
On 10/26/2015 10:06 PM, Xie, Huawei wrote:
> On 10/19/2015 1:16 PM, Stephen Hemminger wrote:
>> This is a tested version of the virtio Tx performance improvements
>> that I posted earlier on the list, and described at the DPDK Userspace
>> meeting in Dublin. Together they get a 25% performance impr
A common usage scenario is to bond a vnic like virtio which typically has
only a single rx queue with a VF device that has multiple receive queues.
This is done to do live migration
On Jan 5, 2016 05:47, "Declan Doherty" wrote:
> On 04/12/15 19:18, Eric Kinzie wrote:
>
>> On Fri Dec 04 19:36:09 +
On 1/5/2016 2:42 PM, Xie, Huawei wrote:
> This patch removes the internal lockless enqueue implmentation.
> DPDK doesn't support receiving/transmitting packets from/to the same
> queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK
> applications normally have their own lock implmentation
On 12/17/2015 7:18 PM, Tom Kiely wrote:
>
>
> On 11/25/2015 05:32 PM, Xie, Huawei wrote:
>> On 11/13/2015 5:33 PM, Tom Kiely wrote:
>>> If all rx descriptors are processed while transient
>>> mbuf exhaustion is present, the rx ring ends up with
>>> no available descriptors. Thus no packets are rece
Thanks Jasvinder , I am running the below command
./build/qos_sched -c 0xe -n 1 -- --pfc "0,1,3,2" --cfg ./profile.cfg
Bound two 1G physical ports to DPDK , and started running the above command
with the default profile mentioned in profile.cfg .
I am using lcore 3 and 2 for RX and TX. It was n
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, January 5, 2016 2:32 AM
> To: Tan, Jianfeng; dev at dpdk.org
> Cc: Zhang, Helin
> Subject: RE: [PATCH 12/12] examples/l3fwd: add option to parse ptype
>
>
> Hi Jianfeng,
> > -Original Message-
> > From: Tan, Jianf
On 1/5/2016 10:21 AM, Tan, Jianfeng wrote:
>
>> -Original Message-
>> From: Xie, Huawei
>> Sent: Monday, January 4, 2016 9:52 AM
>> To: dev at dpdk.org
>> Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
>> Subject: [PATCH] fix checkpatch errors
>>
>> Signed-off-by: Huawei Xie
> ...
>>
> -Original Message-
> From: Xie, Huawei
> Sent: Monday, January 4, 2016 9:52 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
> Subject: [PATCH] fix checkpatch errors
>
> Signed-off-by: Huawei Xie
...
> mbuf_poolname_build(sock_id, pool_name, sizeof(pool_
63 matches
Mail list logo
