This patch removes the internal lockless enqueue implmentation.
DPDK doesn't support receiving/transmitting packets from/to the same
queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK
applications normally have their own lock implmentation when enqueue
packets to the same queue of a port
Hi All,
I am seeing an issue where the stats counters for vmxnet3 interfaces are reset
to 0 after rte_eth_dev_start() is called, making it difficult to track
statistics over a period of time where interfaces could be disabled and
re-enabled.
There is a memset in the code that clears the txq/rx
On Mon, 4 Jan 2016 18:28:15 -0800
Yong Wang wrote:
> v2:
> * fixed some logging issues when debug option turned on
> * updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
>
> This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
> One of the use cases for these features is
On Mon, 4 Jan 2016 18:28:16 -0800
Yong Wang wrote:
> Tx data ring support was removed in a previous change
> to add multi-seg transmit. This change adds it back.
>
> Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
>
> Signed-off-by: Yong Wang
Do you have any numbers to confi
On Mon, 4 Jan 2016 18:28:18 -0800
Yong Wang wrote:
> +/* The number of descriptors that are needed for a packet. */
> +static unsigned
> +txd_estimate(const struct rte_mbuf *m)
> +{
> + return m->nb_segs;
> +}
> +
A wrapper function only really clarifies if it is hiding some information.
Wh
On Mon, 4 Jan 2016 18:28:18 -0800
Yong Wang wrote:
> + mbuf = txq->cmd_ring.buf_info[eop_idx].m;
> + if (unlikely(mbuf == NULL))
> + rte_panic("EOP desc does not point to a valid mbuf");
> + else
The unlikely is really not needed with rte_panic since it is declared
with
This function should be preferred over the rte_eth_copy_pci_info as it is not
PCI-specific.
Signed-off-by: Jan Viktorin
---
lib/librte_ether/rte_ethdev.c | 38 ++
lib/librte_ether/rte_ethdev.h | 15 +++
2 files changed, 53 insertions(+)
diff --git
Signed-off-by: Jan Viktorin
---
lib/librte_ether/rte_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 6fb3423..75121bc 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -3293,6 +3
Signed-off-by: Jan Viktorin
---
lib/librte_ether/rte_ethdev.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index b17aa11..6fb3423 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_eth
Signed-off-by: Jan Viktorin
---
lib/librte_ether/rte_ethdev.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index a9007e7..b17aa11 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether
Signed-off-by: Jan Viktorin
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index db12515..a9007e7 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@
Make the attach and detach functions independent on the PCI infra. Mostly, this
means to utilize the rte_bus_addr instead of rte_pci_addr.
Signed-off-by: Jan Viktorin
---
lib/librte_ether/rte_ethdev.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
dif
To support a generic manipulation with devices we need to have a general
representation of the rte_*_addr which replaces the rte_pci_addr in the code.
Here we introduce the rte_bus_addr consisting of a union of various rte_*_addr
fields and the device magic to discriminate among them.
A wrapper ar
Generalize strict PCI-specific initialization and uninitialization steps and
prepare the code to be easily reused for other infrastructures. API of the
eth_driver stays backwards compatible. The previously introduced magic is
utilized to test whether we are working with a PCI device or not.
Signed
As rte_dev.h now include rte_pci.h, we can remove the rte_pci.h inclusion
among all DPDK code base or replace it by a more general rte_dev.h inclusion.
Signed-off-by: Jan Viktorin
---
app/test-pipeline/config.c | 2 +-
app/test-pipeline/init.c
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/include/rte_pci.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_pci.h
b/lib/librte_eal/common/include/rte_pci.h
index 1321654..204ee82 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+
Signed-off-by: Jan Viktorin
---
lib/librte_cryptodev/rte_cryptodev.c| 3 +--
lib/librte_eal/common/include/rte_pci.h | 12
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.c
b/lib/librte_cryptodev/rte_cryptodev.c
index f09f67e..
The union rte_device can be used in situations where we want to work with all
devices without distinguishing among bus-specific features (PCI, ...).
The target device type can be detected by reading the magic.
Also, the macros RTE_DEVICE_DECL and RTE_DEVICE_PTR_DECL are introduced to
provide a gen
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_pci.h
b/lib/librte_eal/common/include/rte_pci.h
index db8382f..54d0fe2 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/li
To distinguish between different types of drivers, include a member .magic
at the beginning of the rte_pci_driver structure.
Signed-off-by: Jan Viktorin
---
drivers/net/bnx2x/bnx2x_ethdev.c| 2 ++
drivers/net/cxgbe/cxgbe_ethdev.c| 1 +
drivers/net/e1000/em_ethdev.c | 1
Hello DPDK community,
A few days ago, I've proposed an RFC of a new infrastructure that allows to
detect non-PCI devices present on SoC systems. It is, however, the easier part
of the story. To bring support of non-PCI devices, it is necessary to do much
deeper changes in DPDK. In this patch serie
Hi Jianfeng,
> -Original Message-
> From: Tan, Jianfeng
> Sent: Thursday, December 31, 2015 6:53 AM
> To: dev at dpdk.org
> Cc: Zhang, Helin; Ananyev, Konstantin; Tan, Jianfeng
> Subject: [PATCH 12/12] examples/l3fwd: add option to parse ptype
>
> Firstly, use rte_eth_dev_get_ptype_info()
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index c363bf6..8a40127 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethd
This commit adds vmxnet3 TSO support.
Verified with test-pmd (set fwd csum) that both tso and non-tso
pkts can be successfully transmitted and all segmentes for a tso
pkt are correct on the receiver side.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +
drivers/net/vmx
Support TCP/UDP checksum offload.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 39 +++-
2 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b/do
Tx data ring support was removed in a previous change
to add multi-seg transmit. This change adds it back.
Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 5 +
drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 +++
v2:
* fixed some logging issues when debug option turned on
* updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
One of the use cases for these features is to support STT. It also
restores the tx data ring feature that w
> -Original Message-
> From: Tan, Jianfeng
> Sent: Thursday, December 31, 2015 6:53 AM
> To: dev at dpdk.org
> Cc: Zhang, Helin; Ananyev, Konstantin; Tan, Jianfeng
> Subject: [PATCH 07/12] pmd/ixgbe: add dev_ptype_info_get implementation
>
> Signed-off-by: Jianfeng Tan
> ---
> drivers/
On 1/5/2016 1:24 AM, Stephen Hemminger wrote:
> On Mon, 4 Jan 2016 01:56:13 +0800
> Huawei Xie wrote:
>
>> +if (pci_dev->kdrv != RTE_KDRV_NONE) {
>> +PMD_INIT_LOG(INFO,
>> +"kernel driver is manipulating this device." \
>> +" Please unbind t
Add multicast promiscuous mode support on ixgbe VF driver.
Please note if we want to use this promiscuous mode, we need both PF
and VF driver to support it. The reason is this VF feature is
configged on PF.
If use kernel PF driver + dpdk VF driver, make sure kernel PF driver
support VF multicast p
Hi Uday,
> I have an issue in running qos_sched application in DPDK .Could someone tell
> me how to run the command and what each parameter does In the below
> mentioned text.
>
> Application mandatory parameters:
> --pfc "RX PORT, TX PORT, RX LCORE, WT LCORE" : Packet flow configuration
>
On 1/3/16, 11:12 AM, "dev on behalf of Jan Viktorin" wrote:
>On Sat, 2 Jan 2016 19:45:40 +0100
>Jan Viktorin wrote:
>
>> >
>> > Do you consider this will break binary compatibility since
>> > sizeof (rte_soc_addr) is PATH_MAX (1024) and the other elements of the
>> > union inside rte_devargs ar
Hi Hanoch,
Please find some comments below.
On 12/27/2015 10:39 AM, Hanoch Haim (hhaim) wrote:
> Hi Bruce,
>
> I'm Hanoch from Cisco Systems works for the
> https://github.com/cisco-system-traffic-generator/trex-core traffic generator
> project.
>
> While upgrading from DPDK 1.8 to 2.2 Ido f
Hi Oliver,
Let's take your drawing as a reference and add my question
The use case is sending a duplicate multicast packet by many threads.
I can split it to x threads to do the job and with atomic-ref (my multicast not
mbuf) count it until it reaches zero.
In my following example the two cores
Hello All,
I have an issue in running qos_sched application in DPDK .Could someone tell me
how to run the command and what
each parameter does In the below mentioned text.
Application mandatory parameters:
--pfc "RX PORT, TX PORT, RX LCORE, WT LCORE" : Packet flow configuration
m
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Monday, January 04, 2016 11:38 AM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet
> type is set
>
> I'm not s
You should be able to clone networking-ovs-dpdk, switch to kilo branch, and run
python setup.py install
in the root of networking-ovs-dpdk, that should install agent and mech driver.
Then you would need to enable mech driver (ovsdpdk) on the controller in the
/etc/neutron/plugins/ml2/ml2_conf.ini
Hi Jerin,
Please see some comments below.
On 12/14/2015 05:32 AM, Jerin Jacob wrote:
> - RTE_CACHE_MIN_LINE_SIZE(Supported minimum cache line size)
> - __rte_cache_min_aligned(Force minimum cache line alignment)
> - RTE_CACHE_LINE_SIZE_LOG2(Express cache line size in terms of log2)
>
> Signed-of
I'm not sure about the usefulness of this new callback, but one issue I see
with rte_eth_dev_get_ptype_info() is that determining the proper size for
ptypes[] according to a mask is awkward. For instance suppose
RTE_PTYPE_L4_MASK is redefined to a different size at some point, the caller
must dynam
On Mon, Jan 04, 2016 at 03:55:14AM +, Xu, Qian Q wrote:
> Does dpdk vhost-switch sample support virtio1.0? I tried it but seems not
> working.
It has nothing to do with vhost-switch sample. It worked from my
test; you may come to find me offline to see what might be wrong
on your side.
Hi Jianfeng,
I'm only commenting the mlx4/mlx5 bits in this message, see below.
On Thu, Dec 31, 2015 at 02:53:15PM +0800, Jianfeng Tan wrote:
> Signed-off-by: Jianfeng Tan
> ---
> drivers/net/mlx4/mlx4.c | 27 +++
> 1 file changed, 27 insertions(+)
>
> diff --git a/driv
Hi Jijang,
My comments below MW>
> -Original Message-
> From: Liu, Jijiang
> Sent: Monday, December 28, 2015 6:55 AM
> To: Walukiewicz, Miroslaw; dev at dpdk.org
> Subject: RE: [dpdk-dev] [RFC PATCH 0/6] General tunneling APIs
>
> Hi Miroslaw,
>
> The partial answer is below.
>
> > --
Hello,
Four mails for this ? :-)
Please test off-list when you are not sure how to send patches.
On Sun, Jan 3, 2016 at 3:49 PM, Yi Lu wrote:
> Error message:
> /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function
> ?rte_eal_hpet_init?:
> /root/dpdk-2.2.0/lib/librte_eal/linuxap
Signed-off-by: Huawei Xie
---
app/test-pmd/cmdline.c | 12 ++--
app/test-pmd/config.c | 2 +-
app/test-pmd/flowgen.c | 2 +-
app/test-pmd/mempool_anon.c| 12 ++--
app/test-pmd/testpmd.h
On Mon, 4 Jan 2016 09:02:53 +
"Xie, Huawei" wrote:
> > + PMD_INIT_LOG(ERR,
> Better change ERR to INFO and revise the message followed, since user
> might not want to use this device for DPDK.
> > + "%s(): kernel driver is manipulating this device." \
> > +
On Mon, 4 Jan 2016 01:56:09 +0800
Huawei Xie wrote:
> v2 changes:
> Remove unnecessary assignment of NULL to dev->data->mac_addrs
> Ajust one comment's position
> change LOG level from ERR to INFO
>
> virtio PMD doesn't set RTE_PCI_DRV_NEED_MAPPING in drv_flags of its
> eth_driver. It will t
On Mon, 4 Jan 2016 01:56:13 +0800
Huawei Xie wrote:
> + if (pci_dev->kdrv != RTE_KDRV_NONE) {
> + PMD_INIT_LOG(INFO,
> + "kernel driver is manipulating this device." \
> + " Please unbind the kernel driver.");
Splitting strings in general
On 12/25/2015 6:33 PM, Xie, Huawei wrote:
> virtio PMD could use IO port to configure the virtio device without
> using uio driver.
>
> There are two issues with previous implementation:
> 1) virtio PMD will take over each virtio device blindly even if some
> are not intended for DPDK.
> 2) driver
Hi,
We are using OVS 2.4 with DPDK 2.0 with kernel 3.18.22. Default flow rules i.e
NORMAL rules are there.KNI port is a member port of the ovs bridge
We are using Openmul controller and when invoke the set-controller command i.e
ovs-vsctl --no-wait set-controller br0 tcp:127.0.0.1:6653, kni
Does dpdk vhost-switch sample support virtio1.0? I tried it but seems not
working.
Thanks
Qian
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng
Sent: Tuesday, December 29, 2015 7:19 PM
To: Yuanhan Liu; dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH
On 1/3/16, 4:07 PM, "dev on behalf of Matthew Hall" wrote:
>On 1/3/16 9:09 AM, Wiles, Keith wrote:
>> Pktgen is setup for tabs for 4 (with replace tabs with spaces), using tab
>> stop of 8 is just wrong IMO :-)
>> Just started using kdevelop instead of eclipse, so I may have corrupted the
>> st
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, January 1, 2016 1:02 AM
> To: Wang, Zhihong
> Cc: dev at dpdk.org; Ananyev, Konstantin ;
> Qiu,
> Michael
> Subject: Re: [PATCH v5 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in
> l
v2 changes:
change LOG level from ERR to INFO
virtio PMD could use IO port to configure the virtio device without
using uio driver.
There are two issues with previous implementation:
1) virtio PMD will take over each virtio device blindly even if some
are not intended for DPDK.
2) driver conflic
v2 changes:
Remove unnecessary assignment of NULL to dev->data->mac_addrs
Ajust one comment's position
if virtio_resource_init fails, cleanup the resource and return 1 to
tell the upper layer we don't take over this device.
return -1 means error and DPDK will exit.
Signed-off-by: Huawei Xie
--
Use RTE_KDRV_NONE to indicate that kernel driver isn't manipulating
the device.
Signed-off-by: Huawei Xie
Acked-by: David Marchand
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
b/lib/librte_ea
Signed-off-by: Huawei Xie
---
lib/librte_eal/common/eal_common_pci.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c
b/lib/librte_eal/common/eal_common_pci.c
index dcfe947..bbcdb2b 100644
--- a/lib/librte_eal/common/eal_common_pc
v2 changes:
Remove unnecessary assignment of NULL to dev->data->mac_addrs
Ajust one comment's position
change LOG level from ERR to INFO
virtio PMD doesn't set RTE_PCI_DRV_NEED_MAPPING in drv_flags of its
eth_driver. It will try igb_uio and PORT IO in turn to configure
virtio device. Even user
On 1/3/16, 5:35 PM, "Yigit, Ferruh" wrote:
>On Sun, Jan 03, 2016 at 05:09:16PM +, Wiles, Keith wrote:
>
>
>
>> A bigger question is what is the coding style of DPDK and where is it
>> documented? I looked in the docs/web site and did not find any coding style
>> suggestions. Maybe I missed
58 matches
Mail list logo
