On 1/5/2016 1:24 AM, Stephen Hemminger wrote: > On Mon, 4 Jan 2016 01:56:13 +0800 > Huawei Xie <huawei.xie at intel.com> wrote: > >> + if (pci_dev->kdrv != RTE_KDRV_NONE) { >> + PMD_INIT_LOG(INFO, >> + "kernel driver is manipulating this device." \ >> + " Please unbind the kernel driver."); > Splitting strings in general is a bad idea since it makes it harder to find > log messages. > Also the first clause is lower case and the second is captialized. Got it. This is to avoid 80 char warning. Will put it in one line to make it friendly for searching. The first clause is lower is because it actually follows "%s():". > > Lastly, the backslash continuation is unnecessary here and will cause > checkpatch warning. >
- [dpdk-dev] [PATCH 4/4] virtio: check if any ker... Xie, Huawei
- [dpdk-dev] [PATCH 4/4] virtio: check if any... Stephen Hemminger
- [dpdk-dev] [PATCH 4/4] virtio: check if any... Panu Matilainen
- [dpdk-dev] [PATCH 0/4] check if any kernel driver i... Peter Xu
- [dpdk-dev] [PATCH v2 0/4] fix the issue that DPDK takes ... Huawei Xie
- [dpdk-dev] [PATCH v2 1/4] eal: make the comment mor... Huawei Xie
- [dpdk-dev] [PATCH v2 2/4] eal: set kdrv to RTE_KDRV... Huawei Xie
- [dpdk-dev] [PATCH v2 3/4] virtio: return 1 to tell ... Huawei Xie
- [dpdk-dev] [PATCH v2 4/4] virtio: check if any kern... Huawei Xie
- [dpdk-dev] [PATCH v2 4/4] virtio: check if any ... Stephen Hemminger
- [dpdk-dev] [PATCH v2 4/4] virtio: check if ... Xie, Huawei
- [dpdk-dev] [PATCH v2 4/4] virtio: check... Yuanhan Liu
- [dpdk-dev] [PATCH v2 4/4] virtio: check... Ferruh Yigit
- [dpdk-dev] [PATCH v2 4/4] virtio: check if any ... Panu Matilainen
- [dpdk-dev] [PATCH v2 4/4] virtio: check if ... Thomas Monjalon
- [dpdk-dev] [PATCH v2 0/4] fix the issue that DPDK t... Stephen Hemminger
- [dpdk-dev] [PATCH v2 0/4] fix the issue that DP... Xie, Huawei
- [dpdk-dev] [PATCH v2 0/4] fix the issue tha... Santosh Shukla
- [dpdk-dev] [PATCH v2 0/4] fix the issue... Xie, Huawei
- [dpdk-dev] [PATCH v2 0/4] fix the ... Santosh Shukla
- [dpdk-dev] [PATCH v3 0/4] fix the issue that DPDK takes ... Huawei Xie