[dpdk-dev] rte_lpm with larger nexthops or another method?

2015-06-22 Thread Stephen Hemminger
In order to make Vyatta/Brocade router work with LPM code I ended up redoing the layout. It is: /** Tbl24 entry structure. */ struct rte_lpm_tbl24_entry { /* Using single uint8_t to store 3 values. */ uint8_t valid :1; /**< Validation flag. */ uint8_t ext_entry :1;

[dpdk-dev] rte_lpm with larger nexthops or another method?

2015-06-22 Thread Matthew Hall
On Mon, Jun 22, 2015 at 11:51:02PM -0400, Stephen Hemminger wrote: > In order to make Vyatta/Brocade router work with LPM code > I ended up redoing the layout. It is: > > And also several other scalability improvements (plus IPv6) > and the correct handling of /32. > > Unfortunately, this is such

[dpdk-dev] [PATCH] app/test: Fix potential null pointer accesses in test_mbuf

2015-06-22 Thread Thomas Monjalon
2015-06-12 11:54, Tetsuya Mukawa: > The patch fixes potential null pointer accesses in test_mbuf. > if 'm[i]' is null, stop accessing it. > > Signed-off-by: Tetsuya Mukawa Applied, thanks

[dpdk-dev] [PATCH v1] app/test: fix pmd_perf issue in no NUMA case

2015-06-22 Thread Thomas Monjalon
2015-06-08 14:33, Cunming Liang: > Reported-by: Jayakumar, Muthurajan > Signed-off-by: Cunming Liang Please explain exactly what you try to fix. Is it still needed since this patch? http://dpdk.org/browse/dpdk/commit/?id=94ef2964148a4540 > + socket_id = rte_eth_dev_socket_id(port_id

[dpdk-dev] [PATCH] examples/distributor: fix missing "; " in debug macro

2015-06-22 Thread Thomas Monjalon
2015-06-08 11:58, Bruce Richardson: > On Fri, Jun 05, 2015 at 10:45:04PM +0200, Thomas Monjalon wrote: > > It shows that such dead code is almost never tested. > > It would be saner if this command would return no result: > > git grep 'ifdef.*DEBUG' examples > > examples/distributor

[dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros

2015-06-22 Thread Thomas Monjalon
2015-06-22 13:23, Cyril Chemparathy: > On Mon, 22 Jun 2015 22:16:59 +0200 > Thomas Monjalon wrote: > > Cyril, feel free to fix it if it breaks with Tile arch. > > Why define these locally within rte_port.h? Shouldn't these macros > really be in rte_mbuf.h? No, an application is free to put its m

[dpdk-dev] [PATCH] examples/distributor: fix missing "; " in debug macro

2015-06-22 Thread Thomas Monjalon
2015-06-05 17:01, Bruce Richardson: > The macro to turn on additional debug output when the app was compiled > with "-DDEBUG" was missing a ";". > > Fixes: 07db4a975094 ("examples/distributor: new sample app") > > Signed-off-by: Anbarasan Murugesan > Signed-off-by: Bruce Richardson Applied, th

[dpdk-dev] [PATCH] rte_reorder: Allow sequence numbers > 0 as starting point

2015-06-22 Thread Thomas Monjalon
2015-05-29 17:37, Gonzalez Monroy, Sergio: > On 20/05/2015 12:02, Simon Kagstrom wrote: > > We use sequence numbers from a generator which has potentially started > > long before the receiver. Therefore, the first number will typically > > be > 0. The rte_reorder code will not work in this case, si

[dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros

2015-06-22 Thread Thomas Monjalon
2015-06-05 15:31, Dumitrescu, Cristian: > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to > > meta-data fields. > > Forcing aligned accesses is not really required, so this is removing an > > unneeded constraint. > > This issue was met during testing of the new version of the ip_p

[dpdk-dev] [PATCH v2] eal:Fix log messages always being printed from rte_eal_cpu_init

2015-06-22 Thread Thomas Monjalon
2015-06-19 11:54, David Marchand: > On Mon, Jun 8, 2015 at 11:55 PM, Keith Wiles wrote: > > The RTE_LOG(DEBUG, ...) messages in rte_eal_cpu_init() are printed > > even when the log level on the command line was set to INFO or lower. > > > > The problem is the rte_eal_cpu_init() routine was called

[dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support.

2015-06-22 Thread Thomas Monjalon
2015-06-22 10:03, Cyril Chemparathy: > On Mon, 22 Jun 2015 19:00:44 +0200 > Thomas Monjalon wrote: > > > > > Not sure it makes sense to have different library names. > > > > Why not renaming all to "dpdk"? > > > > > > This config doesn't seem to be getting used anywhere. Maybe just > > > get

[dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support.

2015-06-22 Thread Thomas Monjalon
2015-06-22 09:54, Cyril Chemparathy: > On Mon, 22 Jun 2015 11:39:07 +0200 > Thomas Monjalon wrote: > > > > +CONFIG_RTE_LIBNAME="tile_dpdk" > > > > Not sure it makes sense to have different library names. > > Why not renaming all to "dpdk"? > > This config doesn't seem to be getting used anywh

[dpdk-dev] [PATCH v2 05/10] eal: add and use unaligned integer types

2015-06-22 Thread Thomas Monjalon
2015-06-22 09:47, Cyril Chemparathy: > On Mon, 22 Jun 2015 11:36:20 +0200 > Thomas Monjalon wrote: > > > 2015-06-19 10:34, Cyril Chemparathy: > > > On machines that are strict on pointer alignment, current code > > > breaks on GCC's -Wcast-align checks on casts from narrower to wider > > > types.

[dpdk-dev] [PATCH v2] log: Properly reset log_history_size in rte_log_dump_history()

2015-06-22 Thread Thomas Monjalon
2015-06-01 11:46, Olivier MATZ: > On 06/01/2015 11:30 AM, Jan Blunck wrote: > > In rte_log_dump_history() the log_history list is reinitialized without > > resetting the log_history_size. In the next call to rte_log_add_in_history() > > the log_history_size > RTE_LOG_HISTORY and the code unconditio

[dpdk-dev] [PATCH] ivshmem: fix segmentation fault in corner case

2015-06-22 Thread Thomas Monjalon
2015-06-18 13:27, Sergio Gonzalez Monroy: > Depending on the configured segments it is possible to hit a > segmentation fault as a result of decrementing an unsigned index with > value 0. > > To avoid it, exit the loop if the index has value 0. > > Signed-off-by: Sergio Gonzalez Monroy Applied,

[dpdk-dev] [PATCH v2] kni: ignore double calls to rte_kni_init()

2015-06-22 Thread Thomas Monjalon
> > Prevent double initialization of the KNI subsytem. > > > > v2: added warning trace > > > > Signed-off-by: Marc Sune > Acked-by: Helin Zhang Applied, thanks

[dpdk-dev] DPDK with Openvswitch Compatibility issue

2015-06-22 Thread Sundar Ramakrishnan
Hello, I have trying to compile and install openvswitch with dpdk. I have tried dpdk-1.7.0 through dpdk-2.0.0 with openvswitch-2.0.0 through openvswitch-2.3.2. I have been following these two guides -? http://openvswitch.org/support/dist-docs/INSTALL.DPDK.md.txt Intel? Data Plane Development Kit

[dpdk-dev] [PATCH v2] lib_vhost:reset secure_len when rte_atomic16_cmpset failed

2015-06-22 Thread Thomas Monjalon
2015-06-01 06:14, Ouyang, Changchun: > From: Wei li, June 1, 2015 2:12 PM: > > when rte_atomic16_cmpset return 0 in first loop, secure_len should be > > reset to 0 in second loop, otherwise (pkt_len > secure_len) always be > > false, > > the num of desc maybe not enough > > > > Signed-off-by: W

[dpdk-dev] [PATCH] pmd_ring: return new port id on ethdev creation

2015-06-22 Thread Thomas Monjalon
> The rte_eth_from_rings API allowed the creation of an ethdev port at > runtime using rte_rings as the underlying storage. However, the return > value from this function was either 0 or -1, and these values were never > actually documented in the API documentation. Unfortunately, the programmers >

[dpdk-dev] [PATCH v2 1/3] spinlock: add support for HTM lock elision for x86

2015-06-22 Thread Adrien Mazarguil
On Fri, Jun 19, 2015 at 03:35:38PM +0200, Thomas Monjalon wrote: > 2015-06-18 11:00, Bruce Richardson: > > On Wed, Jun 17, 2015 at 11:29:49PM +0200, Thomas Monjalon wrote: > > > Introducing rte_cpuflags.h in this header breaks the compilation of > > > the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=

[dpdk-dev] [PATCH] ixgbe: fix x550 shutdown API issue

2015-06-22 Thread Thomas Monjalon
> > For there're only laser ports on x550 before, we only considered laser > > ports for the testpmd CLIs "port start/stop ...". Now we have new x550 > > devices which have copper ports. Use the API for copper to enable/disable > > these ports. > > > > And also let the testpmd CLI "set link-up/dow

[dpdk-dev] [PATCH v2] fm10k: fix PF/VF MAC address register and clean up bug

2015-06-22 Thread Thomas Monjalon
> > v2 changes: > > - rebase this patch onto the HEAD > > - add more description for this patch > > > > This patch includes 3 changes related to MAC/VLAN address table > > when the system(e.g. testpmd) is started and closed: > > - remove default MAC address with fixed VLAN 0 which was for the >

[dpdk-dev] [PATCH 2/4] ethdev: expose extended error stats

2015-06-22 Thread Olivier MATZ
Hello Maryam, On 06/22/2015 04:12 PM, Tahhan, Maryam wrote: > >> 2015-06-05 18:35, Maryam Tahhan: >>> Extend rte_eth_xstats_get to retrieve additional stats from the device >>> driver as well the top level extended stats. Add additional drop >>> counters to the extended stats. >>> >>> Signed-off-

[dpdk-dev] [PATCH v2] ixgbe: fix TSO in IPv6

2015-06-22 Thread Thomas Monjalon
> > From: Didier Pallard > > > > When TSO is used with IPv6, generated frames are incorrect. > > L4 frame is OK, but length field of IPv6 header was not populated correctly. > > > > IXGBE_ADVTXD_TUCMD_IPV6 flag is set for better readability, even if it does > > nothing. > > > > Signed-off-by: D

[dpdk-dev] [PATCH v3 0/3] fm10k: update MAC/VLAN filter and VLAN offload features

2015-06-22 Thread Thomas Monjalon
> > v3 changes: > > - add more result check for MAC table mailbox operation for VLAN filter > > - remove two extra indentation tabs > > > > v2 changes: > > - add result check when updating MAC address table for VLAN filter > > - move VLAN Table updating to the end of VLAN filter process > > -

[dpdk-dev] [PATCH v2] ixgbe: fix TSO in IPv6

2015-06-22 Thread David Marchand
From: Didier Pallard When TSO is used with IPv6, generated frames are incorrect. L4 frame is OK, but length field of IPv6 header was not populated correctly. IXGBE_ADVTXD_TUCMD_IPV6 flag is set for better readability, even if it does nothing. Signed-off-by: Didier Pallard Signed-off-by: David

[dpdk-dev] [PATCH 0/6] fm10k: A series of bug fixes

2015-06-22 Thread Thomas Monjalon
> > This patch set include a few bug fixes and enhancements on fm10k driver. > > > > Chen Jing D(Mark) (6): > > fm10k: Fix improper RX buffer size assignment > > fm10k: Fix jumbo frame issue > > fm10k: Fix data integrity issue with multi-segment frame > > fm10k: Fix issue that MAC addr can'

[dpdk-dev] [PATCH 2/4] ethdev: expose extended error stats

2015-06-22 Thread Tahhan, Maryam
> >>> + packets. */ > >>> }; > >> > >> You are extending the generic stats. This is not the idea behind xstats. > >> The xstats are specific to the driver. > > > > I'd followed the example of: > > http://patchwork.dpdk.org/dev/patchwork/patch/85/ > > to added generic extended stats (at least what

[dpdk-dev] Issue with rte_compat versioning macros

2015-06-22 Thread Gajdzica, MaciejX T
Hi Neil > -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Friday, June 19, 2015 5:32 PM > To: Gajdzica, MaciejX T > Cc: Thomas Monjalon; dev at dpdk.org > Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros > > On Fri, Jun 19, 2015 at 03:04:17P

[dpdk-dev] [PATCH v2 0/3] fm10k: Add promiscuous mode support

2015-06-22 Thread Thomas Monjalon
2015-06-12 15:06, Chen Jing D: > From: "Chen Jing D(Mark)" > > v2: > Add debug messages in allmulticast enable/disable functions. > > The patch set add promiscuous mode configuration and 2 bug fixes. > > Chen Jing D(Mark) (3): > fm10k: Add promiscuous mode support > fm10k: remove mbuf siz

[dpdk-dev] [PATCH v2 0/6] cfgfile: config file parsing extension

2015-06-22 Thread Gajdzica, MaciejX T
> -Original Message- > From: Gajdzica, MaciejX T > Sent: Wednesday, June 17, 2015 4:49 PM > To: dev at dpdk.org > Cc: Gajdzica, MaciejX T > Subject: [PATCH v2 0/6] cfgfile: config file parsing extension > > Added new implementation of section parsing in config file. Refactored > existing

[dpdk-dev] [PATCH v2] ixgbe: fix TSO in IPv6

2015-06-22 Thread Zhang, Helin
> -Original Message- > From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Monday, June 22, 2015 10:21 PM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Zhang, Helin; Didier Pallard > Subject: [PATCH v2] ixgbe: fix TSO in IPv6 > > From: Didier Pallard > > When TSO is us

[dpdk-dev] [PATCH v3 00/10] vmxnet3: multisegment and bugfixes

2015-06-22 Thread Thomas Monjalon
2015-03-10 14:42, Thomas Monjalon: > 2015-03-05 16:10, Stephen Hemminger: > > From: Stephen Hemminger > > > > Revised version of earlier patches. > > Incorporate the small packet optimization > > Add more cleanups > > > > Stephen Hemminger (10): > > vmxnet3: fix link state handling > > vmxne

[dpdk-dev] [PATCH 2/4] ethdev: expose extended error stats

2015-06-22 Thread Tahhan, Maryam
> 2015-06-05 18:35, Maryam Tahhan: > > Extend rte_eth_xstats_get to retrieve additional stats from the device > > driver as well the top level extended stats. Add additional drop > > counters to the extended stats. > > > > Signed-off-by: Maryam Tahhan > [..] > Patch 1/4 doesn't compile without pa

[dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize the VXLAN sample

2015-06-22 Thread Liu, Jijiang
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, June 22, 2015 3:49 PM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize > the VXLAN sample > > 2015-06-18 09:03, Jijian

[dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros

2015-06-22 Thread Cyril Chemparathy
On Mon, 22 Jun 2015 22:16:59 +0200 Thomas Monjalon wrote: > 2015-06-05 15:31, Dumitrescu, Cristian: > > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to > > > meta-data fields. > > > Forcing aligned accesses is not really required, so this is > > > removing an unneeded constraint

[dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros

2015-06-22 Thread Cyril Chemparathy
On Mon, 22 Jun 2015 22:16:59 +0200 Thomas Monjalon wrote: > 2015-06-05 15:31, Dumitrescu, Cristian: > > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to > > > meta-data fields. > > > Forcing aligned accesses is not really required, so this is > > > removing an unneeded constraint

[dpdk-dev] rte_lpm with larger nexthops or another method?

2015-06-22 Thread Vladimir Medvedkin
Hi Matthew, I just recently thought about next_hop extension. For ipv4 we can do something like: struct rte_lpm_tbl24_entry { /* Stores Next hop or group index (i.e. gindex)into tbl8. */ union { uint32_t next_hop :24; uint32_t tbl8_gindex :24;

[dpdk-dev] Issue with rte_compat versioning macros

2015-06-22 Thread Neil Horman
On Mon, Jun 22, 2015 at 03:32:01PM +, Gajdzica, MaciejX T wrote: > Hi Neil > > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Friday, June 19, 2015 5:32 PM > > To: Gajdzica, MaciejX T > > Cc: Thomas Monjalon; dev at dpdk.org > > Subject: Re: [dpd

[dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize

2015-06-22 Thread Iremonger, Bernard
> -Original Message- > From: Qiu, Michael > Sent: Thursday, June 11, 2015 8:30 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; thomas.monjalon at 6wind.com; Qiu, Michael > Subject: [PATCH v2] ixgbe: reset hardware stat when initialize > > When initialize the hardware, the stat should be

[dpdk-dev] Changing emulator in virsh XML

2015-06-22 Thread Venkateswara Rao Dokku
Hi All, I have installed qemu 2.0 version. I could able to launch a VM with this version of qemu. I compiled OVDK qemu version from sources & wanted to launch a VM with this OVDK qemu version. For this, I tried adding a line */root/ovdk/qemu/x86_64-softmmu/qemu-system-x86_64* under block in t

[dpdk-dev] Cannot ping host network from guest

2015-06-22 Thread Venkateswara Rao Dokku
HI, I instantiated a VM from the qemu that was given along with the OVDK package with the follwoing command. ./qemu/x86_64-softmmu/qemu-system-x86_64 --enable-kvm -smp 2 -m 4096m -device virtio-scsi-pci,id=scsi -device scsi-hd,drive=hd,physical_block_size=4096 -drive if=none,id=hd,file=/var/lib/l

[dpdk-dev] [PATCH] ixgbevf: fix link status for PF up/down events

2015-06-22 Thread Thomas Monjalon
2015-06-16 15:38, Sergio Gonzalez Monroy: > Current ixgbe VF base driver only really read the status register when: > - get_link_status is true > - link reset > - mailbox timeout. > > We only set get_link_status to true when we start the PF/VF, so > following calls to ixgbe_dev_link_update will

[dpdk-dev] [PATCH] ixgbevf: fix incorrect RX function selection

2015-06-22 Thread Thomas Monjalon
> > The logic to select ixgbe VF RX function is different than PF side. > > > > There are a few issues with its current state: > > - it does not allow to select ixgbe_recv_pkts_vec among other options. > > - it can cause memory corruption for scatter mode as it does not allocate > >enough en

[dpdk-dev] [PATCH] use tab rather than space in mbuf version map file

2015-06-22 Thread Olivier MATZ
Hi, On 06/18/2015 07:55 PM, Huawei Xie wrote: > Signed-off-by: Huawei Xie > --- > lib/librte_mbuf/rte_mbuf_version.map | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Acked-by: Olivier Matz Thanks Olivier > diff --git a/lib/librte_mbuf/rte_mbuf_version.map > b/lib/librte_

[dpdk-dev] [PATCH] ixgbe: fix the flow director flexbytes offset issues

2015-06-22 Thread Thomas Monjalon
> > > The flexbytes offset can not be set, because the value is over written > > > when fdir is enabled. > > > This patch fixes this issue, and also removes some reduplicate lines. > > > > > > Reported-by: David Marchand > > > Signed-off-by: Jingjing Wu > > > > Tested-by: Gaetan Rivet > > Thank

[dpdk-dev] [PATCH v2 12/12] maintainers: claim responsibility for TILE-Gx platform

2015-06-22 Thread Cyril Chemparathy
Change-Id: I6491108ff86c1249bf4ffa4d4624c01b4594805e Signed-off-by: Cyril Chemparathy --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9362c19..bffc1e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -113,6 +113,10 @@ M: Bruce Richardson M: K

[dpdk-dev] [PATCH v2 11/12] tile: Add TILE-Gx mPIPE poll mode driver.

2015-06-22 Thread Cyril Chemparathy
This commit adds a poll mode driver for the mPIPE hardware present on TILE-Gx SoCs. Change-Id: I1b9a9ef2c9f1c96810ec58b4d2ae77b870a6ec94 Signed-off-by: Cyril Chemparathy --- config/defconfig_tile-tilegx-linuxapp-gcc |1 + drivers/net/Makefile |1 + drivers/net/mpipe/

[dpdk-dev] [PATCH v2 10/12] tile: initial TILE-Gx support.

2015-06-22 Thread Cyril Chemparathy
This commit adds support for the TILE-Gx platform, as well as the TILE CPU architecture. This architecture port is fairly simple due to its reliance on generics for most arch stuff. Change-Id: I809fcf740e25ba5976a6b7736c1673515338cf80 Signed-off-by: Cyril Chemparathy --- config/defconfig_tile-t

[dpdk-dev] [PATCH v2 09/12] tile: add page sizes for TILE-Gx/Mx platforms

2015-06-22 Thread Cyril Chemparathy
This patch adds a few new page sizes that are supported on the TILE-Gx and TILE-Mx platforms. Change-Id: I7da783703149c4f96b84d0017fa4f1191fc029c6 Signed-off-by: Cyril Chemparathy --- lib/librte_eal/common/eal_common_memzone.c | 8 + lib/librte_eal/common/include/rte_memory.h | 16 +--

[dpdk-dev] [PATCH v2 08/12] mempool: allow config override on element alignment

2015-06-22 Thread Cyril Chemparathy
On TILE-Gx and TILE-Mx platforms, the buffers fed into the hardware buffer manager require a 128-byte alignment. With this change, we allow configuration based override of the element alignment, and default to RTE_CACHE_LINE_SIZE if left unspecified. Change-Id: I9cd789d92b0bc9c8f44a633de59bb04d45

[dpdk-dev] [PATCH v2 07/12] memzone: allow multiple pagesizes to be requested

2015-06-22 Thread Cyril Chemparathy
This patch extends the memzone allocator to remove the restriction that prevented callers from specifying multiple page sizes in the flags argument. In doing so, we also sanitize the free segment matching logic to get rid of architecture specific disjunctions (2MB vs 1GB on x86, and 16MB vs 16GB o

[dpdk-dev] [PATCH v2 06/12] memzone: refactor rte_memzone_reserve() variants

2015-06-22 Thread Cyril Chemparathy
The definitions of rte_memzone_reserve_aligned() and rte_memzone_reserve_bounded() were identical with the exception of the bound argument passed into rte_memzone_reserve_thread_safe(). This patch removes this replication of code by unifying it into rte_memzone_reserve_thread_safe(), which is then

[dpdk-dev] [PATCH v2 05/12] config: remove RTE_LIBNAME definition.

2015-06-22 Thread Cyril Chemparathy
The library name is now being pinned to "dpdk" instead of intel_dpdk, powerpc_dpdk, etc. As a result, we no longer need this config item. This patch removes it. Change-Id: I36f7cf6c18c3563c6f5ccdf01bb70579c7ccaa16 Signed-off-by: Cyril Chemparathy --- config/common_bsdapp

[dpdk-dev] [PATCH v2 04/12] eal: allow empty compile time flags

2015-06-22 Thread Cyril Chemparathy
The rte_cpu_check_supported() code breaks with a "comparison is always false due to limited range of data type" when the compile_time_flags[] array is empty. Assigning the array dimension to a local variable apparently solves this. Change-Id: I0ae21f529cf7b6dd9cf0f4532dce9198f4bf4230 Signed-off-b

[dpdk-dev] [PATCH v2 03/12] hash: check SSE flags only on x86 builds

2015-06-22 Thread Cyril Chemparathy
This is necessary because the required CPU flags may not be defined on other architectures. Change-Id: I14d3f9f625b2e7567123f1c97095f8d06abd674b Signed-off-by: Cyril Chemparathy --- lib/librte_hash/rte_hash_crc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_hash/rte_hash_crc.

[dpdk-dev] [PATCH v2 02/12] hash: fix compilation on non-X86 platforms

2015-06-22 Thread Cyril Chemparathy
The "hash: remove duplicated code" change unfortunately broke the build for non-X86 platforms. This patch fixes this breakage. Change-Id: Ie109d67e681b75b45320fab1bf9de4eb9c9701bf Signed-off-by: Cyril Chemparathy --- lib/librte_hash/rte_jhash.h | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[dpdk-dev] [PATCH v2 01/12] test: limit x86 cpuflags checks to x86 builds

2015-06-22 Thread Cyril Chemparathy
The original code mistakenly defaulted to X86 when RTE_ARCH_PPC_64 was left undefined. This did not accomodate other non-PPC/non-X86 architectures. This patch fixes this issue. Change-Id: I5e8cf33c2eb917f7f6583dc95ed0f336066a285e Signed-off-by: Cyril Chemparathy --- app/test/test_cpuflags.c |

[dpdk-dev] [PATCH v2 00/12] Introducing the TILE-Gx platform

2015-06-22 Thread Cyril Chemparathy
This series adds support for the EZchip TILE-Gx family of SoCs. The architecture port in itself is fairly straight forward due to its reliance on generics for the most part. In addition to adding TILE-Gx architecture specific code, this series includes a few cross-platform fixes for DPDK (cpuflag

[dpdk-dev] [PATCH v6] e1000: igb and em1000 PCI Port Hotplug changes

2015-06-22 Thread Bernard Iremonger
This patch depends on the Port Hotplug Framework. It implements the eth_dev_uninit functions for rte_em_pmd, rte_igb_pmd and rte_igbvf_pmd. Changes in v6: Set nb_rx_queues and nb_tx_queues to 0 in uninit functions. Rebase to latest code. Changes in V5: Moved adapter stopped boolean to struct e100

[dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support.

2015-06-22 Thread Thomas Monjalon
2015-06-19 12:15, Cyril Chemparathy: > +CONFIG_RTE_LIBNAME="tile_dpdk" Not sure it makes sense to have different library names. Why not renaming all to "dpdk"?

[dpdk-dev] [PATCH v2 05/10] eal: add and use unaligned integer types

2015-06-22 Thread Thomas Monjalon
2015-06-19 10:34, Cyril Chemparathy: > On machines that are strict on pointer alignment, current code breaks > on GCC's -Wcast-align checks on casts from narrower to wider types. > This patch introduces new unaligned_uint(16|32|64)_t types, which > correctly retain alignment in such cases. [...] >

[dpdk-dev] [PATCH v4 9/9] librte_mbuf: Apply mtod-offset.cocci transform

2015-06-22 Thread Cyril Chemparathy
This patch simply applies the transform previously committed in scripts/cocci/mtod-offset.cocci. No other modifications have been made here. This patch applies on commit 960e8a22fc6d9373e37dd1454131e91f082bb8bc. This patch may need to be regenerated by rerunning scripts/cocci.sh instead of simply

[dpdk-dev] [PATCH v4 8/9] librte_mbuf: Add transform for rte_pktmbuf_mtod_offset()

2015-06-22 Thread Cyril Chemparathy
This patch adds a coccinelle (see http://coccinelle.lip6.fr/) transform to use the newly added rte_pktmbuf_mtod_offset() helper. In addition, we add a simple script to apply all available transforms to a codebase. Acked-by: Olivier Matz Change-Id: Ie1a82c48210098dd7bece81cc77cd5ea2da4148d Signed

[dpdk-dev] [PATCH v4 7/9] librte_mbuf: Add rte_pktmbuf_mtod_offset()

2015-06-22 Thread Cyril Chemparathy
There are a number of instances in the code where rte_pktmbuf_mtod() is used to get the mbuf data pointer, only to add an offset before casting the result to some other header type. This patch adds a new rte_pktmbuf_mtod_offset() macro to eliminate these awful double cast situations. Change-Id: I

[dpdk-dev] [PATCH v4 6/9] app/test-pmd: pack simple_gre_hdr

2015-06-22 Thread Cyril Chemparathy
Not packing this causes -Wcast-align breakage on machines that are strict on alignment. This patch fixes this bug. Acked-by: Olivier Matz Change-Id: I7feab9ea4fc33c4ebdf3503ca67477ca0809bb7e Signed-off-by: Cyril Chemparathy --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH v4 5/9] eal: add and use unaligned integer types

2015-06-22 Thread Cyril Chemparathy
On machines that are strict on pointer alignment, current code breaks on GCC's -Wcast-align checks on casts from narrower to wider types. This patch introduces new unaligned_uint(16|32|64)_t types, which correctly retain alignment in such cases. Strict alignment architectures will need to define C

[dpdk-dev] [PATCH v4 4/9] hash: silence -Wcast-align on pointer arithmetic

2015-06-22 Thread Cyril Chemparathy
Since sig_tbl_bucket_size and key_tbl_key_size are explicitly aligned at initialization, offset dereferences in the hash table code cannot possibly be unaligned. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_ADD(), thereby

[dpdk-dev] [PATCH v4 3/9] ethdev: silence -Wcast-align on pointer arithmetic

2015-06-22 Thread Cyril Chemparathy
Statistics offsets in the rte_stats_strings[] array are always 64-bit aligned. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_ADD(), thereby silencing the compiler by casting through (void *). Change-Id: I6460b4b84b89dce6ac0

[dpdk-dev] [PATCH v4 2/9] mbuf: silence -Wcast-align on pointer arithmetic

2015-06-22 Thread Cyril Chemparathy
Translating from an mbuf element to the mbuf pointer does not break alignment constraints. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_SUB(), thereby silencing the compiler by casting through (void *). Change-Id: I60d9b

[dpdk-dev] [PATCH v4 1/9] mempool: silence -Wcast-align on pointer arithmetic

2015-06-22 Thread Cyril Chemparathy
Translating from a mempool object to the mempool pointer does not break alignment constraints. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_SUB(), thereby silencing the compiler by casting through (void *). Change-Id: I4

[dpdk-dev] [PATCH v4 0/9] Improve cast alignment for strict aligned machines

2015-06-22 Thread Cyril Chemparathy
This series contains a few improvements that allow the DPDK code base to build properly on machines that enforce strict pointer cast alignment constraints. When dealing with packet data which could be arbitrarily aligned, we get the compiler to do the right thing by (a) making sure that header typ

[dpdk-dev] rte_lpm with larger nexthops or another method?

2015-06-22 Thread Matthew Hall
That's a lot better indeed! 16 million CIDR blocks would be a huge improvement. Do you happen to know what is also possible for rte_lpm6? Matthew. On Mon, Jun 22, 2015 at 01:11:14PM +0300, Vladimir Medvedkin wrote: > Hi Matthew, > > I just recently thought about next_hop extension. For ipv4 we

[dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support.

2015-06-22 Thread Cyril Chemparathy
On Mon, 22 Jun 2015 19:00:44 +0200 Thomas Monjalon wrote: > > > Not sure it makes sense to have different library names. > > > Why not renaming all to "dpdk"? > > > > This config doesn't seem to be getting used anywhere. Maybe just > > get rid of it globally? > > No it's used in mk/ direct

[dpdk-dev] [PATCH] mk: add support for gdb debug info generation

2015-06-22 Thread Simon Kågström
On 2015-06-22 09:44, Gonzalez Monroy, Sergio wrote: > On 19/06/2015 22:29, Cyril Chemparathy wrote: >> From: Cyril Chemparathy >> >> It is often useful to build with debug enabled, we add a config >> (CONFIG_RTE_TOOLCHAIN_DEBUG) to do so. >> >> +ifeq ($(CONFIG_RTE_TOOLCHAIN_DEBUG),y) >> +TOOLCHA

[dpdk-dev] [PATCH 09/11] tile: initial TILE-Gx support.

2015-06-22 Thread Cyril Chemparathy
On Mon, 22 Jun 2015 11:39:07 +0200 Thomas Monjalon wrote: > > +CONFIG_RTE_LIBNAME="tile_dpdk" > > Not sure it makes sense to have different library names. > Why not renaming all to "dpdk"? This config doesn't seem to be getting used anywhere. Maybe just get rid of it globally?

[dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize the VXLAN sample

2015-06-22 Thread Thomas Monjalon
2015-06-18 09:03, Jijiang Liu: > This sample uses the basic virtio devices management function from the vHost > example, which includes virtio device creation, destroying and maintenance. Please wrap commit message to about 72 characters. https://github.com/erlang/otp/wiki/Writing-good-commit-mes

[dpdk-dev] [PATCH v2 05/10] eal: add and use unaligned integer types

2015-06-22 Thread Cyril Chemparathy
On Mon, 22 Jun 2015 11:36:20 +0200 Thomas Monjalon wrote: > 2015-06-19 10:34, Cyril Chemparathy: > > On machines that are strict on pointer alignment, current code > > breaks on GCC's -Wcast-align checks on casts from narrower to wider > > types. This patch introduces new unaligned_uint(16|32|64)

[dpdk-dev] [PATCH] mk: add support for gdb debug info generation

2015-06-22 Thread Cyril Chemparathy
On Mon, 22 Jun 2015 08:44:41 +0100 "Gonzalez Monroy, Sergio" wrote: > I don't think you need to modify the makefiles and introduce a new > compile time option for this. > The same result can be easily achieved by setting EXTRA_CFLAGS in the > command line. ie: > $ make install T=x86_64-nat

[dpdk-dev] [PATCH v2 07/10] app/test: use struct ether_addr instead of a byte array cast

2015-06-22 Thread Cyril Chemparathy
On Sun, 21 Jun 2015 21:56:24 -0400 Stephen Hemminger wrote: > On Fri, 19 Jun 2015 10:34:50 -0700 > Cyril Chemparathy wrote: > > > + static struct ether_addr src_mac = > > + { { 0x00, 0xFF, 0xAA, 0xFF, 0xAA, 0xFF } }; > > + static struct ether_addr dst_mac = > > + { { 0x0

[dpdk-dev] [PATCH] mk: add support for gdb debug info generation

2015-06-22 Thread Gonzalez Monroy, Sergio
On 19/06/2015 22:29, Cyril Chemparathy wrote: > From: Cyril Chemparathy > > It is often useful to build with debug enabled, we add a config > (CONFIG_RTE_TOOLCHAIN_DEBUG) to do so. > > Note: This patch does not include corresponding changes for ICC. The > author pleads abject ignorance in this re

[dpdk-dev] Receive errors on all packets with multi-queues

2015-06-22 Thread Jakub Mazur
Hi I'm having problems with packets received when running 2 receive queues (on seperate lcores) on the same port but when I run 1 queue everything works correctly. The queues are using 32 bursts and are using the same mempool which is allocated on the same socket as the NIC, as are the queues. Whe