> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, June 22, 2015 3:49 PM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize > the VXLAN sample > > 2015-06-18 09:03, Jijiang Liu: > > This sample uses the basic virtio devices management function from the vHost > example, which includes virtio device creation, destroying and maintenance. > > Please wrap commit message to about 72 characters. > https://github.com/erlang/otp/wiki/Writing-good-commit-messages > https://git-scm.com/book/ch5-2.html
Ok, will follow this rule. > typo in Makefile: > overriden -> overridden > > There are 2 functions where ret is incremented but never initialized: > examples/tep_termination/main.c:473:6: error: ?ret? may be used uninitialized > in > this function > examples/tep_termination/main.c:536:8: error: ?ret? may be used uninitialized > in > this function > > Making a patch buildable with recent GCC and clang is the minimum before > submitting it. There is no a such error when I used GCC version 4.6.2. I will check the codes and use latest gcc version and clang to try. Anyway, thanks.
