[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 2:24 PM, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman > wrote: > >> On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: >> > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman >> wrote: >> > >> > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Rav

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Dave Neary
Hi Tim, On 04/23/2015 07:36 AM, O'Driscoll, Tim wrote: >> Alternatively, propose some options and vote, but I don't think we have >> things defined >> enough for that yet. > > We tried to keep the initial communication neutral and avoid suggesting > solutions to give others a chance to comment.

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Neil Horman
On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman > wrote: > > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > > wrote: > > > > > > > On Fri, Apr 24, 2015 at 08:14:04AM -

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread O'Driscoll, Tim
> From: lukego at gmail.com [mailto:lukego at gmail.com] On Behalf Of Luke > Gorrie > > > On 16 April 2015 at 12:38, O'Driscoll, Tim > > wrote: > > Following the launch of DPDK by Intel as an internal development project, > > the launch of dpdk.org by > > 6WIND in 2013, and the first DPDK RPM

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Jay Rolette
On Fri, Apr 24, 2015 at 1:51 PM, Neil Horman wrote: > So, I hear your arguments, and its understandable that you might not want > a GPL > licensed product, given that the DPDK is a library (though I'm not sure > what the > aversion to LGPL would be). Regardless, I think this conversation is a >

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Neil Horman
On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman wrote: > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > > wrote: > > > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Neil Horman
On Fri, Apr 24, 2015 at 01:12:13PM -0500, Matt Laswell wrote: > On Fri, Apr 24, 2015 at 12:39 PM, Jay Rolette > wrote: > > > > I can tell you that if DPDK were GPL-based, my company wouldn't be using > > it. I suspect we wouldn't be the only ones... > > > > I want to emphasize this point. It's u

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 12:51 PM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 12:21:23PM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman > wrote: > > > > > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman

[dpdk-dev] [PATCH 2/2] doc: refactored table numbers into references

2015-04-24 Thread John McNamara
This change adds automatic table references to the docs. The table numbers in the generated Html and PDF docs are now automatically numbered based on section. Requires Sphinx >= 1.3. This change: * Adds a RST table:: directive to each table caption. * Indents the tables to the required directiv

[dpdk-dev] [PATCH 1/2] doc: refactored figure numbers into references

2015-04-24 Thread John McNamara
This change adds automatic figure references to the docs. The figure numbers in the generated Html and PDF docs are now automatically numbered based on section. Requires Sphinx >= 1.3. The patch makes the following changes. * Changes image:: tag to figure:: and moves image caption to the figur

[dpdk-dev] [PATCH 0/2] doc: refactored fig and table nums into references

2015-04-24 Thread John McNamara
This patch adds automatic figure and table references to the docs. The figure and table numbers in the generated Html and PDF docs can now be automatically numbered based on section. Requires Sphinx >= 1.3. Advantages: * Figues/tables are numbered automatically and adding/removing items no lo

[dpdk-dev] [PATCH] doc: fixed spellings and typos

2015-04-24 Thread John McNamara
Fixed several typos and spelling errors in guide docs. Signed-off-by: John McNamara --- doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +- doc/guides/linux_gsg/build_dpdk.rst| 2 +- doc/guides/linux_gsg/build_sample_apps.rst | 2 +- doc/guides/linux_gsg/quick_s

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Matt Laswell
On Fri, Apr 24, 2015 at 12:39 PM, Jay Rolette wrote: > > I can tell you that if DPDK were GPL-based, my company wouldn't be using > it. I suspect we wouldn't be the only ones... > I want to emphasize this point. It's unsurprising that Jay and I agree, since we work together. But I can say with

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Neil Horman
On Fri, Apr 24, 2015 at 03:29:01PM +, O'Driscoll, Tim wrote: > > > From: lukego at gmail.com [mailto:lukego at gmail.com] On Behalf Of Luke > > Gorrie > > > > > On 16 April 2015 at 12:38, O'Driscoll, Tim > > > wrote: > > > Following the launch of DPDK by Intel as an internal development pro

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Jay Rolette
On Fri, Apr 24, 2015 at 2:47 AM, Luke Gorrie wrote: > 2. How will DPDK users justify contributing to DPDK upstream? > > Engineers in network equipment vendors want to contribute to open source, > but what is the incentive for the companies to support this? This would be > easy if DPDK were GPL'd

[dpdk-dev] [PATCH v2 6/6] hash: rename rte_jhash2 to rte_jhash_32b

2015-04-24 Thread Pablo de Lara
Changed name to something more meaningful, and mark rte_jhash2 as deprecated. Signed-off-by: Pablo de Lara --- app/test/test_func_reentrancy.c |2 +- app/test/test_hash.c|4 ++-- lib/librte_hash/rte_jhash.h | 18 +++--- 3 files changed, 18 insertions(+), 6 d

[dpdk-dev] [PATCH v2 5/6] hash: remove duplicated code

2015-04-24 Thread Pablo de Lara
rte_jhash is basically like _rte_jhash_2hashes but it returns only 1 hash, instead of 2. In order to remove duplicated code, rte_jhash calls _rte_jhash_2hashes, passing 0 as the second seed and returning just the first hash value. (performance penalty is negligible) The same is done with rte_jhas

[dpdk-dev] [PATCH v2 4/6] hash: add two new functions to jhash library

2015-04-24 Thread Pablo de Lara
With the jhash update, two new functions were introduced: - rte_jhash_2hashes: Same as rte_jhash, but takes two seeds and return two hashes (uint32_ts) - rte_jhash2_2hashes: Same as rte_jhash2, but takes two seeds and return two hashes (uint32_ts) Signed

[dpdk-dev] [PATCH v2 3/6] hash: update jhash function with the latest available

2015-04-24 Thread Pablo de Lara
Jenkins hash function was developed originally in 1996, and was integrated in first versions of DPDK. The function has been improved in 2006, achieving up to 60% better performance, compared to the original one. This patch integrates that code into the rte_jhash library. Signed-off-by: Pablo de L

[dpdk-dev] [PATCH v2 2/6] test/hash: improve accuracy on cycle measurements

2015-04-24 Thread Pablo de Lara
Cycles per hash calculation were measured per single operation. It is much more accurate to run several iterations between measurements and divide by number of iterations. Signed-off-by: Pablo de Lara --- app/test/test_hash_func_perf.c | 18 +- 1 files changed, 9 insertions(+),

[dpdk-dev] [PATCH v2 1/6] test/hash: move hash function perf tests to separate file

2015-04-24 Thread Pablo de Lara
This patch moves hash function performance tests to a separate file, so user can check performance of the existing hash functions quicker, without having to run all the other hash operation performance tests, which takes some time. Signed-off-by: Pablo de Lara --- app/test/Makefile

[dpdk-dev] [PATCH v2 0/6] update jhash function

2015-04-24 Thread Pablo de Lara
Jenkins hash function was developed originally in 1996, and was integrated in first versions of DPDK. The function has been improved in 2006, achieving up to 60% better performance, compared to the original one. This patchset updates the current jhash in DPDK, including two new functions that gene

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 11:53 AM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 09:45:24AM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman > wrote: > > > > > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman

[dpdk-dev] DPDK Community Call - Software QoS

2015-04-24 Thread Thomas Monjalon
2015-04-24 09:14, Dumitrescu, Cristian: > Hi Tim, > > Thank you for your help in recording this readout! > The slides that you attached to the email are dropped by the dpdk.org email > server. No, they are not dropped: http://dpdk.org/ml/archives/dev/2015-April/016842.html http:

[dpdk-dev] [PATCH v6 00/13] mbuf: enhancements of mbuf clones

2015-04-24 Thread Zoltan Kiss
Hi, On 22/04/15 12:59, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] >> Sent: Wednesday, April 22, 2015 10:57 AM >> To: dev at dpdk.org >> Cc: Ananyev, Konstantin; zoltan.kiss at linaro.org; Richardson, Bruce; >> nhorman at t

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Neil Horman
On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > Changes in v7 > > > Remove _setname_ pthread calls. > > > Use rte_gettid() API in RTE_LOG to print thread_id. >

[dpdk-dev] QoS Question

2015-04-24 Thread Dumitrescu, Cristian
Hi Greg, Great question, thank you! Please see my comments below. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Greg Smith > Sent: Monday, April 20, 2015 7:40 PM > To: dev at dpdk.org > Subject: [dpdk-dev] QoS Question > > Hi DPDK team, > > The docs on Q

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Matthew Hall
On Fri, Apr 24, 2015 at 12:39:47PM -0500, Jay Rolette wrote: > I can tell you that if DPDK were GPL-based, my company wouldn't be using > it. I suspect we wouldn't be the only ones... > > Jay I could second this, from the past employer where I used it. Right now I am using it in an open source a

[dpdk-dev] DPDK Community Call - Software QoS

2015-04-24 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, April 24, 2015 1:17 PM > To: Dumitrescu, Cristian > Cc: O'Driscoll, Tim; dev at dpdk.org > Subject: Re: DPDK Community Call - Software QoS > > 2015-04-24 09:14, Dumitrescu, Cristian: > > Hi

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Neil Horman
On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > Changes in v7 > Remove _setname_ pthread calls. > Use rte_gettid() API in RTE_LOG to print thread_id. > > Changes in v6 > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > Add pthread_setname_np/pthread_set_name_np for Linux/F

[dpdk-dev] Beyond DPDK 2.0

2015-04-24 Thread Luke Gorrie
Hi Tim, On 16 April 2015 at 12:38, O'Driscoll, Tim wrote: > Following the launch of DPDK by Intel as an internal development project, > the launch of dpdk.org by 6WIND in 2013, and the first DPDK RPM packages > for Fedora in 2014, 6WIND, Red Hat and Intel would like to prepare for > future relea

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 8:22 AM, Neil Horman wrote: > On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman > wrote: > > > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > > Changes in v7 > > > > Remove _setname_ pthread

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

2015-04-24 Thread Luke Gorrie
On 24 April 2015 at 03:01, Linhaifeng wrote: > If not add memory fence what would happen? Packets loss or interrupt > loss?How to test it ? > You should be able to test it like this: 1. Boot two Linux kernel (e.g. 3.13) guests. 2. Connect them via vhost switch. 3. Run continuous traffic between

[dpdk-dev] [PATCH] docs: convert from using inkscape to ImageMagick tools

2015-04-24 Thread Neil Horman
Requiring inkscape to convert svg files to png/pdf files, while functional is difficult for ephemeral build environments (i.e. build systems in which a new build root is setup for each build), as inkscape and its dependencies typically totals over 128Mb of code. Instead, lets use ImageMagick tools

[dpdk-dev] DPDK Community Call - Software QoS

2015-04-24 Thread Dumitrescu, Cristian
Hi Tim, Thank you for your help in recording this readout! The slides that you attached to the email are dropped by the dpdk.org email server. Thomas, I suggest we setup a page on dpdk.org to keep track of all the community readouts, we can store there the slides and a link to the Youtube vide

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

2015-04-24 Thread Linhaifeng
On 2015/4/23 0:33, Huawei Xie wrote: > update of used->idx and read of avail->flags could be reordered. > memory fence should be used to ensure the order, otherwise guest could see a > stale used->idx value after it toggles the interrupt suppression flag. > > Signed-off-by: Huawei Xie > --- >

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-24 Thread Ravi Kerur
On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > Changes in v7 > > Remove _setname_ pthread calls. > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > Changes in v6 > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thre

[dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags

2015-04-24 Thread Xie, Huawei
> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Friday, April 24, 2015 9:01 AM > To: Xie, Huawei; dev at dpdk.org > Cc: luke at snabb.co; mst at redhat.com > Subject: Re: [PATCH] vhost: flush used->idx update before reading avail- > >flags > > > > On