rte_jhash is basically like _rte_jhash_2hashes but it returns only 1 hash,
instead of 2.
In order to remove duplicated code, rte_jhash calls _rte_jhash_2hashes,
passing 0 as the second seed and returning just the first hash value.
(performance penalty is negligible)
The same is done with rte_jhash2. Also, rte_jhash2 is just an specific case
where keys are multiple of 32 bits, and where no key alignment check is
required.
So,to avoid duplicated code, the function calls _rte_jhash_2hashes with
check_align = 0
(to use the optimal path)
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
---
lib/librte_hash/rte_jhash.h | 283 ++++++++++---------------------------------
1 files changed, 62 insertions(+), 221 deletions(-)
diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h
index 1e69e40..9f5b833 100644
--- a/lib/librte_hash/rte_jhash.h
+++ b/lib/librte_hash/rte_jhash.h
@@ -108,22 +108,8 @@ extern "C" {
#define LOWER16b_MASK rte_le_to_cpu_32(0xffff)
#define LOWER24b_MASK rte_le_to_cpu_32(0xffffff)
-/**
- * The most generic version, hashes an arbitrary sequence
- * of bytes. No alignment or length assumptions are made about
- * the input key.
- *
- * @param key
- * Key to calculate hash of.
- * @param length
- * Length of key in bytes.
- * @param initval
- * Initialising value of hash.
- * @return
- * Calculated hash value.
- */
-static inline uint32_t
-rte_jhash(const void *key, uint32_t length, uint32_t initval)
+static inline void
+__rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, uint32_t
*pb, unsigned check_align)
{
uint32_t a, b, c;
union {
@@ -132,12 +118,18 @@ rte_jhash(const void *key, uint32_t length, uint32_t
initval)
} u;
/* Set up the internal state */
- a = b = c = RTE_JHASH_GOLDEN_RATIO + ((uint32_t)length) + initval;
+ a = b = c = RTE_JHASH_GOLDEN_RATIO + ((uint32_t)length) + *pc;
+ c += *pb;
u.ptr = key;
- /* Check key alignment. For x86 architecture, first case is always
optimal */
- if (!strcmp(RTE_ARCH,"x86_64") || !strcmp(RTE_ARCH,"i686") || (u.i &
0x3) == 0) {
+ /*
+ * Check key alignment. For x86 architecture, first case is always
optimal
+ * If check_align is not set, first case will be used
+ */
+
+ if ((!strcmp(RTE_ARCH,"x86_64") || !strcmp(RTE_ARCH,"i686")
+ || (!check_align) || (u.i & 0x3) == 0)) {
const uint32_t *k = (const uint32_t *)key;
while (length > 12) {
@@ -178,7 +170,9 @@ rte_jhash(const void *key, uint32_t length, uint32_t
initval)
a += k[0] & LOWER8b_MASK; break;
/* zero length strings require no mixing */
case 0:
- return c;
+ *pc = c;
+ *pb = b;
+ return;
};
} else {
const uint8_t *k = (const uint8_t *)key;
@@ -233,63 +227,16 @@ rte_jhash(const void *key, uint32_t length, uint32_t
initval)
a += ((uint32_t)k[0]) << RTE_JHASH_BYTE0_SHIFT;
break;
case 0:
- return c;
+ *pc = c;
+ *pb = b;
+ return;
}
}
__rte_jhash_final(a, b, c);
- return c;
-}
-
-/**
- * A special optimized version that handles 1 or more of uint32_ts.
- * The length parameter here is the number of uint32_ts in the key.
- *
- * @param k
- * Key to calculate hash of.
- * @param length
- * Length of key in units of 4 bytes.
- * @param initval
- * Initialising value of hash.
- * @return
- * Calculated hash value.
- */
-static inline uint32_t
-rte_jhash2(const uint32_t *k, uint32_t length, uint32_t initval)
-{
- uint32_t a, b, c;
-
- /* Set up the internal state */
- a = b = c = RTE_JHASH_GOLDEN_RATIO + (((uint32_t)length) << 2) +
initval;
-
- /* Handle most of the key */
- while (length > 3) {
- a += k[0];
- b += k[1];
- c += k[2];
-
- __rte_jhash_mix(a, b, c);
-
- k += 3;
- length -= 3;
- }
-
- /* Handle the last 3 uint32_t's */
- switch (length) {
- case 3:
- c += k[2];
- case 2:
- b += k[1];
- case 1:
- a += k[0];
- __rte_jhash_final(a, b, c);
- /* case 0: nothing left to add */
- case 0:
- break;
- };
-
- return c;
+ *pc = c;
+ *pb = b;
}
/**
@@ -310,127 +257,7 @@ rte_jhash2(const uint32_t *k, uint32_t length, uint32_t
initval)
static inline void
rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, uint32_t *pb)
{
- uint32_t a, b, c;
- union {
- const void *ptr;
- size_t i;
- } u;
-
- /* Set up the internal state */
- a = b = c = RTE_JHASH_GOLDEN_RATIO + ((uint32_t)length) + *pc;
- c += *pb;
-
- u.ptr = key;
-
- /* Check key alignment. For x86 architecture, first case is always
optimal */
- if (!strcmp(RTE_ARCH,"x86_64") || !strcmp(RTE_ARCH,"i686") || (u.i &
0x3) == 0) {
- const uint32_t *k = (const uint32_t *)key;
-
- while (length > 12) {
- a += k[0];
- b += k[1];
- c += k[2];
-
- __rte_jhash_mix(a, b, c);
-
- k += 3;
- length -= 12;
- }
-
- switch (length) {
- case 12:
- c += k[2]; b += k[1]; a += k[0]; break;
- case 11:
- c += k[2] & LOWER24b_MASK; b += k[1]; a += k[0]; break;
- case 10:
- c += k[2] & LOWER16b_MASK; b += k[1]; a += k[0]; break;
- case 9:
- c += k[2] & LOWER8b_MASK; b += k[1]; a += k[0]; break;
- case 8:
- b += k[1]; a += k[0]; break;
- case 7:
- b += k[1] & LOWER24b_MASK; a += k[0]; break;
- case 6:
- b += k[1] & LOWER16b_MASK; a += k[0]; break;
- case 5:
- b += k[1] & LOWER8b_MASK; a += k[0]; break;
- case 4:
- a += k[0]; break;
- case 3:
- a += k[0] & LOWER24b_MASK; break;
- case 2:
- a += k[0] & LOWER16b_MASK; break;
- case 1:
- a += k[0] & LOWER8b_MASK; break;
- /* zero length strings require no mixing */
- case 0:
- *pc = c;
- *pb = b;
- return;
- };
- } else {
- const uint8_t *k = (const uint8_t *)key;
-
- /* all but the last block: affect some 32 bits of (a, b, c) */
- while (length > 12) {
- a += ((uint32_t)k[0]) << RTE_JHASH_BYTE0_SHIFT;
- a += ((uint32_t)k[1]) << RTE_JHASH_BYTE1_SHIFT;
- a += ((uint32_t)k[2]) << RTE_JHASH_BYTE2_SHIFT;
- a += ((uint32_t)k[3]) << RTE_JHASH_BYTE3_SHIFT;
- b += ((uint32_t)k[4]) << RTE_JHASH_BYTE0_SHIFT;
- b += ((uint32_t)k[5]) << RTE_JHASH_BYTE1_SHIFT;
- b += ((uint32_t)k[6]) << RTE_JHASH_BYTE2_SHIFT;
- b += ((uint32_t)k[7]) << RTE_JHASH_BYTE3_SHIFT;
- c += ((uint32_t)k[8]) << RTE_JHASH_BYTE0_SHIFT;
- c += ((uint32_t)k[9]) << RTE_JHASH_BYTE1_SHIFT;
- c += ((uint32_t)k[10]) << RTE_JHASH_BYTE2_SHIFT;
- c += ((uint32_t)k[11]) << RTE_JHASH_BYTE3_SHIFT;
-
- __rte_jhash_mix(a, b, c);
-
- k += 12;
- length -= 12;
- }
-
- /* last block: affect all 32 bits of (c) */
- /* all the case statements fall through */
- switch (length) {
- case 12:
- c += ((uint32_t)k[11]) << RTE_JHASH_BYTE3_SHIFT;
- case 11:
- c += ((uint32_t)k[10]) << RTE_JHASH_BYTE2_SHIFT;
- case 10:
- c += ((uint32_t)k[9]) << RTE_JHASH_BYTE1_SHIFT;
- case 9:
- c += ((uint32_t)k[8]) << RTE_JHASH_BYTE0_SHIFT;
- case 8:
- b += ((uint32_t)k[7]) << RTE_JHASH_BYTE3_SHIFT;
- case 7:
- b += ((uint32_t)k[6]) << RTE_JHASH_BYTE2_SHIFT;
- case 6:
- b += ((uint32_t)k[5]) << RTE_JHASH_BYTE1_SHIFT;
- case 5:
- b += ((uint32_t)k[4]) << RTE_JHASH_BYTE0_SHIFT;
- case 4:
- a += ((uint32_t)k[3]) << RTE_JHASH_BYTE3_SHIFT;
- case 3:
- a += ((uint32_t)k[2]) << RTE_JHASH_BYTE2_SHIFT;
- case 2:
- a += ((uint32_t)k[1]) << RTE_JHASH_BYTE1_SHIFT;
- case 1:
- a += ((uint32_t)k[0]) << RTE_JHASH_BYTE0_SHIFT;
- break;
- case 0:
- *pc = c;
- *pb = b;
- return;
- }
- }
-
- __rte_jhash_final(a, b, c);
-
- *pc = c;
- *pb = b;
+ __rte_jhash_2hashes(key, length, pc, pb, 1);
}
/**
@@ -451,40 +278,54 @@ rte_jhash_2hashes(const void *key, uint32_t length,
uint32_t *pc, uint32_t *pb)
static inline void
rte_jhash2_2hashes(const uint32_t *k, uint32_t length, uint32_t *pc, uint32_t
*pb)
{
- uint32_t a, b, c;
+ __rte_jhash_2hashes((const void *) k, (length << 2), pc, pb, 0);
+}
- /* Set up the internal state */
- a = b = c = RTE_JHASH_GOLDEN_RATIO + (((uint32_t)length) << 2) + *pc;
- c += *pb;
+/**
+ * The most generic version, hashes an arbitrary sequence
+ * of bytes. No alignment or length assumptions are made about
+ * the input key.
+ *
+ * @param key
+ * Key to calculate hash of.
+ * @param length
+ * Length of key in bytes.
+ * @param initval
+ * Initialising value of hash.
+ * @return
+ * Calculated hash value.
+ */
+static inline uint32_t
+rte_jhash(const void *key, uint32_t length, uint32_t initval)
+{
+ uint32_t initval2 = 0;
- /* Handle most of the key */
- while (length > 3) {
- a += k[0];
- b += k[1];
- c += k[2];
+ rte_jhash_2hashes(key, length, &initval, &initval2);
- __rte_jhash_mix(a, b, c);
+ return initval;
+}
- k += 3;
- length -= 3;
- }
+/**
+ * A special optimized version that handles 1 or more of uint32_ts.
+ * The length parameter here is the number of uint32_ts in the key.
+ *
+ * @param k
+ * Key to calculate hash of.
+ * @param length
+ * Length of key in units of 4 bytes.
+ * @param initval
+ * Initialising value of hash.
+ * @return
+ * Calculated hash value.
+ */
+static inline uint32_t
+rte_jhash2(const uint32_t *k, uint32_t length, uint32_t initval)
+{
+ uint32_t initval2 = 0;
- /* Handle the last 3 uint32_t's */
- switch (length) {
- case 3:
- c += k[2];
- case 2:
- b += k[1];
- case 1:
- a += k[0];
- __rte_jhash_final(a, b, c);
- /* case 0: nothing left to add */
- case 0:
- break;
- };
+ rte_jhash2_2hashes(k, length, &initval, &initval2);
- *pc = c;
- *pb = b;
+ return initval;
}
/**
--
1.7.4.1
