[dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count

2015-03-24 Thread Ananyev, Konstantin
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, March 24, 2015 3:55 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count > > On

[dpdk-dev] Inputs needed - testing l2fwd

2015-03-24 Thread Stephen Hemminger
On Wed, 25 Mar 2015 09:40:47 +0530 Shankari Vaidyalingam wrote: > Hi, > > Can anyone please help me whether I'm missing something in the below > exercise > > Regards > Shankari.V > > On Wed, Mar 25, 2015 at 12:25 AM, Shankari Vaidyalingam < > shankari.v2k6 at gmail.com> wrote: > > > I'm tryin

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

2015-03-24 Thread Pavel Boldin
On Tue, Mar 24, 2015 at 6:20 PM, Xie, Huawei wrote: > On 3/24/2015 7:10 PM, Pavel Boldin wrote: > > > On Tue, Mar 24, 2015 at 8:28 AM, Xie, Huawei huawei.xie at intel.com>> wrote: > On 3/23/2015 8:54 PM, Pavel Boldin wrote: > > Due to increased `struct file's reference counter subsequent call >

[dpdk-dev] [PATCH v2 2/6] eal: Close file descriptor of uio configuration

2015-03-24 Thread Stephen Hemminger
On Wed, 25 Mar 2015 12:17:32 +0900 Tetsuya Mukawa wrote: > On 2015/03/25 3:33, Stephen Hemminger wrote: > > On Tue, 24 Mar 2015 13:18:33 +0900 > > Tetsuya Mukawa wrote: > > > >> When pci_uio_unmap_resource() is called, a file descriptor that is used > >> for uio configuration should be closed. >

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-24 Thread Linhaifeng
On 2015/3/24 18:06, Xie, Huawei wrote: > On 3/24/2015 3:44 PM, Linhaifeng wrote: >> >> On 2015/3/24 9:53, Xie, Huawei wrote: >>> On 3/24/2015 9:00 AM, Linhaifeng wrote: On 2015/3/23 20:54, Xie, Huawei wrote: >> -Original Message- >> From: Linhaifeng [mailto:haifeng.lin at hua

[dpdk-dev] [PATCH v2] hash: fix breaking strict-aliasing rules

2015-03-24 Thread Yerden Zhumabekov
Fix rte_hash_crc() function by making use of uintptr_t variable to hold a pointer to data being hashed. In this way, casting uint64_t pointer to uint32_t avoided. Signed-off-by: Yerden Zhumabekov --- lib/librte_hash/rte_hash_crc.h | 21 +++-- 1 file changed, 11 insertions(+), 1

[dpdk-dev] ovs-dpdk: placing the metadata

2015-03-24 Thread Zoltan Kiss
Hi, I've noticed in lib/netdev-dpdk.c that __rte_pktmbuf_init() stores the packet metadata right after "struct rte_mbuf", and before the buffer data: /* start of buffer is just after mbuf structure */ m->buf_addr = (char *)m + sizeof(struct dp_packet); (struct dp_packet has the rte_mb

[dpdk-dev] Need some info on the impact of BIOS setting

2015-03-24 Thread Shankari Vaidyalingam
Hi I'd like to know the impact of the virtualization setting (Intel VT set to enabled in BIOS) on the execution of the DPDK applications. Do I need to disable this setting while executing the DPDK applications in virtual machines in VirtualBox. Any help in this regard is appreciated. Regards Shan

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

2015-03-24 Thread Bruce Richardson
On Tue, Mar 24, 2015 at 04:10:18PM +0200, Dor Green wrote: > 1 . The eth_conf is: > > static struct rte_eth_conf const ethconf = { > .link_speed = 0, > .link_duplex = 0, > > .rxmode = { > .mq_mode = ETH_MQ_RX_RSS, > .max_rx_pkt_len = ETHER_MAX_LEN, > .split_hdr

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

2015-03-24 Thread Xie, Huawei
On 3/24/2015 7:10 PM, Pavel Boldin wrote: On Tue, Mar 24, 2015 at 8:28 AM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

2015-03-24 Thread Dor Green
1 . The eth_conf is: static struct rte_eth_conf const ethconf = { .link_speed = 0, .link_duplex = 0, .rxmode = { .mq_mode = ETH_MQ_RX_RSS, .max_rx_pkt_len = ETHER_MAX_LEN, .split_hdr_size = 0, .header_split = 0, .hw_ip_checksum = 0, .hw_

[dpdk-dev] [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails

2015-03-24 Thread Linhaifeng
On 2015/3/24 15:14, Xie, Huawei wrote: > On 3/22/2015 8:08 PM, Ouyang, Changchun wrote: >> >>> -Original Message- >>> From: linhaifeng [mailto:haifeng.lin at huawei.com] >>> Sent: Saturday, March 21, 2015 9:47 AM >>> To: dev at dpdk.org >>> Cc: Ouyang, Changchun; Xie, Huawei >>> Subject:

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-24 Thread Linhaifeng
On 2015/3/24 9:53, Xie, Huawei wrote: > On 3/24/2015 9:00 AM, Linhaifeng wrote: >> >> On 2015/3/23 20:54, Xie, Huawei wrote: >>> -Original Message- From: Linhaifeng [mailto:haifeng.lin at huawei.com] Sent: Monday, March 23, 2015 8:24 PM To: dev at dpdk.org Cc: Ouy

[dpdk-dev] [PATCH] mk: added make target to print out system info

2015-03-24 Thread John McNamara
Added a 'make system_info' target to print out system info related to DPDK. This is intended as output that can be attached to bug reports. --- mk/rte.sdkroot.mk | 33 + 1 file changed, 33 insertions(+) diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk index e8423

[dpdk-dev] [PATCH] mk: added make target to print out system info

2015-03-24 Thread John McNamara
Added a 'make system_info' target to print out system info related to DPDK. This is intended as output that can be attached to bug reports. This is related to the recent call for tools brainstorming by Thomas. http://dpdk.org/ml/archives/dev/2015-March/015499.html Bug reports to the DPDK mai

[dpdk-dev] [PATCH v2] ixgbe: fix ixgbe access endian issue on bigendian arch

2015-03-24 Thread xuelin....@freescale.com
From: Xuelin Shi enforce rules of the cpu and ixgbe exchange data. 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) Signed-off-by: Xuelin Shi --- changes for v2: rebased on latest head. fix some style issue detected by ch

[dpdk-dev] [PATCH v2] librte_lpm: define tbl entry reversely for big endian

2015-03-24 Thread xuelin....@freescale.com
From: Xuelin Shi This module uses type conversion between struct and int. Also truncation and comparison is used with this int. It is not safe for different endian arch. Add ifdef for big endian struct to fix this issue. Signed-off-by: Xuelin Shi --- changes for v2: add lib/librte_lpm/rte

[dpdk-dev] [PATCH v2 6/6] eal: Fix interface of pci_map_resource()

2015-03-24 Thread Tetsuya Mukawa
The function is implemented in both linuxapp and bsdapp, but interface is different. The patch fixes the function of bsdapp to do same as linuxapp. After applying it, file descriptor should be opened and closed out of pci_map_resource(). Also, remove redundant error messages from linuxapp. Signed-

[dpdk-dev] [PATCH v2 5/6] eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as linuxapp

2015-03-24 Thread Tetsuya Mukawa
This patch changes code that maps pci resources in bsdapp. Linuxapp has almost same code. To consolidate both, fix implementation of bsdapp to work same as linuxapp. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 24 1 file changed, 12 insertions

[dpdk-dev] [PATCH v2 4/6] eal/bsdapp: Change names of pci related data structure

2015-03-24 Thread Tetsuya Mukawa
To merge pci code of linuxapp and bsdapp, this patch changes names like below. - uio_map to pci_map - uio_resource to mapped_pci_resource - uio_res_list to mapped_pci_res_list Also, add 'path' variable to pci_map of bsdapp. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v2 3/6] eal: Fix memory leaks and needless increment of pci_map_addr

2015-03-24 Thread Tetsuya Mukawa
This patch fixes following memory leaks. - When pci_map_resource() is failed but path is allocated correctly, path won't be freed in pci_uio_map_recource(). - When open() is failed, uio_res won't be freed in pci_uio_map_resource(). - When pci_uio_unmap() is called, path should be freed. Also,

[dpdk-dev] [PATCH v2 2/6] eal: Close file descriptor of uio configuration

2015-03-24 Thread Tetsuya Mukawa
When pci_uio_unmap_resource() is called, a file descriptor that is used for uio configuration should be closed. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci

[dpdk-dev] [PATCH v2 1/6] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

2015-03-24 Thread Tetsuya Mukawa
This patch fixes coding style of below files in linuxapp and bsdapp. - eal_pci.c - eal_pci_uio.c Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +--- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12 2 files changed, 21 insertion

[dpdk-dev] [PATCH 6/6] eal: Fix interface of pci_map_resource()

2015-03-24 Thread Tetsuya Mukawa
On 2015/03/20 18:53, Iremonger, Bernard wrote: >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Tuesday, March 17, 2015 9:31 AM >> To: dev at dpdk.org >> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa >> Subject: [PATCH 6/6] eal: Fix interface

[dpdk-dev] [PATCH v2 0/6] Clean up pci uio implementations

2015-03-24 Thread Tetsuya Mukawa
This patch set cleans up pci uio implementation. These clean up are for consolidating pci uio implementation of linuxapp and bsdapp, and moving consolidated functions in eal common. Because of above, this patch set tries to implement linuxapp and bsdapp almost same. Actual consolidations will be do

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

2015-03-24 Thread Bruce Richardson
On Tue, Mar 24, 2015 at 12:54:14PM +0200, Dor Green wrote: > I've managed to fix it so 1.8 works, and the segmentation fault still occurs. > > On Tue, Mar 24, 2015 at 11:55 AM, Dor Green wrote: > > I tried 1.8, but that fails to initialize my device and fails at the pci > > probe: > > "Cause

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

2015-03-24 Thread Pavel Boldin
On Tue, Mar 24, 2015 at 8:28 AM, Xie, Huawei wrote: > On 3/23/2015 8:54 PM, Pavel Boldin wrote: > > Due to increased `struct file's reference counter subsequent call > > to `filp_close' does not free the `struct file'. Prepend `fput' call > > to decrease the reference counter. > > > > Signed-off-

[dpdk-dev] [PATCH] mk: added make target to print out system info

2015-03-24 Thread Neil Horman
On Tue, Mar 24, 2015 at 02:52:59PM +, John McNamara wrote: > Added a 'make system_info' target to print out system info > related to DPDK. This is intended as output that can be > attached to bug reports. > --- > mk/rte.sdkroot.mk | 33 + > 1 file changed, 33 in

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

2015-03-24 Thread Dor Green
I've managed to fix it so 1.8 works, and the segmentation fault still occurs. On Tue, Mar 24, 2015 at 11:55 AM, Dor Green wrote: > I tried 1.8, but that fails to initialize my device and fails at the pci > probe: > "Cause: Requested device :04:00.1 cannot be used" > Can't even compile 2.

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

2015-03-24 Thread Olivier MATZ
Hi, On 03/24/2015 11:48 AM, Jastrzebski, MichalX K wrote: >>> On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote: Function match_inst is used to take buffor using sizeof() which is size_t >> type. This modification also involved changing '%u' to '%zu' in printf function. Signed-off-

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

2015-03-24 Thread Dor Green
I tried 1.8, but that fails to initialize my device and fails at the pci probe: "Cause: Requested device :04:00.1 cannot be used" Can't even compile 2.0rc2 atm, getting: "/usr/lib/gcc/x86_64-linux-gnu/4.6/include/emmintrin.h:701:1: note: expected '__m128i' but argument is of type 'int'" For

[dpdk-dev] [PATCH v2 2/6] eal: Close file descriptor of uio configuration

2015-03-24 Thread Stephen Hemminger
On Tue, 24 Mar 2015 13:18:33 +0900 Tetsuya Mukawa wrote: > When pci_uio_unmap_resource() is called, a file descriptor that is used > for uio configuration should be closed. > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +- > 1 file changed, 5 inser

[dpdk-dev] dpdk kni ping answer

2015-03-24 Thread Yaron Illouz
The source of my problem seems to be that Ethtool is not supported in VMs (VF). Is there another solution to give an ip to a dpdk port? -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yaron Illouz Sent: Monday, March 23, 2015 2:08 PM To: dev at dpdk.org; dev Subj

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

2015-03-24 Thread Ananyev, Konstantin
Hi Vadim, > From: Vadim Suraev [mailto:vadim.suraev at gmail.com] > Sent: Tuesday, March 24, 2015 7:53 AM > To: Ananyev, Konstantin > Cc: Olivier MATZ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions > added + unittest > > Hi, Konstantin, > > >Tho

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

2015-03-24 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, March 23, 2015 12:47 PM > To: Mrzyglod, DanielX T > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cmdline: fix type format from unsigned to > size_t for buffer size > > Da

[dpdk-dev] [PATCH] lib/librte_pmd_virtio fix can't receive packets after rx_q is empty

2015-03-24 Thread Xie, Huawei
On 3/21/2015 10:25 AM, Linhaifeng wrote: > > On 2015/3/21 0:54, Xie, Huawei wrote: >> On 3/20/2015 6:47 PM, linhaifeng wrote: >>> From: Linhaifeng >>> >>> If failed to alloc mbuf ring_size times the rx_q may be empty and can't >>> receive any packets forever because nb_used is 0 forever. >> Agreed

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-24 Thread Xie, Huawei
On 3/24/2015 3:44 PM, Linhaifeng wrote: > > On 2015/3/24 9:53, Xie, Huawei wrote: >> On 3/24/2015 9:00 AM, Linhaifeng wrote: >>> On 2015/3/23 20:54, Xie, Huawei wrote: > -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Monday, March 23, 2015 8:24

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

2015-03-24 Thread Vadim Suraev
Hi, Konstantin, >Though from my point, such function should be generic as rte_pktmbuf_free_chain() - >no special limitations like all mbufs from one pool, refcnt==1, etc. I misunderstood, I'll rework. Regards, Vadim. On Tue, Mar 24, 2015 at 1:48 AM, Ananyev, Konstantin < konstantin.ananyev at in

[dpdk-dev] [RFC PATCHv2 5/8] add OSv support

2015-03-24 Thread Neil Horman
On Sat, Mar 21, 2015 at 12:23:02PM +0900, Takuya ASADA wrote: > Adding OSv support. > Based on Linux/FreeBSD EAL, but calling OSv kernel APIs to access devices, > allocate contiguous memory, etc. > > Signed-off-by: Takuya ASADA > --- > diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_

[dpdk-dev] tools brainstorming

2015-03-24 Thread Simon Kågström
On 2015-03-23 17:29, Thomas Monjalon wrote: > 2015-03-20 16:18, Simon K?gstr?m: >>> - make autotests easier and faster to run for smoke testing >>> - automated basic testpmd check >> >> Code coverage for automated tests can be useful as well. >> >> In a way I'm speaking in my own interests

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-24 Thread Linhaifeng
On 2015/3/23 20:54, Xie, Huawei wrote: > > >> -Original Message- >> From: Linhaifeng [mailto:haifeng.lin at huawei.com] >> Sent: Monday, March 23, 2015 8:24 PM >> To: dev at dpdk.org >> Cc: Ouyang, Changchun; Xie, Huawei >> Subject: Re: [dpdk-dev] [PATCH] cast used->idx to volatile >> >

[dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count

2015-03-24 Thread Stephen Hemminger
On Mon, 23 Mar 2015 16:45:44 + "Ananyev, Konstantin" wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of stephen at > > networkplumber.org > > Sent: Friday, January 23, 2015 6:24 AM > > To: dev at dpdk.org > > Cc: Stephen Hemminger > > Subj

[dpdk-dev] [PATCH] ixgbe: fix data access on big endian cpu

2015-03-24 Thread Xuelin Shi
Hi Thomas, Done. http://patchwork.dpdk.org/dev/patchwork/patch/4123/ Thanks, Xuelin Shi > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, March 23, 2015 22:02 > To: Shi Xuelin-B29237 > Cc: dev at dpdk.org; konstantin.ananyev at intel.com;

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-24 Thread Xuelin Shi
Hi Thomas, Done. http://patchwork.dpdk.org/dev/patchwork/patch/4122/ Thanks, Xuelin Shi > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, March 23, 2015 22:04 > To: Shi Xuelin-B29237 > Cc: Bruce Richardson; dev at dpdk.org > Subject: Re:

[dpdk-dev] [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails

2015-03-24 Thread Xie, Huawei
On 3/22/2015 8:08 PM, Ouyang, Changchun wrote: > >> -Original Message- >> From: linhaifeng [mailto:haifeng.lin at huawei.com] >> Sent: Saturday, March 21, 2015 9:47 AM >> To: dev at dpdk.org >> Cc: Ouyang, Changchun; Xie, Huawei >> Subject: [PATCH v3] lib/librte_vhost: update used->idx when

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

2015-03-24 Thread Xie, Huawei
On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `fput' call > to decrease the reference counter. > > Signed-off-by: Pavel Boldin > --- > lib/librte_vhost/eventfd_link/eventfd_l

[dpdk-dev] [PATCH] i40e: remove ALLOW_LB flag on SRIOV vsi

2015-03-24 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Friday, March 20, 2015 3:32 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Xu, HuilongX; Zhang, Helin > Subject: [PATCH] i40e: remove ALLOW_LB flag on SRIOV vsi > > Disable VEB switching by removing ALLOW_LB on SRIOV vsi. > > If the source

[dpdk-dev] [PATCH] kni/ethtool/ixgbe: enforce access between ixgbe PCI and CPU

2015-03-24 Thread Zhang, Helin
Hi Xuelin > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of > xuelin.shi at freescale.com > Sent: Wednesday, February 11, 2015 2:50 PM > To: thomas.monjalon at 6wind.com > Cc: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] kni/ethtool/ixgbe: enforce access betwe

[dpdk-dev] [PATCH] cast used->idx to volatile

2015-03-24 Thread Xie, Huawei
On 3/24/2015 9:00 AM, Linhaifeng wrote: > > On 2015/3/23 20:54, Xie, Huawei wrote: >> >>> -Original Message- >>> From: Linhaifeng [mailto:haifeng.lin at huawei.com] >>> Sent: Monday, March 23, 2015 8:24 PM >>> To: dev at dpdk.org >>> Cc: Ouyang, Changchun; Xie, Huawei >>> Subject: Re: [dpdk

[dpdk-dev] [PATCH] scripts: enable extended tag of PCIe

2015-03-24 Thread Zhang, Helin
Hi Thomas Zhida is our intern who has already been back to university. I think Yong might have reviewed it. It is good supplementation for setting extended tag on Linux, though not necessary. I am OK to have it merged or not. Thanks! Marvin, could you help to ack it, as I know you have reviewed

[dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL

2015-03-24 Thread Zhang, Helin
Hi Alex > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex Gartrell > Sent: Saturday, March 14, 2015 3:22 AM > To: dev at dpdk.org > Cc: kernel-team at fb.com > Subject: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL > > I couldn't figure out