[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

Hi Vadim, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vadim Suraev > Sent: Monday, March 23, 2015 5:31 PM > To: Olivier MATZ > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions > added + unittest > > Hi, O

[dpdk-dev] Need info on --vdev option

Hi Olivier, Thanks a lot. I changed the ordering and it worked. But the pcap file was empty even when I specified the rx interface. I have a basic doubt. When the ethernet interfaces are bound to teh igb driver they become user interfaces and no longer shown in "ifconfig" command output. By what

[dpdk-dev] Need info on --vdev option

Hi I'm trying to do a packet capture on the DPDK interface while running l2fwd sample application and injecting packets from a traffic generator. I'm getting the below error when I give this command: sudo ./build/l2fw-c 0x03 -n 2 -- -p 0x03 --vdev 'eth_pcap0,tx_pcap=/home/controller/pkt_capt/try.p

[dpdk-dev] [PATCH] cast used->idx to volatile

On 2015/3/21 16:07, linhaifeng wrote: > From: Linhaifeng > > Same as rte_vhost_enqueue_burst we should cast used->idx > to volatile before notify guest. > > Signed-off-by: Linhaifeng > --- > lib/librte_vhost/vhost_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

Hi, Olivier, No, I personally need to free a chain using mempool bulk. If I'm not mistaken, it has been proposed by one of reviewers to have lower level function, so it was done (I'm sorry if misunderstood) Regards, Vadim. On Mar 23, 2015 8:44 PM, "Olivier MATZ" wrote: > Hi Neil, > > On 03/19/201

[dpdk-dev] tools brainstorming

On Mon, Mar 23, 2015 at 04:56:32PM -0500, Jim Thompson wrote: > > > On Mar 23, 2015, at 12:44 PM, Neil Horman wrote: > > > > On Mon, Mar 23, 2015 at 11:22:43AM -0500, Jim Thompson wrote: > >> > >> > >>> On Mar 20, 2015, at 10:16 AM, Neil Horman > >>> wrote: > >>> > >>> The kernel does this

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On Mon, Mar 23, 2015 at 5:36 PM, Xie, Huawei wrote: > On 3/23/2015 11:27 PM, Pavel Boldin wrote: > > > On Mon, Mar 23, 2015 at 5:16 PM, Xie, Huawei huawei.xie at intel.com>> wrote: > On 3/23/2015 10:52 PM, Pavel Boldin wrote: > > > On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei huawei.xie at inte

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

Hi Neil, On 03/19/2015 02:16 PM, Neil Horman wrote: >> On 03/18/2015 09:58 PM, Neil Horman wrote: +/** + * Free a bulk of mbufs into its original mempool. + * This function assumes: + * - refcnt equals 1 + * - mbufs are direct + * - all mbufs must belong to the same m

[dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument

> > eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero. > > It needs to reset create_uio_dev explicitly. > > > > Signed-off-by: Haifeng Gao > > Acked-by: Olivier Matz > > Thank you for fixing this. > > Note for Thomas: the bug is there since my initial commit adding > the

[dpdk-dev] tools brainstorming

2015-03-20 16:18, Simon K?gstr?m: > > - make autotests easier and faster to run for smoke testing > > - automated basic testpmd check > > Code coverage for automated tests can be useful as well. > > In a way I'm speaking in my own interests here since I've written a tool > to do just this

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On Mon, Mar 23, 2015 at 5:16 PM, Xie, Huawei wrote: > On 3/23/2015 10:52 PM, Pavel Boldin wrote: > > > On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei huawei.xie at intel.com>> wrote: > On 3/23/2015 10:37 PM, Pavel Boldin wrote: > > > On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei huawei.xie at inte

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

I changed it to free and it still happens. Note that the segmentation fault happens before that anyway. I am using 1.7.1 at the moment. I can try using a newer version. On 23 Mar 2015 17:00, "Bruce Richardson" wrote: > On Mon, Mar 23, 2015 at 04:24:18PM +0200, Dor Green wrote: > > I'm running a

[dpdk-dev] tools brainstorming

2015-03-20 15:07, Butler, Siobhan A: > I propose we also add a bug tracking tool (e.g. Bugzilla or other). Don't you think adding a bug tracker would artificially split discussions between mailing list threads and bug tracker entries? I think patchwork is great because it summarizes patches pendin

[dpdk-dev] [PATCH v3] vhost: Refactor module `eventfd_link'

Changes: * Remove unnecessary #include's. * Deindent by moving the code to an inline function. * Fix return codes. Use appropriate return code for each fault cause. * Remove copy-pasted `close_fd', call `sys_close' instead. * Use `get_pid_task' to correctly reference the `task_target'. Signed

[dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument

Hi, On 03/23/2015 09:11 AM, gaohaifeng wrote: > From: Haifeng Gao > > eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero. > It needs to reset create_uio_dev explicitly. > > Signed-off-by: Haifeng Gao Acked-by: Olivier Matz Thank you for fixing this. Note for Thomas: th

[dpdk-dev] Need info on --vdev option

Hi Shankari, On 03/23/2015 04:54 PM, Shankari Vaidyalingam wrote: > Hi > > I'm trying to do a packet capture on the DPDK interface while running l2fwd > sample application and injecting packets from a traffic generator. > I'm getting the below error when I give this command: sudo ./build/l2fw-c >

[dpdk-dev] tools brainstorming

> On Mar 23, 2015, at 12:44 PM, Neil Horman wrote: > > On Mon, Mar 23, 2015 at 11:22:43AM -0500, Jim Thompson wrote: >> >> >>> On Mar 20, 2015, at 10:16 AM, Neil Horman wrote: >>> >>> The kernel does this with some special make targets (make allyesconfig, make >>> randconfig, etc) >> >> Not

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei wrote: > On 3/23/2015 10:37 PM, Pavel Boldin wrote: > > > On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei huawei.xie at intel.com>> wrote: > On 3/23/2015 8:54 PM, Pavel Boldin wrote: > > Due to increased `struct file's reference counter subsequent call >

[dpdk-dev] tools brainstorming

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, March 23, 2015 4:19 PM > To: Butler, Siobhan A > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] tools brainstorming > > 2015-03-20 15:07, Butler, Siobhan A: > > I propose we also add a bug t

[dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of stephen at > networkplumber.org > Sent: Friday, January 23, 2015 6:24 AM > To: dev at dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count > > From: Stephe

[dpdk-dev] [PATCH] librte_hash: Fix crc32 error when complie i686 in x86_64

When compile target i686 in platform x86_64, the stud fuction will be called, and return zero. This patch fix this issue. Signed-off-by: Michael Qiu --- lib/librte_hash/rte_hash_crc.h | 35 ++- 1 file changed, 6 insertions(+), 29 deletions(-) diff --git a/lib/li

[dpdk-dev] [PATCH] virtio: Fix stats issue

On 3/23/2015 3:20 PM, David Marchand wrote: > Hello, > > Hello, > > On Mon, Mar 23, 2015 at 7:56 AM, Ouyang Changchun > mailto:changchun.ouyang at intel.com>> wrote: > > It need clear/reset the stats information before count in all > queues data. > > Signed-off-by: Changchun Ouyang

[dpdk-dev] tools brainstorming

On Mon, Mar 23, 2015 at 05:18:49PM +0100, Thomas Monjalon wrote: > Don't you think adding a bug tracker would artificially split discussions > between mailing list threads and bug tracker entries? It is difficult to track the workflow around bugs without some kind of bug-friendly workflow tool.

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei wrote: > On 3/23/2015 8:54 PM, Pavel Boldin wrote: > > Due to increased `struct file's reference counter subsequent call > > to `filp_close' does not free the `struct file'. Prepend `fput' call > > to decrease the reference counter. > > > > Signed-off-

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

I'm running a small app which captures packets on a single lcore and then passes it to other workers for processing. Before even sending it to processing, when checking some minor information in the packet mbuf's data I get a segfault. This code, for example gets a segfault: struct rte_mbuf *pkt

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

Huawei, This thread is unreadable because your mailer is not quoting. Please check. Thanks 2015-03-23 15:16, Xie, Huawei: > On 3/23/2015 10:52 PM, Pavel Boldin wrote: > > > On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei intel.com> wrote: > On 3/23/2015 10:37 PM, Pa

[dpdk-dev] Symmetric RSS Hashing, Part 2

2015-03-23 10:05, Matt Laswell: > Hey Folks, > > I have essentially the same question as Matthew. Has there been progress > in this area? No, AFAIK. Submitting a patch would be a good start I think. > -- > Matt Laswell > infinite io, inc. > laswell at infiniteio.com > > > On Sat, Mar 14, 2015

[dpdk-dev] [PATCH] doc: add note on needing igb_uio module for VF devs

Since the uio_pci_generic module requires that the device to which it is being bound supports legacy interrupts, there can be problems using it with VF devices. Add a note to the GSG doc to document this fact, and provide information on loading igb_uio as a replacement. Signed-off-by: Bruce Richar

[dpdk-dev] tools brainstorming

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, March 20, 2015 2:51 PM > To: dev at dpdk.org > Subject: [dpdk-dev] tools brainstorming > > As we are lazy developers, writing guidelines is not enough. It must be > coupled with t

[dpdk-dev] [PATCH] ethdev: additional parameter in RX callback

2015-03-13 19:15, Neil Horman: > On Fri, Mar 13, 2015 at 06:28:31PM +, Mcnamara, John wrote: > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > > > > > Is encoding the information in the array really a better solution here? > > > The cb->param already exists for passing in user defi

[dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument

From: Haifeng Gao eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero. It needs to reset create_uio_dev explicitly. Signed-off-by: Haifeng Gao --- lib/librte_eal/common/eal_common_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH] table: fix a crash during key8 and key32 overload

hash_key8_ext and hash_key32_ext tables allocate cache entries to support table overload cases. The crash can occur when cache entry is free after use. The problem is with computing the index of the free cache entry. The same case for key16 was fixed with earlier patch. Signed-off-by: Maciej Gajdz

[dpdk-dev] [PATCH] table: fix a crash during key8 and key32 overload

hash_key8_ext and hash_key32_ext tables allocate cache entries to support table overload cases. The crash can occur when cache entry is free after use. The problem is with computing the index of the free cache entry. The same case for key16 was fixed with earlier patch. Signed-off-by: Maciej Gajdz

[dpdk-dev] [PATCH] virtio: Fix stats issue

I agree with Thomas. If some other drivers have memset they should also be fixed

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 11:27 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 5:16 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 10:52 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei mailto:huawei.xie at intel.com>

[dpdk-dev] [PATCH] librte_eal: Allow combining --no-huge with -m XXX

Useful to run applications in usermode via a test driver. Signed-off-by: Simon Kagstrom --- Not sure if there are other implications of this, so please check! lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal

[dpdk-dev] Rx/Tx callbacks in debug mode

Hi, As you may know, rte_eth_rx_burst() and rte_eth_tx_burst() have a debug-specific implementation enabled with RTE_LIBRTE_ETHDEV_DEBUG. I'm afraid these implementations have been forgotten when adding optional Rx/Tx callbacks. Or is it intended? What do you think of removing these debug functio

[dpdk-dev] [PATCH] ethdev: additional parameter in RX callback

On Mon, Mar 23, 2015 at 04:16:36PM +0100, Thomas Monjalon wrote: > 2015-03-13 19:15, Neil Horman: > > On Fri, Mar 13, 2015 at 06:28:31PM +, Mcnamara, John wrote: > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > > > > > > > Is encoding the information in the array really a better

[dpdk-dev] [PATCH] table: fix a crash during key8 and key32 overload

Reviewed-by: Mirek Walukiewicz > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Dumitrescu, Cristian > Sent: Monday, March 23, 2015 4:20 PM > To: Gajdzica, MaciejX T; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] table: fix a crash during key8 and key32 >

[dpdk-dev] [PATCH] table: fix a crash during key8 and key32 overload

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, March 23, 2015 3:09 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] table: fix a crash during key8 and key32 > overload > > hash_key8_ext and hash_key32_ext tables alloca

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 10:52 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:41 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 10:37 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei mailto:huawei.xie at intel.com>

[dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count

Konstantin, Helin, your review would be appreciate here. Thanks > From: Stephen Hemminger > > The ixgbe driver was including CRC in the transmit packet byte > count, but not for packets received. This was notice when forwarding and > the number of bytes received was greater than the number of by

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 14:02, Bruce Richardson: > On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote: > > From: Xuelin Shi > > > > This module uses type conversion between struct and int. > > Also truncation and comparison is used with this int. > > It is not safe for different endia

[dpdk-dev] [PATCH] ixgbe: fix data access on big endian cpu

2015-03-03 16:27, xuelin.shi at freescale.com: > From: Xuelin Shi > > enforce rules for cpu and ixgbe exchanging data. > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) > 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) > > Signed-off-by: Xuelin Shi Please Xuelin, could y

[dpdk-dev] Rx/Tx callbacks in debug mode

On Mon, Mar 23, 2015 at 03:31:48PM +0100, Thomas Monjalon wrote: > Hi, > > As you may know, rte_eth_rx_burst() and rte_eth_tx_burst() have a > debug-specific implementation enabled with RTE_LIBRTE_ETHDEV_DEBUG. > I'm afraid these implementations have been forgotten when adding > optional Rx/Tx cal

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

On Mon, Mar 23, 2015 at 04:24:18PM +0200, Dor Green wrote: > I'm running a small app which captures packets on a single lcore and > then passes it to other workers for processing. > > Before even sending it to processing, when checking some minor > information in the packet mbuf's data I get a seg

[dpdk-dev] [PATCH] kni/ethtool/ixgbe: enforce access between ixgbe PCI and CPU

Helin, any opinion? If nothing wrong is seen, it will be merged in few days. 2015-02-20 11:55, Thomas Monjalon: > Anyone to review this patch? > > 2015-02-11 14:49, xuelin.shi at freescale.com: > > From: Xuelin Shi > > > > make sure: > > CPU read from ixgbe with IXGBE_LE32_TO_CPUS > >

[dpdk-dev] [PATCH] virtio: Fix stats issue

It need clear/reset the stats information before count in all queues data. Signed-off-by: Changchun Ouyang --- lib/librte_pmd_virtio/virtio_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c index 60

[dpdk-dev] [PATCH v2] librte_pmd_bond: remove memory alloc for rte_pci_driver

eth_driver already contains rte_pci_driver data structure. Allocating rte_pci_driver without referencing it after bond creation causes memory leakage. Added signed off information. Signed-off-by: Jia Yu --- lib/librte_pmd_bond/rte_eth_bond_api.c | 11 ++- 1 file changed, 2 insertions(+)

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

Due to increased `struct file's reference counter subsequent call to `filp_close' does not free the `struct file'. Prepend `fput' call to decrease the reference counter. Signed-off-by: Pavel Boldin --- lib/librte_vhost/eventfd_link/eventfd_link.c | 1 + 1 file changed, 1 insertion(+) diff --git

[dpdk-dev] [PATCH] testpmd: Fix wrong message when no port started

Pablo, what is your opinion on this patch? 2015-02-03 16:37, Michael Qiu: > The log message is wrong when no port started. > > Signed-off-by: Michael Qiu > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pm

[dpdk-dev] [PATCH v2] rte_mbuf: mbuf bulk alloc/free functions added + unittest

On Mon, Mar 23, 2015 at 05:44:02PM +0100, Olivier MATZ wrote: > Hi Neil, > > On 03/19/2015 02:16 PM, Neil Horman wrote: > >> On 03/18/2015 09:58 PM, Neil Horman wrote: > +/** > + * Free a bulk of mbufs into its original mempool. > + * This function assumes: > + * - refcnt equal

[dpdk-dev] [PATCH 1/1] tools: Fix some strings and functions regarding VFIO support

> This patch fixes several minor issues in setup.sh: > > - show_nics() would not display the current Ethernet settings if >the user only loads the vfio-pci module, b/c it only checks for >presence of igb_uio. Fix this by adding a check for vfio-pci. > > - unbind_nics():

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 10:37 PM, Pavel Boldin wrote: On Mon, Mar 23, 2015 at 4:21 PM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote: On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend

[dpdk-dev] [PATCH] virtio: Fix crash issue for secondary process

On 3/21/2015 5:59 AM, Thomas Monjalon wrote: 2015-03-19 09:45, Ouyang Changchun: It definitely needs Rx function even in the case of secondary process, so put the assignment a bit earlier to make sure of it. Signed-off-by: Changchun Ouyang --- lib/librte_

[dpdk-dev] Need some info on DPDK

Hi Need some info on: (1) How to capture packets received on the DPDK interface? (2) Determine the MAC address corresponding to the PCI interface Regards Shankari.V

[dpdk-dev] Symmetric RSS Hashing, Part 2

On Mon, Mar 23, 2015 at 04:20:33PM +0100, Thomas Monjalon wrote: > 2015-03-23 10:05, Matt Laswell: > > Hey Folks, > > > > I have essentially the same question as Matthew. Has there been progress > > in this area? > > No, AFAIK. > Submitting a patch would be a good start I think. Hi Thomas, We

[dpdk-dev] Packet data out of bounds after rte_eth_rx_burst

On Mon, Mar 23, 2015 at 05:19:00PM +0200, Dor Green wrote: > I changed it to free and it still happens. Note that the segmentation fault > happens before that anyway. > > I am using 1.7.1 at the moment. I can try using a newer version. I'm using 1.7.X in my open-source DPDK-based app and it works

[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

On 3/23/2015 8:54 PM, Pavel Boldin wrote: > Due to increased `struct file's reference counter subsequent call > to `filp_close' does not free the `struct file'. Prepend `fput' call > to decrease the reference counter. > > Signed-off-by: Pavel Boldin > --- > lib/librte_vhost/eventfd_link/eventfd_l

[dpdk-dev] dpdk kni ping answer

Hi I want to give an ip to a dpdk port, because I need to receive traffic by gre replication. I though I could do it with dpdk kni (http://dpdk.org/doc/guides/prog_guide/kernel_nic_interface.html) I am able to give an ip to interface vEth0, but I can't ping or ssh to the ip address. I set

[dpdk-dev] tools brainstorming

On Mon, Mar 23, 2015 at 11:22:43AM -0500, Jim Thompson wrote: > > > > On Mar 20, 2015, at 10:16 AM, Neil Horman wrote: > > > > The kernel does this with some special make targets (make allyesconfig, make > > randconfig, etc) > > Not all the world is Linux. Your point being? Are you suggestin

[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

Hi Thomas, There is by far more than 2 issues, but these are the only ones that appeared to us. The list of the issues that motivated the refactoring: 1. Only one error code for every fault (-EFAULT). 2. Copy-paste code from the `fget' function. 3. Ambiguous variable names. The `files'

[dpdk-dev] tools brainstorming

On Mon, Mar 23, 2015 at 05:18:49PM +0100, Thomas Monjalon wrote: > 2015-03-20 15:07, Butler, Siobhan A: > > I propose we also add a bug tracking tool (e.g. Bugzilla or other). > > Don't you think adding a bug tracker would artificially split discussions > between mailing list threads and bug track

[dpdk-dev] [PATCH] dpdk: fix a crash during rte_table_hash_key16_ext overload

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of > miroslaw.walukiewicz at intel.com > Sent: Tuesday, March 3, 2015 2:16 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] dpdk: fix a crash during > rte_table_hash_key16_ext overload > > From: Miroslaw Wa

[dpdk-dev] [PATCH 1/1] tools: Fix some strings and functions regarding VFIO support

This patch fixes several minor issues in setup.sh: - show_nics() would not display the current Ethernet settings if the user only loads the vfio-pci module, b/c it only checks for presence of igb_uio. Fix this by adding a check for vfio-pci. - unbind_nics(): Fix option nam

[dpdk-dev] [PATCH] cast used->idx to volatile

> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Monday, March 23, 2015 8:24 PM > To: dev at dpdk.org > Cc: Ouyang, Changchun; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH] cast used->idx to volatile > > > > On 2015/3/21 16:07, linhaifeng wrote: > > Fr

[dpdk-dev] [PATCH] scripts: enable extended tag of PCIe

Hi, This patch needs review and documentation. It's going to be dropped if nobody cares. There were some previous discussions about it: http://dpdk.org/ml/archives/dev/2015-February/012708.html 2015-01-30 12:57, zhida zang: > As 'extended tag' of PCIe needs to be enabled for i40e high p

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

Daniel, Without answer to the question from Olivier, this patch is going to be ignored. 2015-02-24 12:03, Olivier MATZ: > Hi Daniel, > > On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote: > > Function match_inst is used to take buffor using sizeof() which is size_t > > type. > > This modification al

[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

2015-03-23 13:36, Pavel Boldin: > Hi Thomas, > > There is by far more than 2 issues, but these are the only ones that > appeared to us. > > The list of the issues that motivated the refactoring: > >1. Only one error code for every fault (-EFAULT). >2. Copy-paste code from the `fget' func

[dpdk-dev] [PATCH] librte_pmd_e1000: power down the serdes link

There is no maintainer declared for e1000. Maybe that an Intel expert could check this patch, please? 2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_p

[dpdk-dev] [PATCH] app/testpmd: fix potential out of bounds read

> After the last enabled port has been seen, and the last time we > evaluate the loop condition, there is an out of bounds read in > ports[p].enabled because p is equal to size, which is the length of > ports. > > Signed-off-by: Julien Cretin Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for rte_pci_driver

Declan, Any comment? 2015-03-12 14:38, Jia Yu: > eth_driver already contains rte_pci_driver data structure. > Allocating rte_pci_driver without referencing it after bond > creation causes memory leakage. Jia, Signed-off is missing.

[dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL

Helin, any comment about this trivial patch? 2015-03-13 12:21, Alex Gartrell: > I couldn't figure out why this #ifdef existed so I looked around upstream > and it's not there. It seems to build just fine without it. > > Signed-off-by: Alex Gartrell > --- > lib/librte_eal/linuxapp/kni/ethtool/i

[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

Hi Pavel, You forgot the Signed-off-by line. Huawei, Changchun, any comment on this patch? 2015-03-18 15:16, Pavel Boldin: > The `eventfd_link' module provides an API to "steal" fd from another > process had been written with a bug that leaks `struct file' because > of the extra reference counte

[dpdk-dev] [PATCH] tools: Fix some strings and functions regarding VFIO support

Hi, Your patch looks good. Please could you resend it with a Signed-off-by line? Procedure is described here: http://dpdk.org/dev#send Thanks 2015-03-18 16:05, Andre Richter: > This patch fixes several minor issues in setup.sh: > > - show_nics() would not display the current Ethern

[dpdk-dev] [PATCH] ethdev: additional parameter in RX callback

On Mon, Mar 23, 2015 at 04:16:36PM +0100, Thomas Monjalon wrote: > 2015-03-13 19:15, Neil Horman: > > On Fri, Mar 13, 2015 at 06:28:31PM +, Mcnamara, John wrote: > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > > > > > > > Is encoding the information in the array really a better

[dpdk-dev] [PATCH] librte_hash: Fix crc32 error when complie i686 in x86_64

2015-03-23 16:43, Michael Qiu: > When compile target i686 in platform x86_64, the stud fuction will > be called, and return zero. > > This patch fix this issue. > > Signed-off-by: Michael Qiu Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] tools: Fix some strings and functions regarding VFIO support

Ah sorry, I wonder where that went missing. I'll resend. Thomas Monjalon schrieb am Mo., 23. M?rz 2015 um 12:10 Uhr: > Hi, > > Your patch looks good. > Please could you resend it with a Signed-off-by line? > Procedure is described here: > http://dpdk.org/dev#send > > Thanks > > 2015-03-1

[dpdk-dev] [PATCH] virtio: Fix stats issue

2015-03-23 16:38, Ouyang, Changchun: > On 3/23/2015 3:20 PM, David Marchand wrote: > > On Mon, Mar 23, 2015 at 7:56 AM, Ouyang Changchun > > mailto:changchun.ouyang at intel.com>> > > wrote: > > > > It need clear/reset the stats information before count in all > > queues data. > > > >

[dpdk-dev] tools brainstorming

> On Mar 20, 2015, at 10:16 AM, Neil Horman wrote: > > The kernel does this with some special make targets (make allyesconfig, make > randconfig, etc) Not all the world is Linux.

[dpdk-dev] Testpmd application failing with Cause: No probed ethernet device with DPDK-1.8.0

Hi Bruce, Thanks for your reply. I used dpdk_nic_bind.py script to bind igb_uio driver for the specific NIC ports. [root at SSBC swe]# ./ dpdk_nic_bind.py --status Network devices using IGB_UIO driver :03:00.0 'VMXNET3 Ethernet Controller' drv=igb_uio

[dpdk-dev] pktgen rx errors with intel 82599

> On Mar 14, 2015, at 1:33 PM, Wiles, Keith wrote: > > Hi Matt, > > On 3/14/15, 8:47 AM, "Wiles, Keith" > wrote: > >> Hi Matt >> >> On 3/13/15, 3:49 PM, "Matt Smith" wrote: >> >>> >>> Hi, >>> >>> I?ve been using DPDK pktgen 2.8.0 (built against DPDK 1.8.0

[dpdk-dev] [PATCH] cast used->idx to volatile

cc changchun.ouyang at intel.com cc huawei.xie at intel.com On 2015/3/21 16:07, linhaifeng wrote: > From: Linhaifeng > > Same as rte_vhost_enqueue_burst we should cast used->idx > to volatile before notify guest. > > Signed-off-by: Linhaifeng > --- > lib/librte_vhost/vhost_rxtx.c | 2 +- > 1

[dpdk-dev] Symmetric RSS Hashing, Part 2

Hey Folks, I have essentially the same question as Matthew. Has there been progress in this area? -- Matt Laswell infinite io, inc. laswell at infiniteio.com On Sat, Mar 14, 2015 at 3:47 PM, Matthew Hall wrote: > A few months ago we had this thread about symmetric hashing of TCP in RSS: > >

[dpdk-dev] tools brainstorming

2015-03-20 11:16, Neil Horman: > On Fri, Mar 20, 2015 at 03:51:11PM +0100, Thomas Monjalon wrote: > > - build check with various options combinations > > The kernel does this with some special make targets (make allyesconfig, make > randconfig, etc). They basically act as build time fuzzers a

[dpdk-dev] Need some info on DPDK

It's all in the docs. http://dpdk.org/doc/guides/prog_guide/libpcap_ring_based_poll_mode_drv.html http://dpdk.org/doc/api/rte__ethdev_8h.html#a5686df2817980236f2c4f1cc72dd2c30 On 23/03/15 09:00, Shankari Vaidyalingam wrote: > Hi > > Need some info on: > (1) How to capture packets received on the

[dpdk-dev] tools brainstorming

On 2015/3/20 22:52, Thomas Monjalon wrote: > Hi, > > As you probably know, a MAINTAINERS file is being filled, which is a great > help to request patch reviews and discuss design with the knowledgeable people > of this young DPDK community: > http://dpdk.org/browse/dpdk/tree/MAINTAINERS > > T

[dpdk-dev] [PATCH] virtio: Fix stats issue

Hello, Hello, On Mon, Mar 23, 2015 at 7:56 AM, Ouyang Changchun < changchun.ouyang at intel.com> wrote: > It need clear/reset the stats information before count in all queues data. > > Signed-off-by: Changchun Ouyang > --- > lib/librte_pmd_virtio/virtio_ethdev.c | 8 > 1 file changed,

[dpdk-dev] [PATCH] vhost library doc update

On 3/22/2015 10:00 PM, Butler, Siobhan A wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Huawei Xie Sent: Wednesday, March 11, 2015 4:22 PM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH] vhost library doc update add vhost user docume

[dpdk-dev] [PATCH] ixgbe: fix buffer overrun bug in non-bulk alloc mode setup

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Saturday, March 21, 2015 5:46 AM > To: Jiajia, SunX > Cc: dev at dpdk.org; Wodkowski, PawelX > Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix buffer overrun bug in non- > bulk alloc mode setup

[dpdk-dev] [PATCH 0/6] fix build warnings and errors in SUSE11 SP3

> From: Marvin Liu > > SUSE11 SP3 default gcc version is 4.3.4. Some options not supported in this > version. This patch set add gcc version check for those options and fix other > build warning in Suse11 SP3. > > Marvin Liu (6): > fix sse3 functions not found with gcc 4.3.4 > fix fm10k driv