[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 Thread Tetsuya Mukawa
On 2015/02/25 23:00, Thomas Monjalon wrote: > 2015-02-25 21:32, Tetsuya Mukawa: >> 2015-02-25 20:21 GMT+09:00 Thomas Monjalon : >>> 2015-02-25 13:04, Tetsuya Mukawa: --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -32,10 +32,13 @@ *

[dpdk-dev] [PATCH] eal: Clean up export of per_lcore__socket_id

2015-02-25 Thread Liang, Cunming
Hi Neil, Thanks for the cleanup. Does it better moving rte_socket_id() to eal_common_thread.c ? As it simply returns _socket_id, it's not necessary to have two copy in both linux and bsd. -Cunming > -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Wednesd

[dpdk-dev] [PATCH 1/4] xen: allow choosing dom0 support at runtime

2015-02-25 Thread Stephen Hemminger
On Thu, 26 Feb 2015 06:53:24 + "Liu, Jijiang" wrote: > Ok, thanks for the explanation. > > Could you replace 'internal_config.xen_dom0_support' with > 'is_xen_dom0_supported()' in the function rte_eal_hugepage_init()? Ok, but then as a function it would have to be exported as shared lib

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 Thread Tetsuya Mukawa
2015-02-25 20:21 GMT+09:00 Thomas Monjalon : > 2015-02-25 13:04, Tetsuya Mukawa: >> --- a/lib/librte_eal/common/eal_common_dev.c >> +++ b/lib/librte_eal/common/eal_common_dev.c >> @@ -32,10 +32,13 @@ >> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> */ >> >> +#inclu

[dpdk-dev] [PATCH 3/3] doc: add docs for the rxtx_callbacks sample app

2015-02-25 Thread John McNamara
Added a sample application guide for the rxtx_callbacks app. Signed-off-by: John McNamara --- MAINTAINERS |1 + doc/guides/sample_app_ug/index.rst |1 + doc/guides/sample_app_ug/rxtx_callbacks.rst | 251 +++ 3 files change

[dpdk-dev] [PATCH 2/3] doc: add docs for basic forwarding skeleton app

2015-02-25 Thread John McNamara
Added a sample application guide for the basic forwarding /skeleton app. Signed-off-by: John McNamara --- MAINTAINERS |3 + doc/guides/sample_app_ug/index.rst|3 +- doc/guides/sample_app_ug/skeleton.rst | 338 + 3 files chang

[dpdk-dev] [PATCH 1/3] examples/skeleton: minor refactoring to help documentation

2015-02-25 Thread John McNamara
Minor refactoring and comments to make the sample app and code examples clearer for the sample app guide. Signed-off-by: John McNamara --- examples/skeleton/basicfwd.c | 77 +++--- 1 files changed, 57 insertions(+), 20 deletions(-) diff --git a/examples/ske

[dpdk-dev] [PATCH 0/3] additional sample app guides

2015-02-25 Thread John McNamara
This patchset includes two new sample app guides. The first is for the existing basic forwarding/skeleton application. The second is for the recently added rxtx_callbacks sample application. John McNamara (3): examples/skeleton: minor refactoring to help documentation doc: add docs for b

[dpdk-dev] [PATCH] eal: Clean up export of per_lcore__socket_id

2015-02-25 Thread Neil Horman
On Wed, Feb 25, 2015 at 11:54:51PM +, Liang, Cunming wrote: > Hi Neil, > > Thanks for the cleanup. > Does it better moving rte_socket_id() to eal_common_thread.c ? > As it simply returns _socket_id, it's not necessary to have two copy in both > linux and bsd. > > -Cunming > Sure, I can resp

[dpdk-dev] : ixgbe: why bulk allocation is not used for a scattered Rx flow?

2015-02-25 Thread Vlad Zolotarov
On 02/25/15 13:02, Bruce Richardson wrote: > On Wed, Feb 25, 2015 at 11:40:36AM +0200, Vlad Zolotarov wrote: >> Hi, I have a question about the "scattered Rx" feature: why enabling it >> disabled "bulk allocation" feature? > The "bulk-allocation" feature is one where a more optimized RX code path

[dpdk-dev] [PATCH v2] app/test: add crc32 algorithms equivalence check

2015-02-25 Thread Yerden Zhumabekov
All notes taken into account. v3 posted. 25.02.2015 17:34, Bruce Richardson ?: > On Wed, Feb 25, 2015 at 10:08:32AM +0600, Yerden Zhumabekov wrote: >> New function test_crc32_hash_alg_equiv() checks whether software, >> 4-byte operand and 8-byte operand versions of CRC32 hash function >> imple

[dpdk-dev] [PATCH v3] app/test: add crc32 algorithms equivalence check

2015-02-25 Thread Yerden Zhumabekov
New function test_crc32_hash_alg_equiv() checks whether software, 4-byte operand and 8-byte operand versions of CRC32 hash function implementations return the same result value. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c | 60 ++ 1

[dpdk-dev] [PATCH 7/7] vmxnet3: support jumbo frames

2015-02-25 Thread Stephen Hemminger
Add support for linking multi-segment buffers together to handle Jumbo packets. Signed-off-by: Stephen Hemminger --- v2 -- add missing pieces from last version lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +- lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 2 + lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH 6/7] vmxnet3: support RSS and refactor offload

2015-02-25 Thread Stephen Hemminger
Refactor the logic to compute receive offload flags to a simpler function. And add support for putting RSS flow hash into packet. Signed-off-by: Stephen Hemminger Signed-off-by: Bill Hong --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 69 --- 1 file changed, 40 inse

[dpdk-dev] [PATCH 5/7] vmxnet3: fix link state handling

2015-02-25 Thread Stephen Hemminger
The Intel version of VMXNET3 driver does not handle link state properly. The VMXNET3 API returns 1 if connected and 0 if disconnected. Also need to return correct value to indicate state change. Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 5

[dpdk-dev] [PATCH 4/7] vmxnet3: add support for multi-segment transmit

2015-02-25 Thread Stephen Hemminger
Change sending loop to support multi-segment mbufs. The VMXNET3 api has start-of-packet and end-packet flags, so it is not hard to send multi-segment mbuf's. Also, update descriptor in 32 bit value rather than toggling bitfields which is slower and error prone. Based on code in earlier driver, and

[dpdk-dev] [PATCH 3/7] vmxnet3: cleanup txq stats

2015-02-25 Thread Stephen Hemminger
There are several stats here which are never set, and have no way to be displayed. Assume in future xstats could be used. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/librte_p

[dpdk-dev] [PATCH 2/7] vmxnet3: remove mtu check

2015-02-25 Thread Stephen Hemminger
Remove check for packets greater than MTU. No other driver does this, it should be handled at higher layer Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 1 - lib/librte_pmd_vmxnet3/vmxnet3_rxt

[dpdk-dev] [PATCH 1/7] vmxnet3: enable VLAN filtering

2015-02-25 Thread Stephen Hemminger
Support the VLAN filter functionality of the VMXNET3 interface. Signed-off-by: Stephen Hemminger --- v2 -- incorporate comments from Yong Wang lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 105 +--- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 3 +- lib/librte_pmd_vmxnet3

[dpdk-dev] Manage DPDK port capability via KNI

2015-02-25 Thread Tim Deng
Thanks Danny, That means DPDK ports have to have dedicated control path other than KNI. I originally got confused by the statement at http://dpdk.org/doc/guides/prog_guide/kernel_nic_interface.html: "...Allows management of DPDK ports using standard Linux net tools such as ethtool, ifconfig and

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-25 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 24, 2015 8:07 PM > To: Stephen Hemminger > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when > read

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

2015-02-25 Thread Hemant Agrawal
From: Hemant Agrawal if any buffer is read from the tx_q, MAX_BURST buffers will be allocated and attempted to be added to to the alloc_q. This seems terribly inefficient and it also looks like the alloc_q will quickly fill to its maximum capacity. If the system buffers are low in number, it wi

[dpdk-dev] ixgbe vector mode not working.

2015-02-25 Thread Stephen Hemminger
On Wed, 25 Feb 2015 08:49:48 + "Liang, Cunming" wrote: > Hi Stephen, > > Thanks for the info, with rxd=4000, I can reproduce it. > On that time, it runs out of mbuf. > I'll follow up this issue. The first time I ran it, the code was configure rx/tx conf which was leftover from older version

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

2015-02-25 Thread David Marchand
On Wed, Feb 25, 2015 at 4:29 PM, Zhou, Danny wrote: > > > > > *From:* David Marchand [mailto:david.marchand at 6wind.com] > *Sent:* Wednesday, February 25, 2015 6:22 PM > *To:* Zhou, Danny > *Cc:* dev at dpdk.org; Liang, Cunming > *Subject:* Re: [dpdk-dev] [PATCH v5 5/6] eal: add per rx queue int

[dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function

2015-02-25 Thread Stephen Hemminger
Build fails if HOTPLUG is disabled == Build lib/librte_ether CC rte_ethdev.o /var/src/dpdk/lib/librte_ether/rte_ethdev.c:430:1: error: ?rte_eth_dev_get_device_type? defined but not used [-Werror=unused-function] rte_eth_dev_get_device_type(uint8_t port_id) ^ /var/src/dpdk/lib/librte_ether/rte

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

2015-02-25 Thread Thomas Monjalon
Please Danny, click on the button "uninstall Outlook" or configure it to have quote marks. This email is really hard to read. 2015-02-25 15:29, Zhou, Danny: > From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Wednesday, February 25, 2015 6:22 PM > To: Zhou, Danny > Cc: dev at dpdk.

[dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5

2015-02-25 Thread Thomas Monjalon
> > gcc 5 supports a new logical-not-parentheses warning which > > ixgbe_common.c triggers, causing build failure with -Werror. > > Since this source must not be modified, silence the warning instead. > > > > Signed-off-by: Panu Matilainen > > Acked-by: Konstantin Ananyev Applied, thanks

[dpdk-dev] [PATCH v3] app/test: add crc32 algorithms equivalence check

2015-02-25 Thread Thomas Monjalon
> > New function test_crc32_hash_alg_equiv() checks whether software, > > 4-byte operand and 8-byte operand versions of CRC32 hash function > > implementations return the same result value. > > > > Signed-off-by: Yerden Zhumabekov > > Acked-by: Bruce Richardson Applied, thanks

[dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD

2015-02-25 Thread Thomas Monjalon
> This PMD adds support for Mellanox ConnectX-3-based adapters through the > verbs framework. It relies on external libraries (libibverbs and user space > driver libmlx4) and kernel support to do so. > > While these libraries and kernel modules are available on OpenFabrics > Alliance's website [1]

[dpdk-dev] Looking forward to DPDK 2.1

2015-02-25 Thread Thomas Monjalon
Hi Siobhan, Thanks for contributing to the roadmap, the page http://dpdk.org/dev/roadmap will be updated soon. 2015-02-25 13:39, Butler, Siobhan A: > Hi all, > > The progress on DPDK 2.0 has been really positive and thanks to everyone for > contributing and helping to grow our community. We now

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

2015-02-25 Thread Zhou, Danny
From: David Marchand [mailto:david.march...@6wind.com] Sent: Wednesday, February 25, 2015 6:22 PM To: Zhou, Danny Cc: dev at dpdk.org; Liang, Cunming Subject: Re: [dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO Hello Danny, On Wed, Feb 25, 2015 at 7:58 AM, Zhou

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 Thread Thomas Monjalon
2015-02-25 21:32, Tetsuya Mukawa: > 2015-02-25 20:21 GMT+09:00 Thomas Monjalon : > > 2015-02-25 13:04, Tetsuya Mukawa: > >> --- a/lib/librte_eal/common/eal_common_dev.c > >> +++ b/lib/librte_eal/common/eal_common_dev.c > >> @@ -32,10 +32,13 @@ > >> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POS

[dpdk-dev] [PATCH v3 3/3] doc: add librte_pmd_mlx4 documentation

2015-02-25 Thread Adrien Mazarguil
This documentation covers implementation details, features and limitations, configuration, prerequisites and provides a usage example. Signed-off-by: Adrien Mazarguil --- MAINTAINERS | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_g

[dpdk-dev] [PATCH v3 2/3] mlx4: new poll mode driver

2015-02-25 Thread Adrien Mazarguil
This PMD manages all variants of Mellanox ConnectX-3 (EN 40, EN 10, Pro EN 40) as well as their virtual functions in SR-IOV context through IB Verbs (libibverbs) and the dedicated user-space driver (libmlx4). It is disabled by default due to dependencies on these libraries and only supports Linux

[dpdk-dev] [PATCH v3 1/3] scripts: check features to generate configuration header

2015-02-25 Thread Adrien Mazarguil
This script looks for types, macros and functions in header files using compilation options found in the environment (CC, CFLAGS, CPPFLAGS) to define feature macros in a generated header. Useful in combination with external headers that do not provide such macros. Signed-off-by: Adrien Mazarguil

[dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD

2015-02-25 Thread Adrien Mazarguil
This PMD adds support for Mellanox ConnectX-3-based adapters through the verbs framework. It relies on external libraries (libibverbs and user space driver libmlx4) and kernel support to do so. While these libraries and kernel modules are available on OpenFabrics Alliance's website [1] and provide

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

2015-02-25 Thread Thomas Monjalon
2015-02-25 07:30, Neil Horman: > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote: > > These two patches are the fixing for the compling error when > > CONFIG_RTE_BUILD_SHARED_LIB=y. > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing > > in the version map.

[dpdk-dev] [PATCH] headers: typeof -> __typeof__ to unbreak C++11 code

2015-02-25 Thread Simon Kagstrom
When compiling C++11-code or above (--std=c++11), the build fails with lots of rte_eth_ctrl.h:517:3: note: in expansion of macro RTE_ALIGN (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT) ^ When reading the GCC info pages, I get the feeling that __typeof__ is a better choice, and th

[dpdk-dev] [PATCH] maintainers: claim responsibility for timers

2015-02-25 Thread Sanford, Robert
Signed-off-by: Robert Sanford --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2eb7761..a2b53b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -371,6 +371,7 @@ F: examples/vm_power_manager/ F: doc/guides/sample_app_ug/vm_power_

[dpdk-dev] [PATCH v2 4/4] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

2015-02-25 Thread Pawel Wodkowski
Fix warning reported during static analysis about size_t to int cast when passing parameters to parse_set_list(). This patch fix code formating errors that give checkpatch.pl errors after generating patch. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline_parse_portlist.c | 4 ++--

[dpdk-dev] [PATCH v2 3/4] pmd ring: fix possible memory leak during devinit

2015-02-25 Thread Pawel Wodkowski
Free kvlist on function exit to avoid memory leak. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ring/rte_eth_ring.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_ring/rte_eth_ring.c b/lib/librte_pmd_ring/rte_eth_ring.c index a5dc71e..f049bb3 10064

[dpdk-dev] [PATCH v2 2/4] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

2015-02-25 Thread Pawel Wodkowski
By convenction free() functions should ignore NULL parameter. This patch add this behaviour for rte_kvargs_free(). Signed-off-by: Pawel Wodkowski --- lib/librte_kvargs/rte_kvargs.c | 4 lib/librte_kvargs/rte_kvargs.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib

[dpdk-dev] [PATCH v2 1/4] rte_timer: change declaration of rte_timer_cb_t

2015-02-25 Thread Pawel Wodkowski
This patch remove inconsistency between declaration of type rte_timer_cb_t, field f in struct rte_timer and function __rte_timer_reset(). Although compiler treat both of them the same, the static analysis tool like complain about that. Signed-off-by: Pawel Wodkowski --- lib/librte_timer/rte_tim

[dpdk-dev] [PATCH v2 0/4] Fix issues reported by static analysis tool

2015-02-25 Thread Pawel Wodkowski
Static analysis report some issues against current DPDK version. Most of them need only cosmetic code changes (changing type of variable). One issue related with ring pmd fix real memory leak problem. PATCH v2 changes: - remove patch 5/5 as it was NACKed - reword commit log acording to mailing

[dpdk-dev] Looking forward to DPDK 2.1

2015-02-25 Thread Butler, Siobhan A
Hi all, The progress on DPDK 2.0 has been really positive and thanks to everyone for contributing and helping to grow our community. We now look onwards to DPDK 2.1 planning which is due to release at the end of July, and we'd like to inform the community of the features that we hope to submit

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

2015-02-25 Thread Marc Sune
On 25/02/15 13:24, Hemant at freescale.com wrote: > Hi OIivier >Comments inline. > Regards, > Hemant > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Deme >> Sent: 25/Feb/2015 5:44 PM >> To: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 01:12:43PM +, Iremonger, Bernard wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Wednesday, February 25, 2015 12:28 PM > > To: Iremonger, Bernard > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update programmers gui

[dpdk-dev] [PATCH v3] app/test: add crc32 algorithms equivalence check

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 06:34:06PM +0600, Yerden Zhumabekov wrote: > New function test_crc32_hash_alg_equiv() checks whether software, > 4-byte operand and 8-byte operand versions of CRC32 hash function > implementations return the same result value. > > Signed-off-by: Yerden Zhumabekov Acked-by

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

2015-02-25 Thread Iremonger, Bernard
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, February 25, 2015 12:28 PM > To: Iremonger, Bernard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update programmers guide for > uio_pci_generic > > On Wed, Feb 25, 2015 at 12:19:10PM +, Iremonger,

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

2015-02-25 Thread Tetsuya Mukawa
On 2015/02/25 12:39, Cunming Liang wrote: > These two patches are the fixing for the compling error when > CONFIG_RTE_BUILD_SHARED_LIB=y. > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in > the version map. > Thanks for the notification from Tetsuya Mukawa . > > Cunm

[dpdk-dev] [PATCH v14] testpmd: Add port hotplug support

2015-02-25 Thread Tetsuya Mukawa
The patch introduces following commands. - port attach [ident] - port detach [port_id] - attach: attaching a port - detach: detaching a port - ident: pci address of physical device. Or device name and parameters of virtual device. (ex. :02:00.0, eth_pcap0,iface=eth0) - po

[dpdk-dev] [PATCH v14] librte_pmd_pcap: Add port hotplug support

2015-02-25 Thread Tetsuya Mukawa
This patch adds finalization code to free resources allocated by the PMD. v6: - Fix a paramter of rte_eth_dev_free(). v4: - Change function name. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++ 1 file changed, 40 insertions(+)

[dpdk-dev] [PATCH v14 13/13] doc: Add port hotplug framework section to programmers guide

2015-02-25 Thread Tetsuya Mukawa
This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 Thread Tetsuya Mukawa
These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When rte_eal_dev_

[dpdk-dev] [PATCH v14 11/13] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

2015-02-25 Thread Tetsuya Mukawa
This new parameter is needed to keep device type like PCI or virtual. Port detaching processes are different between PCI device and virtual device. RTE_ETH_DEV_PCI indicates device type is PCI. RTE_ETH_DEV_VIRTUAL indicates device is virtual. v12: - Add missing symbol in version map. (Thanks to

[dpdk-dev] [PATCH v14 10/13] eal/pci: Add probe and close functions of pci driver

2015-02-25 Thread Tetsuya Mukawa
- Add pci_close_all_drivers() The function tries to find a driver for the specified device, and then close the driver. - Add rte_eal_pci_probe_one() and rte_eal_pci_close_one() The functions are used for probe and close a device. First the function tries to find a device that has the specif

[dpdk-dev] [PATCH v14 09/13] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-25 Thread Tetsuya Mukawa
The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v9: - Remove "rte_dev_hotplug.h". - Remove needless "#ifdef". (Thanks to Thomas Monjalon and Neil Horman) - Remove pci_unmap_device(). It will be impleme

[dpdk-dev] [PATCH v14 08/13] ethdev: Add functions that will be used by port hotplug functions

2015-02-25 Thread Tetsuya Mukawa
The patch adds following functions. - rte_eth_dev_save() The function is used for saving current rte_eth_dev structures. - rte_eth_dev_get_changed_port() The function receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or deta

[dpdk-dev] [PATCH v14 07/13] eal, ethdev: Add a function and function pointers to close ether device

2015-02-25 Thread Tetsuya Mukawa
The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v10: - Add size par

[dpdk-dev] [PATCH v14 06/13] ethdev: Add rte_eth_dev_release_port to release specified port

2015-02-25 Thread Tetsuya Mukawa
This patch adds rte_eth_dev_release_port(). The function is used for changing an attached status of the device that has specified name. v9: - rte_eth_dev_free() is replaced by rte_eth_dev_release_port(). (Thanks to Thomas Monjalon) v6: - Use rte_eth_dev structure as the paramter of rte_eth_dev_f

[dpdk-dev] [PATCH v14 05/13] eal/pci: Consolidate pci address comparison APIs

2015-02-25 Thread Tetsuya Mukawa
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by rte_eal_compare_pci_addr(). To compare PCI addresses, rte_eal_compare_pci_addr() doesn't use memcmp(). This is because sizeof(struct rte_pci_addr) returns 6, but actually this structure is like below. struct rte_pci_addr {

[dpdk-dev] [PATCH v14 04/13] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-25 Thread Tetsuya Mukawa
To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to rt

[dpdk-dev] [PATCH v14 03/13] eal_pci: pci memory map work with driver type

2015-02-25 Thread Tetsuya Mukawa
From: Michael Qiu With the driver type flag in struct rte_pci_dev, we do not need to always map uio devices with vfio related function when vfio enabled. Signed-off-by: Michael Qiu Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 30 +- 1

[dpdk-dev] [PATCH v14 02/13] eal_pci: Add flag to hold kernel driver type

2015-02-25 Thread Tetsuya Mukawa
From: Michael Qiu Currently, dpdk has no ability to know which type of driver( vfio-pci/igb_uio/uio_pci_generic) the device used. It only can check whether vfio is enabled or not staticly. It really useful to have the flag, becasue different type need to handle differently in runtime. For exampl

[dpdk-dev] [PATCH v14 01/13] eal: Enable port Hotplug framework in Linux

2015-02-25 Thread Tetsuya Mukawa
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD configuration. So far, Hotplug functions only support linux. v9: - Move this patch at the top of this patch series. (Thanks to Thomas Monjalon) Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 ++ config/common_linu

[dpdk-dev] [PATCH v14 00/13] Port Hotplug Framework

2015-02-25 Thread Tetsuya Mukawa
This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have responsibility to manage ports. DPDK apps only know which ports are attached or deta

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

2015-02-25 Thread Olivier Deme
Hi Marc, I think one of the observations is that currently the alloc_q grows very quickly to the maximum fifo size (1024). The patch suggests fixing the alloc_q to a fix size and maybe make that size configurable in rte_kni_alloc or rte_kni_init. It should then be up to the application to provi

[dpdk-dev] Vhost-user early adopter feedback

2015-02-25 Thread BenoƮt Canet
The Wednesday 25 Feb 2015 ? 07:46:56 (+), Xie, Huawei wrote : > On 2/18/2015 3:59 PM, Beno?t Canet wrote: > > Hello Xie, > > > > As promized I integrated your vhost-user patchset from january in my > > vswitch. > > > > I just tried it, it works pretty well. > > > > I just had a minor bug with

[dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV

2015-02-25 Thread Pawel Wodkowski
On 2015-02-25 04:36, Ouyang, Changchun wrote: >> @@ -652,7 +655,9 @@ ixgbe_get_vf_queues(struct rte_eth_dev *dev, >> >uint32_t vf, uint32_t *msgbuf) { >> >struct ixgbe_vf_info *vfinfo = >> >*IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data- >>> > >dev_private); >> >- uint32_t default_q =

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

2015-02-25 Thread Olivier Deme
I guess it would be unusual but possible for the kernel to enqueue faster to tx_q than the application dequeues. But that would also be possible with a real NIC, so I think it is acceptable for the kernel to have to drop egress packets in that case. On 25/02/15 12:24, Hemant at freescale.com wr

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 12:19:10PM +, Iremonger, Bernard wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, February 24, 2015 4:28 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] doc: update

[dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 12:14:15PM +, Iremonger, Bernard wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, February 24, 2015 4:28 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] doc: Update

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

2015-02-25 Thread hem...@freescale.com
Hi OIivier Comments inline. Regards, Hemant > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Deme > Sent: 25/Feb/2015 5:44 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst > > Thank you Hemant, I

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 Thread Thomas Monjalon
2015-02-25 13:04, Tetsuya Mukawa: > --- a/lib/librte_eal/common/eal_common_dev.c > +++ b/lib/librte_eal/common/eal_common_dev.c > @@ -32,10 +32,13 @@ > * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > +#include > +#include > #include > #include > #inclu

[dpdk-dev] dpdk - poll mode - context switches

2015-02-25 Thread Jog Lie
Hi Bruce, Ok. understood. Thanks ! --? Jog

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

2015-02-25 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, February 24, 2015 4:28 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: update programmers guide for > uio_pci_generic > > Since DPDK now has support for the i

[dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use

2015-02-25 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, February 24, 2015 4:28 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use > > Since DPDK now has support for the in-tree uio_pc

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

2015-02-25 Thread Olivier Deme
Thank you Hemant, I think there might be one issue left with the patch though. The alloc_q must initially be filled with mbufs before getting mbuf back on the tx_q. So the patch should allow rte_kni_rx_burst to check if alloc_q is empty. If so, it should invoke kni_allocate_mbufs(kni, 0) (to fil

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

2015-02-25 Thread Thomas Monjalon
2015-02-25 06:02, Robert Sanford: > Hi Thomas, > > Yes, I'm interested in becoming a maintainer of rte_timer. What are the > responsibilities? It means we know someone who can answer our questions about rte_timer. Having you email in the MAINTAINERS file helps to CC you. And we expect from the ma

[dpdk-dev] Missing symbol error

2015-02-25 Thread Tetsuya Mukawa
Hi, I've got following error when I enable CONFIG_RTE_BUILD_SHARED_LIB. dpdk/x86_64-native-linuxapp-gcc/lib/libethdev.so: undefined reference to `per_lcore__socket_id' collect2: error: ld returned 1 exit status make[5]: *** [dump_cfg] Error 1 make[4]: *** [dump_cfg] Error 2 make[4]: *** Waiting f

[dpdk-dev] [PATCH v2 0/4] DPDK memcpy optimization

2015-02-25 Thread Thomas Monjalon
> > This patch set optimizes memcpy for DPDK for both SSE and AVX platforms. > > It also extends memcpy test coverage with unaligned cases and more test > > points. > > > > Optimization techniques are summarized below: > > > > 1. Utilize full cache bandwidth > > > > 2. Enforce aligned stores > >

[dpdk-dev] : ixgbe: why bulk allocation is not used for a scattered Rx flow?

2015-02-25 Thread Vlad Zolotarov
Hi, I have a question about the "scattered Rx" feature: why enabling it disabled "bulk allocation" feature? There is some unclear comment in the ixgbe_recv_scattered_pkts(): /* * Descriptor done. * * Allocate a new mbuf to repleni

[dpdk-dev] [PATCH v1 2/2] eal/bsd: fix symbol missing in version map

2015-02-25 Thread Cunming Liang
As per_lcore__socket_id and rte_sys_gettid are missing in version map, it causes compiling error when CONFIG_RTE_BUILD_SHARED_LIB is enabled. Signed-off-by: Cunming Liang --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/bsdapp

[dpdk-dev] [PATCH v1 1/2] eal/linux: fix symbol missing in version map

2015-02-25 Thread Cunming Liang
As per_lcore__socket_id and rte_sys_gettid are missing in version map, it causes compiling error when CONFIG_RTE_BUILD_SHARED_LIB is enabled. Signed-off-by: Cunming Liang --- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/linu

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

2015-02-25 Thread Cunming Liang
These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y. The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map. Thanks for the notification from Tetsuya Mukawa . Cunming Liang (2): eal/linux: fix symbol missing in versi

[dpdk-dev] [PATCH v2] app/test: add crc32 algorithms equivalence check

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 10:08:32AM +0600, Yerden Zhumabekov wrote: > New function test_crc32_hash_alg_equiv() checks whether software, > 4-byte operand and 8-byte operand versions of CRC32 hash function > implementations return the same result value. > > Signed-off-by: Yerden Zhumabekov Two smal

[dpdk-dev] Cannot compile l2fwd-jobstats example

2015-02-25 Thread Tetsuya Mukawa
Hi, I cannot compile l2fwd-jobstats using master branch. Here is log $ T=x86_64-native-linuxapp-gcc make examples == Build examples for x86_64-native-linuxapp-gcc == bond == cmdline == distributor == exception_path == helloworld == ip_pipeline == ip_reassembly == ipv4_multicast ==

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

2015-02-25 Thread David Marchand
Hello Danny, On Wed, Feb 25, 2015 at 7:58 AM, Zhou, Danny wrote: > > +int > +rte_intr_wait_rx_pkt(struct rte_intr_handle *intr_handle, uint8_t > queue_id) > +{ > + struct epoll_event ev; > + unsigned numfds = 0; > + > + if (!intr_handle || intr_handle->fd < 0 || intr_handle->ui

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 06:02:24AM -0500, Robert Sanford wrote: > Hi Thomas, > > Yes, I'm interested in becoming a maintainer of rte_timer. What are the > responsibilities? > > > One question about lib rte_timer that's been troubling me for a while: How > are skip lists better than BSD-style tim

[dpdk-dev] dpdk - poll mode - context switches

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 10:54:51AM +0100, Jog Lie wrote: > Hello, > > I am not sure to understand the mechanism behind dpdk concerning the context > switches. > I have two user space applications that need access to the NIC according to > incoming port rules (port 80 and port 443). > > How to b

[dpdk-dev] : ixgbe: why bulk allocation is not used for a scattered Rx flow?

2015-02-25 Thread Bruce Richardson
On Wed, Feb 25, 2015 at 11:40:36AM +0200, Vlad Zolotarov wrote: > Hi, I have a question about the "scattered Rx" feature: why enabling it > disabled "bulk allocation" feature? The "bulk-allocation" feature is one where a more optimized RX code path is used. For the sake of performance, when doing

[dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() logic to driver

2015-02-25 Thread Pawel Wodkowski
On 2015-02-25 07:14, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski >> Sent: Thursday, February 19, 2015 11:55 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() >> l

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 Thread Thomas Monjalon
2015-02-25 09:52, Liang, Cunming: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-02-25 00:57, Liang, Cunming: > > > From: John W. Linville [mailto:linville at tuxdriver.com] > > > > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote: > > > > > 2015-02-12 17:08,

[dpdk-dev] dpdk - poll mode - context switches

2015-02-25 Thread Jog Lie
Hello, I am not sure to understand the mechanism behind dpdk concerning the context switches. I have two user space applications that need access to the NIC according to incoming port rules (port 80 and port 443). How to be sure that DPDK spreads the load to the right application ? Will 2 dpd

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

2015-02-25 Thread Thomas Monjalon
> > Changes in v2: > > - split into multiple patches > > - minor coding-style changes > > > > Robert Sanford (3): > >timer: fix return value of rte_timer_reset(), > > insert rte_pause() into rte_timer_reset_sync() wait-loop > >app/test: fix timer stress test to succeed on multiple runs

[dpdk-dev] KNI as kernel vHost backend failing

2015-02-25 Thread Xie, Huawei
On 1/1/2015 5:02 PM, sai kiran wrote: > Hi, > > > > We are trying to experiment with DPDK?s KNI application, with KNI working > as Kernel vHost backend. > > > 1. After starting the KNI application, KNI application has detected link > up. > > > *[root at localhost kni]# ./build/app/kni -c 0xf0 -n 4

[dpdk-dev] Cannot compile l2fwd-jobstats example

2015-02-25 Thread Thomas Monjalon
2015-02-25 08:38, Pawel Wodkowski: > On 2015-02-25 03:26, Tetsuya Mukawa wrote: > > Hi, > > > > I cannot compile l2fwd-jobstats using master branch. > > Here is log > > > > $ T=x86_64-native-linuxapp-gcc make examples > > == Build examples for x86_64-native-linuxapp-gcc > > == bond

[dpdk-dev] ixgbe vector mode not working.

2015-02-25 Thread Thomas Monjalon
2015-02-24 23:36, Stephen Hemminger: > On Wed, 25 Feb 2015 04:55:09 + > "Liang, Cunming" wrote: > > > Hi Stephen, > > > > I tried on the latest mater branch with testpmd. > > 2 rxq and 2 txq as below, vector pmd on both rx and tx. I can't reproduced > > it. > > I checked your log, on tx sid

[dpdk-dev] [PATCH v2] app/test: add crc32 algorithms equivalence check

2015-02-25 Thread Yerden Zhumabekov
New function test_crc32_hash_alg_equiv() checks whether software, 4-byte operand and 8-byte operand versions of CRC32 hash function implementations return the same result value. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c | 63 ++ 1

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

2015-02-25 Thread Thomas Monjalon
> > These two patches are the fixing for the compling error when > > CONFIG_RTE_BUILD_SHARED_LIB=y. > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing > > in the version map. > > Thanks for the notification from Tetsuya Mukawa . Please use Reported-by: in such case. Fix

  1   2   >