[dpdk-dev] ixgbe vector mode not working.

On Wed, 25 Feb 2015 04:55:09 + "Liang, Cunming" wrote: > Hi Stephen, > > I tried on the latest mater branch with testpmd. > 2 rxq and 2 txq as below, vector pmd on both rx and tx. I can't reproduced it. > I checked your log, on tx side, it looks the tx vector haven't enabled. (it > shows vp

[dpdk-dev] [PATCH v13 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-24 22:25 GMT+09:00 Maxime Leroy : > Hi Tetsuya, > > On Tue, Feb 24, 2015 at 5:49 AM, Tetsuya Mukawa wrote: >> These functions are used for attaching or detaching a port. > [...] >> +static int >> +rte_eal_vdev_init(const char *name, const char *args) >> +{ >> + struct rte_driver *dri

[dpdk-dev] [PATCH v2 3/3] timer: fix rte_timer_reset return value

- API rte_timer_reset() should return -1 when the timer is in the RUNNING or CONFIG state. Instead, it ignores the return value of internal function __rte_timer_reset() and always returns 0. We change rte_timer_reset() to return the value returned by __rte_timer_reset(). - Enhance timer stress tes

[dpdk-dev] [PATCH v2 2/3] timer: fix stress test on multiple runs

Fix timer stress test to succeed on multiple runs. Signed-off-by: Robert Sanford --- app/test/test_timer.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/app/test/test_timer.c b/app/test/test_timer.c index 4b4800b..070437a 100644 --- a/app/test/test_timer.c +++ b/a

[dpdk-dev] [PATCH v2 1/3] timer: pause in rte_timer_reset_sync

In rte_timer_reset_sync(), insert rte_pause() into loop that waits for rte_timer_reset() to succeed. Signed-off-by: Robert Sanford --- lib/librte_timer/rte_timer.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

Changes in v2: - split into multiple patches - minor coding-style changes Robert Sanford (3): timer: fix return value of rte_timer_reset(), insert rte_pause() into rte_timer_reset_sync() wait-loop app/test: fix timer stress test to succeed on multiple runs, display number of times that

[dpdk-dev] closing version 2.0.0-rc1

It is time to close the first release candidate for DPDK 2.0. Then we are going to enter into the RC testing phase which was planned from 23rd February to 13th March. Only fixes, and cleanups will be accepted. At the end, the release should be out on 31st March. This is the list of the integrated

[dpdk-dev] [PATCH 0/2] update docs for uio_pci_generic

2015-02-24 16:27, Bruce Richardson: > Since we now have support for using uio_pci_generic instead of the > DPDK-specific > igb_uio kernel module, update the documentation to reflect this fact. > The doc update includes presenting the uio_pci_generic as the primary uio > module > over igb_uio, sin

[dpdk-dev] [PATCH v4 0/3] fix and improve uio_pci_generic support

> V4 changes: Split second patch into two for more readable history > > V3 changes: Rebase to take account of commit 90a1633b > "eal/linux: allow to map BARs with MSI-X tables" > > This patch does some cleanup of the uio mapping code to > a) fix issue with mmap of PCI bars reported by Tet

[dpdk-dev] [PATCH v6 0/3] new rte_jobstats library and example application

> > Hi community, > > I would like to introduce library for measuring load of some arbitrary jobs > > and > > help finding optimal poll time in poll mode applications. It can be used to > > measure and drive every kind of job sets on any arbitrary execution unit or > > tasking library. > > > > In

[dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example

2015-02-24 17:33, Pawel Wodkowski: > --- a/examples/Makefile > +++ b/examples/Makefile > @@ -50,6 +50,7 @@ DIRS-$(CONFIG_RTE_MBUF_REFCNT) += ip_fragmentation > DIRS-$(CONFIG_RTE_MBUF_REFCNT) += ipv4_multicast > DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni > DIRS-y += l2fwd > +DIRS-y += l2fwd-jobstats Y

[dpdk-dev] [PATCH v6 1/3] librte_jobstats: New library for checking core/system/app load

2015-02-24 17:33, Pawel Wodkowski: > --- /dev/null > +++ b/lib/librte_jobstats/rte_jobstats_version.map > @@ -0,0 +1,19 @@ > +DPDK_2.0 { > + global: > + > + rte_jobstats_context_init; > + rte_jobstats_context_start; > + rte_jobstats_context_finish; > + rte_jobstats_context_reset

[dpdk-dev] [PATCH v3] test: fix missing NULL pointer checks

2015-02-10 11:46, Bruce Richardson: > On Fri, Jan 30, 2015 at 11:18:19AM +0100, Thomas Monjalon wrote: > > 2015-01-27 13:06, Neil Horman: > > > On Tue, Jan 27, 2015 at 04:44:53PM +0100, Daniel Mrzyglod wrote: > > > > In test_sched, we are missing NULL pointer checks after create_mempool() > > > > a

[dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example

2015-02-24 19:16, De Lara Guarch, Pablo: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > > Pablo > > Sent: Tuesday, February 24, 2015 7:11 PM > > To: Wodkowski, PawelX; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v6 2/3] example

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-24 11:18, Stephen Hemminger: > On Mon, 23 Feb 2015 23:51:31 + > Thomas Monjalon wrote: > > > 2015-02-05 07:43, Neil Horman: > > > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > > > + > > > > +/** > > > > + * Hierarchical scheduler subport statistics reset > > >

[dpdk-dev] [PATCH v6 0/3] new rte_jobstats library and example application

> -Original Message- > From: Wodkowski, PawelX > Sent: Tuesday, February 24, 2015 4:33 PM > To: dev at dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v6 0/3] new rte_jobstats library and example application > > Hi community, > I would like to introduce library for measuring load of so

[dpdk-dev] [PATCH] devargs: restore empty devargs as ""

2015-02-24 19:16, Tetsuya Mukawa: > On 2015/02/24 18:41, David Marchand wrote: > > Following commit c07691ae1089, an implicit change has been done in the > > devargs > > api. > > This triggers problem in virtual pmds that did not check for parameters > > validity > > as it was implicitely valid.

[dpdk-dev] [PATCH v1] doc: prog guide update for eal multi-pthread

2015-02-16 15:34, Cunming Liang: > The patch add the multi-pthread section under EAL chapter of prog_guide. > > Signed-off-by: Cunming Liang I guess this documentation has been co-written with a native english? Applied, thanks

[dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores

2015-02-15 13:47, Cunming Liang: > The patch add unit test for the new eal option "--lcores". > > Signed-off-by: Cunming Liang > --- > It depends on the previous patch which enabling EAL "--lcores" option. > http://dpdk.org/ml/archives/dev/2015-February/013204.html Applied, thanks

[dpdk-dev] [PATCH v8 00/19] support multi-pthread per core

> > v8 changes: > > keep using strlen for trusted input string > > > > v7 changes: > > update EAL version map for new public EAL API > > rollback to use strnlen() passing EAL core option > > > > v6 changes: > > rename RTE_RING_PAUSE_REP(_COUNT) and set default to 0 > > rollback to use R

[dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, February 24, 2015 7:11 PM > To: Wodkowski, PawelX; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd- > jobstats example > > > >

[dpdk-dev] [PATCH] devargs: restore empty devargs as ""

On 2015/02/24 18:41, David Marchand wrote: > Following commit c07691ae1089, an implicit change has been done in the devargs > api. > This triggers problem in virtual pmds that did not check for parameters > validity > as it was implicitely valid. > > Fix this by restoring the empty argument as ""

[dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example

> -Original Message- > From: Wodkowski, PawelX > Sent: Tuesday, February 24, 2015 4:33 PM > To: dev at dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example > > This app demonstrate usage of new rte_jobstats library. > It is basically th

[dpdk-dev] [PATCH] app/test: add crc32 algorithms equivalence check

New function test_crc32_hash_alg_equiv() checks whether software, 4-byte operand and 8-byte operand versions of CRC32 hash function implementations return the same result value. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c | 53 ++ 1

[dpdk-dev] [PATCH] eal: mmap uio resources using resourceX files

On 2015/02/24 0:00, Bruce Richardson wrote: > On Mon, Feb 23, 2015 at 02:57:24PM +, Bruce Richardson wrote: >> Instead of distinguishing the BAR mappings via offset within a single >> file, originally /dev/uioX, switch to mapping each individual bar via >> the appropriately numbered resourceX f

[dpdk-dev] [PATCH v6 3/3] MAINTAINERS: claim responsibility for rte_jobstats library and example app

Signed-off-by: Pawel Wodkowski --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a771fa3..7b3ef00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,10 @@ F: app/test/test_timer* F: examples/timer/ F: doc/guides/sample_app_ug/timer.rs

[dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example

This app demonstrate usage of new rte_jobstats library. It is basically the orginal l2fwd with following modifications to met library requirements: - main_loop() was split into two jobs: forward job and flush job. Logic for those jobs is almost the same as in original application. - stats is moved

[dpdk-dev] [PATCH v6 1/3] librte_jobstats: New library for checking core/system/app load

This library provide API to measure time spend in particular parts of code and to calculate optimal polling time. To calculate a those statistics application code need to be divided into parts (called jobs) that do something. It is up to application to decide what is considered a job. Series of j

[dpdk-dev] [PATCH v6 0/3] new rte_jobstats library and example application

Hi community, I would like to introduce library for measuring load of some arbitrary jobs and help finding optimal poll time in poll mode applications. It can be used to measure and drive every kind of job sets on any arbitrary execution unit or tasking library. In provided l2fwd-jobstats example

[dpdk-dev] closing version 2.0.0-rc1

On Tue, 24 Feb 2015 22:50:29 +0100 Thomas Monjalon wrote: > It is time to close the first release candidate for DPDK 2.0. > Then we are going to enter into the RC testing phase which was planned > from 23rd February to 13th March. Only fixes, and cleanups will be accepted. > At the end, the relea

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

Since DPDK now has support for the in-tree uio_pci_generic driver, update the programmers guide document to reference this module, and to use it in preference to the igb_uio driver, which is DPDK-specific. Signed-off-by: Bruce Richardson --- doc/guides/prog_guide/env_abstraction_layer.rst

[dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use

Since DPDK now has support for the in-tree uio_pci_generic driver, update the GSG document to reference this module, and to use it in preference to the igb_uio driver, which is DPDK-specific. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/build_dpdk.rst| 63 +---

[dpdk-dev] [PATCH 0/2] update docs for uio_pci_generic

Since we now have support for using uio_pci_generic instead of the DPDK-specific igb_uio kernel module, update the documentation to reflect this fact. The doc update includes presenting the uio_pci_generic as the primary uio module over igb_uio, since in-tree drivers should be generally preferred o

[dpdk-dev] ixgbe vector mode not working.

The ixgbe driver (from 1.8 or 2.0) works fine in normal (non-vectored) mode. But when vector mode is enabled, it gets a few packets through then hangs. We use 2 Rx queues and 1 Tx queue per interface. Devices: 01:00.0 Ethernet controller: Intel Corporation 82599EB 10-Gigabit SFI/SFP+ Network Conn

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

On 02/24/2015 03:34 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Tuesday, February 24, 2015 10:47 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc - >>

[dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5

gcc 5 supports a new logical-not-parentheses warning which ixgbe_common.c triggers, causing build failure with -Werror. Since this source must not be modified, silence the warning instead. Signed-off-by: Panu Matilainen --- lib/librte_pmd_ixgbe/Makefile | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types

> -Original Message- > From: Zhang, Helin > Sent: Tuesday, February 24, 2015 9:45 PM > To: Thomas Monjalon > Cc: dev at dpdk.org; Wu, Jingjing; Chen, Jing D > Subject: RE: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload > types > > > > > -Original Message- > > From

[dpdk-dev] [PATCH] app/test: add crc32 algorithms equivalence check

On Tue, Feb 24, 2015 at 06:36:28PM +0600, Yerden Zhumabekov wrote: > New function test_crc32_hash_alg_equiv() checks whether software, > 4-byte operand and 8-byte operand versions of CRC32 hash function > implementations return the same result value. > > Signed-off-by: Yerden Zhumabekov Looks li

[dpdk-dev] [PATCH v13 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

Hi Tetsuya, On Tue, Feb 24, 2015 at 5:49 AM, Tetsuya Mukawa wrote: > These functions are used for attaching or detaching a port. [...] > +static int > +rte_eal_vdev_init(const char *name, const char *args) > +{ > + struct rte_driver *driver; > + > + if (name == NULL) > +

[dpdk-dev] [PATCH v13] testpmd: Add port hotplug support

The patch introduces following commands. - port attach [ident] - port detach [port_id] - attach: attaching a port - detach: detaching a port - ident: pci address of physical device. Or device name and parameters of virtual device. (ex. :02:00.0, eth_pcap0,iface=eth0) - po

[dpdk-dev] [PATCH v13] librte_pmd_pcap: Add port hotplug support

This patch adds finalization code to free resources allocated by the PMD. v6: - Fix a paramter of rte_eth_dev_free(). v4: - Change function name. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++ 1 file changed, 40 insertions(+)

[dpdk-dev] [PATCH v13 13/13] doc: Add port hotplug framework section to programmers guide

This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v13 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When rte_eal_dev_

[dpdk-dev] [PATCH v13 11/13] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

This new parameter is needed to keep device type like PCI or virtual. Port detaching processes are different between PCI device and virtual device. RTE_ETH_DEV_PCI indicates device type is PCI. RTE_ETH_DEV_VIRTUAL indicates device is virtual. v12: - Add missing symbol in version map. (Thanks to

[dpdk-dev] [PATCH v13 10/13] eal/pci: Add probe and close functions of pci driver

- Add pci_close_all_drivers() The function tries to find a driver for the specified device, and then close the driver. - Add rte_eal_pci_probe_one() and rte_eal_pci_close_one() The functions are used for probe and close a device. First the function tries to find a device that has the specif

[dpdk-dev] [PATCH v13 09/13] eal/linux/pci: Add functions for unmapping igb_uio resources

The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v9: - Remove "rte_dev_hotplug.h". - Remove needless "#ifdef". (Thanks to Thomas Monjalon and Neil Horman) - Remove pci_unmap_device(). It will be impleme

[dpdk-dev] [PATCH v13 08/13] ethdev: Add functions that will be used by port hotplug functions

The patch adds following functions. - rte_eth_dev_save() The function is used for saving current rte_eth_dev structures. - rte_eth_dev_get_changed_port() The function receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or deta

[dpdk-dev] [PATCH v13 07/13] eal, ethdev: Add a function and function pointers to close ether device

The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v10: - Add size par

[dpdk-dev] [PATCH v13 06/13] ethdev: Add rte_eth_dev_release_port to release specified port

This patch adds rte_eth_dev_release_port(). The function is used for changing an attached status of the device that has specified name. v9: - rte_eth_dev_free() is replaced by rte_eth_dev_release_port(). (Thanks to Thomas Monjalon) v6: - Use rte_eth_dev structure as the paramter of rte_eth_dev_f

[dpdk-dev] [PATCH v13 05/13] eal/pci: Consolidate pci address comparison APIs

This patch replaces pci_addr_comparison() and memcmp() of pci addresses by rte_eal_compare_pci_addr(). To compare PCI addresses, rte_eal_compare_pci_addr() doesn't use memcmp(). This is because sizeof(struct rte_pci_addr) returns 6, but actually this structure is like below. struct rte_pci_addr {

[dpdk-dev] [PATCH v13 04/13] eal/pci, ethdev: Remove assumption that port will not be detached

To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to rt

[dpdk-dev] [PATCH v13 03/13] eal_pci: pci memory map work with driver type

From: Michael Qiu With the driver type flag in struct rte_pci_dev, we do not need to always map uio devices with vfio related function when vfio enabled. Signed-off-by: Michael Qiu Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 30 +- 1

[dpdk-dev] [PATCH v13 02/13] eal_pci: Add flag to hold kernel driver type

From: Michael Qiu Currently, dpdk has no ability to know which type of driver( vfio-pci/igb_uio/uio_pci_generic) the device used. It only can check whether vfio is enabled or not staticly. It really useful to have the flag, becasue different type need to handle differently in runtime. For exampl

[dpdk-dev] [PATCH v13 01/13] eal: Enable port Hotplug framework in Linux

The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD configuration. So far, Hotplug functions only support linux. v9: - Move this patch at the top of this patch series. (Thanks to Thomas Monjalon) Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 ++ config/common_linu

[dpdk-dev] [PATCH v13 00/13] Port Hotplug Framework

This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have responsibility to manage ports. DPDK apps only know which ports are attached or deta

[dpdk-dev] [PATCH v11 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

On 2015/02/23 22:29, Maxime Leroy wrote: > Hi Tetsuya, > > On Mon, Feb 23, 2015 at 6:09 AM, Tetsuya Mukawa wrote: >> These functions are used for attaching or detaching a port. > [...] >> +static int >> +rte_eal_vdev_init(const char *name, const char *args) >> +{ >> + struct rte_driver *dri

[dpdk-dev] [PULL REQUEST] i40e: Performance workaround for XL710, enable

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, February 24, 2015 7:04 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PULL REQUEST] i40e: Performance workaround for > XL710, enable > > > Helin Zhang (1): > >

[dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5

> -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Tuesday, February 24, 2015 1:14 PM > To: dev at dpdk.org > Cc: Ananyev, Konstantin > Subject: [PATCH v2] ixgbe: fix build with gcc 5 > > gcc 5 supports a new logical-not-parentheses warning which > ixgbe

[dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, February 23, 2015 6:59 AM > To: Zhang, Helin > Cc: dev at dpdk.org; Wu, Jingjing; Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload > types > > > > I

[dpdk-dev] [PATCH v3 1/2] eal: mmap uio resources using resourceX files

On Tue, Feb 24, 2015 at 1:20 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > Instead of distinguishing the BAR mappings via offset within a single > file, originally /dev/uioX, switch to mapping each individual bar via > the appropriately numbered resourceX file. > > Signed-off-by:

[dpdk-dev] [PATCH v3 2/2] eal: populate uio_maps from pci mem_resources array

On Tue, Feb 24, 2015 at 1:20 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > Rather than scanning the resource file in sysfs a second time, we > can pull the information on physical addresses of BARs from the > pci resource information already present in the dev structure. > > Signe

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, February 24, 2015 5:09 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified > packet > types > > Hi Helin, > > On 02/20/2015 03:26

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

Hi Pawel, On 02/24/2015 12:12 PM, Wodkowski, PawelX wrote: > > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, February 24, 2015 11:39 AM >> To: Wodkowski, PawelX; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/5] rte_timer: fix invalid

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

On Tue, Feb 24, 2015 at 12:32 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Feb 24, 2015 at 12:23:15PM +0100, David Marchand wrote: > > Hello Bruce, > > > > On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < > > bruce.richardson at intel.com> wrote: > > > > > On Mon, Feb

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Tuesday, February 24, 2015 10:47 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc - > dumpversion' output > > Commit 71f0ab1849b4fc3ca928

[dpdk-dev] [PATCH v4 3/3] eal: remove unnecessary check for primary instance

In pci_uio_map_resource we check that we are in a primary process before calling pci_uio_set_bus_master. However, there is already an earlier check which means that we are always in a primary instance at this point in the code, so the check can be removed. Signed-off-by: Bruce Richardson Acked-by

[dpdk-dev] [PATCH v4 2/3] eal: populate uio_maps from pci mem_resources array

Rather than scanning the resource file in sysfs a second time, we can pull the information on physical addresses of BARs from the pci resource information already present in the dev structure. Signed-off-by: Bruce Richardson Acked-by: David Marchand --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c

[dpdk-dev] [PATCH v4 1/3] eal: mmap uio resources using resourceX files

Instead of distinguishing the BAR mappings via offset within a single file, originally /dev/uioX, switch to mapping each individual bar via the appropriately numbered resourceX file. Signed-off-by: Bruce Richardson Acked-by: David Marchand --- lib/librte_eal/common/include/rte_pci.h| 2 +-

[dpdk-dev] [PATCH v4 0/3] fix and improve uio_pci_generic support

V4 changes: Split second patch into two for more readable history V3 changes: Rebase to take account of commit 90a1633b "eal/linux: allow to map BARs with MSI-X tables" This patch does some cleanup of the uio mapping code to a) fix issue with mmap of PCI bars reported by Tetsuya and con

[dpdk-dev] [PATCH 0/8] Improve build process

On 23/02/2015 18:23, Neil Horman wrote: > On Mon, Feb 23, 2015 at 02:58:30PM +, Gonzalez Monroy, Sergio wrote: >> On 23/02/2015 13:52, Neil Horman wrote: >>> On Mon, Feb 23, 2015 at 10:25:01AM +, Gonzalez Monroy, Sergio wrote: On 22/02/2015 23:37, Neil Horman wrote: > On Fri, Feb 2

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

On 02/24/2015 01:14 PM, Olivier MATZ wrote: > Hi Panu, David, > > On 02/24/2015 11:59 AM, David Marchand wrote: >>> >Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation >>> >on some versions of Debian and Ubuntu where gcc has been modified >>> >to only emit MAJOR.MINOR part of the ver

[dpdk-dev] Not getting statistics for all queues.

Hi guys, I'm trying to get statistics per queue (on rx side), therefore I'm using rte_eth_dev_set_rx_queue_stats_mapping function in order to map a particular queue to a stat index (Note: I have 4 rx queues with the following mapping: queue 0 -> stat_idx 0; queue 1 -> stat_idx 1 , etc). The proble

[dpdk-dev] rte_kni_rx_burst issues

All, I know that an issue was already raised with regards to the efficiency of rte_kni_rx_burst but I think that there is more to it than previously discussed. As previously pointed out rte_kni_rx_burst invokes kni_allocate_mbufs every single time. In turn, it looks like kni_allocate_mbufs all

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

On 02/24/2015 12:44 PM, David Marchand wrote: > On Tue, Feb 24, 2015 at 11:36 AM, Mcnamara, John > mailto:john.mcnamara at intel.com>> wrote: > > > > >> $ gcc -dumpversion > > >>> 4.7 > > >>> > > Hum, how about something like always appending .0.0 to the gcc - > > dumpversion th

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation on some versions of Debian and Ubuntu where gcc has been modified to only emit MAJOR.MINOR part of the version from 'gcc -dumpversion'. Drop the micro-version from gcc version comparisons to work around this, it wasn't being used for

[dpdk-dev] [PATCH] maintainers: claim VFIO and IVSHMEM

> Signed-off-by: Anatoly Burakov Acked-by: Thomas Monjalon Applied, thanks Anatoly.

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 11:59, David Marchand: > Panu, > > ack (and works with my debian gcc). > > > Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation > > on some versions of Debian and Ubuntu where gcc has been modified > > to only emit MAJOR.MINOR part of the version from 'gcc -dumpversion'.

[dpdk-dev] [PATCH 2/5] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > It is desired that all type of *_free() functions mimic behaviour of > libc free() function. This function does nothing if given parameter is > NULL. This patch add this behaviour for rte_kvargs_free(). > > Signed-off-by: Pawel Wodkowski Acked-by:

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

On 02/24/2015 12:15 PM, Pawel Wodkowski wrote: > On 2015-02-24 12:05, Olivier MATZ wrote: >> On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: >>> Free kvlist on function exit to avoid memory leak. >>> >>> Signed-off-by: Pawel Wodkowski >> >> Acked-by: Olivier Matz >> > > Please have in mind that th

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

Hello Bruce, On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Mon, Feb 23, 2015 at 05:02:33PM +, Bruce Richardson wrote: > > This patch does some cleanup of the uio mapping code to > > a) fix issue with mmap of PCI bars reported by Tetsuya and co

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

On 02/24/2015 12:09 PM, David Marchand wrote: > On Tue, Feb 24, 2015 at 10:50 AM, Panu Matilainen > wrote: > > On 02/24/2015 11:25 AM, David Marchand wrote: > > Hello Panu, > > Looks like there is an issue with gcc 4.7 on my debian. > > $

[dpdk-dev] [PATCH v3 2/2] eal: populate uio_maps from pci mem_resources array

Rather than scanning the resource file in sysfs a second time, we can pull the information on physical addresses of BARs from the pci resource information already present in the dev structure. Signed-off-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 163 +++

[dpdk-dev] [PATCH v3 1/2] eal: mmap uio resources using resourceX files

Instead of distinguishing the BAR mappings via offset within a single file, originally /dev/uioX, switch to mapping each individual bar via the appropriately numbered resourceX file. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_pci.h| 2 +- lib/librte_eal/linuxapp/e

[dpdk-dev] [PATCH v3 0/2] fix and improve uio_pci_generic support

V3 changes: Rebase to take account of commit 90a1633b "eal/linux: allow to map BARs with MSI-X tables" This patch does some cleanup of the uio mapping code to a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed by others. b) eliminate redundant code and reduce scans of /

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

On 2015-02-24 12:05, Olivier MATZ wrote: > On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: >> Free kvlist on function exit to avoid memory leak. >> >> Signed-off-by: Pawel Wodkowski > > Acked-by: Olivier Matz > Please have in mind that this patch depend on patch 2/5 -- Pawel

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

Hi Panu, David, On 02/24/2015 11:59 AM, David Marchand wrote: >> >Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation >> >on some versions of Debian and Ubuntu where gcc has been modified >> >to only emit MAJOR.MINOR part of the version from 'gcc -dumpversion'. >> >Drop the micro-ver

[dpdk-dev] [PATCH v3 0/2] help option

> > This is a small reorganization of options. > > The main goal is to provide a nice --help option. > > > > changes in v3: > > - reword arguments in usage > > changes in v2: > > - sort also the options enum > > > > Thomas Monjalon (2): > > eal: sort and align options lists > > eal: add help op

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Free kvlist on function exit to avoid memory leak. > > Signed-off-by: Pawel Wodkowski Acked-by: Olivier Matz

[dpdk-dev] [PATCH 4/5] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

Hi Pawel, On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Fix warning reported by klocwork about size_t to int cast when passing > parameters to parse_set_list(). > > This patch fix code formating errors that give checkpatch.pl errors > after generating patch. > > Signed-off-by: Pawel Wodkowski

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

Hi Daniel, On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote: > Function match_inst is used to take buffor using sizeof() which is size_t > type. > This modification also involved changing '%u' to '%zu' in printf function. > > Signed-off-by: Daniel Mrzyglod > --- > lib/librte_cmdline/cmdline_parse

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

Panu, ack (and works with my debian gcc). -- David Marchand On Tue, Feb 24, 2015 at 11:46 AM, Panu Matilainen wrote: > Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation > on some versions of Debian and Ubuntu where gcc has been modified > to only emit MAJOR.MINOR part of the v

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

On 02/24/2015 11:25 AM, David Marchand wrote: > Hello Panu, > > Looks like there is an issue with gcc 4.7 on my debian. > > $ make config T=x86_64-native-linuxapp-gcc && make -j8 > ../mk/toolchain/gcc/rte.toolchain-compat.mk:46 > : You are using GCC < 4.x. This is

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

On Tue, Feb 24, 2015 at 11:36 AM, Mcnamara, John wrote: > > > >> $ gcc -dumpversion > > >>> 4.7 > > >>> > > Hum, how about something like always appending .0.0 to the gcc - > > dumpversion then cut at 3 characters ? > > Hi, > > Or something like this in Sed or Perl within the $(shell) expansion:

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

Hello Danny, On Mon, Feb 23, 2015 at 5:55 PM, Zhou Danny wrote: [snip] +/** > + * @param intr_handle > + * pointer to the interrupt handle. > + * @param queue_id > + * the queue id > + * @return > + * - On success, return 0 > + * - On failure, returns -1. > + */ > +int rte_intr_wait_rx_

[dpdk-dev] [PATCH] ring: fix minor memory leak of kvlist in dev init

> -Original Message- > From: Mcnamara, John > Sent: Monday, February 23, 2015 1:17 PM > To: dev at dpdk.org > Cc: Mcnamara, John > Subject: [PATCH] ring: fix minor memory leak of kvlist in dev init > > Fix for Klocwork identified issue. Superseded by: http://dpdk.org/ml/archives/dev/

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

Hi Pawel, On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Declaration for function pointer should be > typedef ret_type (*type_name)(args...) > not > typedef ret_type (type_name)(args...) > > although compiler treat both of them the same, the static analysis tool > like klocwork complain about th

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

On Tue, Feb 24, 2015 at 12:23:15PM +0100, David Marchand wrote: > Hello Bruce, > > On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Mon, Feb 23, 2015 at 05:02:33PM +, Bruce Richardson wrote: > > > This patch does some cleanup of the uio map

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

On Tue, Feb 24, 2015 at 11:09 AM, David Marchand wrote: > On Tue, Feb 24, 2015 at 10:50 AM, Panu Matilainen > wrote: > >> $ gcc -dumpversion >>> 4.7 >>> >> >> Meh. This seems to be a Debian specific modification to gcc, discussed >> here and there including but not limited to: >> https://bugs.de

[dpdk-dev] [PATCH 5/5] Fix usage of fgets in various places

On 02/23/2015 06:00 PM, Stephen Hemminger wrote: > On Mon, 23 Feb 2015 15:10:00 +0100 > Pawel Wodkowski wrote: > >> Declaration of fgets() is >> char *fgets(char *str, int size, FILE *stream); >> >> Klocwork complain about passing "sizeof()" as size parameter since >> implicit casting size_t to in

[dpdk-dev] [PATCH] maintainers: claim VFIO and IVSHMEM

Signed-off-by: Anatoly Burakov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7750881..2eb7761 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -117,6 +117,7 @@ F: lib/librte_eal/linuxapp/igb_uio/ F: lib/librte_eal/linuxapp/eal/*uio* Linux V

  1   2   >