Hello Bruce, On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < bruce.richardson at intel.com> wrote:
> On Mon, Feb 23, 2015 at 05:02:33PM +0000, Bruce Richardson wrote: > > This patch does some cleanup of the uio mapping code to > > a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed > > by others. > > b) eliminate redundant code and reduce scans of /sys > > > > > > Bruce Richardson (2): > > eal: mmap uio resources using resourceX files > > eal: populate uio_maps from pci mem_resources array > > > > lib/librte_eal/common/include/rte_pci.h | 2 +- > > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 173 > +++++++++++------------------ > > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > > 4 files changed, 66 insertions(+), 111 deletions(-) > > > > -- > > 2.1.0 > > > Given your previous suggestions on the uio_pic_generic code, I'd appreciate > any feedback you could provide on this patchset. Well, I only have one pending question on the use of resourceX files instead of /dev/uioX. You rely on sysfs mmap code for pci resources. Is this really equivalent to uio mmap operations ? If you can ensure me this won't break igb_uio setups, then these patches are ok for me. Thanks for the cleanup in eal_pci_uio.c. -- David Marchand
