[dpdk-dev] [PATCH] testpmd: HW vlan command

2015-02-13 Thread Ouyang Changchun
This patch enables testpmd user can config port hw_vlan with more fine granularity: hw vlan filter, hw vlan strip, and hw vlan extend. Don't remove the original command(hw-vlan) considering that some user still want to use only one command to switch on/off all 3 options. Signed-off-by: Changchu

[dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return value in 32bit icc

2015-02-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Friday, February 13, 2015 5:55 PM > To: Olivier MATZ > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return > value in 32bit icc > > On Fri, Feb 1

[dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs

2015-02-13 Thread Thomas Monjalon
2015-02-13 17:06, Thomas Monjalon: > 2015-02-13 15:39, John McNamara: > > From: Richardson, Bruce > > > > The callbacks member of the rte_eth_dev structure has been renamed > > to intr_cbs to make it clear that it refers to callbacks from NIC > > interrupts. This then allows us to add other types

[dpdk-dev] [PATCH v2 2/4] ethdev: Add in data rxtx callback support

2015-02-13 Thread Bruce Richardson
On Fri, Feb 13, 2015 at 05:33:12PM +0100, Thomas Monjalon wrote: > 2015-02-13 15:39, John McNamara: > > From: Richardson, Bruce > > > > Add in support for inline processing of packets inside the RX or > > TX call. For an RX callback, what happens is that we get a set of > > packets from the NIC a

[dpdk-dev] [PATCH v2 2/4] ethdev: Add in data rxtx callback support

2015-02-13 Thread Thomas Monjalon
2015-02-13 15:39, John McNamara: > From: Richardson, Bruce > > Add in support for inline processing of packets inside the RX or > TX call. For an RX callback, what happens is that we get a set of > packets from the NIC and then pass them to a callback function, if > configured, to allow additiona

[dpdk-dev] [PATCH] testpmd: use default rx/tx port configuration values

2015-02-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, February 12, 2015 2:57 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] testpmd: use default rx/tx port configuration > values > > Function to get rx/tx port configuration f

[dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs

2015-02-13 Thread Thomas Monjalon
2015-02-13 15:39, John McNamara: > From: Richardson, Bruce > > The callbacks member of the rte_eth_dev structure has been renamed > to intr_cbs to make it clear that it refers to callbacks from NIC > interrupts. This then allows us to add other types of callbacks to > the structure without ambigu

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-13 Thread Thomas Monjalon
It appears you made some copy paste of an old example. Please try to send something up to date. > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. Old > +#ifdef RTE_EXEC_ENV_BAREMETAL > +#define MAIN _main > +#else > +#define MAIN main > +#endif There is no bare metal anymore

[dpdk-dev] [PATCH v2 4/4] abi: Added rxtx callback functions to ABI versioning

2015-02-13 Thread Thomas Monjalon
2015-02-13 15:39, John McNamara: > --- There is no signed-off. And there is no need of a separate patch for that. > lib/librte_ether/rte_ether_version.map |4

[dpdk-dev] [PATCH] doc: Add requirements for x32 ABI

2015-02-13 Thread Daniel Mrzyglod
This patch add requirements about compiler and distribution support. Signed-off-by: Daniel Mrzyglod --- doc/guides/linux_gsg/sys_reqs.rst | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index 8

[dpdk-dev] [PATCH v4 3/5] doc: Fix encoding of (r) character

2015-02-13 Thread Iremonger, Bernard
> -Original Message- > From: Mcnamara, John > Sent: Friday, February 13, 2015 3:59 PM > To: Iremonger, Bernard; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 3/5] doc: Fix encoding of (r) character > > > -Original Message- > > From: Iremonger, Bernard > > Sent: Friday, Febr

[dpdk-dev] [PATCH v5 17/17] fm10k: Add ABI version of librte_pmd_fm10k

2015-02-13 Thread Chen Jing D(Mark)
From: Michael Qiu ABI version must be specified, set to version 1 for DPDK 2.0 Signed-off-by: Michael Qiu Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/Makefile |4 lib/librte_pmd_fm10k/rte_pmd_fm10k_version.map |4 2 files changed, 8 insertions(

[dpdk-dev] [PATCH v5 16/17] maintainers: claim for fm10k review

2015-02-13 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Claim for fm10k polling mode driver review. Signed-off-by: Chen Jing D(Mark) --- MAINTAINERS |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a771fa3..e7a425b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -213

[dpdk-dev] [PATCH v5 15/17] fm10k: add PF and VF interrupt handling function

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add functions to enable PF/VF interrupt. 2. Add function to process error message passed from interrupt. 2. Add 2 interrupt handling functions, one for PF and one for VF. 2. Enable interrupt after completing initialization of NIC. Signed-off-by: Jeff Shaw Signed-off-by: Chen

[dpdk-dev] [PATCH v5 14/17] fm10k: Add SRIOV-VF support

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw fm10k pmd driver will support both PF and VF device with single copy of code. The reason is NIC maps registers with same function in PF and VF to same PCI I/O address. Then, PF/VF drivers use same address to access registers belonging to it, HW will translate the request to correc

[dpdk-dev] [PATCH v5 13/17] fm10k: add function to set vlan

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k_vlan_filter_set to set vlan. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c b/lib/librte_pm

[dpdk-dev] [PATCH v5 12/17] fm10k: Add scatter receive function

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add fm10k_recv_scattered_pkts function to receive jumbo frame and multi-segment packets. 2. Configure correct receive function in rx_init and dev_init. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k.h|3 + lib/librte_

[dpdk-dev] [PATCH v5 11/17] fm10k: add PF RSS support

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Configure RSS in fm10k_dev_rx_init function. 2. Add fm10k_rss_hash_update and fm10k_rss_hash_conf_get to get and inquery RSS configuration. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 156 ++

[dpdk-dev] [PATCH v5 10/17] fm10k: add receive and tranmit function

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add fm10k_recv_pkts and fm10k_xmit_pkts functions. 2. Link app function pointer to actual fm10k recv/xmit functions. 3. Change Makefile to compile new file fm10k_rxtx.c Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/Makefile |

[dpdk-dev] [PATCH v5 09/17] fm10k: add dev start/stop functions

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add function to initialize RX queues. 2. Add function to initialize TX queues. 3. Add fm10k_dev_start, fm10k_dev_stop and fm10k_dev_close functions. 4. Add function to close mailbox service. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm1

[dpdk-dev] [PATCH v5 08/17] fm10k: add RX/TX single queue start/stop function

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add 4 functions fm10k_dev_rx_queue_start, fm10k_dev_rx_queue_stop, fm10k_dev_tx_queue_start, and fm10k_dev_tx_queue_stop. 2. verify Rx packet buffer alignment is valid. Hardware requires specific alignment for Rx packet buffers. At least one of the following two con

[dpdk-dev] [PATCH v5 07/17] fm10k: add tx_queue_setup/release function

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k_tx_queue_setup and fm10k_tx_queue_release functions. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 205 +++ 1 files changed, 205 insertions(+), 0 deletions(-) diff --git a/lib/lib

[dpdk-dev] [PATCH v5 06/17] fm10k: add rx_queue_setup/release function

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k_rx_queue_setup and fm10k_rx_queue_release functions. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 255 +++ 1 files changed, 255 insertions(+), 0 deletions(-) diff --git a/lib/lib

[dpdk-dev] [PATCH v5 05/17] fm10k: add reta update/requery functions

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add fm10k_reta_update and fm10k_reta_query functions. 2. Add fm10k_link_update and fm10k_dev_infos_get functions. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 162 +++ 1 files changed, 1

[dpdk-dev] [PATCH v5 04/17] Change config files to add fm10k into compile

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Change config/common_bsdapp and config/common_linuxapp, add macros to control fm10k pmd driver compile for linux and bsd. 2. Change lib/Makefile to add fm10k driver into compile list. 3. Change mk/rte.app.mk to add fm10k lib into link. Signed-off-by: Jeff Shaw Signed-off-b

[dpdk-dev] [PATCH v5 03/17] fm10k: register fm10k pmd PF driver

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add init function to scan and initialize fm10k PF device. 2. Add implementation to register fm10k pmd PF driver. 3. Add 3 functions fm10k_dev_configure, fm10k_stats_get and fm10k_stats_get. 4. Add fm10k.h to define macros and basic data structure. 5. Add fm10k_logs.h to cont

[dpdk-dev] [PATCH v5 02/17] eal: add fm10k device id

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k device ID list into rte_pci_dev_ids.h. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/lib/librte_eal/common/i

[dpdk-dev] [PATCH v5 01/17] fm10k: add base driver

2015-02-13 Thread Chen Jing D(Mark)
From: Jeff Shaw Base driver is developed and maintained by Intel ND team, includes basic functional service to Intel Ethernet Switch FM1 Series of silicons. Any suggestion on bug fix and improvement within this directory is welcome, but need this team to change and update. Signed-off-by: Che

[dpdk-dev] [PATCH v5 00/17] lib/librte_pmd_fm10k : fm10k pmd driver

2015-02-13 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" The patch set add poll mode driver for the host interface of Intel Ethernet Switch FM1 Series of silicons, which integrate NIC and switch functionalities. The patch set include below features: 1. Basic RX/TX functions for PF/VF. 2. Interrupt handling mechanism for P

[dpdk-dev] [PATCH v2 6/6] bond: add unit tests for link bonding mode 6.

2015-02-13 Thread Michal Jastrzebski
Added 4 unit tests checking link bonding mode 6 behavior. Also modified virtual_pmd so it is possible to provide packets, that should be received with rx_burst and to inspect packets transmitted by tx_burst. In packet_burst_generator.c function creating eth_header is modified, so it accepts ether

[dpdk-dev] [PATCH v2 5/6] bond: modify TLB unit tests

2015-02-13 Thread Michal Jastrzebski
This patch modify mode older name from BONDING_MODE_ADAPTIVE_TRANSMIT_LOAD_BALANCING to BONDING_MODE_TLB that was used in unittests. It also changes Signed-off-by: Daniel Mrzyglod --- app/test/test_link_bonding.c| 27 ++- lib/librte_pmd_bond/rte_eth_bond.

[dpdk-dev] [PATCH v2 4/6] bond: add example application for link bonding mode 6

2015-02-13 Thread Michal Jastrzebski
v2 changes - remove count parameter from send command - fixed quit command to use cmdline_quit(cl) - add echo function - all IPv4 packets will be retransmitted. Bonding driver will use TLB policy - this will show how TX works in mode 6 - remove unused structures rx_conf_default and tx_conf_default

[dpdk-dev] [PATCH v2 3/6] bond: add debug info for mode 6 link bonding

2015-02-13 Thread Michal Jastrzebski
v2 changes - add IPv4 RX/TX information - add mode6_debug(..) function This patch add some debug information when using link bonding mode 6. It prints basic information about ARP packets on RX and TX (MAC, ip, packet number, arp packet type). If CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB == y. If CONFIG_R

[dpdk-dev] [PATCH v2 2/6] bond: add link bonding mode 6 implementation

2015-02-13 Thread Michal Jastrzebski
v2 changes - add VLAN support - fixed sending duplicated ARPupdates - fixed assigning slaves for next clients - fixed TLB mode This mode includes adaptive TLB and receive load balancing (RLB). In RLB the bonding driver intercepts ARP replies send by local system and overwrites its source MAC addre

[dpdk-dev] [PATCH v2 1/6] net: changed arp_hdr struct declaration

2015-02-13 Thread Michal Jastrzebski
Changed MAC address type from uint8_t[6] to struct ether_addr and IP address type from uint8_t[4] to uint32_t. Also removed union from arp_hdr struct. Updated test-pmd to match new arp_hdr version. Signed-off-by: Maciej Gajdzica --- app/test-pmd/icmpecho.c | 27 ++- l

[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

2015-02-13 Thread Michal Jastrzebski
This patchset add support for link bonding mode 6. Additionally it changes an arp_header structure definition. Also a basic example is introduced. Using this example, Bonding will configure each client ARP table, that packets from each client will be received on different slave, mode 6 uses round-r

[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

2015-02-13 Thread Declan Doherty
On 13/02/15 15:16, Michal Jastrzebski wrote: > This patchset add support for link bonding mode 6. > Additionally it changes an arp_header structure definition. > Also a basic example is introduced. Using this example, > Bonding will configure each client ARP table, > that packets from each client w

[dpdk-dev] [PATCH v2 3/3] app/test: fix devargs tests

2015-02-13 Thread David Marchand
Add missing free for devargs->args and fix tests. Signed-off-by: David Marchand --- app/test/test_devargs.c |6 -- app/test/test_pci.c |2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c index 3d9f7bc..08fb781 10

[dpdk-dev] [PATCH v2 2/3] devargs: remove limit on parameters length

2015-02-13 Thread David Marchand
As far as I know, there is no reason why we should have a limit on the length of parameters that can be given for a device. Remove this limit by using dynamic allocations. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_devargs.c | 26 +- lib/librte_

[dpdk-dev] [PATCH v2 1/3] devargs: indent and cleanup

2015-02-13 Thread David Marchand
Prepare for next commit. Fix some indent issues, refactor error code. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_devargs.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib

[dpdk-dev] [PATCH v2 0/3] remove limit on devargs parameters length

2015-02-13 Thread David Marchand
Here is a little patchset that removes the limit on the devargs parameters length. Previously, arguments specified by user would be stored in a static buffer, while there is no particular reason why we should have such a constraint, afaik. Changes since v1: - fix devargs tests (problem reported by

[dpdk-dev] [PATCH v4 3/5] doc: Fix encoding of (r) character

2015-02-13 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Friday, February 13, 2015 2:30 PM > To: Mcnamara, John; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 3/5] doc: Fix encoding of (r) character > > The following error occurs when applying this patch: > > :Applying: doc: Fix enc

[dpdk-dev] [PATCH v2 0/4] DPDK ethdev callback support

2015-02-13 Thread Declan Doherty
On 13/02/15 15:39, John McNamara wrote: > This patchset is for a small addition to the ethdev library, to > add in support for callbacks at the RX and TX stages. This allows > packet processing to be done on packets before they get returned > to applications using rte_eth_rx_burst call. > > See the

[dpdk-dev] [PATCH v2 4/4] abi: Added rxtx callback functions to ABI versioning

2015-02-13 Thread John McNamara
--- lib/librte_ether/rte_ether_version.map |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 7316530..3227cda 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-13 Thread John McNamara
From: Richardson, Bruce Example showing how callbacks can be used to insert a timestamp into each packet on RX. On TX the timestamp is used to calculate the packet latency through the app, in cycles. Signed-off-by: Bruce Richardson --- examples/rxtx_callbacks/Makefile | 57 + examp

[dpdk-dev] [PATCH v2 2/4] ethdev: Add in data rxtx callback support

2015-02-13 Thread John McNamara
From: Richardson, Bruce Add in support for inline processing of packets inside the RX or TX call. For an RX callback, what happens is that we get a set of packets from the NIC and then pass them to a callback function, if configured, to allow additional processing to be done on them, e.g. filling

[dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs

2015-02-13 Thread John McNamara
From: Richardson, Bruce The callbacks member of the rte_eth_dev structure has been renamed to intr_cbs to make it clear that it refers to callbacks from NIC interrupts. This then allows us to add other types of callbacks to the structure without ambiguity. Signed-off-by: Bruce Richardson --- a

[dpdk-dev] [PATCH v2 0/4] DPDK ethdev callback support

2015-02-13 Thread John McNamara
This patchset is for a small addition to the ethdev library, to add in support for callbacks at the RX and TX stages. This allows packet processing to be done on packets before they get returned to applications using rte_eth_rx_burst call. See the RFC cover letter for the use cases: http://dp

[dpdk-dev] [PATCH v2] Adding RTE_KNI_PREEMPT_DEFAULT configuration option

2015-02-13 Thread Marc Sune
This patch introduces CONFIG_RTE_KNI_PREEMPT_DEFAULT flag. When set to 'no', KNI kernel thread(s) do not call schedule_timeout_interruptible(), which improves overall KNI performance at the expense of CPU cycles (polling). Default values is 'yes', maintaining the same behaviour as of now. v2: CON

[dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return value in 32bit icc

2015-02-13 Thread Neil Horman
On Fri, Feb 13, 2015 at 06:11:02PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > > Sent: Friday, February 13, 2015 5:55 PM > > To: Olivier MATZ > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PAT

[dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return value in 32bit icc

2015-02-13 Thread Olivier MATZ
Hi Neil, On 02/13/2015 02:49 PM, Neil Horman wrote: > On Fri, Feb 13, 2015 at 09:38:06AM +0800, Cunming Liang wrote: >> The problem is that strnlen() here may return invalid value with 32bit icc. >> (actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)). >> It starts to manifest hwe

[dpdk-dev] [PATCH 0/3] DPDK ethdev callback support

2015-02-13 Thread Declan Doherty
On 12/02/15 19:57, John McNamara wrote: > This patchset is for a small addition to the ethdev library, to > add in support for callbacks at the RX and TX stages. This allows > packet processing to be done on packets before they get returned > to applications using rte_eth_rx_burst call. > > See the

[dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

2015-02-13 Thread Thomas Monjalon
> > max_vfs will only be created by igb_uio driver, for other > > drivers like vfio or pci_uio_generic, max_vfs will miss. > > > > But sriov_numvfs is not driver related, just get the vf numbers > > from that field. > > > > Signed-off-by: Michael Qiu > > I can see a different solution : maybe fak

[dpdk-dev] [PATCH v4 3/5] doc: Fix encoding of (r) character

2015-02-13 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John McNamara > Sent: Tuesday, February 3, 2015 2:11 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4 3/5] doc: Fix encoding of (r) character > > Change encoding of (r) from Latin-1 to UTF8 to match th

[dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config

2015-02-13 Thread Thomas Monjalon
2015-02-13 12:33, Panu Matilainen: > On 02/13/2015 11:28 AM, Thomas Monjalon wrote: > > 2015-02-13 09:27, Panu Matilainen: > >> On 02/12/2015 05:44 PM, Thomas Monjalon wrote: > >>> A library is considered as a plugin if there is no public API and it > >>> registers itself. That's the case of normal

[dpdk-dev] [PATCH v6 12/19] malloc: fix the issue of SOCKET_ID_ANY

2015-02-13 Thread Neil Horman
On Fri, Feb 13, 2015 at 09:38:14AM +0800, Cunming Liang wrote: > Add check for rte_socket_id(), avoid get unexpected return like (-1). > > Signed-off-by: Cunming Liang > --- > lib/librte_malloc/malloc_heap.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/lib/libr

[dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return value in 32bit icc

2015-02-13 Thread Neil Horman
On Fri, Feb 13, 2015 at 03:05:44PM +0100, Olivier MATZ wrote: > Hi Neil, > > On 02/13/2015 02:49 PM, Neil Horman wrote: > > On Fri, Feb 13, 2015 at 09:38:06AM +0800, Cunming Liang wrote: > >> The problem is that strnlen() here may return invalid value with 32bit icc. > >> (actually it returns it?s

[dpdk-dev] [PATCH v5 12/17] fm10k: Add scatter receive function

2015-02-13 Thread David Marchand
Hello, On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) wrote: [snip] + if (unlikely(ret != 0)) { > + PMD_RX_LOG(ERR, "Failed to alloc mbuf"); > Idem mono segment. rx_mbuf_alloc_failed++ ? -- David Marchand

[dpdk-dev] [PATCH v5 10/17] fm10k: add receive and tranmit function

2015-02-13 Thread David Marchand
On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) wrote: [snip] + if ((q->next_dd > q->next_trigger) || (alloc == 1)) { > + ret = rte_mempool_get_bulk(q->mp, > + (void > **)&q->sw_ring[q->next_alloc], > +

[dpdk-dev] [PATCH v5 10/17] fm10k: add receive and tranmit function

2015-02-13 Thread David Marchand
Hello, On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) wrote: [snip] + > + /* set checksum flags on first descriptor of packet. SCTP checksum > +* offload is not supported, but we do not explicitely check for > this > +* case in favor of greatly simplified processing. *

[dpdk-dev] [PATCH v5 15/17] fm10k: add PF and VF interrupt handling function

2015-02-13 Thread David Marchand
Hello, On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) wrote: [snip] + > + /* Only INT 0 availiable, other 15 are reserved. */ > available. -- David Marchand

[dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config

2015-02-13 Thread Panu Matilainen
On 02/13/2015 11:28 AM, Thomas Monjalon wrote: > 2015-02-13 09:27, Panu Matilainen: >> On 02/12/2015 05:44 PM, Thomas Monjalon wrote: >>> 2015-02-11 12:31, Gonzalez Monroy, Sergio: From: Panu Matilainen [mailto:pmatilai at redhat.com] > On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote

[dpdk-dev] [PATCH v5 08/17] fm10k: add RX/TX single queue start/stop function

2015-02-13 Thread David Marchand
Hello, On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) wrote: [snip] +/* > + * Verify Rx packet buffer alignment is valid. > + * > + * Hardware requires specific alignment for Rx packet buffers. At > + * least one of the following two conditions must be satisfied. > + * 1. Address is 512B a

[dpdk-dev] [PATCH 0/8] Improve build process

2015-02-13 Thread Panu Matilainen
On 02/12/2015 05:52 PM, Neil Horman wrote: > On Thu, Feb 12, 2015 at 04:07:50PM +0200, Panu Matilainen wrote: >> On 02/12/2015 02:23 PM, Neil Horman wrote: [...snip...] >>> >> So I just realized that I was not having into account a possible >> scenario, where >> we have an app built

[dpdk-dev] [PATCH v5 06/17] fm10k: add rx_queue_setup/release function

2015-02-13 Thread David Marchand
Hello, On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) wrote: [snip] +static int > +fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id, > + uint16_t nb_desc, unsigned int socket_id, > + const struct rte_eth_rxconf *conf, struct rte_mempool *mp) > +{ > + struct

[dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config

2015-02-13 Thread Thomas Monjalon
2015-02-13 12:33, Panu Matilainen: > On 02/13/2015 11:28 AM, Thomas Monjalon wrote: > > 2015-02-13 09:27, Panu Matilainen: > >> On 02/12/2015 05:44 PM, Thomas Monjalon wrote: > >>> 2015-02-11 12:31, Gonzalez Monroy, Sergio: > From: Panu Matilainen [mailto:pmatilai at redhat.com] > > On 02/

[dpdk-dev] [PATCH v3 0/2] help option

2015-02-13 Thread David Marchand
On Thu, Feb 12, 2015 at 5:47 PM, Thomas Monjalon wrote: > This is a small reorganization of options. > The main goal is to provide a nice --help option. > > changes in v3: > - reword arguments in usage > changes in v2: > - sort also the options enum > > Thomas Monjalon (2): > eal: sort and alig

[dpdk-dev] [PATCH v4 4/4] pmd_bond: Set routines required by test app global

2015-02-13 Thread Tomasz Kulasek
rte_eth_bond_8023ad_setup and rte_eth_bond_8023ad_conf_get entries need to be exported to be used by test application for shared libraries compilation. Signed-off-by: Tomasz Kulasek --- lib/librte_pmd_bond/rte_eth_bond_version.map |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libr

[dpdk-dev] [PATCH v4 3/4] mk: Link test app against librte_pmd_ring when needed

2015-02-13 Thread Tomasz Kulasek
This patch links test application against librte_pmd_ring.so for shared libraries. It's required as long as librte_pmd_ring provides some aditional routines used for testing purposes and must be "hard-linked". Signed-off-by: Tomasz Kulasek --- app/test/Makefile | 15 +++ 1 file cha

[dpdk-dev] [PATCH v4 2/4] test: Unit tests for mode 4

2015-02-13 Thread Tomasz Kulasek
This patch adds unit tests for mode 4. It is split into separate file to avoid problems with other modes that does not need to look into packets payload. This patch includes also a modification of maximum number of ports used in their tests for bonding modes 0-3 from 16 to 6. v4 changes - Adapting

[dpdk-dev] [PATCH v4 1/4] test: test.h rework

2015-02-13 Thread Tomasz Kulasek
Signed-off-by: Pawel Wodkowski Signed-off-by: Tomasz Kulasek --- app/test/test.h | 112 --- 1 file changed, 66 insertions(+), 46 deletions(-) diff --git a/app/test/test.h b/app/test/test.h index 896f7db..5450986 100644 --- a/app/test/test.h +

[dpdk-dev] [PATCH v4 0/4] Unit tests for mode 4

2015-02-13 Thread Tomasz Kulasek
This patch series depends of "PMD ring" patches and should be applied after them to run successfully. v4 changes - Adapting to changes in the initialize_eth_header API - Fix linking problem against librte_pmd_bond.so for shared libraries - Patchset cleanup for smoother application v3 changes - Fi

[dpdk-dev] [PATCH] bond: fix for kvlist memory leak on rte_kvargs_process failure identified by klockwork scan

2015-02-13 Thread Olivier MATZ
Hi, On 02/13/2015 11:27 AM, Declan Doherty wrote: > Signed-off-by: Declan Doherty > --- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 49 > ++ > 1 file changed, 26 insertions(+), 23 deletions(-) > Acked-by: Olivier Matz

[dpdk-dev] [PATCH 0/8] Improve build process

2015-02-13 Thread Gonzalez Monroy, Sergio
On 13/02/2015 10:14, Panu Matilainen wrote: > On 02/12/2015 05:52 PM, Neil Horman wrote: >> On Thu, Feb 12, 2015 at 04:07:50PM +0200, Panu Matilainen wrote: >>> On 02/12/2015 02:23 PM, Neil Horman wrote: > [...snip...] >>> So I just realized that I was not having into account a possibl

[dpdk-dev] [PATCH v4 0/4] Unit tests for mode 4

2015-02-13 Thread Declan Doherty
On 13/02/15 10:38, Tomasz Kulasek wrote: > This patch series depends of "PMD ring" patches and should be applied after > them > to run successfully. > > v4 changes > - Adapting to changes in the initialize_eth_header API > - Fix linking problem against librte_pmd_bond.so for shared libraries > - P

[dpdk-dev] [PATCH v6 00/19] support multi-pthread per core

2015-02-13 Thread Olivier MATZ
Hi, On 02/13/2015 02:38 AM, Cunming Liang wrote: > v6 changes: > rename RTE_RING_PAUSE_REP(_COUNT) and set default to 0 > rollback to use RTE_MAX_LCORE when checking valid lcore_id for EAL thread > > v5 changes: > reorder some patch and split into addtional two patches > rte_thread_get_af

[dpdk-dev] Packet drops during non-exhaustive flood with OVS and 1.8.0

2015-02-13 Thread Traynor, Kevin
> -Original Message- > From: Andrey Korolyov [mailto:andrey at xdel.ru] > Sent: Thursday, February 12, 2015 3:16 PM > To: Traynor, Kevin > Cc: dev at dpdk.org; discuss at openvswitch.org > Subject: Re: Packet drops during non-exhaustive flood with OVS and 1.8.0 > > On Thu, Feb 12, 2015 at

[dpdk-dev] [PATCH v5 19/19] timer: add support to non-EAL thread

2015-02-13 Thread Olivier MATZ
Hi, On 02/13/2015 01:55 AM, Liang, Cunming wrote: >> About ' lcore_id != LCORE_ID_ANY' vs ' lcore_id < RTE_MAX_LCORE'. >> I think both ways are valid right now. >> Though using ' lcore_id != LCORE_ID_ANY' means, that if user will setup >> PER_LCORE(_lcore_id) for dynamically created thread to some

[dpdk-dev] [PATCH v2 4/4] app/testpmd:test NVGRE Tx checksum offload

2015-02-13 Thread Olivier MATZ
Hi Jijiang, On 02/12/2015 01:45 AM, Jijiang Liu wrote: > Enhance csum fwd engine based on current TX checksum framework in order to > test TX Checksum offload for NVGRE packet. > > It includes: > - IPv4 and IPv6 packet > - outer L3, inner L3 and L4 checksum offload for Tx side. > > [...] > @

[dpdk-dev] [PATCH] bond: fix for kvlist memory leak on rte_kvargs_process failure identified by klockwork scan

2015-02-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty > Sent: Friday, February 13, 2015 10:27 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] bond: fix for kvlist memory leak on > rte_kvargs_process failure identified by klockwork scan > > S

[dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config

2015-02-13 Thread Thomas Monjalon
2015-02-13 09:27, Panu Matilainen: > On 02/12/2015 05:44 PM, Thomas Monjalon wrote: > > 2015-02-11 12:31, Gonzalez Monroy, Sergio: > >> From: Panu Matilainen [mailto:pmatilai at redhat.com] > >>> On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote: > I think that vhost is being linked in the

[dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h

2015-02-13 Thread Mcnamara, John
> -Original Message- > From: Richardson, Bruce > Sent: Friday, February 13, 2015 10:18 AM > To: Mcnamara, John > Cc: Stefan Puiu; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h > > > > > > > In C++11 concatenated string literals need to have a s

[dpdk-dev] [PATCH] bond: fix for kvlist memory leak on rte_kvargs_process failure identified by klockwork scan

2015-02-13 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 49 ++ 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index 09b0f30..a75b163 100644 --- a/li

[dpdk-dev] [PATCH v3 20/20] i40e: add debug logs for tx context descriptors

2015-02-13 Thread Olivier Matz
This could be useful to have this values for debug purposes. Suggested-by: Konstantin Ananyev Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rx

[dpdk-dev] [PATCH v3 19/20] i40e: fix offloading of outer checksum for ip in ip tunnels

2015-02-13 Thread Olivier Matz
When offloading the checksums of ipip tunnels, m->l2_len is set to 0 as there is no tunnel or inner l2 header. Since this is a valid value remove the test. By the way, also remove the same test with l3_len because at this point, it is expected that the software provides proper values in the mbuf.

[dpdk-dev] [PATCH v3 18/20] testpmd: fix TSO when using outer checksum offloads

2015-02-13 Thread Olivier Matz
The l4_len has also to be copied in mbuf in case we are offloading outer IP checksum. Currently, TSO + outer checksum is not supported by any driver but it will soon be supported by i40e. Pointed-out-by: Jijiang Liu Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 1 + 1 file changed,

[dpdk-dev] [PATCH v3 17/20] testpmd: add a warning if outer ip cksum requested but not supported

2015-02-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index fc08183..9de3e7e 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2930,7 +2930,11 @@ csum_show(

[dpdk-dev] [PATCH v3 16/20] i40e: advertise outer IPv4 checksum capability

2015-02-13 Thread Olivier Matz
From: Jijiang Liu Advertise the DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM flag in the PMD features. It means that the i40e PMD supports the offload of outer IP checksum when transmitting tunneling packet. Signed-off-by: Jijiang Liu Acked-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_ethdev.c | 3 ++- 1

[dpdk-dev] [PATCH v3 15/20] ethdev: add outer IP offload capability flag

2015-02-13 Thread Olivier Matz
From: Jijiang Liu If the flag is advertised by a PMD, the NIC supports the outer IP checksum TX offload of tunneling packets, therefore an application can set the PKT_TX_OUTER_IP_CKSUM flag in mbufs when transmitting on this port. Signed-off-by: Jijiang Liu Acked-by: Olivier Matz --- lib/libr

[dpdk-dev] [PATCH v3 14/20] testpmd: support ipip tunnel in csum forward engine

2015-02-13 Thread Olivier Matz
Add support for IP over IP tunnels. Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/csumonly.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b19869c..fc08

[dpdk-dev] [PATCH v3 13/20] testpmd: support gre tunnels in csum fwd engine

2015-02-13 Thread Olivier Matz
Add support for Ethernet over GRE and IP over GRE tunnels. Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 6 ++-- app/test-pmd/csumonly.c | 91 + 2 files changed, 87 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/cmdline.c b/

[dpdk-dev] [PATCH v3 12/20] testpmd: introduce parse_vxlan in csum fwd engine

2015-02-13 Thread Olivier Matz
Move code parsing vxlan into a function. It will ease the support of GRE tunnels and IPIP tunnels in next commits. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 68 +++-- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/app/t

[dpdk-dev] [PATCH v3 11/20] testpmd: use a structure to store offload info in csum fwd engine

2015-02-13 Thread Olivier Matz
To simplify the API of parse_* functions, store all the offload information for the current packet in a structure. No functional change. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 222 +--- 1 file changed, 115 insertions(+), 107 deletio

[dpdk-dev] [PATCH v3 10/20] testpmd: introduce parse_ipv* in csum fwd engine

2015-02-13 Thread Olivier Matz
These functions may be used to parse encapsulated layers when we will support IP over GRE tunnels. No functional change. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 51 + 1 file changed, 39 insertions(+), 12 deletions(-) diff --git

[dpdk-dev] [PATCH v3 09/20] testpmd: rename vxlan in outer_ip in csum commands

2015-02-13 Thread Olivier Matz
The tx_checksum command concerns outer IP checksum, not VxLAN checksum. Actually there is no checkum in VxLAN header, there is one checksum in outer IP header, and one checksum in outer UDP header. This option only controls the outer IP checksum. Signed-off-by: Olivier Matz --- app/test-pmd/cmdl

[dpdk-dev] [PATCH v3 08/20] testpmd: add csum parse_tunnel command

2015-02-13 Thread Olivier Matz
Add a new command related to csum forward engine: csum parse-tunnel (on|off) (tx_port_id) If enabled, the tunnel packets received by the csum forward engine are parsed and seen as "outer-headers/inner-headers/data". If disabled, the parsing of the csum forward engine stops at the first l4 laye

[dpdk-dev] [PATCH v3 07/20] testpmd: move csum_show in a function

2015-02-13 Thread Olivier Matz
No functional changes in this commit, we just move the code that displays the csum forward engine configuration in a function. This makes the next commit easier to read as it will also use this function. Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 82 +++

[dpdk-dev] [PATCH v3 06/20] testpmd: replace tx_checksum command by csum

2015-02-13 Thread Olivier Matz
Replace the "tx_checksum" command by "csum". It has several advantages: - it's more coherent with the forward engine name - it's shorter - the next commit will introduce a command that is related to the csum forward engine, but about rx side. Signed-off-by: Olivier Matz --- app/test-pmd/cmdli

[dpdk-dev] [PATCH v3 05/20] mbuf: remove PKT_TX_UDP_TUNNEL_PKT flag

2015-02-13 Thread Olivier Matz
Since previous commit, this flag is not used by any PMD, remove it from mbuf API and from csumonly (testpmd). In csumonly, the PKT_TX_OUTER_IP_CKSUM flag is already set for vxlan checksum, providing enough information to the underlying driver. Signed-off-by: Olivier Matz --- app/test-pmd/csumonl

[dpdk-dev] [PATCH v3 04/20] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag

2015-02-13 Thread Olivier Matz
The definition of the flag in rte_mbuf.h was: TX packet is an UDP tunneled packet. It must be specified when using outer checksum offload (PKT_TX_OUTER_IP_CKSUM) This flag was used to tell the NIC that the offload type is UDP (I40E_TXD_CTX_UDP_TUNNELING flag). In the datasheet, it says it's re

  1   2   >