2015-02-13 17:06, Thomas Monjalon: > 2015-02-13 15:39, John McNamara: > > From: Richardson, Bruce <bruce.richardson at intel.com> > > > > The callbacks member of the rte_eth_dev structure has been renamed > > to intr_cbs to make it clear that it refers to callbacks from NIC > > interrupts. This then allows us to add other types of callbacks to > > the structure without ambiguity. > > Yes, good. > Actually this callback is used only for link status interrupt, right? > In the patchset for interrupt mode, new callbacks are used, right? > Should we name this callback more precisely?
More naming considerations: - The link status interrupt callback could be named link_intr_cb. - The Rx callback could be named post_rx_burst_cb - The Tx callback could be named pre_tx_burst_cb
