Hi,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur
> Sent: Thursday, January 15, 2015 8:34 PM
> To: Thomas Monjalon
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets.
>
> On Wed, Jan 14, 2015 at 8:27 AM
2015-01-15 13:51, Neil Horman:
> On Thu, Jan 15, 2015 at 06:25:33PM +0100, Thomas Monjalon wrote:
> > 2015-01-15 08:06, Neil Horman:
> > > Ok, I think what you're saying here is you're too busy to handle all the
> > > patches
> > > comming in at the moment. As such I'd like to propose a sub-tree
For ixgbe, when queue start failure, for example, mbuf allocate
failure, the device will still start success, which could be
an issue.
Add return status check of queue start to avoid this issue.
Signed-off-by: Michael Qiu
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 6 +-
lib/librte_pmd_ixgbe
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> Sent: Thursday, January 15, 2015 6:51 PM
> To: Thomas Monjalon
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] Why nothing since 1.8.0?
>
> On Thu, Jan 15, 2015 at 06:25:33PM +0100, Thomas Monjalon
> On Thursday, January 15, 2015 at 8:34 PM, Ravi Kerur
> wrote:
>
> On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon
>
> wrote:
>
> > 2015-01-09 04:41, Ravi Kerur:
> > > Thomas,
> > >
> > > Please let me know how I can move forward on this. If i confine changes
> > in
> > > e1000/ directory t
>>> update the RSS RETA table so that traffic doesn't get sent
>> to that queue via RSS. Is that what you are asking?
Thanks Bruce, that's exactly it. Basically each filter will forward
traffic to a unique RSS queue which can allow me to calculate filter match
statistics for that queue(or filter)
2015-01-15 08:06, Neil Horman:
> On Thu, Jan 15, 2015 at 10:51:38AM +0100, Thomas Monjalon wrote:
> > 2015-01-15 04:27, Ouyang, Changchun:
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Helin
> > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> > > > >
On Thu, Jan 15, 2015 at 09:55:00PM +, O'driscoll, Tim wrote:
> As you said, there's a balance to be struck, and too many subtrees may
> become unmanageable. With respect to your concern about developers having to
> potentially develop patches against multiple subtrees, this has never been
>
Thanks Tim, Konstantin and Helin. I will send out revised patch.
Thanks,
Ravi
On Thu, Jan 15, 2015 at 5:14 PM, Zhang, Helin wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur
> > Sent: Monday, January 5, 2015 7:28 AM
> > To: dev at d
2015-01-15 13:42, Burakov, Anatoly:
> Yep, apologies, it's my fault as it was my suggestion.
> I knew there was a linuxapp-only EAL header, for some reason I thought it's
> eal_private.
> Any suggestions on where to put this function? I don't think BSD needs this
> function.
No, it's OK. I thin
On Wed, Jan 14, 2015 at 04:59:17PM -0500, Kamraan Nasim wrote:
> Many thanks Helin and Bruce :)
>
> Now if 1Gb NICs don't support fdir filters then im wondering how would we
> count the number of packets matching a filter.
>
> Regular 5tuple filters don't have any stats similar to "fdirmatch"(in
> > There were two static functions called "parse_item_list" in testpmd app.
> > Since one was a superset of the functionality of the other, we can
> > collapse the two calls down into a single one, shared between the two
> > C files.
> >
> > Signed-off-by: Bruce Richardson
>
> Acked-by: Pablo d
> This patch contains a fix for link bonding handling of vlan tagged packets in
> mode 3 and 5.
> Currently xmit_slave_hash function misinterprets the PKT_RX_VLAN_PKT flag to
> mean that
> there is a vlan tag within the packet when in actually means that there is a
> valid entry
> in the vlan_tc
> > When vfio module is not loaded when kernel support vfio feature, the
> > routine still try to open the container to get file description.
> >
> > This action is not safe, and of cause got error messages:
> >
> > EAL: Detected 40 lcore(s)
> > EAL: unsupported IOMMU type!
> > EAL: VFIO suppor
Adding a document describing rudimentary ABI policy and adding notice space for
any deprecation announcements
Signed-off-by: Neil Horman
CC: Thomas Monjalon
CC: "Richardson, Bruce"
---
doc/abi.txt | 17 +
1 file changed, 17 insertions(+)
create mode 100644 doc/abi.txt
diff --
To differentiate libraries that break ABI, we add a library version number
suffix to the library, which must be incremented when a given libraries ABI is
broken. This patch enforces that addition, sets the initial abi soname
extension to 1 for each library and creates a symlink to the base SONAME
Add linker version script files to each DPDK library to put a stake in the
ground from which we can start cleaning up API's
Signed-off-by: Neil Horman
CC: Thomas Monjalon
CC: "Richardson, Bruce"
---
Change Notes:
v2)
* Updated export map to not require full path
---
lib/librte_acl/Ma
Add initial pass header files to support symbol versioning.
Signed-off-by: Neil Horman
CC: Thomas Monjalon
CC: "Richardson, Bruce"
CC: "Gonzalez Monroy, Sergio"
---
Change Notes:
V2)
Moved ifeq to _INSTALL target
V3)
Undo V2 changes and make librte_compat use the rte.install.
> The read/seek/close stub functions are unnecessary on the
> log stream. Per glibc fopencookie man page:
>
>cookie_read_function_t *read
> If *read is a null pointer, then reads from the custom stream
> always return end of file.
>
>cookie_seek_fun
> When scanning the hugetlbfs maps search only for the DPDK maps.
> This will allow the application create its own hugetlbfs mappings
> and use the DPDK facilities on the same hugetlbfs mount point.
>
> Signed-off-by: Vlad Zolotarov
Acked-by: Thomas Monjalon
It is a RFC patch but there is no c
2015-01-09 16:05, Michal Jastrzebski:
> Signed-off-by: Pawel Wodkowski
Good catch!
Was introduced in commit 4bdefaade6d1 (VMDQ enhancements).
Note that quite often, when a patch contains too much things,
we miss this kind of bugs. That's a reason to well split patches.
Acked-by: Thomas Monjalon
> > rte_is_power_of_2 returns true for 0 and 0 is not power_of_2. Fix
> > by checking for n.
> >
> > Signed-off-by: Ravi Kerur
> Acked-by: Neil Horman
Applied
Thanks
--
Thomas
2015-01-02 14:58, Neil Horman:
> When building static archives with CONFIG_COMBINED_LIBS, we still need to
> specify --whole-archive to pull in all the proper constructors.
>
> Signed-off-by: Neil Horman
> Reported-by: Lyn M
> Tested-by: Lyn M
> CC: Lyn M
> CC: Thomas Monjalon
Acked-by: Thom
On Thu, Jan 15, 2015 at 06:25:33PM +0100, Thomas Monjalon wrote:
> 2015-01-15 08:06, Neil Horman:
> > On Thu, Jan 15, 2015 at 10:51:38AM +0100, Thomas Monjalon wrote:
> > > 2015-01-15 04:27, Ouyang, Changchun:
> > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Helin
> > > > > Fr
Yep, apologies, it's my fault as it was my suggestion. I knew there was a
linuxapp-only EAL header, for some reason I thought it's eal_private. Any
suggestions on where to put this function? I don't think BSD needs this
function.
Thanks,
Anatoly
> -Original Message-
> From: Thomas Mon
Hi lads,
> -Original Message-
> From: Liu, Jijiang
> Sent: Wednesday, January 14, 2015 3:01 AM
> To: Olivier MATZ
> Cc: dev at dpdk.org; Ananyev, Konstantin
> Subject: RE: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum
> forwarding engine
>
> Hi Olivier,
>
> > -Origi
To keep the consistent logic with normal Rx path, the mergeable
Rx path also needs software vlan strip/decap if it is enabled.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
b/li
Support turn on/off RX VLAN strip on host, this let guest get the chance of
using its software VALN strip functionality.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b
Check if it has already been vlan-tagged packet, if true, avoid inserting a
duplicated vlan tag into it.
This is a possible case when guest has the capability of inserting vlan tag.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 18 ++
1 file changed, 14 insertions(
Need swap the data from cpu to BE(big endian) for vlan-type.
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ether.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ether.h b/lib/librte_ether/rte_ether.h
index 3b6ab4b..90fb3c9 100644
--- a/li
It should use vring descriptor index instead of used_ring index to index
vq_descx.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
b/lib/librte_pmd_virtio/virtio_rxtx
Make virtio not require UIO for some security reasons, this is to match 6Wind's
virtio-net-pmd.
Signed-off-by: Changchun Ouyang
---
config/common_linuxapp | 2 +
lib/librte_eal/common/include/rte_pci.h | 4 ++
lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +-
lib/librte_pmd_vi
This makes virtio driver work like ixgbe. Transmit buffers are
held until a transmit threshold is reached. The previous behavior
was to hold mbuf's until the ring entry was reused which caused
more memory usage than needed.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
li
Need to have do special things to set default mac address.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 5 +
lib/librte_pmd_virtio/virtio_ethdev.c | 24
2 files changed, 29 insertions(+)
diff --git a/
Virtio support multiple MAC addresses.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++-
lib/librte_pmd_virtio/virtio_ethdev.h | 3 +-
lib/librte_pmd_virtio/virtqueue.h | 34 -
3
Virtio supports vlan filtering.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
b/lib/librte_pmd
If allocation fails, don't want to leave virtio device stuck
in middle of initialization sequence.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/li
Better to check at compile time than fail at runtime.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
b/lib/librte_pmd_virti
Make vtpci_get_status a local function as it is used in one file.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_pci.c | 4 +++-
lib/librte_pmd_virtio/virtio_pci.h | 2 --
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librt
Change order of initialiazation to match Linux kernel.
Don't blow away control queue by doing reset when stopped.
Calling dev_stop then dev_start would not work.
Dev_stop was calling virtio reset and that would clear all queues
and clear all feature negotiation.
Resolved by only doing reset on dev
Since vq_alignment is constant (always 4K), it does not
need to be part of the vring struct.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 1 -
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
lib/librte_pmd_virtio/virtqueue.h | 3
Cleanup virtio code by eliminating unnecessary nesting of
virtio hardware structure inside adapter structure.
Also allows removing unneeded macro, making code clearer.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 43 ---
Implement VLAN stripping in software. This allows application
to be device independent.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 3 +++
lib/librte_pmd_virtio/virtio_ethdev.c | 2 ++
lib/librte_pmd_virtio/virtio_pci.h| 1
It is helpful to allow device drivers that don't support hardware
VLAN stripping to emulate this in software. This allows application
to be device independent.
Avoid discarding shared mbufs. Make a copy in rte_vlan_insert() of any
packet to be tagged that has a reference count > 1.
Signed-off-by:
Virtio has link state interrupt which can be used.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 78 +++
lib/librte_pmd_virtio/virtio_pci.c| 22 ++
lib/librte_pmd_virtio/virtio_pci.h|
Starting driver with link down should be ok, it is with every
other driver. So just allow it.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/librte_pmd_virti
The DPDK driver only has to deal with the case of running on PCI
and with SMP. In this case, the code can use the weaker barriers
instead of using hard (fence) barriers. This will help performance.
The rationale is explained in Linux kernel virtio_ring.h.
To make it clearer that this is a virtio t
For clarity make the setup of PCI resources for Linux into a function rather
than block of code #ifdef'd in middle of dev_init.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 76 ---
1 file changed, 43
This is the patch set for single virtio implementation.
Why we need single virtio?
As we know currently there are at least 3 virtio PMD driver implementations:
A) lib/librte_pmd_virtio(refer as virtio A);
B) virtio_net_pmd by 6wind(refer as virtio B);
C) virtio by Broc
On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon
wrote:
> 2015-01-09 04:41, Ravi Kerur:
> > Thomas,
> >
> > Please let me know how I can move forward on this. If i confine changes
> in
> > e1000/ directory to e1000_osdep.h file only and the rest in PMD will that
> > work? The reason I ask is beca
Thanks folks for the information.
On Mon, Jan 12, 2015 at 5:51 AM, Neil Horman wrote:
> On Mon, Jan 12, 2015 at 11:21:32AM +, Bruce Richardson wrote:
> > On Fri, Jan 09, 2015 at 09:14:16AM -0800, Ravi Kerur wrote:
> > > Hi,
> > >
> > > Has anyone successfully cross compiled bsdapp on Ubuntu
Someone to review these patches?
2014-12-16 21:13, Stephen Hemminger:
> This set of patches updates the vmxnet3 in the DPDK to match
> the features in the driver I wrote. The most important critical
> feature is support for multi-segment jumbo frames.
>
> Stephen Hemminger (7):
> vmxnet3: add s
hi,
i have two* '82574L Gigabit Network Connection'* NIC cards .
Can i run dpdk application with this interfaces .
i have binded to igb_uio . My l2forward application is successfully getting
initialized but could not receive/transmit traffic .
How can i run dpdk l2fwd application with this NIC car
2014-12-12 09:14, Michal Jastrzebski:
[...]
> Additionally some typos fix is included.
>
> Signed-off-by: Pawel Wodkowski
> ---
> app/test/Makefile |1 +
> app/test/test.h| 111 +--
> app/test/test_link_bonding.c |2 +-
> app/test/test_link_bon
2014-12-12 09:14, Michal Jastrzebski:
> * add MAC management per device
> * fix initialization procedure
> * add link up/down functions
>
> Signed-off-by: Pawel Wodkowski
> Signed-off-by: Tomasz Kulasek
Please, split this patch: only 1 feature per patch.
Thanks
--
Thomas
2015-01-15 04:27, Ouyang, Changchun:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Helin
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> > > On Wed, Jan 14, 2015 at 12:23:52PM -0800, Stephen Hemminger wrote:
> > > > Ok, so 1.8.0 came out almost a month a
Following structures are removed:
- rte_2tuple_filter
- rte_5tuple_filter
Following APIs are removed:
- rte_eth_dev_add_2tuple_filter
- rte_eth_dev_remove_2tuple_filter
- rte_eth_dev_get_2tuple_filter
- rte_eth_dev_add_5tuple_filter
- rte_eth_dev_remove_5tuple_filter
- rte_eth_dev_get_5tupl
Following commands of 5tuple and 2tuple filter are removed:
- add_2tuple_filter (port_id) protocol (pro_value) (pro_mask)
dst_port (port_value) (port_mask) flags (flg_value) priority (prio
queue (queue_id) index (idx)
- remove_2tuple_filter (port_id) index (idx)
- get_2tuple_filter (port_i
This patch defines new functions dealing with ntuple filters which is
corresponding to 2tuple filter for 82580 and i350 in HW, and to 5tuple
filter for 82576 in HW.
It removes old functions which deal with 2tuple and 5tuple filters in igb
driver.
It also defines eth_igb_filter_ctrl which is bindin
This patch defines new functions dealing with ntuple filters which is
corresponding to 5tuple in HW.
It removes old functions which deal with 5tuple filters.
It also defines ixgbe_dev_filter_ctrl which is binding to filter_ctrl API,
and ntuple filter can be dealt with through this new entrance.
Si
This patch defines ntuple filter type RTE_ETH_FILTER_NTUPLE and its structure
rte_eth_ntuple_filter.
It also corrects the typo TCP_UGR_FLAG to TCP_URG_FLAG
Signed-off-by: Jingjing Wu
---
lib/librte_ether/rte_eth_ctrl.h | 50 +
lib/librte_ether/rte_ethdev.
The patch set uses new filter_ctrl API to replace old 2tuple and 5tuple filter
APIs.
It defines ntuple filter to combine 2tuple and 5tuple types.
It uses new functions and structure to replace old ones in igb/ixgbe driver,
new commands to replace old ones in testpmd, and removes the old APIs.
It
On Thu, 15 Jan 2015 13:15:30 +0800
Ouyang Changchun wrote:
> To keep the consistent logic with normal Rx path, the mergeable
> Rx path also needs software vlan strip/decap if it is enabled.
>
> Signed-off-by: Changchun Ouyang
> ---
> lib/librte_pmd_virtio/virtio_rxtx.c | 4
> 1 file chang
On Thu, 15 Jan 2015 13:15:26 +0800
Ouyang Changchun wrote:
> It should use vring descriptor index instead of used_ring index to index
> vq_descx.
>
> Signed-off-by: Changchun Ouyang
> ---
> lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -
On Thu, Jan 15, 2015 at 10:51:38AM +0100, Thomas Monjalon wrote:
> 2015-01-15 04:27, Ouyang, Changchun:
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Helin
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> > > > On Wed, Jan 14, 2015 at 12:23:52PM -0800
Hi Ayon
Good to see that!
DPDK just has only one driver of igb_uio to bind NICs. VFIO is another story.
You don?t have choices.
Please read the online documents for more details and steps of using DPDK!
Regards,
Helin
From: ayon jyoti Biswas [mailto:ajbiswas2...@gmail.com]
Sent: Thursday, Janu
Hi Ayon
1521 is the device ID of my NIC, yours is 10d3. So you need to check if 10d3 is
listed in that file or not, but not checking 1521.
Regards,
Helin
From: ayon jyoti Biswas [mailto:ajbiswas2...@gmail.com]
Sent: Thursday, January 15, 2015 3:19 PM
To: Zhang, Helin
Subject: Re: [dpdk-dev] How
Hi Deepak
I got it. Thanks for the detailed explanation!
The performance of packet IO shouldn?t be affected from DPDK side as long as
enough cpu cycles can be used. While you cannot expect too much high
performance number transmitted from kernel space to user space, as kernel stack
or netdev fr
Check the device ID can know if your NIC is supported by dpdk or not.
"Lspci -nn | grep Eth" will show like below, 1521 is the device ID.
04:00.0 Ethernet controller [0200]: Intel Corporation I350 Gigabit Network
Connection [8086:1521]
Then check rte_pci_dev_ids.h to see if that device ID is list
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Helin
> Sent: Thursday, January 15, 2015 12:15 PM
> To: Neil Horman; Stephen Hemminger
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] Why nothing since 1.8.0?
>
> +1, Some patch set might be ready for
+1, Some patch set might be ready for being merged.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> Sent: Thursday, January 15, 2015 5:02 AM
> To: Stephen Hemminger
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] Why nothing since 1.8.0?
>
> On
71 matches
Mail list logo
