[dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only

2014-10-29 Thread Thomas Monjalon
2014-10-29 08:53, Wu, Jingjing: > From: Zhang, Helin > > For those registers and their relevant for early hardware only, they should > > neither be defined nor be used. Thus i40e_register_x710_int.h should be > > removed. As I40E_GLINT_CTL and its relevant is really needed, just define it > > direc

[dpdk-dev] [PATCH 0/2] fix of configuring inside NIC RX interrupt

2014-10-29 Thread Thomas Monjalon
2014-10-29 05:00, Chen, Jing D: > From: Zhang, Helin > > Inside NIC RX interrupt is needed for single RX descriptor > > write back. The fix is to correct the wrong configuration > > of register 'I40E_QINT_RQCTL'. In addition, several code > > style fixes are added. > > Note that interrupt will be i

[dpdk-dev] [PATCH] vhost: Check descriptor number for vector Rx

2014-10-29 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang, Changchun > Sent: Monday, October 27, 2014 6:56 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: Check descriptor number for vector Rx > > Hi Thomas, > > > -

[dpdk-dev] [PULL REQUEST] doc: freebsd getting started guide.

2014-10-29 Thread Thomas Monjalon
2014-10-23 15:35, Bernard Iremonger: > doc: getting started guide for linux (2014-10-23 14:36:42 +0200) > > are available in the git repository at: > git://dpdk.org/next/dpdk-doc master Pulled in the main repository. Thanks -- Thomas

[dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature

2014-10-29 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Sunday, October 26, 2014 8:46 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config > VMDQ offload register for multicast feature > > This

[dpdk-dev] Creation of mbuf pool for socket 0 failed

2014-10-29 Thread De Lara Guarch, Pablo
Hi Eduard, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eduard Gibert > Renart > Sent: Wednesday, October 29, 2014 9:30 PM > To: dev at dpdk.org > Subject: [dpdk-dev] Creation of mbuf pool for socket 0 failed > > Hi, > > I was trying to run testpmd appli

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Matthew Hall
On Wed, Oct 29, 2014 at 11:32:12AM -0400, Neil Horman wrote: > > > Well, abnormal termination results in abnormal consequences. You expect > garbage to get left behind of a program crashes, so I wouldn't really worry > about that too much. If you really wanted to you can register chained > hand

[dpdk-dev] [PATCH v2] support free hugepages

2014-10-29 Thread Matthew Hall
On Wed, Oct 29, 2014 at 01:47:39PM +0800, linhaifeng wrote: > +int > +rte_eal_hugepage_free(void) > +{ > + struct hugepage_file *hugepg_tbl = g_hugepage_table.hugepg_tbl; > + unsigned i; > + unsigned nr_hugefiles = g_hugepage_table.nr_hugefiles; > + int ret = 0; > + > + for (i =

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-29 Thread Thomas Monjalon
2014-10-29 17:57, Yong Wang: > Sounds good to me but it does look like the rte_rxmbuf_alloc() could use > some comments to make it explicit that rte_pktmbuf_reset() is avoided by > design for the reasons that Bruce described. Furthermore, > rte_rxmbuf_alloc() is duplicated in almost all the pmd dr

[dpdk-dev] Creation of mbuf pool for socket 0 failed

2014-10-29 Thread Eduard Gibert Renart
I just rebooted the vm and It worked right away so I guess is that the hugepages was not big enough I was reserving 128 MB. Thanks, Eduard Gibert Renart > On oct 29, 2014, at 5:49 PM, De Lara Guarch, Pablo intel.com> wrote: > > Hi Eduard, > >> -Original Message- >> From: dev [mailto:d

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-29 Thread Yong Wang
Sounds good to me but it does look like the rte_rxmbuf_alloc() could use some comments to make it explicit that rte_pktmbuf_reset() is avoided by design for the reasons that Bruce described. Furthermore, rte_rxmbuf_alloc() is duplicated in almost all the pmd drivers. Will it make sense to promote

[dpdk-dev] [Testing purpose] librte_pmd_e1000: Add workaround to test the port hotplug framework.

2014-10-29 Thread Tetsuya Mukawa
This patch is for testing the port hotplug framework. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_e1000/em_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_e1000/em_ethdev.c b/lib/librte_pmd_e1000/em_ethdev.c index 3f2897e..90ec2d7 100644 --- a/l

[dpdk-dev] [RFC PATCH 2/2] testpmd: Add support for the port hotplug framework

2014-10-29 Thread Tetsuya Mukawa
The patch introduces following commands. - port [attach|detach] [p|v] [ident] - attach: attaching a port - detach: detaching a port - p: physical port - v: virtual port - ident: pci address of physical device. Or device name and paramerters of virtual device. (ex. :02:00

[dpdk-dev] [RFC PATCH 1/2] librte_pmd_pcap: Add support for port hotplug

2014-10-29 Thread Tetsuya Mukawa
This patch adds finalization code to free resources allocated by the PMD. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pc

[dpdk-dev] [RFC PATCH 25/25] eal: Enable port hotplug framework in Linux

2014-10-29 Thread Tetsuya Mukawa
The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration. Signed-off-by: Tetsuya Mukawa --- config/common_linuxapp | 5 + 1 file changed, 5 insertions(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index c5751bd..f94ec65 100644 --- a/config/common_linuxapp +++

[dpdk-dev] [RFC PATCH 24/25] eal/pci: Add port hotplug functions for physical devices.

2014-10-29 Thread Tetsuya Mukawa
The patch adds rte_eal_dev_attach_pdev() and rte_eal_dev_detach_pdev(). rte_eal_dev_attach_pdev() receives a PCI address of the device and returns an attached port number. rte_eal_dev_detach_pdev() receives a port number, and returns a PCI address actually detached. Signed-off-by: Tetsuya Mukawa

[dpdk-dev] [RFC PATCH 23/25] eal/pci: Add rte_eal_pci_probe_one and rte_eal_pci_close_one

2014-10-29 Thread Tetsuya Mukawa
The functions are used for probe and close a device. First the function tries to find a device that has the specfied PCI address. Then, probe or close the device. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci.c | 58 + lib/librte_eal/comm

[dpdk-dev] [RFC PATCH 22/25] eal/pci: Add pci_close_all_drivers

2014-10-29 Thread Tetsuya Mukawa
The function tries to find a driver for the specified device, and then close the driver. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/comm

[dpdk-dev] [RFC PATCH 21/25] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-10-29 Thread Tetsuya Mukawa
pci_close_all_drivers() will be implemented after the patch. To share a part of code between thses 2 functions, The patch fixes pci_probe_all_drivers() first. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci.c | 28 1 file changed, 20 insertions

[dpdk-dev] [RFC PATCH 20/25] eal/pci: Add rte_eal_pci_close_one_driver

2014-10-29 Thread Tetsuya Mukawa
The function is used for closing the specified driver and device. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/eal_private.h | 11 ++ lib/librte_eal/linuxapp/eal/eal_pci.c | 58 + 2 files changed, 69 insertions(+) diff --git a/lib/librte_

[dpdk-dev] [RFC PATCH 19/25] eal/pci: Change scope of rte_eal_pci_scan to global

2014-10-29 Thread Tetsuya Mukawa
The function is called by port hotplug framework, so change scope of the function to global. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/eal_private.h | 11 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 6 +++--- 2 files changed, 14 insertions(+), 3 deletions(-)

[dpdk-dev] [RFC PATCH 18/25] eal/pci: Prevent double registrations for pci_device_list

2014-10-29 Thread Tetsuya Mukawa
The patch fixes pci_scan_one() not to register same pci devices twice. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci

[dpdk-dev] [RFC PATCH 17/25] eal/linux/pci: Add functions for unmapping igb_uio resources

2014-10-29 Thread Tetsuya Mukawa
The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 32 + lib/librte_eal/linuxapp/eal/eal_pci_uio.c

[dpdk-dev] [RFC PATCH 16/25] eal/pci: Add port hotplug functions for virtual devices.

2014-10-29 Thread Tetsuya Mukawa
The patch adds rte_eal_dev_attach_vdev() and rte_eal_dev_detach_vdev(). rte_eal_dev_attach_vdev() receives virtual device name and parameters, and returns an attached port number. rte_eal_dev_detach_vdev() receives a port number, and returns device name actually detached. Signed-off-by: Tetsuya M

[dpdk-dev] [RFC PATCH 15/25] eal/pci: Add probe and close function for virtual drivers

2014-10-29 Thread Tetsuya Mukawa
The patch adds rte_eal_dev_init_one() and rte_eal_dev_close_one(). These are used for attaching and detaching virtual devices. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_dev.c | 74 + lib/librte_eal/common/include/rte_dev.h | 6 +++ lib/l

[dpdk-dev] [RFC PATCH 14/25] eal/pci: Add rte_eal_devargs_remove

2014-10-29 Thread Tetsuya Mukawa
The function removes a specified devargs from devargs_list. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 13 + lib/librte_eal/common/include/rte_devargs.h | 18 ++ 2 files changed, 31 insertions(+) diff --git a/lib/librte_eal/common

[dpdk-dev] [RFC PATCH 13/25] eal/pci: Prevent double registration for devargs_list

2014-10-29 Thread Tetsuya Mukawa
The patch fixes rte_eal_devargs_add() not to register same device twice. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/c

[dpdk-dev] [RFC PATCH 12/25] ethdev: Change scope of rte_eth_dev_allocated to global

2014-10-29 Thread Tetsuya Mukawa
This function is used by virtual PMDs to support port hotplug framework. So change scope of the function to global. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 2 +- lib/librte_ether/rte_ethdev.h | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [RFC PATCH 11/25] ethdev: Add rte_eth_dev_check_detachable

2014-10-29 Thread Tetsuya Mukawa
The function returns whether a PMD supports detach function, or not. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 9 + lib/librte_ether/rte_ethdev.h | 11 +++ 2 files changed, 20 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rt

[dpdk-dev] [RFC PATCH 10/25] ethdev: Add rte_eth_dev_get_name_by_port

2014-10-29 Thread Tetsuya Mukawa
The function returns a unique identifier name of a ethdev specified by port identifier. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 17 + lib/librte_ether/rte_ethdev.h | 12 2 files changed, 29 insertions(+) diff --git a/lib/librte_ether/rte_et

[dpdk-dev] [RFC PATCH 09/25] ethdev: Add rte_eth_dev_get_port_by_addr

2014-10-29 Thread Tetsuya Mukawa
The function returns a port identifier of a ethdev specified by pci address. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 13 + lib/librte_ether/rte_ethdev.h | 13 + 2 files changed, 26 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/l

[dpdk-dev] [RFC PATCH 08/25] ethdev: Add rte_eth_dev_get_addr_by_port

2014-10-29 Thread Tetsuya Mukawa
The function returns a pci address of a ethdev specified by port identifier. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 12 lib/librte_ether/rte_ethdev.h | 13 + 2 files changed, 25 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li

[dpdk-dev] [RFC PATCH 07/25] ethdev: Add functions to know which port is attached or detached

2014-10-29 Thread Tetsuya Mukawa
The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). rte_eth_dev_save() is used for saving current rte_eth_dev structures. rte_eth_dev_get_changed_port() receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or detached.

[dpdk-dev] [RFC PATCH 06/25] ethdev: Add rte_eth_dev_shutdown for closing PCI devices.

2014-10-29 Thread Tetsuya Mukawa
rte_eth_dev_shutdown() is called when PCI device is closed. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 37 + 1 file changed, 37 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index aea6627..752e

[dpdk-dev] [RFC PATCH 05/25] eal, ethdev: Add function pointer for closing a device

2014-10-29 Thread Tetsuya Mukawa
The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/rte_pci.h | 7 +++ lib/librte_ether/rte_ethdev.h | 4 2 files changed, 11 inser

[dpdk-dev] [RFC PATCH 04/25] ethdev: Add rte_eth_dev_free to free specified device

2014-10-29 Thread Tetsuya Mukawa
This patch adds rte_eth_dev_free(). The function is used for changing a attached status of the device that has specified name. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 16 lib/librte_ether/rte_ethdev.h | 11 +++ 2 files changed, 27 insertions(+)

[dpdk-dev] [RFC PATCH 03/25] eal/pci: Replace pci address comparison code by eal_compare_pci_addr

2014-10-29 Thread Tetsuya Mukawa
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by eal_compare_pci_addr(). Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 16 +--- lib/librte_eal/common/eal_common_pci.c| 2 +- lib/librte_eal/common/include/rte_pci.h | 29

[dpdk-dev] [RFC PATCH 02/25] ethdev: Remove assumption that port will not be detached

2014-10-29 Thread Tetsuya Mukawa
To remove assumption, do like followings. - Add 'attached' member to rte_eth_dev structure. This member is used for indicating the port is attached, or not. - Delete nb_ports, and fix rte_eth_dev_count(). The value was used for counting attached ports and also used for indicating maximum att

[dpdk-dev] [RFC PATCH 01/25] eal/pci: Add a new flag indicating a driver can detach devices at runtime.

2014-10-29 Thread Tetsuya Mukawa
This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicates the driver can detach devices at runtime. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/rte_pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/i

[dpdk-dev] [RFC PATCH 00/25] Port Hotplug Framework

2014-10-29 Thread Tetsuya Mukawa
This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have resposibility to manage ports. DPDK apps only know which ports are attached or detac

[dpdk-dev] working with VMXNET3 driver in a "NIC Connected to a vSwitch" setup on VMware

2014-10-29 Thread Yan Freedland
Hi I am interested in working with VMXNET3 driver in a NIC - vSwitch fashion on VMware. For that purpose I did the following: 1. On my VMware VM I compiled the driver and loaded it as described in http://dpdk.org/doc/vmxnet3-usermap 2. Using vSphere client I created 2 network ad

[dpdk-dev] Creation of mbuf pool for socket 0 failed

2014-10-29 Thread Eduard Gibert Renart
Hi, I was trying to run testpmd application in interactive mode ($RTE_TARGET/app/testpmd) from the ./tools/setup.sh script with a 0x3 mask and I get the following error: Interactive-mode selected EAL: Error - exiting with code: 1 Cause: Creation of mbuf pool for socket 0 failed I get a simil

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Bruce Richardson
On Wed, Oct 29, 2014 at 11:32:12AM -0400, Neil Horman wrote: > On Wed, Oct 29, 2014 at 03:22:25PM +, Ramia, Kannan Babu wrote: > > The problem still remains if one of the process gets abruptly killed, then > > the corresponding refcount will not get decremented. There should be some > > scave

[dpdk-dev] [RFC PATCH 03/25] eal/pci: Replace pci address comparison code by eal_compare_pci_addr

2014-10-29 Thread Bruce Richardson
On Wed, Oct 29, 2014 at 05:49:14PM +0900, Tetsuya Mukawa wrote: > This patch replaces pci_addr_comparison() and memcmp() of pci addresses by > eal_compare_pci_addr(). > > Signed-off-by: Tetsuya Mukawa Looks like a good cleanup. Acked-by: Bruce Richardson > --- > lib/librte_eal/bsdapp/eal/eal

[dpdk-dev] How to improve the TX performance?

2014-10-29 Thread GongJinrong
Hi, Guys I am using DPDK for the packet transmission, but rte_eth_tx_burst() seems drops too many packets, the NIC is 82574, anyone to help, thanks a lot. also, does DPDK has a reliable TX API for no packet drop? Best Regard John Gong

[dpdk-dev] [PATCH v2] support free hugepages

2014-10-29 Thread Linhaifeng
On 2014/10/29 16:04, Qiu, Michael wrote: > 10/29/2014 2:41 PM, Linhaifeng : >> >> On 2014/10/29 14:14, Qiu, Michael wrote: >>> ? 10/29/2014 1:49 PM, linhaifeng ??: rte_eal_hugepage_free() is used for unlink all hugepages.If you want to free all hugepages you must make sure that you have

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Ramia, Kannan Babu
The problem still remains if one of the process gets abruptly killed, then the corresponding refcount will not get decremented. There should be some scavenging function to be implemented to check the process liveliness. regards Kannan Babu -Original Message- From: dev [mailto:dev-boun

[dpdk-dev] [RFC PATCH 02/25] ethdev: Remove assumption that port will not be detached

2014-10-29 Thread Bruce Richardson
On Wed, Oct 29, 2014 at 05:49:13PM +0900, Tetsuya Mukawa wrote: > To remove assumption, do like followings. > > - Add 'attached' member to rte_eth_dev structure. > This member is used for indicating the port is attached, or not. > - Delete nb_ports, and fix rte_eth_dev_count(). > The value was

[dpdk-dev] [PATCH v2 2/2] i40e: remove i40e_register_x710_int.h

2014-10-29 Thread Helin Zhang
As i40e_register_x710_int.h is defined for early hardware only, it should be deleted. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e/i40e_register_x710_int.h | 10712 1 file changed, 10712 deletions(-) delete mode 100644 lib/librte_pmd_i40e/i40e/i40e_register_x710_

[dpdk-dev] [PATCH v2 1/2] i40e: do not use macros defined in i40e_register_x710_int.h

2014-10-29 Thread Helin Zhang
As i40e_register_x710_int.h is for early hardware only and should be removed finally, the macros defiend in it should not be used. For those registers which is not defined, just define it in code directly as workaround. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.c | 5 -

[dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only

2014-10-29 Thread Helin Zhang
For those registers and their relevant for early hardware only, they should neither be defined nor be used. Thus i40e_register_x710_int.h should be removed. As I40E_GLINT_CTL and its relevant is really needed, just define it directly as a workaround. v2 changes: * Added back writing I40E_GLINT_CTL

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Linhaifeng
On 2014/10/29 13:26, Qiu, Michael wrote: > ? 10/29/2014 11:46 AM, Matthew Hall ??: >> On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >>> I just saw one return path with value '0', and no any other place >>> return a negative value, so it is better to be designed as one >>> non-r

[dpdk-dev] [PATCH v2] support free hugepages

2014-10-29 Thread Linhaifeng
On 2014/10/29 14:14, Qiu, Michael wrote: > ? 10/29/2014 1:49 PM, linhaifeng ??: >> rte_eal_hugepage_free() is used for unlink all hugepages.If you want to >> free all hugepages you must make sure that you have stop to use it,and you >> must call this function before exit process. >> >> Signed-off

[dpdk-dev] [PATCH] librte_vhost: Fix compilation issue

2014-10-29 Thread Ouyang Changchun
It fixes this compilation complain: "error: ignoring return value of 'realpath', declared with attribute warn_unused_result [-Werror=unused-result]" Signed-off-by: Changchun Ouyang --- lib/librte_vhost/virtio-net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/li

[dpdk-dev] [PATCH v2] support free hugepages

2014-10-29 Thread linhaifeng
rte_eal_hugepage_free() is used for unlink all hugepages.If you want to free all hugepages you must make sure that you have stop to use it,and you must call this function before exit process. Signed-off-by: linhaifeng --- .../lib/librte_eal/common/include/rte_memory.h | 11 .../lib/

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Linhaifeng
On 2014/10/29 11:44, Matthew Hall wrote: > On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >> I just saw one return path with value '0', and no any other place >> return a negative value, so it is better to be designed as one >> non-return function, >> >> +void >> +rte_eal_hugepa

[dpdk-dev] [PATCH 2/2] i40e: fix of configuring inside NIC RX interrupt

2014-10-29 Thread Helin Zhang
Inside NIC RX interrupt is needed for single RX descriptor write back. The fix is to correct the wrong configuration of register 'I40E_QINT_RQCTL'. Note that interrupt will be inside NIC only, that means it will never be reported outside NIC hardware. Signed-off-by: Helin Zhang --- lib/librte_pm

[dpdk-dev] [PATCH 1/2] i40e: code style fix

2014-10-29 Thread Helin Zhang
Add several code style fixes. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c index e1f581a..20c99a4 100644 --- a/lib/

[dpdk-dev] [PATCH 0/2] fix of configuring inside NIC RX interrupt

2014-10-29 Thread Helin Zhang
Inside NIC RX interrupt is needed for single RX descriptor write back. The fix is to correct the wrong configuration of register 'I40E_QINT_RQCTL'. In addition, several code style fixes are added. Note that interrupt will be inside NIC only, that means it will never be reported outside NIC hardware

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Neil Horman
On Wed, Oct 29, 2014 at 03:22:25PM +, Ramia, Kannan Babu wrote: > The problem still remains if one of the process gets abruptly killed, then > the corresponding refcount will not get decremented. There should be some > scavenging function to be implemented to check the process liveliness. >

[dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table

2014-10-29 Thread Thomas Monjalon
2014-10-29 08:24, Zhang, Helin: > > > -Original Message- > > From: Zhang, Helin > > Sent: Tuesday, October 28, 2014 8:01 PM > > To: Thomas Monjalon > > Cc: dev at dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes > > of > > redirection table > > > >

[dpdk-dev] [PATCH v4 16/21] ethdev: define structures for configuring flexible payload

2014-10-29 Thread Thomas Monjalon
2014-10-29 03:21, Wu, Jingjing: > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Tuesday, October 28, 2014 10:15 PM > > To: Wu, Jingjing > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 16/21] ethdev: define structures for > >

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread linhaifeng
maybe somebody want to free hugepages when application exit. so add this function for application to release hugepages when exit. Signed-off-by: linhaifeng --- .../lib/librte_eal/common/include/rte_memory.h | 11 + .../lib/librte_eal/linuxapp/eal/eal_memory.c | 27 +

[dpdk-dev] [PATCH v4 11/21] ethdev: define structures for getting flow director information

2014-10-29 Thread Thomas Monjalon
2014-10-29 02:10, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-10-22 09:01, Jingjing Wu: > > > +/** > > > + * A structure used to report the status of the flow director filters in > > > use. > > > + */ > > > +struct rte_eth_fdir { > > > + /** Number of filte

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-29 Thread Thomas Monjalon
2014-10-29 09:04, Bruce Richardson: > On Tue, Oct 28, 2014 at 09:57:14PM +, Yong Wang wrote: > > On 10/22/14, 6:39 AM, "Stephen Hemminger" > > wrote: > > > > > > >On Mon, 13 Oct 2014 18:42:18 + > > >Yong Wang wrote: > > > > > >> Are you referring to the patch as a whole or your comment

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Neil Horman
On Wed, Oct 29, 2014 at 10:26:35AM +, Bruce Richardson wrote: > On Wed, Oct 29, 2014 at 02:49:05PM +0800, Linhaifeng wrote: > > > > > > On 2014/10/29 13:26, Qiu, Michael wrote: > > > ? 10/29/2014 11:46 AM, Matthew Hall ??: > > >> On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >

[dpdk-dev] release hugepages after application exit?

2014-10-29 Thread Choonho Son
Hi, After terminating DPDK application, it does not release hugepages. Is there any reason for it or to-do item? Thanks, Choonho Son

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Bruce Richardson
On Wed, Oct 29, 2014 at 02:49:05PM +0800, Linhaifeng wrote: > > > On 2014/10/29 13:26, Qiu, Michael wrote: > > ? 10/29/2014 11:46 AM, Matthew Hall ??: > >> On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: > >>> I just saw one return path with value '0', and no any other place > >>>

[dpdk-dev] release hugepages after application exit?

2014-10-29 Thread Linhaifeng
On 2014/10/29 9:26, Choonho Son wrote: > Hi, > > After terminating DPDK application, it does not release hugepages. > Is there any reason for it or to-do item? > > Thanks, > Choonho Son > > I have wrote a patch to release hugepages but haven't send it. I will send this path later. -- Regard

[dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni() call

2014-10-29 Thread Thomas Monjalon
Hi, 2014-10-28 23:07, Ariel Rodriguez: > Hi, im trying the kni example. When i hit ctrl-c in the terminal stopping > the example, the os signals with a segmentation fault. [...] > The following change fix that issue: > > static int kni_free_kni(uint8_t port_id) { > uint8_t i; > struct kni_port_

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-29 Thread Bruce Richardson
On Tue, Oct 28, 2014 at 09:57:14PM +, Yong Wang wrote: > On 10/22/14, 6:39 AM, "Stephen Hemminger" > wrote: > > > >On Mon, 13 Oct 2014 18:42:18 + > >Yong Wang wrote: > > > >> Are you referring to the patch as a whole or your comment is about the > >>reset of vlan_tci on the "else" (no v

[dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only

2014-10-29 Thread Wu, Jingjing
> -Original Message- > From: Zhang, Helin > Sent: Wednesday, October 29, 2014 3:09 PM > To: dev at dpdk.org > Cc: Cao, Waterman; Wu, Jingjing; Zhang, Helin > Subject: [PATCH v2 0/2] remove registers for early hardware only > > For those registers and their relevant for early hardware onl

[dpdk-dev] [PATCH] librte_vhost: Fix compilation issue

2014-10-29 Thread Fu, JingguoX
Sorry, not excepted, those are expected! Patch name: librte_vhost: Fix compilation issue Brief description: to fix compilation error on ubuntu14.04 for vhost lib and example Test Flag: Tested-by Tester name:jingguox.fu at intel.com Commit ID:

[dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni() call

2014-10-29 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, October 29, 2014 4:35 PM > To: Ariel Rodriguez > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni() > call > > Hi, > > 2014-10-2

[dpdk-dev] How to improve the TX performance?

2014-10-29 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of GongJinrong > Sent: Wednesday, October 29, 2014 4:22 PM > To: dev at dpdk.org > Subject: [dpdk-dev] How to improve the TX performance? > > Hi, Guys > >I am using DPDK for the packet transmission, but rte_

[dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table

2014-10-29 Thread Zhang, Helin
> -Original Message- > From: Zhang, Helin > Sent: Tuesday, October 28, 2014 8:01 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of > redirection table > > Hi Thomas > > > -Original Message- > > From: Th

[dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table

2014-10-29 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 10:23 PM > To: Zhang, Helin > Cc: Richardson, Bruce; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of > redirection table >

[dpdk-dev] [PATCH] librte_vhost: Fix compilation issue

2014-10-29 Thread Fu, JingguoX
Patch name: librte_vhost: Fix compilation issue Brief description: to fix compilation error on ubuntu14.04 for vhost lib and example Test Flag: Tested-by Tester name:jingguox.fu at intel.com Commit ID: 1ab07743b21b785a71fa33464

[dpdk-dev] [PATCH 1/2] i40e: code style fix

2014-10-29 Thread Qiu, Michael
10/29/2014 2:26 PM, Zhang, Helin: > Hi Michael > >> -Original Message- >> From: Qiu, Michael >> Sent: Wednesday, October 29, 2014 2:11 PM >> To: Zhang, Helin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] i40e: code style fix >> >> 10/29/2014 11:44 AM, Helin Zhang : >>> Add sever

[dpdk-dev] [PATCH v2] support free hugepages

2014-10-29 Thread Qiu, Michael
10/29/2014 2:41 PM, Linhaifeng : > > On 2014/10/29 14:14, Qiu, Michael wrote: >> ? 10/29/2014 1:49 PM, linhaifeng ??: >>> rte_eal_hugepage_free() is used for unlink all hugepages.If you want to >>> free all hugepages you must make sure that you have stop to use it,and you >>> must call this functio

[dpdk-dev] [PATCH 1/2] i40e: code style fix

2014-10-29 Thread Zhang, Helin
Hi Michael > -Original Message- > From: Qiu, Michael > Sent: Wednesday, October 29, 2014 2:11 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] i40e: code style fix > > 10/29/2014 11:44 AM, Helin Zhang : > > Add several code style fixes. > > > > Signed-off-by:

[dpdk-dev] [PATCH v2] support free hugepages

2014-10-29 Thread Qiu, Michael
? 10/29/2014 1:49 PM, linhaifeng ??: > rte_eal_hugepage_free() is used for unlink all hugepages.If you want to > free all hugepages you must make sure that you have stop to use it,and you > must call this function before exit process. > > Signed-off-by: linhaifeng > --- > .../lib/librte_eal/commo

[dpdk-dev] [PATCH 1/2] i40e: code style fix

2014-10-29 Thread Qiu, Michael
10/29/2014 11:44 AM, Helin Zhang : > Add several code style fixes. > > Signed-off-by: Helin Zhang > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Qiu, Michael
? 10/29/2014 11:46 AM, Matthew Hall ??: > On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >> I just saw one return path with value '0', and no any other place >> return a negative value, so it is better to be designed as one >> non-return function, >> >> +void >> +rte_eal_hugepage_

[dpdk-dev] [PATCH v6 0/3] app/test: unit test to measure cycles per packet

2014-10-29 Thread Liang, Cunming
Hi Thomas, All the open issues from the former patches are closed. Could you please have a look and get it applied ? -Liang Cunming > -Original Message- > From: Liang, Cunming > Sent: Monday, October 27, 2014 9:20 AM > To: dev at dpdk.org > Cc: nhorman at tuxdriver.com; Ananyev, Konstant

[dpdk-dev] [PATCH 0/2] fix of configuring inside NIC RX interrupt

2014-10-29 Thread Chen, Jing D
> -Original Message- > From: Zhang, Helin > Sent: Wednesday, October 29, 2014 11:43 AM > To: dev at dpdk.org > Cc: Cao, Waterman; Chen, Jing D; Zhang, Helin > Subject: [PATCH 0/2] fix of configuring inside NIC RX interrupt > > Inside NIC RX interrupt is needed for single RX descriptor >

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Qiu, Michael
10/29/2014 10:55 AM, linhaifeng : > maybe somebody want to free hugepages when application exit. > so add this function for application to release hugepages when exit. > > Signed-off-by: linhaifeng > --- > .../lib/librte_eal/common/include/rte_memory.h | 11 + > .../lib/librte_eal/li

[dpdk-dev] [PATCH v4 16/21] ethdev: define structures for configuring flexible payload

2014-10-29 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 10:15 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 16/21] ethdev: define structures for > configuring flexible payload > > 2014-10-22 09

[dpdk-dev] [PATCH v4 21/21] testpmd: add test command to configure flexible masks

2014-10-29 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 10:18 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 21/21] testpmd: add test command to > configure flexible masks > > 2014-10-22 09:01,

[dpdk-dev] [PATCH v4 11/21] ethdev: define structures for getting flow director information

2014-10-29 Thread Wu, Jingjing
Hi, Thomas Thanks for your comments. Jingjing > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 9:45 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 11/21] ethdev: define structures for > g

[dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field

2014-10-29 Thread Wu, Jingjing
Hi, Thomas Thanks for your comments. Jingjing > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 9:28 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field > > 2014

[dpdk-dev] [PATCH v4 04/21] ethdev: define structures for adding/deleting flow director

2014-10-29 Thread Wu, Jingjing
Hi, Thomas Thanks for your comments. Jingjing > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 9:18 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 04/21] ethdev: define structures for > a

[dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement

2014-10-29 Thread Cao, Waterman
Hi Yong, Let us recheck it again with your instruction. I will response your questions once we get result. Thanks Waterman >-Original Message- >From: Yong Wang [mailto:yongwang at vmware.com] >Sent: Wednesday, October 29, 2014 3:59 AM >To: Thomas Monjalon >Cc: dev at dpdk.org; Cao, Wa