Hi, Thomas Thanks for your comments.
Jingjing > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 28, 2014 9:28 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field > > 2014-10-22 09:01, Jingjing Wu: > > extend fdir field to support flex bytes reported when fdir match > > The commit log should explain why it is required (i40e?). > It will help to understand when digging into git history of mbuf file. > OK. Will explain. > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -171,8 +173,14 @@ struct rte_mbuf { > > union { > > uint32_t rss; /**< RSS hash result if RSS enabled */ > > struct { > > - uint16_t hash; > > - uint16_t id; > > + union { > > + struct { > > + uint16_t hash; > > + uint16_t id; > > + }; > > + uint32_t lo; /**< flexible bytes low*/ > > + }; > > + uint32_t hi; /**< flexible bytes high*/ > > } fdir; /**< Filter identifier if FDIR enabled */ > > Please explain what could be the data of "flexible bytes high". > When set the report status to report flex bytes, flexible bytes high field report first 4 bytes in "little endian" notation. OK. Will add comments in detail. > -- > Thomas
