[dpdk-dev] [PATCH v8 6/6] Link Bonding Library doxygen additions

2014-06-25 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md |1 + doc/doxy-api.conf |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 7b26e98..ee3ad4f 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md @@

[dpdk-dev] [PATCH v8 5/6] testpmd link bonding additions

2014-06-25 Thread Declan Doherty
- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c| 579 +

[dpdk-dev] [PATCH v8 4/6] Link bonding Unit Tests

2014-06-25 Thread Declan Doherty
Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c |7 + app/tes

[dpdk-dev] [PATCH v8 3/6] EAL support for link bonding device initialization

2014-06-25 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c | 10 - lib/librte_eal/

[dpdk-dev] [PATCH v8 2/6] Support for unique interface naming of pmds

2014-06-25 Thread Declan Doherty
Adding support to rte_eth_dev_data structure to support unique name identifier for ethdevs to support adding slave ethdevs (specifically virtual devices which have no public unique identifier) to a link bonding device. This changes the API rte_eth_dev_allocate() to require a const char *name when a

[dpdk-dev] [PATCH v8 1/6] Link Bonding Library (lib/librte_pmd_bond)

2014-06-25 Thread Declan Doherty
Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |5 + config/common_linuxapp

[dpdk-dev] [PATCH v8 0/6] Link Bonding Library

2014-06-25 Thread Declan Doherty
This patch contains the initial release of the Link Bonding PMD Library Supporting bonding modes: 0 - Round Robin 1 - Active Backup 2 - Balance (Supporting 3 transmission polices) layer 2, layer 2+3, layer 3+4 3 - Broadcast Version 8 of patch set: This version splits the bonding libra

[dpdk-dev] [PATCH v7 3/6] EAL support for link bonding device initialization

2014-06-25 Thread Thomas Monjalon
2014-06-25 14:41, Doherty, Declan: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Not sure to understand why you need to split rte_eal_dev_init() in 2 > > steps. > > Should it be possible to keep existing rte_eal_dev_init() > > behaviour and makes further initialization when call

[dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC

2014-06-25 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Richardson, Bruce > Sent: Tuesday, June 24, 2014 10:22 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC > > > -Original Message

[dpdk-dev] [PATCH v7 6/6] Link Bonding Library doxygen additions

2014-06-25 Thread Thomas Monjalon
2014-06-25 14:19, Doherty, Declan: > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Wednesday, June 25, 2014 2:44 PM > > To: Doherty, Declan > > Cc: dev at dpdk.org > > Subject: Re: [PATCH v7 6/6] Link Bonding Library doxygen additions > > >

[dpdk-dev] [PATCH v7 3/6] EAL support for link bonding device initialization

2014-06-25 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, June 25, 2014 9:01 AM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 3/6] EAL support for link bonding device > initialization > > 2014-06-25 1

[dpdk-dev] [PATCH 0/3] previous patches about "shared code"/"base drivers"

2014-06-25 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, June 25, 2014 5:22 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] previous patches about "shared code"/"base > drivers" > > There were discussions about how to fix/

[dpdk-dev] [PATCH v7 3/6] EAL support for link bonding device initialization

2014-06-25 Thread Thomas Monjalon
Hi Declan, 2014-06-24 17:03, Declan Doherty: > Updating functionality in EAL to support adding link bonding > devices via ?vdev option. Link bonding devices will be > initialized after all physical devices have been probed and > initialized. [...] > --- a/lib/librte_eal/common/eal_common_dev.c > +

[dpdk-dev] [PATCH v7 6/6] Link Bonding Library doxygen additions

2014-06-25 Thread Thomas Monjalon
Hi Declan, Since bonding library is a PMD, there should have no need of integrate it in the API documentation. I hadn't time to review it yet, so I would miss something. Do you mean it can be used directly by the application with a specific API? In this case, you could explain it in the commit log

[dpdk-dev] [PATCH 1/3] i40e: explicit shared code naming as base driver

2014-06-25 Thread Chen, Jing D
My bad. Please ignore " BTW, won't this patch overwrite previous one that fix GCC 32bits warning?" > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chen, Jing D > Sent: Wednesday, June 25, 2014 10:44 PM > To: Thomas Monjalon; dev at dpdk.org > Subject: Re: [d

[dpdk-dev] [PATCH 1/3] i40e: explicit shared code naming as base driver

2014-06-25 Thread Chen, Jing D
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 25, 2014 8:22 PM > To: dev at dpdk.org > Cc: Chen, Jing D; Zhang, Helin; Ananyev, Konstantin; De Lara Guarch, Pablo > Subject: [PATCH 1/3] i40e: explicit shared code naming

[dpdk-dev] [PATCH v7 3/6] EAL support for link bonding device initialization

2014-06-25 Thread Doherty, Declan
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 25, 2014 2:55 PM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [PATCH v7 3/6] EAL support for link bonding device initialization > > Hi Declan, > > 2014-06-24 17:03, D

[dpdk-dev] [PATCH 3/3] ixgbe: rework fix of media type for bypass device

2014-06-25 Thread Thomas Monjalon
From: Pablo de Lara This was previously solved in commit 60a70d4e042350ca (fix link status interrupt of bypass device), but this alternative fix reverts the previous one and solves the same issue without modifying the base driver (also named "shared code"). Signed-off-by: Pablo de Lara Acked-by

[dpdk-dev] [PATCH 2/3] i40e/base: ignore warning

2014-06-25 Thread Thomas Monjalon
From: "Chen Jing D(Mark)" There is a warning in base driver (shared code) on 32-bits RHEL6.3/6.5: lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c:917: error: integer constant is too large for ?long? type As we don't modify base driver, this warning must be ignored. Signed-off-by: Chen J

[dpdk-dev] [PATCH 1/3] i40e: explicit shared code naming as base driver

2014-06-25 Thread Thomas Monjalon
The PMD is built on top of the base driver which is provided by Intel and shouldn't be modified to allow easy batch upgrade from Intel. The base driver is a "shared code" between many projects. But in DPDK, the "base driver" naming makes more sense. Signed-off-by: Thomas Monjalon --- lib/librte

[dpdk-dev] [PATCH 0/3] previous patches about "shared code"/"base drivers"

2014-06-25 Thread Thomas Monjalon
There were discussions about how to fix/workaround bugs in Intel code which we don't want to modify. And it raised wording issue to clarify things. I modify my patch and accept others. So I resend them in order to have a final acknowledgement. Please comment and/or acknowledge. Thanks Thomas Monj

[dpdk-dev] [PATCH v7 6/6] Link Bonding Library doxygen additions

2014-06-25 Thread Doherty, Declan
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 25, 2014 2:44 PM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [PATCH v7 6/6] Link Bonding Library doxygen additions > > Hi Declan, > > Since bonding library is a PMD, t

[dpdk-dev] [PATCH] ethdev: read link state interrupt without link_update service

2014-06-25 Thread Olivier MATZ
On 06/20/2014 03:13 PM, Thomas Monjalon wrote: > It is now possible to read link status updated by interrupt without > having manual link_update() service provided by the PMD. > Indeed link_update() is useless in interrupt case. > > Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz

[dpdk-dev] [PATCH] kni: compatibility with RHEL 7

2014-06-25 Thread Cao, Waterman
Hi Thomas, OK, we will verify this patch tomorrow. Waterman > >-Original Message- >From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >Sent: Wednesday, June 25, 2014 6:05 PM >To: Cao, Waterman >Cc: dev at dpdk.org; Hiroshi Shimamoto; Hayato Momma >Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] multi segment TX/RX for vmxnet3

2014-06-25 Thread Thomas Monjalon
Hi, 2014-06-12 11:07, Hyunseok: > Do you guys plan to include this feature in the upcoming DPDK release? AFAIK, it's implemented in this PMD: http://dpdk.org/browse/vmxnet3-usermap/tree/pmd http://dpdk.org/doc/vmxnet3-usermap There are currently many vmxnet3 PMD implementations f

[dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE

2014-06-25 Thread Thomas Monjalon
Hi Huawei, 2014-06-17 03:48, Xie, Huawei: > At least rte_tailq.h, rte_mbuf.h should also include stdio.h. It has been fixed in this commit: http://dpdk.org/browse/dpdk/commit/?id=86d5de5c46fc0 But rte_memory.h was forgotten. rte_mbuf.h has no problem because it includes rte_mempool.h whic

[dpdk-dev] [PATCH v2] rte_ethdev: add link support flag

2014-06-25 Thread Thomas Monjalon
Hi Stephen, I had no answer to this comment. Please check. 2014-06-20 15:06, Thomas Monjalon: > 2014-06-19 15:12, Stephen Hemminger: > > Only some devices support the link state interrupt configuration option. > > Link state control does not work in virtual drivers > > (virtio, vmxnet3, igbvf, an

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-25 Thread Thomas Monjalon
2014-06-24 17:39, Richardson, Bruce: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > > The function rte_snprintf serves no useful purpose. It is the > > same as snprintf() for all valid inputs. Just remove it and > > replace all uses in current code. > > NAK to this a

[dpdk-dev] [PATCH] mempool: don't leak ring on failure

2014-06-25 Thread Olivier MATZ
On 06/25/2014 09:46 AM, Olivier MATZ wrote: > Your patch moves the creation of the ring after the call to > rte_memzone_reserve(), so now it tries to create the memory > for the object pool before the ring. The problem disappears > because the object pool is usually much bigger than the ring, > so

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-25 Thread Olivier MATZ
Hi Bruce, On 06/24/2014 08:00 PM, Richardson, Bruce wrote: >> I want to get it out now rather than some 2 year life cycle. >> The issue was discussed and marking it as deprecated breaks the build. >> Alternate is removing all instances and adding: >> >> #define rte_snprintf snprintf >> >> in heade

[dpdk-dev] [PATCH] mempool: don't leak ring on failure

2014-06-25 Thread Olivier MATZ
Hello Stephen, On 06/24/2014 05:49 PM, Stephen Hemminger wrote: > If mempool can not be created because of insufficient memory > it returns an error but has already created a ring (and leaves it > behind). This prevents code from trying one mempool size and then > retrying with a smaller size if t

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

2014-06-25 Thread Chen, Jing D
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 24, 2014 6:06 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning > > 2014-06-24 09:47, Chen, Jing D: > > Fro

[dpdk-dev] [PATCH] kni: compatibility with RHEL 7

2014-06-25 Thread Thomas Monjalon
Hi Waterman, 2014-06-12 09:35, Hiroshi Shimamoto: > 2014-06-12 09:18, Cao, Waterman: > > Can you give details about Linux Kernel version and complier version? > > Because we tried to build code in the Redhat 7.0 before, but we don't > > meet this issue. Please see information as the followin

[dpdk-dev] [RFC PATCH DRAFT 1/2] ethdev: add buffered single pkt TX function to API

2014-06-25 Thread Richardson, Bruce
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, June 24, 2014 4:06 PM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH DRAFT 1/2] ethdev: add buffered single pkt > TX function to API > > On Tue, 24 Jun

[dpdk-dev] [RFC PATCH DRAFT 1/2] ethdev: add buffered single pkt TX function to API

2014-06-25 Thread Richardson, Bruce
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, June 24, 2014 4:07 PM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH DRAFT 1/2] ethdev: add buffered single pkt > TX function to API > > On Tue, 24 Jun