[GitHub] chaoyli commented on a change in pull request #532: Make reader can be compiled

2019-01-15 Thread GitBox
chaoyli commented on a change in pull request #532: Make reader can be compiled URL: https://github.com/apache/incubator-doris/pull/532#discussion_r247800834 ## File path: be/src/olap/reader.cpp ## @@ -503,43 +485,93 @@ OLAPStatus Reader::_capture_rs_readers(const ReaderPa

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r247806042 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,220 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r247815587 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,220 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r247813197 ## File path: be/src/exec/exchange_node.h ## @@ -109,6 +111,9 @@ class ExchangeNode : public ExecNode {

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r247806844 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,220 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r247805471 ## File path: be/src/exec/analytic_eval_node.h ## @@ -68,6 +68,7 @@ class AnalyticEvalNode : public ExecNode

[GitHub] imay commented on a change in pull request #336: Implement new tablet repair and balance framework

2019-01-15 Thread GitBox
imay commented on a change in pull request #336: Implement new tablet repair and balance framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r247032618 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -1421,8 +1446,11 @@ AgentStatus TaskWorker

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248138992 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,220 @@ +// Licensed to the Apache So

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248138959 ## File path: be/src/exec/exchange_node.h ## @@ -109,6 +111,9 @@ class ExchangeNode : public ExecN

[GitHub] morningman opened a new issue #537: Meta data on BE is not consisten with the real data on Disk

2019-01-15 Thread GitBox
morningman opened a new issue #537: Meta data on BE is not consisten with the real data on Disk URL: https://github.com/apache/incubator-doris/issues/537 Sometimes we may see that A Tablet exist in metadata, but broken on disk. We should have a solution to synchronize the meta data in me

[GitHub] imay opened a new pull request #538: Add counters to OlapScanNode

2019-01-15 Thread GitBox
imay opened a new pull request #538: Add counters to OlapScanNode URL: https://github.com/apache/incubator-doris/pull/538 There is unnegligible cost to covnert VectorRowBatch to RowBatch, When we seek block, we only read one row from engine to minimize this convert cost. This pa

[GitHub] EmmyMiao87 opened a new pull request #539: Add param of specified thirdparty path

2019-01-15 Thread GitBox
EmmyMiao87 opened a new pull request #539: Add param of specified thirdparty path URL: https://github.com/apache/incubator-doris/pull/539 1. The thirdparth path can be specify on build.sh: ./build.sh --thirdparty /specified/path/to/thirdparty 2. If there are only thirdparty param of bui

[GitHub] morningman merged pull request #336: Implement new tablet repair and balance framework

2019-01-15 Thread GitBox
morningman merged pull request #336: Implement new tablet repair and balance framework URL: https://github.com/apache/incubator-doris/pull/336 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None ---

[GitHub] morningman opened a new issue #540: Implement new tablet repair and balance framework

2019-01-15 Thread GitBox
morningman opened a new issue #540: Implement new tablet repair and balance framework URL: https://github.com/apache/incubator-doris/issues/540 # Doris 副本修复和均衡策略 # 名词解释 1. Tablet:Doris 表的逻辑分片,一个表有多个分片 2. Replica:分片的副本,默认一个分片有3个副本 3. Healthy Replica:健康副本,副本所在 Backend 存活,且

[GitHub] morningman opened a new pull request #541: Fix bug that internal retry of stream load return wrong result

2019-01-15 Thread GitBox
morningman opened a new pull request #541: Fix bug that internal retry of stream load return wrong result URL: https://github.com/apache/incubator-doris/pull/541 Add a timestamp as an internal identifier to identify that a 'request' is a 'retry request' from same request

[GitHub] chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-15 Thread GitBox
chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r248136081 ## File path: be/src/olap/push_handler.cpp ## @@ -277,22 +272,35 @@ void PushHandler::_get_tablet_

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248163920 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248162137 ## File path: fe/src/main/java/org/apache/doris/qe/RowBatch.java ## @@ -0,0 +1,55 @@ +// Licensed to the Apa

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248163890 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248168875 ## File path: be/src/exec/exchange_node.cpp ## @@ -95,6 +96,12 @@ Status ExchangeNode::open(RuntimeState* st

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248161902 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -774,4 +787,40 @@ private void ha

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248162211 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -537,26 +542,34 @@ private void h

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248163814 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248163831 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Fou

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248162508 ## File path: fe/src/main/java/org/apache/doris/qe/ConnectProcessor.java ## @@ -92,12 +93,16 @@ private void

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248171059 ## File path: fe/src/main/java/org/apache/doris/qe/RowBatch.java ## @@ -0,0 +1,55 @@ +// Licensed

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248171978 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -774,4 +787,40 @@ priva

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-15 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248172593 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -537,26 +542,34 @@ priv