chaoyli commented on a change in pull request #536: Add Rowset and
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r248136081
##########
File path: be/src/olap/push_handler.cpp
##########
@@ -277,22 +272,35 @@ void PushHandler::_get_tablet_infos(
OLAPStatus PushHandler::_convert(
TabletSharedPtr curr_tablet,
TabletSharedPtr new_tablet,
- Indices* curr_olap_indices,
- Indices* new_olap_indices,
+ std::vector<RowsetSharedPtr>* cur_rowsets,
+ std::vector<RowsetSharedPtr>* related_rowsets,
AlterTabletType alter_tablet_type) {
OLAPStatus res = OLAP_SUCCESS;
RowCursor row;
BinaryFile raw_file;
IBinaryReader* reader = NULL;
ColumnDataWriter* writer = NULL;
Review comment:
ColumnDataWriter should not be left exposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
