Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Willem Jiang
In this case I had to vote -1 as fixing the License issue of third party dependency is quit important release process. And please provide the binary build evidence such as CI build log as reference if there is no solution to build the code on mac. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Zhao Chun
Hi Willem Willem Jiang 于2019年1月11日周五 下午11:06写道: > I think you should cut another RC release as a quick fix. > > I plan to continue this release, because we already have three +1 votes. If we cancel this vote, It will take IPMC more time to check new release. Problems that you mentioned will be

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Makoto Yui
With PARALLEL=1, the build fails as follows /usr/bin/../bin/g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I./src -I/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/installed/include -Wall -Wextra -pedantic -g -O2 -std=c++11 -MT src/generate/thrift-t_as3_generator.o -MD -

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Willem Jiang
I think you should cut another RC release as a quick fix. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Jan 11, 2019 at 9:30 PM Zhao Chun wrote: > > Hi Willem > > Willem Jiang 于2019年1月11日周五 下午8:44写道: > > > What's your plan for the next release? > > > > We plan to start next release

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Zhao Chun
Hi Willem Willem Jiang 于2019年1月11日周五 下午8:44写道: > What's your plan for the next release? > We plan to start next release at the end of March this year. > It has been a month since we start the vote. My suggestion is do a > quick RC release for it. > > Now we have three +1(binding), however th

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Willem Jiang
What's your plan for the next release? It has been a month since we start the vote. My suggestion is do a quick RC release for it. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Jan 11, 2019 at 4:07 PM Li,De(BDG) wrote: > > Hi Makoto, > > Thank you for your check. > > >> Why not

[GitHub] chaoyli commented on a change in pull request #529: Remove segment group from delta writer

2019-01-11 Thread GitBox
chaoyli commented on a change in pull request #529: Remove segment group from delta writer URL: https://github.com/apache/incubator-doris/pull/529#discussion_r247086761 ## File path: be/src/olap/delta_writer.cpp ## @@ -172,15 +164,18 @@ OLAPStatus DeltaWriter::close(googl

[GitHub] chaoyli commented on a change in pull request #529: Remove segment group from delta writer

2019-01-11 Thread GitBox
chaoyli commented on a change in pull request #529: Remove segment group from delta writer URL: https://github.com/apache/incubator-doris/pull/529#discussion_r247087030 ## File path: be/src/olap/delta_writer.cpp ## @@ -172,15 +164,18 @@ OLAPStatus DeltaWriter::close(googl

[GitHub] chaoyli commented on a change in pull request #529: Remove segment group from delta writer

2019-01-11 Thread GitBox
chaoyli commented on a change in pull request #529: Remove segment group from delta writer URL: https://github.com/apache/incubator-doris/pull/529#discussion_r247086596 ## File path: be/src/olap/delta_writer.cpp ## @@ -143,20 +148,7 @@ OLAPStatus DeltaWriter::write(Tuple*

[GitHub] chaoyli closed pull request #530: Change StorageMigrationTask to be adapted to Rowset interface

2019-01-11 Thread GitBox
chaoyli closed pull request #530: Change StorageMigrationTask to be adapted to Rowset interface URL: https://github.com/apache/incubator-doris/pull/530 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] chaoyli opened a new pull request #530: Change StorageMigrationTask to be adapted to Rowset interface

2019-01-11 Thread GitBox
chaoyli opened a new pull request #530: Change StorageMigrationTask to be adapted to Rowset interface URL: https://github.com/apache/incubator-doris/pull/530 This is an automated message from the Apache Git Service. To respo

[GitHub] kangpinghuang opened a new pull request #529: remove segment group from delta writer

2019-01-11 Thread GitBox
kangpinghuang opened a new pull request #529: remove segment group from delta writer URL: https://github.com/apache/incubator-doris/pull/529 1. remove SegmengGroup and ColumnDataWriter from DeltaWriter, replace them with Rowset and RowsetBuilder 2. Add RowsetBuilderContext and RowsetBui

[GitHub] kangpinghuang opened a new issue #528: DeltaWriter should not use SegmentGroup and ColumnDataWriter

2019-01-11 Thread GitBox
kangpinghuang opened a new issue #528: DeltaWriter should not use SegmentGroup and ColumnDataWriter URL: https://github.com/apache/incubator-doris/issues/528 **Is your feature request related to a problem? Please describe.** In BE refactor, Now DeltaWriter still directly use ColumnDataWr

[GitHub] kangpinghuang commented on issue #509: Rowset should provide some meta info interfaces

2019-01-11 Thread GitBox
kangpinghuang commented on issue #509: Rowset should provide some meta info interfaces URL: https://github.com/apache/incubator-doris/issues/509#issuecomment-453487240 Resolved by #510 This is an automated message from the A

[GitHub] kangpinghuang closed issue #509: Rowset should provide some meta info interfaces

2019-01-11 Thread GitBox
kangpinghuang closed issue #509: Rowset should provide some meta info interfaces URL: https://github.com/apache/incubator-doris/issues/509 This is an automated message from the Apache Git Service. To respond to the message, p

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2019-01-11 Thread Li,De(BDG)
Hi Makoto, Thank you for your check. >> Why not cancel rc1 and create rc2 fixing license header issue that Willem >> pointed? >> It seems it's better to be fixed. Actually, we have fixed these issues in branch-0.9.0 (#471, #473) after Willem pointed. I’m afraid it will take everyone