chaoyli commented on a change in pull request #529: Remove segment group from
delta writer
URL: https://github.com/apache/incubator-doris/pull/529#discussion_r247087030
##########
File path: be/src/olap/delta_writer.cpp
##########
@@ -172,15 +164,18 @@ OLAPStatus
DeltaWriter::close(google::protobuf::RepeatedPtrField<PTabletInfo>* t
return st;
}
}
- RETURN_NOT_OK(_mem_table->close(_writer));
+ RETURN_NOT_OK(_mem_table->close(_rowset_builder.get()));
OLAPStatus res = OLAP_SUCCESS;
//add pending data to tablet
- RETURN_NOT_OK(_tablet->add_pending_version(_req.partition_id,
_req.transaction_id, nullptr));
- for (SegmentGroup* segment_group : _segment_group_vec) {
- RETURN_NOT_OK(_tablet->add_pending_segment_group(segment_group));
- RETURN_NOT_OK(segment_group->load());
- }
+ RETURN_NOT_OK(_tablet->add_pending_version(_req.partition_id, _req.txn_id,
nullptr));
+ // use rowset meta manager to save meta
+ _cur_rowset = _rowset_builder->build();
+ RowsetMetaManager::save(
+ _tablet->data_dir()->get_meta(),
+ _cur_rowset->rowset_id(),
+ _cur_rowset->rowset_meta().get());
Review comment:
Also, use std::shared_ptr<RowsetMeta> instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
