Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-16 Thread Andy Grove
The vote has now been open for more than seven days and we have seven +1 votes (three binding) so the vote passes. Thank you all. The next step will be to start the IP clearance process. I will start a separate email thread for this. Thanks, Andy. > On Jul 14, 2024, at 10:48 PM, Renjie Liu

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-14 Thread Renjie Liu
+1, non-binding. On Mon, Jul 15, 2024 at 11:07 AM Mehmet Ozan Kabak wrote: > +1 > > > On Jul 14, 2024, at 7:55 PM, tison wrote: > > > > +1 non-binding > > > > LGTM > > > > Best, > > tison. > > > > > > Edmondo Porcu 于2024年7月14日 周日08:31写道: > > > >> +1 (non-binding) > >> > >> > >> I was starting t

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-14 Thread Mehmet Ozan Kabak
+1 > On Jul 14, 2024, at 7:55 PM, tison wrote: > > +1 non-binding > > LGTM > > Best, > tison. > > > Edmondo Porcu 于2024年7月14日 周日08:31写道: > >> +1 (non-binding) >> >> >> I was starting to work on a contribution to make it possible to produce >> indented SQL using `unparser(expr).to_string()

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-14 Thread tison
+1 non-binding LGTM Best, tison. Edmondo Porcu 于2024年7月14日 周日08:31写道: > +1 (non-binding) > > > I was starting to work on a contribution to make it possible to produce > indented SQL using `unparser(expr).to_string()` and I realized that > `ast::Statement` lives in sql-parser. I think keeping

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-14 Thread Edmondo Porcu
+1 (non-binding) I was starting to work on a contribution to make it possible to produce indented SQL using `unparser(expr).to_string()` and I realized that `ast::Statement` lives in sql-parser. I think keeping the SQL parsing code under the Datafusion umbrella could help development of features

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-08 Thread Phillip LeBlanc
+1 (non-binding) I believe this will be positive for both the `sqlparser-rs` and DataFusion communities going forward. Thanks Andrew for you work on sqlparser-rs so far! From: Andrew Lamb Date: Tuesday, July 9, 2024 at 8:52 AM To: dev@datafusion.apache.org Subject: Re: [VOTE] Accept donation

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-08 Thread Andrew Lamb
+1 As for the new initial committers, at the moment there is only one active maintainer with write access (myself). However, there are three active maintainers[1] of sqlparser whom we had discussed granting commit rights to. My hope would be that if we proceed and continue sqlparser-rs developmen

Re: [VOTE] Accept donation of sqlparser-rs project

2024-07-08 Thread tison
Generally sounds good especially considering the tight collaborations. One question here: Are there new initial committers except those who are already a DataFusion committer that will be nominated? I remember that the IP clearance process can contain this section. Best, tison. Andy Grove 于20