We are contemplating changing the `TableProvider::Scan` method (to take a
trait object, rather than `SessionState`). Please review and provide
comments if you are interested[1]
[1]: https://github.com/apache/datafusion/pull/11516
+1 (non-binding)
Verified on m2 macbook pro.
On Sat, Jul 20, 2024 at 4:57 PM Andy Grove
wrote:
> Hi,
>
> I would like to propose a release of Apache DataFusion Comet version 0.1.0.
>
> This release candidate is based on commit:
> df980bf67e59f439521b90dd2139c6a8d706c0bc [1]
> The proposed relea
+1 (non-binding)
(resolved my previous comment). There is a `release-nogit` target for make.
On Mon, Jul 22, 2024 at 10:21 AM Parth Chandra wrote:
> Src tarball verified successfully.
>
> However, building the artifacts from src gives an error because the
> makefile does not have "-Dmaven.gitc
Thanks, Parth. You should be able to run "make release-nogit". I will add
this information to the release verification instructions and the getting
started guide.
On Mon, Jul 22, 2024 at 11:25 AM Parth Chandra wrote:
> Src tarball verified successfully.
>
> However, building the artifacts from s
Src tarball verified successfully.
However, building the artifacts from src gives an error because the
makefile does not have "-Dmaven.gitcommitid.skip=true" specified.
$ make release ( or just make)
...
[ERROR] Failed to execute goal
io.github.git-commit-id:git-commit-id-maven-plugin:4.9.9:revisi
I just noticed that this release candidate depends on the DataFusion 40.0.0
revision in GitHub rather than depending on the released version in
crates.io. This means we won't be able to publish the
datafusion-comet-spark-expr crate to crates.io. I don't think that is too
important for this first re
Thanks for the feedback so far on the release process. I have a PR open to
fix the issues reported so far.
https://github.com/apache/datafusion-comet/pull/696
On Mon, Jul 22, 2024 at 8:46 AM Xianjin YE wrote:
> +1 (non-binding)
>
> I verified it on a M1 Mac.
>
> BTW, I believe the verify-releas
+1 (non-binding)
I verified it on a M1 Mac.
BTW, I believe the verify-release-candidate.sh in main branch doesn’t work yet,
have to switch to branch-0.1 to verify that.
> On Jul 22, 2024, at 20:15, Andrew Lamb wrote:
>
> +1 (binding)
>
> I verified it on a m3 mac
>
> I noted the changelog l
+1 (binding)
I verified it on a m3 mac
I noted the changelog link in your email [3] gives me a 404. I think the
right link may be [1]
Thanks,
Andrew
[1]:
https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/dev/changelog/0.1.0.md
[3]:
https://github.com/apac
