+1 (non-binding) (resolved my previous comment). There is a `release-nogit` target for make.
On Mon, Jul 22, 2024 at 10:21 AM Parth Chandra <par...@apache.org> wrote: > Src tarball verified successfully. > > However, building the artifacts from src gives an error because the > makefile does not have "-Dmaven.gitcommitid.skip=true" specified. > $ make release ( or just make) > ... > [ERROR] Failed to execute goal > io.github.git-commit-id:git-commit-id-maven-plugin:4.9.9:revision > (get-the-git-infos) on project comet-common-spark3.4_2.12: .git directory > is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> > [Help 1] > > > On Sat, Jul 20, 2024 at 1:56 PM Andy Grove <andy.gr...@apple.com.invalid> > wrote: > >> Hi, >> >> I would like to propose a release of Apache DataFusion Comet version >> 0.1.0. >> >> This release candidate is based on commit: >> df980bf67e59f439521b90dd2139c6a8d706c0bc [1] >> The proposed release tarball and signatures are hosted at [2]. >> The changelog is located at [3]. >> >> Please download, verify checksums and signatures, run the unit tests, and >> vote >> on the release. The vote will be open for at least 72 hours. >> >> Only votes from PMC members are binding, but all members of the community >> are >> encouraged to test the release and vote with "(non-binding)". >> >> The standard verification procedure is documented at >> https://github.com/apache/datafusion-comet/blob/main/dev/release/verifying-release-candidates.md >> >> [ ] +1 Release this as Apache DataFusion Comet 0.1.0 >> [ ] +0 >> [ ] -1 Do not release this as Apache DataFusion Comet 0.1.0 because... >> >> Here is my vote: >> >> +1 >> >> [1]: >> https://github.com/apache/datafusion-comet/tree/df980bf67e59f439521b90dd2139c6a8d706c0bc >> [2]: >> https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-comet-0.1.0-rc2 >> [3]: >> https://github.com/apache/datafusion-comet/blob/df980bf67e59f439521b90dd2139c6a8d706c0bc/CHANGELOG.md >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org >> For additional commands, e-mail: dev-h...@datafusion.apache.org >> >>
