RE: Infrastructures questions.

2016-12-16 Thread Finan, Sean
Thanks for testing! And thank you for bringing it to our attention! Sean -Original Message- From: Andrey Kurdumov [mailto:kant2...@googlemail.com] Sent: Friday, December 16, 2016 3:29 AM To: dev@ctakes.apache.org Subject: Re: Infrastructures questions. `mvn clean package` also working

Re: Infrastructures questions.

2016-12-16 Thread Andrey Kurdumov
`mvn clean package` also working for me. Could someone close CTAKES-361, since this is issue reported couple years ago? Thanks for helping out and impatiently waiting for release :) 2016-12-16 5:30 GMT+06:00 Pei Chen : > I can recreate what Tim suggested. > 1) Comment out LVG from the dependency

Re: Infrastructures questions.

2016-12-15 Thread Pei Chen
I can recreate what Tim suggested. 1) Comment out LVG from the dependency parser test/pipeline 2) The same thing would need to be done in the Regression Test (comment out LVG in the test) 3) Update the regression test suite newly generated output -> expected I'll commit the changes. Basically with

Re: Infrastructures questions.

2016-12-15 Thread Andrey Kurdumov
Hi Tim, Not sure which fix you are talking about? modify pipeline or ignore test? Are this is test meaningful? Since I don't know if this test is valuable, I assume that it is and spend time trying to figure out what's wrong with tests and found two Jira issues - CTAKES-361 and CTAKES-307 which di

Re: Infrastructures questions.

2016-12-14 Thread Miller, Timothy
Dependency tests pass with my change; new test error in regression test module that I'm not familiar with and error type I've never seen before -- reaching out for help debugging: > Exception in thread "BaseCPMImpl-Thread" > junit.framework.AssertionFailedError: Verifying Test Output: > testpat

RE: Infrastructures questions.

2016-12-13 Thread Finan, Sean
:chen...@apache.org] Sent: Tuesday, December 13, 2016 11:15 AM To: dev@ctakes.apache.org Subject: Re: Infrastructures questions. What release are you referring to? On Tue, Dec 13, 2016 at 11:08 AM, Finan, Sean wrote: > By the way, did we ever vote on the release? > https://urldefense.proofpoint.com/v2

Re: Infrastructures questions.

2016-12-13 Thread Miller, Timothy
Quick followup - the test passes in eclipse, both with and without LVG enabled. Can someone try to replicate at the command line and see if mvn package works with LVG commented out? This is line 130 in WriteClearNLPDescriptors.java. Otherwise I can try this afternoon. Tim On Tue, 2016-12-13 at 1

Re: Infrastructures questions.

2016-12-13 Thread Pei Chen
g] > Sent: Tuesday, December 13, 2016 10:51 AM > To: dev@ctakes.apache.org > Subject: Re: Infrastructures questions. > > That's right. mvn compile and test should work fine. The benign test failed > error from junit tests is coming from install/package; it's been there sinc

RE: Infrastructures questions.

2016-12-13 Thread Finan, Sean
By the way, did we ever vote on the release? http://www.apache.org/dev/release.html#approving-a-release -Original Message- From: Pei Chen [mailto:chen...@apache.org] Sent: Tuesday, December 13, 2016 10:51 AM To: dev@ctakes.apache.org Subject: Re: Infrastructures questions. That's

Re: Infrastructures questions.

2016-12-13 Thread Miller, Timothy
Pretty sure this particular issue is caused by LVG being part of the test pipeline and the "URI is not hierarchical" bug from not having its files unpacked from the jar. A simple fix is to disable that test in code; a slightly more complex fix is to run the test with a modified pipeline that doesn'

Re: Infrastructures questions.

2016-12-13 Thread Pei Chen
That's right. mvn compile and test should work fine. The benign test failed error from junit tests is coming from install/package; it's been there since the beginning of time [1]. It would be a nice to have and remove the benign warning messages. If a proposed critical patch release passes the r

Re: Infrastructures questions.

2016-12-13 Thread Andrey Kurdumov
NP for broken build. Finally I manage to run it, so I just report issue so other don't have have to go through hoops like me. I just want to made small correction - mvn compile works. mvn test works too, but mvn package require -DskipTests. The problem with build is somehow related to how Maven pa

RE: Infrastructures questions.

2016-12-13 Thread Finan, Sean
Hi Andrey, The requirement of skipping tests for a successful build is something that all ctakes developers have stumbled across, but after initial setup we all forget about it and it has never been handled. Apologies. The github mirror is something that would be great to have, but getting it