Contributing to Cordova

2014-11-26 Thread Oliver Salzburg
Hello list, we've been working with Cordova for about a year now. In the process we've opened a couple of issues on the Cordova Jira and submitted a couple of pull requests on GitHub. I've noticed that responses to these actions usually take either a very long time, or don't happen at all. We've

Re: Status of Next Major

2018-09-11 Thread Oliver Salzburg
I just wanted to voice my concern regarding package-locks on the list, even though consensus was probably reached in the past already. From our experience, this is almost as bad as committing node_modules into VCS. I understand the idea behind them and I would agree with that idea, but the imp

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-12 Thread Oliver Salzburg
On 2018-09-12 21:29, Chris Brody wrote: > I think this would give us better integrity of nightly builds. I don't think I understand the proposal. If the goal is to produce nightly builds, why not change the dependency version during the nightly build, publish the nightly and leave master dependen

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-12 Thread Oliver Salzburg
On 2018-09-12 22:31, raphine...@gmail.com wrote: > Yeah, I mean that's what we do with the nightlies already. I agree that it > would be great to be notified of integration problems ASAP. But to achieve > that, we should test the nightlies produced during the nightly build. On 2018-09-12 21:36, Ja

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-12 Thread Oliver Salzburg
On 2018-09-12 22:40, Jan Piotrowski wrote: > cordova-create uses cordova-common and cordova-fetch. Right now two > existing releases are pinned as dependencies. cordova-common and > cordova-fetch have changes in master, that are necessary for new > things in cordova-create to work. Right now there

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-13 Thread Oliver Salzburg
On 2018-09-13 00:34, Chris Brody wrote: In case of major version bump each Cordova package will continue to keep dependency on previous patch release of other packages until we make the new release. Reading this makes me think I didn't understand an important part of the discussion. Isn't this

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-13 Thread Oliver Salzburg
Alright, as long as we're talking about a manual process to resolve this conflict temporarily, I see it as a valid suggestion. However, I would still prefer if a -rc.0 suffixed version was published and then depended upon, for clarity. On 2018-09-13 11:49, Jan Piotrowski wrote: Chris didn't re

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-13 Thread Oliver Salzburg
do this just once per Cordova package in a major release. On Thu, Sep 13, 2018, 6:08 AM Oliver Salzburg wrote: Alright, as long as we're talking about a manual process to resolve this conflict temporarily, I see it as a valid suggestion. However, I would still prefer if a -rc.0 suffixed ve

Re: Cordova 8.1.0 (minor release) proposal

2018-09-14 Thread Oliver Salzburg
I feel like this would help move things forward. So I'm in favor. On 2018-09-14 08:24, Chris Brody wrote: I would like to propose making 8.1.0 minor release, which would consist of: * new cordova-lib@8.1.0 minor release * new cordova-cli@8.1.0 minor release to accomplish the following: * resol

Re: [DISCUSS] Update dependencies for nightly builds in master

2018-09-14 Thread Oliver Salzburg
Yes, that makes sense. What I meant was the opposite: When specifying a range, it should not be fulfilled with a suffixed version. On 2018-09-13 16:20, Chris Brody wrote: If I would try the following command in master branch of cordova-common (just an experiment): npm install cordova-comm

Re: Commit package-lock.json in next major Cordova release or not?

2018-09-14 Thread Oliver Salzburg
The problems that appear when you have linked dependencies is that npm will pick them up as being bundled and mark them as such in the lockfile. *However* this behavior has changed in the past. At one point this affected any direct dependency, at another point it "only" affected dependencies of

Re: [DISCUSS cordova-windows@6.0.1 patch release

2018-09-17 Thread Oliver Salzburg
What kind of verification is expected for these types of changes? #285 only adds a license header. That looks pretty safe to me. #287 I have a hard time seeing any relevant changes either. The references to C:/Users/brodybits/Documents seem weird. #281 seems to be the only relevant change at a

Re: Commit package-lock.json in next major Cordova release or not?

2018-09-17 Thread Oliver Salzburg
ed by npm; we should both read the documentation and experiment, ideally with its own test cases On Fri, Sep 14, 2018 at 9:47 AM Oliver Salzburg wrote: The problems that appear when you have linked dependencies is that npm will pick them up as being bundled and mark them as such in the lock

Re: Commit package-lock.json in next major Cordova release or not?

2018-09-17 Thread Oliver Salzburg
a-cli/pull/325> to validate as best we can * semver package seems to be a major library package used by npm; we should both read the documentation and experiment, ideally with its own test cases On Fri, Sep 14, 2018 at 9:47 AM Oliver Salzburg wrote: The problems that appear when you have link

Re: [DISCUSS] When to do npm shrinkwrap?

2018-09-17 Thread Oliver Salzburg
such as cordova-cli. I would like to ask people to please use references whenever possible. [1] https://lists.apache.org/thread.html/7f92561d382f143aaf49e083bbe215dcf95a3f4d8b6e3cbb6089a5f3@%3Cdev.cordova.apache.org%3E On Mon, Sep 17, 2018 at 5:38 AM Oliver Salzburg wrote: +1 to shrinkwrap

Re: Commit package-lock.json in next major Cordova release or not?

2018-09-17 Thread Oliver Salzburg
I would agree with your conclusion. Except that my personal interpretation of it was that npm is as stable as a hovercraft filled with eels. :D On 2018-09-17 13:22, Chris Brody wrote: On Mon, Sep 17, 2018 at 5:35 AM Oliver Salzburg wrote: I would also suggest to have a brief look at the

Re: [VOTE] cordova-cli@8.1.2 patch release

2018-10-05 Thread Oliver Salzburg
I vote +1 - Confirmed sigs & hashes with `coho verify-archive` [1] - Verified sha1s match tags with `coho verify-tags` - Checked out the branch and ran `npm test` - Continuous build was green when repo was tagged [1] The signature is a match, but I have not verified the signature yet. On 2018-10

Re: plugins release?

2018-10-16 Thread Oliver Salzburg
I believe the issue with the pending releases is not that nobody is performing the release task. There are still implementation details being worked on if I'm not mistaken. The next release will supposedly introduce several major breaking changes, which have to be prepared for thoroughly. On

Re: [cordova-tizen] support cordova-tizen

2018-10-19 Thread Oliver Salzburg
Hi Piotr, some of the more seasoned contributors can probably be of more help, but I would recommend joining the Cordova Slack http://slack.cordova.io/ for faster information exchange. I recommend the #dev channel ;) Cheers, Oliver On 2018-10-19 15:11, Piotr Kosko wrote: Hello, I am Tiz

Re: App Store rejection (Cordova IOS APP)

2018-10-29 Thread Oliver Salzburg
Can't confirm. Our app is going through just fine. On Mon, Oct 29, 2018, 03:38 Stephen Day wrote: > Hi All, > > I received the following app-store review rejection for an angular 6 app > wrapped in the Cordova framework with a splash screen: > > > > It appears Apple are rejecting Cordova apps in

Re: [DISCUSS] cordova-android@7.1.3 patch release, any objections?

2018-11-20 Thread Oliver Salzburg
Maybe it's time to get rid of the warning? It was confusing me as well when I first saw it and that was already quite some time ago. On Tue, Nov 20, 2018 at 6:38 PM gandhi rajan wrote: > Ya Jesse. While creating hello world app as mentioned in > > https://github.com/apache/cordova-coho/blob/mast

Re: [dev] Introduce ES6 classes or not?

2018-11-30 Thread Oliver Salzburg
I'm in favor of ES6 classes. But that doesn't mean that everything that _can_ be written with classes should. Pick the right tool for the job. While you can achieve the same object structure by just extending the prototype, classes have the benefit of keeping related code parts close to each

Re: Nomination for a new chair for Apache Cordova

2018-12-07 Thread Oliver Salzburg
+1 Thanks for everything! On Fri, Dec 7, 2018 at 10:22 AM Jan Piotrowski wrote: > +1 > > Thanks to you both! > Am Fr., 7. Dez. 2018 um 10:05 Uhr schrieb julio cesar sanchez > : > > > > +1 > > > > And thanks to you for all this years and to him for taking over > > > > El El vie, 7 dic 2018 a las

Re: [DISCUSS] Tools Release for Cordova 9

2018-12-19 Thread Oliver Salzburg
Are we getting cordova-serve#14 into this release? https://github.com/apache/cordova-serve/pull/14 On 2018-12-18 08:35, Bryan Ellis wrote: Does anyone have any reason to delay tools release? Any outstanding patches to land? I believe everything planned for the next major had been merged, and w

Re: [dev] some bad press

2019-01-25 Thread Oliver Salzburg
Why do you feel the need to be competitive? Isn't it enough to serve all the existing users that appreciate the framework as it is? Seems fine to me. And popularity is a pretty bad quality indicator IMHO, especially when the source is the SO community. On 2019-01-24 19:31, Chris Brody wrote:

Re: [Proposal] Supporting Proper DATA_URL for Camera plugin

2019-02-27 Thread Oliver Salzburg
I don't think the behavior should be changed. If anything, just introduce another type that has the prefix. And maybe add an alias for the existing type to make the differences clearer. On 27/02/2019 03:51, Hazem Saleh wrote: Hello Team, When calling navigator.camera.getPicture with destinati

Re: [Proposal] Supporting Proper DATA_URL for Camera plugin

2019-03-01 Thread Oliver Salzburg
release. It was called data url but it’s not a data url, that’s a bug that has become “feature”. I think we should have the new type but that returns current string and make data url return the real data url and document it on the breaking changes. El miércoles, 27 de febrero de 2019, Oliver

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Oliver Salzburg
I really think we should get #680[1] merged before the release. It should be good in a moment. [1]: https://github.com/apache/cordova-lib/pull/680 On 14/03/2019 07:31, Bryan Ellis wrote: Does anyone have any reason to delay the Cordova Lib release? Any outstanding patches to land? If not, I w

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Oliver Salzburg
schrieb Oliver Salzburg : I really think we should get #680[1] merged before the release. It should be good in a moment. [1]: https://github.com/apache/cordova-lib/pull/680 On 14/03/2019 07:31, Bryan Ellis wrote: Does anyone have any reason to delay the Cordova Lib release? Any outstanding patches

Re: [DISCUSS] non-global Cordova installs

2019-05-10 Thread Oliver Salzburg
npx ships with Node. On Fri, May 10, 2019, 00:33 Jesse wrote: > Hello Dmitry, > > In my mind, cordova-cli is intended to be installed globally, in situations > where that is not is possible we could *maybe* recommend that users use > npx, but I don't think it's a great experience. btw, npx need

Re: [DISCUSS] non-global Cordova installs

2019-05-10 Thread Oliver Salzburg
ems with npx not working after it was first added to node - so Julio's was indeed true in the past. Luckily it was fixed, so even we lowly Windows users now can use npx. Am Fr., 10. Mai 2019 um 09:48 Uhr schrieb Oliver Salzburg : npx ships with Node. On Fri, May 10, 2019, 00:33 Jesse wrote:

Re: [DISCUSS] non-global Cordova installs

2019-05-10 Thread Oliver Salzburg
t; On Fri, May 10, 2019 at 2:46 AM wrote: > >> Thanks for that structured write-up, Oliver. You saved me from writing all >> of that myself. >> >> +100 on all those points >> >> Oliver Salzburg schrieb am Fr., 10. Mai 2019, >> 11:01: >> >

Re: [DISCUSS] non-global Cordova installs

2019-05-10 Thread Oliver Salzburg
xes in the past. But I would rather take the > extra time and effort to ensure we keep up the best app DX we can. > > And I don't really follow what you mean about CORDOVA_CMDLINE, would > probably be easiest if we keep it in a separate discussion thread or > issue. > > On