Re: [VOTE] Camera Plugin Release 5.0.1

2020-11-08 Thread Bryan Ellis
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Niklas Merz * Tim Brust Negative Binding Votes: 0 The vote has passed. Thanks everyone! > On Nov 7, 2020, at 2:46, Tim Brust wrote: > > I vote +1: > > * changes make sense > * coho-verify archive > * npm a

Re: [DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-08 Thread Norman Breau
Testing the feature that was added, I observed some odd behaviour. I added the plugin with the --variable GPS_REQUIRED set to false. This works as expected, with the variable recorded in package.json and the AndroidManifest.xml containing the proper flag to signal that gps hardware is not requi

Re: [DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-08 Thread Bryan Ellis
I also agree that this issue is not related to the plugin and should not be a blocker for the release. With little digging into this issue, I want to say it might be an issue in Cordova Lib and maybe around munger. When you add the plugin, and review the contents of this file: */cordovaPlugin/pla