Testing the feature that was added, I observed some odd behaviour.
I added the plugin with the --variable GPS_REQUIRED set to false. This works as expected, with the variable recorded in package.json and the AndroidManifest.xml containing the proper flag to signal that gps hardware is not required. However, if I change the variable inside package.json from "false" to "true" and rerun prepare or build, the AndroidManifest.xml is not updated. The only way I can get AndroidManifest.xml to update properly is by removing the plugin and re-adding it with the updated variable. Is this intentional? Even if this is a bug, I don't think it's a bug inside this plugin so I don't think it's necessary to block the release or anything. Just simply pointing out a potential problem. On Nov 5 2020, at 11:32 pm, Bryan Ellis <er...@apache.org> wrote: > > This is an updated thread of the previous thread > https://lists.apache.org/thread.html/r431cbb7ae688285280e2cb0a92f88c241596960c0932c34ca45bd7b7%40%3Cdev.cordova.apache.org%3E > > <https://lists.apache.org/thread.html/r431cbb7ae688285280e2cb0a92f88c241596960c0932c34ca45bd7b7@%3Cdev.cordova.apache.org%3E> > The only exception is that it will prepare for the cordova-plugin-geolocation > 4.1.0 release instead.
