Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Chris Brody
Hi Tim Brust do you have time to look at this? I would like to get this published if possible. I keep running into the bug with WinJS when testing a commercial plugin update on Windows. On Wed, Dec 18, 2019 at 2:09 PM Tim Brust wrote: > I’ll try to take a look at it tomorrow (GMT+1) > Sorry for

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Bryan Ellis
Hi Brody, I reviewed the release but came across something inaccurate. The file in question is: https://github.com/apache/cordova-windows/blob/7.1.0/VERSION Please note that the file I am referencing above is from tag `7.1.0`. This is also in the `tar.gz` that is up for votes. The content of

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Bryan Ellis
Continuation: I have also discovered the content of the file: https://github.com/apache/cordova-windows/blob/7.1.0/template/cordova/version to also contain the incorrect version. On Fri, Dec 20, 2019 at 7:58 AM Bryan Ellis wrote: > Hi Brody, > > > I reviewed the release but came across so

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Bryan Ellis
Continuation: I have also noticed that there are changes to these files: - cordova-js-src/confighelper.js - cordova-js-src/exec.js - cordova-js-src/platform.js - cordova-js-src/splashscreen.js These changes should be reflected in `template/www/cordova.js` but it appears that the cord

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Chris Brody
Thanks Bryan. I tried to make cut a release with no more changes to cordova.js than had already been applied before. Reason is that I wanted to get it out the door with no more blockages than absolutely necessary. You are correct that the VERSION and template/cordova/version artifacts would need to

Nightly build #1269 for cordova has succeeded!

2019-12-19 Thread Apache Jenkins Server
Nightly build #1269 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/1269/consoleFull - Jenkins for Apache Cordova ---