Continuation: I have also noticed that there are changes to these files:
- cordova-js-src/confighelper.js - cordova-js-src/exec.js - cordova-js-src/platform.js - cordova-js-src/splashscreen.js These changes should be reflected in `template/www/cordova.js` but it appears that the cordova-js build process was skipped. Additionally, please note that when rebuilding, make sure that you are not using `cordova-js` master as it contains major breaking changes for the next major release. It would be recommended to check out `9c79667cd175f51fd2edf2dc91ac8be98b89076a` from `cordova-js` before creating the `windows-7.1.0` tag of cordova-js, and use that for the build. On Fri, Dec 20, 2019 at 8:02 AM Bryan Ellis <ellis.br...@gmail.com> wrote: > Continuation: > > > I have also discovered the content of the file: > > > https://github.com/apache/cordova-windows/blob/7.1.0/template/cordova/version > > > to also contain the incorrect version. > > > > On Fri, Dec 20, 2019 at 7:58 AM Bryan Ellis <ellis.br...@gmail.com> wrote: > >> Hi Brody, >> >> >> I reviewed the release but came across something inaccurate. >> >> >> The file in question is: >> >> https://github.com/apache/cordova-windows/blob/7.1.0/VERSION >> >> >> Please note that the file I am referencing above is from tag `7.1.0`. >> This is also in the `tar.gz` that is up for votes. The content of this file >> contains `7.1.0-dev` which is the incorrect version. >> >> >> This file needs to be either: >> >> A) fixed first before continuing the release >> >> B) confirmed that it is no longer used anywhere in code. >> >> >> If it can be confirmed that it is not used, we might be able to let it >> slide and remove the file in the next release. >> >> >> >> On Fri, Dec 20, 2019 at 4:18 AM Chris Brody <chris.br...@gmail.com> >> wrote: >> >>> Hi Tim Brust do you have time to look at this? >>> >>> I would like to get this published if possible. I keep running into the >>> bug >>> with WinJS when testing a commercial plugin update on Windows. >>> >>> On Wed, Dec 18, 2019 at 2:09 PM Tim Brust <timbrust3...@gmail.com> >>> wrote: >>> >>> > I’ll try to take a look at it tomorrow (GMT+1) >>> > Sorry for the delay! >>> > >>> > Sent from my iPhone >>> > >>> > > On 18. Dec 2019, at 7:07 PM, Chris Brody <chris.br...@gmail.com> >>> wrote: >>> > > >>> > > Any chance I can get a couple reviews on the VOTE thread? >>> > > >>> > >> On Thu, Dec 12, 2019 at 8:15 PM Chris Brody <chris.br...@gmail.com> >>> > wrote: >>> > >> >>> > >> As discussed and agreed in >>> > >> https://github.com/apache/cordova-windows/issues/341 I am now >>> taking >>> > >> cordova-windows@7.1.0 release over. >>> > >> >>> > >> Does anyone have any reason to delay this release? Any patches to >>> land? >>> > >> >>> > >> If not, I will make the release within the next day or early next >>> week. >>> > >> >>> > >>> On Tue, Jul 30, 2019 at 10:12 AM Chris Brody < >>> chris.br...@gmail.com> >>> > >>> wrote: >>> > >>> >>> > >>> Do we have a list of blocking issues? >>> > >>> >>> > >>> I think this release is badly needed since cordova-windows@latest >>> is >>> > >>> currently not working for me or others. >>> > >>> >>> > >>> Thanks in advance, >>> > >>> >>> > >>> Chris >>> > >>> >>> > >>> On Tue, Jul 30, 2019 at 6:00 AM Jan Piotrowski < >>> piotrow...@gmail.com> >>> > >> wrote: >>> > >>>> >>> > >>>> As I wrote in the initial email I am on this release. >>> > >>>> >>> > >>>> CI is green after some work, but there are still open issues or >>> > >>>> questions (e.g. >>> > >>>> >>> > >> >>> > >>> https://github.com/apache/cordova-windows/issues/357#issuecomment-511396401 >>> > >> ) >>> > >>>> or solved issues waiting for feedback from the initial reporter. >>> > >>>> >>> > >>>> J >>> > >>>> >>> > >>>> Am Di., 30. Juli 2019 um 05:26 Uhr schrieb Chris Brody < >>> > >> chris.br...@gmail.com>: >>> > >>>>> >>> > >>>>> I think this release should be made asap. Right now I have to do >>> > >>>>> something like cordova platform add windows@6 or cordova >>> platform >>> > >> add >>> > >>>>> github:apache/cordova-windows#master to get a working Windows >>> build >>> > >>>>> for testing. I got some documentation updates merged to make it >>> clear >>> > >>>>> that it will *not* work with Visual Studio 2019. >>> > >>>>> >>> > >>>>> I can make this release sometime in the next 1-2 weeks if nobody >>> else >>> > >>>>> wants to make it. >>> > >>>>> >>> > >>>>> Is there anything else blocking this release? >>> > >>>>> >>> > >>>>> Does any other committer have time to make this release this >>> week? >>> > >>>>> >>> > >>>>> On Fri, Jul 5, 2019 at 9:50 AM Tim Brust >>> > >>>>> <tim.br...@sinnerschrader.com.invalid> wrote: >>> > >>>>>> >>> > >>>>>> For the lazy ppl, here is the diff: >>> > >>>>>> >>> https://github.com/apache/cordova-windows/compare/7.0.0...master >>> > >>>>>> Go for it Jan! :) >>> > >>>>>> >>> > >>>>>> On Thu, Jul 4, 2019 at 5:51 PM Jan Piotrowski < >>> > >> piotrow...@gmail.com> wrote: >>> > >>>>>> >>> > >>>>>>> Does anyone have any reason to delay a cordova-windows platform >>> > >> release? >>> > >>>>>>> Any outstanding patches to land? >>> > >>>>>>> >>> > >>>>>>> If not, I will start the release soon. >>> > >>>>>>> >>> > >>>>>>> (CI is currently red, so this will require some investigation.) >>> > >>>>>>> >>> > >>>>>>> >>> > >> >>> --------------------------------------------------------------------- >>> > >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> > >>>>>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> > >>>>>>> >>> > >>>>>>> >>> > >>>>>> >>> > >>>>>> -- >>> > >>>>>> Tim Brust, Product Engineer >>> > >>>>>> >>> > >>>>>> tim.br...@sinnerschrader.com >>> > >>>>>> T +49 40 398855 315 >>> > >>>>>> >>> > >>>>>> SinnerSchrader Deutschland GmbH | SinnerSchrader Group >>> > >>>>>> Völckersstraße 38, 22765 Hamburg, Germany >>> > >>>>>> >>> > >>>>>> Amtsgericht Hamburg HRB-Nr. 63663 >>> > >>>>>> Geschäftsführer: Matthias Schrader (Sprecher), >>> > >>>>>> Jürgen Alker, Dr. Axel Averdung, Holger Blank, >>> > >>>>>> Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy >>> Hutchinson >>> > >>>>>> >>> > >>>>>> Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag >>> > >>>>>> >>> > >>>>>> https://www.sinnerschrader.com | NEXT AGENCY >>> > >>>>> >>> > >>>>> >>> --------------------------------------------------------------------- >>> > >>>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> > >>>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> > >>>>> >>> > >>>> >>> > >>>> >>> --------------------------------------------------------------------- >>> > >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> > >>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> > >>>> >>> > >> >>> > >>> > --------------------------------------------------------------------- >>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> > For additional commands, e-mail: dev-h...@cordova.apache.org >>> > >>> > >>> >>
