Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread Chris Brody
I do not think we should make a new cordova-android release before we can resolve https://github.com/apache/cordova-android/issues/508 I think it is a pretty bad bug. I would be happy to explain further if needed. On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis wrote: > Does anyone have any reason

Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread Jan Piotrowski
Is this a new bug introduced by the new code that would be released? If not, there is no reason to stop a release of that (good) code. As soon as a fix for this bug is available, we can release it as a follow up release (patch, minor, major - whatever appropriate). -J Am Fr., 18. Jan. 2019 um 13:

Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread Chris Brody
The bug was introduced by new code that was added to both master and 7.1.4. On 7.1.4 the issue is discussed in: https://github.com/apache/cordova-android/issues/599 I hope we can find a quick solution before we make the new release. Fixing the bug would introduce some kind of change in behavior,

Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread Chris Brody
I am investigating a quick solution for the bug, hope to have something today. On Fri, Jan 18, 2019, 8:42 AM Chris Brody The bug was introduced by new code that was added to both master and 7.1.4. > > On 7.1.4 the issue is discussed in: > https://github.com/apache/cordova-android/issues/599 > > I

Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread julio cesar sanchez
As it's going to be a major release, I think we should look a bit more into Android X before doing a major release, just in case we need to do major changes. In the issue related to Android X, I commented that we didn't have the gradle.properties file, but in the linked PR I saw it's going to be ge

Re: [DISCUSS] Cordova-Android Release

2019-01-18 Thread Chris Brody
I would agree with Julio that we should verify androidx support before we finish the next major release. I don't expect we will have to make any fixes on cordova-android for androidx support. Issues for reference: * https://github.com/apache/cordova/issues/69 * https://github.com/apache/cordova-and

Nightly build #975 for cordova has succeeded!

2019-01-18 Thread Apache Jenkins Server
Nightly build #975 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/975/consoleFull - Jenkins for Apache Cordova -