I would agree with Julio that we should verify androidx support before we finish the next major release. I don't expect we will have to make any fixes on cordova-android for androidx support. Issues for reference: * https://github.com/apache/cordova/issues/69 * https://github.com/apache/cordova-android/issues/565
I just raised WIP PR https://github.com/apache/cordova-android/pull/633 to resolve bug 508. I hope to fix the tests within the next 1-2 days. I think we should also try to resolve the following issues before the next major release: * https://github.com/apache/cordova-android/issues/629 - issue with Android Studio 3.2 & 3.3 * https://github.com/apache/cordova-android/issues/623 - fix logging of Java version (a PR was already proposed) I think it would be nice but not absolutely necessary to resolve the following issue as well: * https://github.com/apache/cordova-android/issues/617 - support ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now deprecated * https://github.com/apache/cordova-android/issues/634 - update Gradle classpath for Android Studio 3.3 * review & merge the following PRs: - https://github.com/apache/cordova-android/pull/632 - ignore more Gradle build artifacts in Android project - https://github.com/apache/cordova-android/pull/635 - ignore Android Studio .idea files in Android project On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <jcesarmob...@gmail.com> wrote: > As it's going to be a major release, I think we should look a bit more into > Android X before doing a major release, just in case we need to do major > changes. > In the issue related to Android X, I commented that we didn't have the > gradle.properties file, but in the linked PR I saw it's going to be > generated by the tooling now, so should be easier to just write to it with > whatever is needed, and probably make it opt-in for now as it's not clear > if using Android X will prevent old plugins from working. > Or is the gradle.properties file supposed to be managed by the user > somehow? > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<chris.br...@gmail.com>) > escribió: > > > I am investigating a quick solution for the bug, hope to have something > > today. > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.br...@gmail.com wrote: > > > > > The bug was introduced by new code that was added to both master and > > 7.1.4. > > > > > > On 7.1.4 the issue is discussed in: > > > https://github.com/apache/cordova-android/issues/599 > > > > > > I hope we can find a quick solution before we make the new release. > > > > > > Fixing the bug would introduce some kind of change in behavior, with a > > > possible risk that it would be a breaking change for someone else. > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <piotrow...@gmail.com> > > > wrote: > > > > > >> Is this a new bug introduced by the new code that would be released? > > >> If not, there is no reason to stop a release of that (good) code. As > > >> soon as a fix for this bug is available, we can release it as a follow > > >> up release (patch, minor, major - whatever appropriate). > > >> > > >> -J > > >> > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody < > > >> chris.br...@gmail.com>: > > >> > > > >> > I do not think we should make a new cordova-android release before > we > > >> can > > >> > resolve https://github.com/apache/cordova-android/issues/508 > > >> > > > >> > I think it is a pretty bad bug. I would be happy to explain further > if > > >> > needed. > > >> > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org> > > wrote: > > >> > > > >> > > Does anyone have any reason to delay a cordova-android platform > > >> release? > > >> > > Any outstanding patches to land? > > >> > > > > >> > > If not, I will start the release process shortly. > > >> > > > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > >> For additional commands, e-mail: dev-h...@cordova.apache.org > > >> > > >> > > >
