Re: CB-9762 iOS Launch Storyboard update

2016-09-13 Thread Shazron
We can either roll this in to cordova-ios 4.3.0 or cordova-ios 4.4.0. cordova-ios 4.3.0 has a new feature, CocoaPods support. On Sat, Sep 10, 2016 at 3:31 PM, Kerri Shotts wrote: > So, in playing around with my PR, I've discovered the following: > > - Travis CI fails because it is using Xcode 6

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Shazron
Bump. There can't be lazy consensus on this. Before I potentially waste time on drafting a proposal, trying to feel the temperature on this change. On Fri, Sep 9, 2016 at 3:34 PM, Shazron wrote: > It's up to us to decide, and right now we require the iCLA except for > trivial contributions. > >

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Jesse
+1 @purplecabbage risingj.com On Tue, Sep 13, 2016 at 10:27 AM, Shazron wrote: > Bump. There can't be lazy consensus on this. Before I potentially waste > time on drafting a proposal, trying to feel the temperature on this change. > > On Fri, Sep 9, 2016 at 3:34 PM, Shazron wrote: > > > It's

Re: [Discuss] Cordova-Android 6.0.x

2016-09-13 Thread Joe Bowser
OK, so it looks like all our ducks are lined up and we should be ready for a 6.0 release pretty soon. How do people feel about doing testing this week, and getting the vote thread going on Monday? I know the vote thread is only 72 hours, so I want a bit more testing on the major before we do it be

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Joe Bowser
I'll agree to this, since I don't know what the definition of trivial is w.r.t. Apache. +1 On Tue, Sep 13, 2016 at 10:30 AM, Jesse wrote: > +1 > > > @purplecabbage > risingj.com > > On Tue, Sep 13, 2016 at 10:27 AM, Shazron wrote: > > > Bump. There can't be lazy consensus on this. Before I pot

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Jesse
You decide per pr if you think it is trivial. @purplecabbage risingj.com On Tue, Sep 13, 2016 at 10:36 AM, Joe Bowser wrote: > I'll agree to this, since I don't know what the definition of trivial is > w.r.t. Apache. > > +1 > > On Tue, Sep 13, 2016 at 10:30 AM, Jesse wrote: > > > +1 > > > > >

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Jesse
Yes, that is the point. Sending a PR is intent! BUT if it is a large change, we need insurance that it is the work of the contributor, and not copy/pasted from somewhere else, and that they cannot retract it later. This is what the CLA offers us. Currently, as Shaz pointed out above, we state fir

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Joe Bowser
So, it's basically the same system that we have now. I still think we should get clear intent from the author, since that's more useful and easy than determining whether it's trivial. I mean, isn't sending a PR through GitHub already clear intent? On Tue, Sep 13, 2016 at 10:41 AM, Jesse wrote:

Regarding Cordova and Gamepad

2016-09-13 Thread iono sphere
I am developing a game using Construct 2 which could export the project to Cordova. Then, I could put the game into Crosswalk and play the game on my Android. My Construct 2 game supports gamepad, and this is the issue: While my HTML5 game could respond to gamepad input just fine on Desktop, I see

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Kerri Shotts
+1 ~ Kerri > On Sep 13, 2016, at 12:27, Shazron wrote: > > Bump. There can't be lazy consensus on this. Before I potentially waste > time on drafting a proposal, trying to feel the temperature on this change. > > On Fri, Sep 9, 2016 at 3:34 PM, Shazron wrote: > >> It's up to us to decide, an

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Shazron
An easy definition of trivial IMO is "if they decide to pull this code away from us, is it not a big deal?" The reasons why the code needs to be pulled, who knows what lurks in the minds of lawyers. Typos, doc changes, one liners, are not a big deal usually. On Tue, Sep 13, 2016 at 10:53 AM, Jess

Re: Regarding Cordova and Gamepad

2016-09-13 Thread Jesse
Yes, it is possible to implement this in cordova. However there are several synchronous apis that make this difficult. Also, FYI - windows universal supports the game pad api out of the box, no need to do anything. Cheers, Jesse @purplecabbage risingj.com On Tue, Sep 13, 2016 at 7:56 AM, ion

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Simon MacDonald
+1 to making it easier to allow people to contribute trivial changes. One thing Shaz just mentioned was adding a check box the the PR template so that people can explicitly indicate their intent. Eventually it would be nice to be able to digitally sign the CLA. Simon Mac Donald http://hi.im/simo

Re: Regarding Cordova and Gamepad

2016-09-13 Thread Joe Bowser
On Tue, Sep 13, 2016 at 7:56 AM, iono sphere <999ionosphe...@gmail.com> wrote: > I am developing a game using Construct 2 which could export the project to > Cordova. Then, I could put the game into Crosswalk and play the game on my > Android. My Construct 2 game supports gamepad, and this is the

Re: [Discuss] Cordova-Android 6.0.x

2016-09-13 Thread Simon MacDonald
I'd love to help out testing but I'm traveling all week. Happy to assist you next week with more testing if you can't find enough other folks to help out this week. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Sep 13, 2016 at 10:30 AM, Joe Bowser wrote: > OK, so it looks like all our d

Re: [Discuss] Cordova-Android 6.0.x

2016-09-13 Thread Darryl Pogue
Just wanted to check whether this cordova-lib change was intended to get pulled in as part of the Cordova Android 6 release: https://github.com/apache/cordova-lib/pull/469 If it is, I have an additional commit to add that fixes the JS spec tests: https://github.com/infil00p/cordova-lib/pull/1 On

Re: [Discuss] Cordova-Android 6.0.x

2016-09-13 Thread Joe Bowser
No, I have no intention of pulling that into this release, since the corresponding Android code caused performance issues due to numerous file reads. On Tue, Sep 13, 2016 at 11:21 AM, Darryl Pogue wrote: > Just wanted to check whether this cordova-lib change was intended to get > pulled in as pa

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-13 Thread Steven Gill
+1 On Tue, Sep 13, 2016 at 11:09 AM, Simon MacDonald wrote: > +1 to making it easier to allow people to contribute trivial changes. > > One thing Shaz just mentioned was adding a check box the the PR template so > that people can explicitly indicate their intent. > > Eventually it would be nice

[CORDOVA-LIB] CocoaPods CI testing stalled CB-11811

2016-09-13 Thread Shazron
See: https://issues.apache.org/jira/browse/CB-11811 Does anyone have experience with CocoaPods testing on Travis CI? Keep getting git errors no matter what I do. Doesn't help that for each test it needs to download the whole CocoaPods repo at ~500MB

Re: CB-9762 iOS Launch Storyboard update

2016-09-13 Thread Kerri Shotts
Meant to respond earlier, but was busy trying to get ready for iOS 10 on one of my native apps. Fun times! ;-) 4.3 is fine by me, although I’d appreciate a second set of eyes on the PR (https://github.com/apache/cordova-ios/pull/250/files) in case I’ve missed a case or if there are things that

Re: [Discuss] plugins release

2016-09-13 Thread Steven Gill
Bump! Please vote on the release On Thu, Sep 8, 2016 at 9:06 AM, Steven Gill wrote: > I can review and merge > > On Sep 8, 2016 9:00 AM, "David Barth" wrote: > >> Hey guys, >> >> Alex has a set of fixes for ubuntu code in the following plugins: >> >>- https://github.com/apache/cordova-plugi

[DRAFT] Apache Cordova Board Report for Sept 2016

2016-09-13 Thread Shazron
Please review, comment on it, etc: https://github.com/cordova/apache-board-reports/blob/master/2016/2016-09.md

Nightly build #145 for cordova has succeeded!

2016-09-13 Thread Apache Jenkins Server
Nightly build #145 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/145/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-docs issue #629: Update index.md according to CB-11705

2016-09-13 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/629 NOTE: Don't pull in until cordova-ios 4.3.0 has been released. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-docs pull request #633: Fix minor typo "fist" -> "first"

2016-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request #632: Moved 40px Spotlight Icon to iOS 7.0+

2016-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request #631: Added iPad Pro icon

2016-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/631 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i