RE: [Android] Refactoring for different engines

2014-04-23 Thread Tommy Williams
More engines, more better... On 23 Apr 2014 16:32, "Joe Bowser" wrote: > Hey > > A Hangout would have to happen on Friday at the earliest. It'd be good if > we could get someone from Mozilla on the hangout as well. I haven't gotten > MozillaView (GeckoView with Cordova methods) fully working ye

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Joe Bowser
I think I need to go into why I don't like "The Apache Way" from the view of the people that I actually care about, our users. The people who talk to me at conventions, and wonder why things are so slow, broken and stupid. 1. All communication on the e-mail list We've been breaking this one with

[GitHub] cordova-cli pull request: Revert "CB-6267 Windows8. Apply Backgrou...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-04-23 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/151#issuecomment-41141270 I've been working on some other stuff with cordova-mobile-spec, but I came back to this topic to deliver the pending changes removing callback functions, and use o

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-04-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41142820 Created a separate JIRA enhancement for 'multiple' option: https://issues.apache.org/jira/browse/CB-6499 --- If your project is set up for it,

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread James Jong
+1 to chair nomination for Shaz. He will do a great job. Let’s try and keep this on topic and move the Apache Way discussion to a separate thread. -James Jong On Apr 23, 2014, at 3:09 AM, Joe Bowser wrote: > I think I need to go into why I don't like "The Apache Way" from the > view of the pe

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Jim Jagielski
On Apr 23, 2014, at 3:09 AM, Joe Bowser wrote: > I think I need to go into why I don't like "The Apache Way" from the > view of the people that I actually care about, our users. The people > who talk to me at conventions, and wonder why things are so slow, > broken and stupid. > > 1. All commu

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Jim Jagielski
On Apr 22, 2014, at 9:21 PM, Joe Bowser wrote: > On Tue, Apr 22, 2014 at 6:17 PM, Andrew Grieve wrote: >> Joe - totally uncalled for. Not sure where it even came from. If you >> hate Apache so much, then why are you a *volunteer* on an Apache >> project? > > Because I like the Cordova project,

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Jim Jagielski
No worries :) On Apr 22, 2014, at 9:17 PM, Andrew Grieve wrote: > Joe - totally uncalled for. Not sure where it even came from. If you > hate Apache so much, then why are you a *volunteer* on an Apache > project? > > I'm fairly confident that there is not a good understanding of what it > means

Re: [DISCUSS] Plugin master branches

2014-04-23 Thread Michal Mocny
Also, it will only "break" new plugin installs. On Tue, Apr 22, 2014 at 9:55 PM, Ian Clelland wrote: > To be clear, this is just referring to Cordova CLI versions 3.0.0 - 3.0.4, > I think. By version 3.0.5, CLI had a dependency on plugman 0.10.0, which > included the "plugman-registry" branch. (

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Jim Jagielski
On Apr 22, 2014, at 10:36 PM, Brian LeRoux wrote: > Some of the Apache rules are build up of old > policy that has become meaningless ceremony. This is not true. If you can provide examples of such "meaningless ceremony" that still exists, please mention them. They will either get removed, fix

Re: [VOTE] Plugins Release

2014-04-23 Thread Carlos Santana
Steve is this doc/index.md same concept as npm README, when publishing put content inside bits being sent to registry but not the pacakge.json left on repo? On Tue, Apr 22, 2014 at 8:51 PM, Steven Gill wrote: > Ian, when you publish these to npm, could you use plugman master? I have > added so

[GitHub] cordova-cli pull request: CB-5833: Copy/link to custom merges and ...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/169#discussion_r1194 --- Diff: src/create.js --- @@ -124,9 +129,22 @@ module.exports = function create (dir, id, name, cfg) { } // Keep going into chi

[GitHub] cordova-cli pull request: CB-5833: Copy/link to custom merges and ...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/169#discussion_r11900183 --- Diff: src/create.js --- @@ -146,11 +170,20 @@ module.exports = function create (dir, id, name, cfg) { } else { shell.mkd

Re: Hooks

2014-04-23 Thread Michal Mocny
Looks good, but I think we should also import hooks/. Also, I think we could attempt a bit of a refactor of the implementation, but I'm happy to leave that for after we break out cordova-lib. On Tue, Apr 22, 2014 at 11:07 PM, Mark Koudritsky wrote: > Fixed it so that cordova doesn't complain a

[RESULT][VOTE] Plugins Release

2014-04-23 Thread Ian Clelland
The vote has now closed! The results are: Positive binding votes: Ian Clelland James Jong Marcel Kinard(*) Michal Mocny Positive non-binding votes: None Negative votes: None The vote has passed. * Marcel is a PMC member, according to the email archives, despite his LDAP status, and despite the

Re: [VOTE] Plugins Release

2014-04-23 Thread Steven Gill
Yes. But for plugins, we create the package.json file from plugin.XML at publish time and it gets deleted after a successful publish. On Apr 23, 2014 6:32 AM, "Carlos Santana" wrote: > Steve is this doc/index.md same concept as npm README, when publishing put > content inside bits being sent to r

Re: Generating configuration files

2014-04-23 Thread Carlos Santana
Cameron As Andrew suggested you can use that will copy the config.plist from your plugin into the the XCode project. Then end user will need to edit config.plist to add their API key If you want more automation cordova-cli/plugman can handle CLI Variables [1]. For example: cordova plugin add com

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Michal Mocny
Jesse, while the config.xml's share the same name, I think that input/output argument is invalid. All of: defaults.xml, plugin.xml, and application level config (sadly named config.xml) are all inputs with slightly different specs that produce several platform level configs (named config.xml) also

Re: ios-deploy vs libimobiledevice

2014-04-23 Thread Carlos Santana
+1 same a Brian, adding Homebrew is a barrier to some. we already requried npm git, lets not add, lets remove like we are doing with "git" by using npm for acquiring the platforms. And yes I have seen ios-deploy get more stable, and thanks to Shaz and others. Be worth looking into adopting ios-d

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Andrew Grieve
I like the idea! The main thing I don't like about , is that it already means something different in platform config.xml: This means that when JS makes an exec() for "LocalStorage", route it to "CDVLocalStorage". JS-only plugins don't inject , and does not contain plugin IDs.

Re: [Android] Refactoring for different engines

2014-04-23 Thread Andrew Grieve
Depends on their interest level I think. Faster we can get this out the door the better. If we need to delay for geckoview, then I don't think we should gate on it, just release it after. On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams wrote: > More engines, more better... > On 23 Apr 2014 16:32,

Re: [Android] Refactoring for different engines

2014-04-23 Thread Andrew Grieve
Does anyone have a contact at moz that we could invite? On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve wrote: > Depends on their interest level I think. Faster we can get this out > the door the better. If we need to delay for geckoview, then I don't > think we should gate on it, just release it

Re: [DISCUSS] Plugin master branches

2014-04-23 Thread Carlos Santana
+1 on using one branch "master" But, should we look into changing/enhancing the default behavior for "git" plugin install implementation to: if just a git url "https://github.com/apache/cordova-plugin-inappbrowser"; it will query the tags/releases, and not pull latest commit and instead pull down

Re: [Android] Refactoring for different engines

2014-04-23 Thread Brian LeRoux
Yup I'll track em down On Apr 23, 2014 7:17 AM, "Andrew Grieve" wrote: > Does anyone have a contact at moz that we could invite? > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve > wrote: > > Depends on their interest level I think. Faster we can get this out > > the door the better. If we nee

Problems with "The Apache Way" and ASF conduct (was Nomination for a new chair for Apache Cordova)

2014-04-23 Thread Joe Bowser
On Wed, Apr 23, 2014 at 6:12 AM, Jim Jagielski wrote: > > On Apr 23, 2014, at 3:09 AM, Joe Bowser wrote: > >> I think I need to go into why I don't like "The Apache Way" from the >> view of the people that I actually care about, our users. The people >> who talk to me at conventions, and wonder

Re: [DISCUSS] Plugin master branches

2014-04-23 Thread purplecabbage
> On Apr 23, 2014, at 7:16 AM, Carlos Santana wrote: > > +1 on using one branch "master" > > But, should we look into changing/enhancing the default behavior for "git" > plugin install implementation to: > > if just a git url "https://github.com/apache/cordova-plugin-inappbrowser"; > it will q

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Michal Mocny
On topic: Big +1 to Shaz, a perfect fit. Also, thank you Brian for your efforts over the years and your work bringing the project through incubation. Thank you also for taking the decision to pass the torch. Off topic: Joe and Jim, please may you each put up email filters for the others' comment

Re: Problems with "The Apache Way" and ASF conduct (was Nomination for a new chair for Apache Cordova)

2014-04-23 Thread Jim Jagielski
I'm not feeding the troll. Contact me off-list if you are serious about wanting true answers to these questions. On Apr 23, 2014, at 10:36 AM, Joe Bowser wrote: > On Wed, Apr 23, 2014 at 6:12 AM, Jim Jagielski wrote: >> >> On Apr 23, 2014, at 3:09 AM, Joe Bowser wrote: >> >>> I think I need

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-04-23 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41175017 Seems we are good now. @purplecabbage, @shazron is there anything else required before we can merge this? --- If your project is set up for it, you ca

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Mike Billau
Thanks a lot Brian for driving the project and always trying to do what's best for the community and the developers! Where's the beer fund I can donate to? ;D +1 Shaz if he is willing! On Wed, Apr 23, 2014 at 10:40 AM, Michal Mocny wrote: > On topic: Big +1 to Shaz, a perfect fit. Also, thank

RE: [REVIEW] Blog post for plugins release

2014-04-23 Thread Parashuram Narasimhan (MS OPEN TECH)
The Jira links seem to be broken. Not sure if that is due to the gist, or if they are really broken. -Original Message- From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of Ian Clelland Sent: Wednesday, April 23, 2014 8:28 AM To: dev@cordova.apache.org Subject: [REVIEW

[REVIEW] Blog post for plugins release

2014-04-23 Thread Ian Clelland
I've put up a draft blog post here: https://gist.github.com/clelland/6cf7cefcbb86f9b9d115 (Gist for easy markdown support) Please review and comment, and we can get these plugins out the door! Ian

Re: [REVIEW] Blog post for plugins release

2014-04-23 Thread Shazron
Looks like viewing the raw output "browser" in the links should be "browse" On Wed, Apr 23, 2014 at 8:34 AM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > The Jira links seem to be broken. Not sure if that is due to the gist, or > if they are really broken. > > -Ori

Re: [REVIEW] Blog post for plugins release

2014-04-23 Thread Ian Clelland
On Wed, Apr 23, 2014 at 11:34 AM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > The Jira links seem to be broken. Not sure if that is due to the gist, or > if they are really broken. > Nope -- that was me :) (too quick to type an 'r' after "browse") I've fixed that in t

[GitHub] cordova-plugman pull request: CB-6188 Spelling fixes

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-23 Thread Parashuram Narasimhan (MS OPEN TECH)
Ripple is critical for the Windows eco system as it give us a great way to try our and build for multiple platforms. There are also multiple tools and IDEs for Cordova that use Ripple as a way to test the deployments. We have an open pull request and are also working on another set of pull req

[GitHub] cordova-cli pull request: CB-5093 versionCode attr support added t...

2014-04-23 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-cli/pull/116#issuecomment-41177828 Support for this just landed! woohoo! https://issues.apache.org/jira/browse/CB-5093 Will be out in the next release. --- If your project is set up for i

[GitHub] cordova-cli pull request: CB-5847 strictSSL is no longer ignored

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6432 pre_package hook does not popula...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-cli/pull/164#issuecomment-41180908 Thanks for the patch. I've created an issue for this: https://issues.apache.org/jira/browse/CB-6501 --- If your project is set up for it, you can reply to t

Setting android launchMode via CLI

2014-04-23 Thread Andrew Grieve
https://github.com/apache/cordova-cli/pull/164 Seems great. Only thing I'm wondering is we should call it "androidLaunchMode" instead of "launchMode". Any objections?

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Michal Mocny
Actually I don't think of platforms as dependencies. Your app doesn't need android to run on iOS. It needs plugins. Plugin deps may be specific to certain platforms, but platforms are targets. So I think dependency is not ambiguous with platforms.. Though your app may have more deps than just Cord

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread purplecabbage
Can we see a mock version of what this all would like in either case? I also withdraw my previous +1 for after Michal's clarification. Sent from my iPhone > On Apr 23, 2014, at 9:03 AM, Michal Mocny wrote: > > Actually I don't think of platforms as dependencies. Your app doesn't need > androi

Re: Setting android launchMode via CLI

2014-04-23 Thread Joe Bowser
Does this exist on any other platform? If not, I'm cool with calling it androidLaunchMode. On Wed, Apr 23, 2014 at 9:13 AM, Andrew Grieve wrote: > https://github.com/apache/cordova-cli/pull/164 > > Seems great. Only thing I'm wondering is we should call it > "androidLaunchMode" instead of "launch

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Carlos Santana
+1 on Shaz if he wants to do it. I hope he has the bandwidth to continue his awesome technical contributions also. I tip my hat to Brian for tremendous leadership in this community that is not just an open source project is a philosophy on what we believe as a community and and willing to dedicat

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-04-23 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-cli/pull/151#issuecomment-41184231 Merged. I did a clean-up commit along with it that you can see here: https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=blobdiff;f=src/info.js;h=c8b8e248

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-04-23 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/151#issuecomment-41187328 Ok, I've see what you've done with it, it's Ok, I tried to keep it consistent as you recommend. Didn't knew about process.version, neither about package.version.

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11911266 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set l

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11911288 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set l

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11911345 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set l

Re: Setting android launchMode via CLI

2014-04-23 Thread Michal Mocny
Comments inline in patch. On Wed, Apr 23, 2014 at 12:23 PM, Joe Bowser wrote: > Does this exist on any other platform? If not, I'm cool with calling > it androidLaunchMode. > > On Wed, Apr 23, 2014 at 9:13 AM, Andrew Grieve > wrote: > > https://github.com/apache/cordova-cli/pull/164 > > > > Se

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Michal Mocny
Gorkem has an initial implementation posted here: https://github.com/apache/cordova-cli/pull/165 -- but its missing a change previously discussed to support explicit "cordova restore" instead of auto-restore-on-prepare. He also made us a video: https://www.youtube.com/watch?v=bc60WAQdOjE The synt

Re: [Android] Refactoring for different engines

2014-04-23 Thread Ian Clelland
I've managed to get this up and running now -- great work on this, Joe! Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well. I used a new build of Crosswalk, and found that the embedding API has changed since the wee

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-04-23 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-cli/pull/151#issuecomment-41190420 Unless there are functions that will be used by other files as well, keep it in one file. --- If your project is set up for it, you can reply to this email and have

Re: [REVIEW] Blog post for plugins release

2014-04-23 Thread Andrew Grieve
Looks great. Only nit is toURI -> toURL On Wed, Apr 23, 2014 at 11:37 AM, Ian Clelland wrote: > On Wed, Apr 23, 2014 at 11:34 AM, Parashuram Narasimhan (MS OPEN TECH) < > panar...@microsoft.com> wrote: > >> The Jira links seem to be broken. Not sure if that is due to the gist, or >> if they are r

Re: [Android] Refactoring for different engines

2014-04-23 Thread Joe Bowser
Sounds good. It really should create its own WebViewClient and WebChromeClients when they exist. I'll pull them into the repo later today. I also have to remove the dependency to xwalk_library from Cordova itself, since that's breaking the compile step on my work with Gecko. (Weird DEX Braille

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-04-23 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/151#issuecomment-41192677 Ok, I got it, thanks Andrew, have a nice day. 2014-04-23 12:30 GMT-05:00 agrieve : > Unless there are functions that will be used by other fil

Re: [Android] Refactoring for different engines

2014-04-23 Thread Brian LeRoux
So I found a Moz hacker whom can help. what time on Fri do you guys want to do this? On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland wrote: > I've managed to get this up and running now -- great work on this, Joe! > > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in > file-tra

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41192886 The title on the commit was what it does, not why. Can see if pull requests can have different titles (I think github automatically sets to comm

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Gorkem Ercan
On Wed, Apr 23, 2014 at 1:26 PM, Michal Mocny wrote: > Gorkem has an initial implementation posted here: > https://github.com/apache/cordova-cli/pull/165 -- but its missing a change > previously discussed to support explicit "cordova restore" instead of > auto-restore-on-prepare. He also made us

Re: [REVIEW] Blog post for plugins release

2014-04-23 Thread Mike Billau
Looks great Ian, no nitpicks that Josh hasn't already pointed out on the gist. Including the curated list of plugin changes is awesome. (BTW did you generate that with coho?) On Wed, Apr 23, 2014 at 1:38 PM, Andrew Grieve wrote: > Looks great. Only nit is toURI -> toURL > > On Wed, Apr 23, 20

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41194815 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Andrew Grieve
On Wed, Apr 23, 2014 at 1:51 PM, Gorkem Ercan wrote: > On Wed, Apr 23, 2014 at 1:26 PM, Michal Mocny wrote: > >> Gorkem has an initial implementation posted here: >> https://github.com/apache/cordova-cli/pull/165 -- but its missing a change >> previously discussed to support explicit "cordova res

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41195514 Of course "why" matters, especially to a committer (the code already is "how"). There is absolutely no reason to add code that you don't understand w

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread sebb
On 22 April 2014 22:34, Brian LeRoux wrote: > Hello Cordova community. To this point I've served as the chair for the > Cordova PMC. > > The duties of chair are solely administrative: board reports, and book > keeping of committer nominations. Some projects at Apache have more formal > incantation

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Joe Bowser
OK, hell has frozen over. Thanks sebb for that! That's actually insane that you can't quit until the meeting. You can normally resign a post by writing a resignation letter in most places. Why is this? On Wed, Apr 23, 2014 at 11:13 AM, sebb wrote: > On 22 April 2014 22:34, Brian LeRoux wrot

[Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Martin Gonzalez Glez
Hi guys, As code contributor, I've been receiving feedback, comments, advice and more from the commiters. Part of the received feedback is about the Cordova code style, best practices, and preferences about how to contribute code to the project, which existing APIs to use, and more. Because of th

Re: [REVIEW] Blog post for plugins release

2014-04-23 Thread Ian Clelland
The plugin release process doc uses a bit of shell logic combined with "git log" to update the release notes; I modified that to print out a complete list, and then curated by hand. I'm updating the release docs as I go through the steps, so I'll make sure that that snippet is in there. for l

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Brian LeRoux
I mentioned that I would formally notify the board in which I was referencing this policy. =| On Wed, Apr 23, 2014 at 11:17 AM, Joe Bowser wrote: > OK, hell has frozen over. Thanks sebb for that! > > That's actually insane that you can't quit until the meeting. You can > normally resign a pos

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Shazron
I'll add this to the wiki, but putting it out here as well for the other platforms/plugins: cordova-ios uses uncrustify in a pre-commit hook: https://github.com/apache/cordova-ios/tree/master/hooks that needs to be added on a per clone basis. Saves me a lot of time when I do my own commits. It can

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41198810 of course you wouldn't pull it in without understanding "why", but I would not ever expect reading the commit message alone to explain the "wh

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r11916904 --- Diff: plugin.xml --- @@ -2,7 +2,7 @@ http://apache.org/cordova/ns/plugins/1.0"; xmlns:android="http://schemas.and

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41199740 @machenmusik file an issue at https://issues.apache.org/jira/browse/CB, and get the issue number in the form of CB-. Edit the title of this PR to

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-inappbrowser pull request: CB-6360: Fix for crash o...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Marvin Humphrey
On Wed, Apr 23, 2014 at 11:17 AM, Joe Bowser wrote: > That's actually insane that you can't quit until the meeting. You can > normally resign a post by writing a resignation letter in most places. > Why is this? Brian could resign, but that would leave a vacancy until the Board passes a resoluti

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41202400 @jesse the version change was just so one could tell version I was using a modified version. (mac being my initials) I assume you would c

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41202671 @machenmusik the sign up is confusing. You have to click Log In to see the sign up link: https://issues.apache.org/jira/secure/Signup!default.jspa

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41203933 @jesse was able to edit out the version change here. @shazron done but manually, no automagical linking detected :-/ --- If your project is

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204117 Thanks! Appreciate your contrib and you filing the issue. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204151 Thanks. The automagical link is just when the pull request is merged into master, the jira issue gets updated with the commit.

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204431 Actually, I was correct. When you edited the title to include the issue id, and then commented, see what happened: https://issues.apache.org/jira/br

[GitHub] cordova-mobile-spec pull request: Fixing firefoxos spec

2014-04-23 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/56 Fixing firefoxos spec Added firefoxos platform and fixed cordova-incl.js to work on firefoxos. You can merge this pull request into a Git repository by running: $ git pull https://g

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41205346 I was expecting for example that it would actually include the (more descriptive) JIRA issue title if I just said CB-6503 to avoid useless cut

[GitHub] cordova-mobile-spec pull request: Fixing firefoxos spec

2014-04-23 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/56#issuecomment-41205846 confirmed - this fixes mobilespec on Firefox OS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Marcel Kinard
+1 to Shaz in the PMC Chair role. Brian, you've done a tremendous job helping to build the community and contribute to the direction. I hope that doesn't change! I got to meet Jim and other board members at ApacheCon a couple weeks ago. My takeaway is that they are super nice people, very reaso

[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/23#issuecomment-41207048 Hi @vladimir-kotikov I have added a comment in Jira here : https://issues.apache.org/jira/browse/CB-6266?focusedCommentId=13978791&page=com.atlassia

Problem publishing plugins (was: [VOTE] Plugins Release)

2014-04-23 Thread Ian Clelland
Steve -- I just tried to publish with 'plugman publish .' from each plugin directory, as the release docs say to do. Each plugin claimed that it was published (taking 10-20 seconds each, so it appeared to be doing *something*) I don't see the updated plugins on plugins.cordova.io, though -- is th

[GitHub] cordova-cli pull request: Fix for issue CB-3191

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Response the correct content type

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Add CORDOVA_HOME environment var

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-2606, CB-3571 Add support for ,...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: 3.0.x Unable to do anything with CLI cor...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Blackberry Fixes

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugman pull request: Updated amazon-fireos as a platform.

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

  1   2   >