Re: [VOTE] cordova-plugin-inappbrowser 4.0.0 release

2020-06-12 Thread Niklas Merz
The vote has now closed. The results are: Positive Binding Votes: 3 Niklas Merz Norman Breau Tim Brust Negative Binding Votes: 0 The vote has passed. Am 12.06.20 um 18:38 schrieb Tim Brust: > Thanks for taking care of this release, Niklas. > > I vote +1: > - Changes make sense ( > https://gi

Re: [VOTE] cordova-plugin-inappbrowser 4.0.0 release

2020-06-12 Thread Tim Brust
Thanks for taking care of this release, Niklas. I vote +1: - Changes make sense ( https://github.com/apache/cordova-plugin-inappbrowser/compare/3.2.0...4.0.0) - Tested our existing iOS app with cordova-ios@5.1.1 - works fine - Tested a new hello world app with cordova-ios@6.0.0 - works fine - ✅ co

Re: [VOTE] cordova-plugin-inappbrowser 4.0.0 release

2020-06-12 Thread Norman Breau
I vote +1: * Ran verify-tags * Ran verify-archive * Ran npm test locally * AppVeyor/Travis is currently green On 2020/06/09 17:24:37, Niklas Merz wrote: > Please review and vote on the release of this plugin release> > by replying to this email (and keep discussion on the DISCUSS thread)> > > T