The vote has now closed. The results are: Positive Binding Votes: 3
Niklas Merz Norman Breau Tim Brust Negative Binding Votes: 0 The vote has passed. Am 12.06.20 um 18:38 schrieb Tim Brust: > Thanks for taking care of this release, Niklas. > > I vote +1: > - Changes make sense ( > https://github.com/apache/cordova-plugin-inappbrowser/compare/3.2.0...4.0.0) > - Tested our existing iOS app with cordova-ios@5.1.1 - works fine > - Tested a new hello world app with cordova-ios@6.0.0 - works fine > - ✅ coho verify-archive cordova-plugin-inappbrowser-4.0.0.tgz > - ✅ npm audit > - ✅ npm test > > On Tue, Jun 9, 2020 at 7:24 PM Niklas Merz <niklasm...@apache.org> wrote: > >> Please review and vote on the release of this plugin release >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> The plugin has been published to dist/dev: >> >> https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-4.0.0/ >> >> The packages were published from their corresponding git tags: >> cordova-plugin-inappbrowser: 4.0.0 (d2b512ed04) >> >> Releasenotes: >> >> https://github.com/apache/cordova-plugin-inappbrowser/blob/master/RELEASENOTES.md#400-jun-09-2020 >> >> Upon a successful vote I will upload the archives to dist/, upload them >> to npm, and post the corresponding blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> How to vote on a plugins release at >> >> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting >> >> Please check the release blog post, too: >> https://github.com/apache/cordova-docs/pull/1085 >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and subdependencies >> have Apache-compatible licenses >> * Ensured continuous build was green when repos were tagged >> * Checked for existence of LICENSE and NOTICE files >> * npm audit green >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
