Re: [VOTE] Cordova Plugin InAppBrowser Minor Release 3.2.0

2020-01-05 Thread Chris Brody
+1 I tested from master branch on GitHub using https://github.com/dpa99c/cordova-plugin-inappbrowser-test (which should have the exact same behavior as proposed release 3.2.0) Basic InAppBrowser functionality works on Android and iOS I checked that the git tag is consistent. On Sat, Jan 4, 202

Re: [VOTE] Cordova Plugin InAppBrowser Minor Release 3.2.0

2020-01-04 Thread Niklas Merz
Hi Julian, Thank you for your quick and profoundly vote. I really appreciate your input from a perspective from other PMCs. Let me address your points below: > Hi Niklas, > > First, congratulations to starting your first Apache Release : ) > Of course, I took the time to check it. > > My Vote i

Re: [VOTE] Cordova Plugin InAppBrowser Minor Release 3.2.0

2020-01-04 Thread Julian Feinauer
Hi Niklas, First, congratulations to starting your first Apache Release : ) Of course, I took the time to check it. My Vote is +0 (non-binding) as I found some issues that are minor / medium. Probably some of these things are historically handled differently in the Cordova project and of course