+1 I tested from master branch on GitHub using https://github.com/dpa99c/cordova-plugin-inappbrowser-test
(which should have the exact same behavior as proposed release 3.2.0) Basic InAppBrowser functionality works on Android and iOS I checked that the git tag is consistent. On Sat, Jan 4, 2020 at 5:32 AM Niklas Merz <niklasm...@apache.org> wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugin has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-3.2.0/ > > The package was published from their corresponding git tags: > cordova-plugin-inappbrowser: 3.2.0 (2cd868e99f) > > A quick review of the release notes would be much appreciated as well: > https://github.com/apache/cordova-docs/pull/1049 > > Upon a successful vote I will upload the archives to dist/, upload them > to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * No NPM audit warnings > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Checked continuous build > * Did tests with an app that uses InAppBrowser and WKWebViewOnly > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
