Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-21 Thread Chris Brody
I have now closed the 7.1.0 vote with -1. I have also removed the 7.1.0 tag from cordova-windows on GitHub and replaced it with this tag: *7.1.0-first-attempt-rejected* Since I did not yet push the changes to master, I would like to make a new 7.1.0 release of cordova-windows. Removing the rejecte

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-21 Thread Chris Brody
I think I will have to close out the VOTE with a -1 due to the issues raised by Bryan Ellis. This means that I will have to build another new release of cordova-windows and go back through the VOTE process again. This is very unfortunate since the most recent cordova-windows release from 9 months

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Chris Brody
Thanks Bryan. I tried to make cut a release with no more changes to cordova.js than had already been applied before. Reason is that I wanted to get it out the door with no more blockages than absolutely necessary. You are correct that the VERSION and template/cordova/version artifacts would need to

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Bryan Ellis
Continuation: I have also noticed that there are changes to these files: - cordova-js-src/confighelper.js - cordova-js-src/exec.js - cordova-js-src/platform.js - cordova-js-src/splashscreen.js These changes should be reflected in `template/www/cordova.js` but it appears that the cord

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Bryan Ellis
Continuation: I have also discovered the content of the file: https://github.com/apache/cordova-windows/blob/7.1.0/template/cordova/version to also contain the incorrect version. On Fri, Dec 20, 2019 at 7:58 AM Bryan Ellis wrote: > Hi Brody, > > > I reviewed the release but came across so

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Bryan Ellis
Hi Brody, I reviewed the release but came across something inaccurate. The file in question is: https://github.com/apache/cordova-windows/blob/7.1.0/VERSION Please note that the file I am referencing above is from tag `7.1.0`. This is also in the `tar.gz` that is up for votes. The content of

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-19 Thread Chris Brody
Hi Tim Brust do you have time to look at this? I would like to get this published if possible. I keep running into the bug with WinJS when testing a commercial plugin update on Windows. On Wed, Dec 18, 2019 at 2:09 PM Tim Brust wrote: > I’ll try to take a look at it tomorrow (GMT+1) > Sorry for

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-18 Thread Tim Brust
I’ll try to take a look at it tomorrow (GMT+1) Sorry for the delay! Sent from my iPhone > On 18. Dec 2019, at 7:07 PM, Chris Brody wrote: > > Any chance I can get a couple reviews on the VOTE thread? > >> On Thu, Dec 12, 2019 at 8:15 PM Chris Brody wrote: >> >> As discussed and agreed in >>

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-18 Thread Chris Brody
Any chance I can get a couple reviews on the VOTE thread? On Thu, Dec 12, 2019 at 8:15 PM Chris Brody wrote: > As discussed and agreed in > https://github.com/apache/cordova-windows/issues/341 I am now taking > cordova-windows@7.1.0 release over. > > Does anyone have any reason to delay this re

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-12-12 Thread Chris Brody
As discussed and agreed in https://github.com/apache/cordova-windows/issues/341 I am now taking cordova-windows@7.1.0 release over. Does anyone have any reason to delay this release? Any patches to land? If not, I will make the release within the next day or early next week. On Tue, Jul 30, 201

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-07-30 Thread Chris Brody
Do we have a list of blocking issues? I think this release is badly needed since cordova-windows@latest is currently not working for me or others. Thanks in advance, Chris On Tue, Jul 30, 2019 at 6:00 AM Jan Piotrowski wrote: > > As I wrote in the initial email I am on this release. > > CI is

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-07-30 Thread Jan Piotrowski
As I wrote in the initial email I am on this release. CI is green after some work, but there are still open issues or questions (e.g. https://github.com/apache/cordova-windows/issues/357#issuecomment-511396401) or solved issues waiting for feedback from the initial reporter. J Am Di., 30. Juli 2

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-07-29 Thread Niklas Merz
Ich hab's. Danke! Am 30. Juli 2019, 05:28, um 05:28, Chris Brody schrieb: >I think this release should be made asap. Right now I >have to dosomething like cordova platform add windows@6 or >cordova platform addgithub:apache/cordova-windows#master to get a >working Windows buildfor testing. I go

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-07-29 Thread Chris Brody
I think this release should be made asap. Right now I have to do something like cordova platform add windows@6 or cordova platform add github:apache/cordova-windows#master to get a working Windows build for testing. I got some documentation updates merged to make it clear that it will *not* work wi

Re: [DISCUSS] Cordova Windows Release 7.1.0

2019-07-05 Thread Tim Brust
For the lazy ppl, here is the diff: https://github.com/apache/cordova-windows/compare/7.0.0...master Go for it Jan! :) On Thu, Jul 4, 2019 at 5:51 PM Jan Piotrowski wrote: > Does anyone have any reason to delay a cordova-windows platform release? > Any outstanding patches to land? > > If not, I