Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-04 Thread Niklas Merz
The vote has now closed. The results are: Positive Binding Votes: 3 Niklas Merz Norman Breau Darryl Pogue Negative Binding Votes: 0 One remark about the release process from Chris Brody The vote has passed. Am 03.02.21 um 16:46 schrieb Darryl Pogue: > +1 > > * Confirmed sigs & hashes with `

Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-03 Thread Norman Breau
+1 * Manual test run by installing on one of my apps * Verified archive with coho * Verified tags with coho * Ran npm test successfully On 2021-02-01 2:35 p.m., Chris Brody wrote: Approved with the following nit: I noticed that for some reason, the 6.2.0 tag is *not* on the master branch. I r

Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-03 Thread Darryl Pogue
+1 * Confirmed sigs & hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` * Verified tests pass On Mon, Feb 1, 2021 at 10:24 AM Niklas Merz wrote: > > Sending again and hopefully now the line breaks work. > > Please review and vote on this 6.2.0 cordova-ios rele

Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-01 Thread Chris Brody
Approved with the following nit: I noticed that for some reason, the 6.2.0 tag is *not* on the master branch. I recall this happening in the past and am definitely aware that this happens due to the way that cordova-coho works. I sincerely hope that steps will be taken to keep major and minor re

Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-01 Thread Niklas Merz
Sending again and hopefully now the line breaks work. Please review and vote on this 6.2.0 cordova-ios release by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-ios-6.2.0/ The p

[VOTE] cordova-ios 6.2.0 Release

2021-02-01 Thread Niklas Merz
|Please review and vote on this 6.2.0 cordova-ios release by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-ios-6.2.0/ The package was published from its corresponding git tag: cor