Re: [DISCUSS] cordova-plugin-inappbrowser 3.2.0 minor release

2020-01-04 Thread Niklas Merz
The releasenotes are ready https://github.com/apache/cordova-plugin-inappbrowser/blob/master/RELEASENOTES.md#320-jan-04-2020 Am 04.01.20 um 09:00 schrieb Niklas Merz: > I am starting the release NOW. > > Am 02.01.20 um 23:13 schrieb Niklas Merz: >> Thank you Chris for your review. Please see belo

Re: [DISCUSS] cordova-plugin-inappbrowser 3.2.0 minor release

2020-01-04 Thread Niklas Merz
I am starting the release NOW. Am 02.01.20 um 23:13 schrieb Niklas Merz: > Thank you Chris for your review. Please see below: > >> I would favor unblocking 3.2.0 by merging PR #584 and leaving PR #503 for >> another release. (#503 looks like a minor improvement that not many people >> are waiting

Re: [DISCUSS] cordova-plugin-inappbrowser 3.2.0 minor release

2020-01-02 Thread Niklas Merz
Thank you Chris for your review. Please see below: > I would favor unblocking 3.2.0 by merging PR #584 and leaving PR #503 for > another release. (#503 looks like a minor improvement that not many people > are waiting for.) Good point. I added #503, because it looked like a trivial change to me w

Re: [DISCUSS] cordova-plugin-inappbrowser 3.2.0 minor release

2020-01-02 Thread Chris Brody
I would favor unblocking 3.2.0 by merging PR #584 and leaving PR #503 for another release. (#503 looks like a minor improvement that not many people are waiting for.) would be happy to give the new release a try in Dave Alden's inappbrowser test app, cannot promise I will get very far with it. A

[DISCUSS] cordova-plugin-inappbrowser 3.2.0 minor release

2020-01-02 Thread Niklas Merz
Hello everyone, I would like to do my very first release with the inappbrowser plugin. I think this plugin needs a minor release soon because users are waiting for important patches [1] and [2] to be released. This should be a minor release since this version aims to support the "WKWebViewOnly" f