I would favor unblocking 3.2.0 by merging PR #584 and leaving PR #503 for another release. (#503 looks like a minor improvement that not many people are waiting for.)
would be happy to give the new release a try in Dave Alden's inappbrowser test app, cannot promise I will get very far with it. A couple of side points that may be a little off topic: In case we need to apply non-trivial fixes to an external contribution before merging, I generally like to open a new PR that closes the original PR. Dave Alden's test app seems to be great at what we need but I did not see much documentation. I would like to give it a try sometime, may contribute some documentation for the benefit of other IAB n00bies. I am also wondering if we should consider bringing the IAB test app into our Cordova, with dpa's blessing of course. On Thu, Jan 2, 2020 at 3:58 PM Niklas Merz <niklasm...@apache.org> wrote: > Hello everyone, > > I would like to do my very first release with the inappbrowser plugin. > > I think this plugin needs a minor release soon because users are waiting > for important patches [1] and [2] to be released. This should be a minor > release since this version aims to support the "WKWebViewOnly" flag from > cordova-ios@5.1.0. > > All PRs in this release should be tracked in the milestone for 3.2.0 > [3]. I would appreciate any additional reviews for the two open PRs. > They look good and ready to be merged to me. > > Any outstanding patches to land? > > If not, I would merge the outstanding PRs and start the release on > Saturday. If somebody has any objections please let me know in this thread. > > This is my first Apache release and I am trying to follow the documented > process, but please let me know if I do anything wrong or forget something. > > Thank you for on-boarding me and I am looking forward to do this release. > > Regards > Niklas > > [1]https://github.com/apache/cordova-plugin-inappbrowser/pull/534 > [2]https://github.com/apache/cordova-plugin-inappbrowser/pull/584 > > [3]https://github.com/apache/cordova-plugin-inappbrowser/milestone/2 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
