Re: [DISCUSS] cordova-common@3.1.0 tools release

2018-12-25 Thread Chris Brody
I would agree that there is no new API or consumer-visible change in behavior. I thought it would be good to increase the minor version since the change in internal behavior made the internal packaging rule no longer needed. Maybe I was wrong, would like to continue with the release if we do not id

Re: [DISCUSS] cordova-common@3.1.0 tools release

2018-12-24 Thread Darryl Pogue
Probably late to be asking this question now, but what necessitates a minor version bump rather than a patch release? I don't think either of the two items in the changelog add new API to the module or change behaviour in a consumer-visible way, do they? On Tue, Dec 18, 2018 at 7:38 PM Chris Brody

[DISCUSS] cordova-common@3.1.0 tools release

2018-12-18 Thread Chris Brody
to include singleton event object as proposed in https://github.com/apache/cordova-common/pull/60 and CordovaLogger singleton object, in order that this rule no longer has to apply: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#cordova-common-singleton-rule Does