I would agree that there is no new API or consumer-visible change in behavior. I thought it would be good to increase the minor version since the change in internal behavior made the internal packaging rule no longer needed. Maybe I was wrong, would like to continue with the release if we do not identify any major issues.
On Mon, Dec 24, 2018 at 10:00 PM Darryl Pogue <dar...@dpogue.ca> wrote: > > Probably late to be asking this question now, but what necessitates a > minor version bump rather than a patch release? I don't think either > of the two items in the changelog add new API to the module or change > behaviour in a consumer-visible way, do they? > > On Tue, Dec 18, 2018 at 7:38 PM Chris Brody <chris.br...@gmail.com> wrote: > > > > to include singleton event object as proposed in > > https://github.com/apache/cordova-common/pull/60 and CordovaLogger > > singleton object, in order that this rule no longer has to apply: > > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#cordova-common-singleton-rule > > > > Does anyone have any reason to delay a tools release? > > > > Any outstanding patches to land? > > > > If not, I will start the release tomorrow. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
