Github user thehuijb commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/80
updated this pull request to the latest version of the apache master, I
still think it would be a valid addition, but if nobody agrees I'll drop it.
---
If your project is set u
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164077925
@Bnaya, thanks for the heads up. Don't know how I missed that, but great
that this issue is finally tackled
---
If your project is set up for it
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164073745
@sebastianor, if you're asking if this pull request solves the issue, yes
it does.
just call the checkForSavedResult method in onDeviceReady t
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/80#issuecomment-154828373
@riknoll, thanks for reviewing this PR
I don't think adding a platform specific option to a plugin is adding a
quirk. I believe that adding pla
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/80#discussion_r44224879
--- Diff: src/android/CameraLauncher.java ---
@@ -270,18 +279,20 @@ public void getImage(int srcType, int returnType, int
encodingType
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-129064021
@stevengill any chance you could review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-129063005
@adamduren thanks for the +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32921498
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +159,19 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32921216
--- Diff: src/android/CameraLauncher.java ---
@@ -173,6 +181,20 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-114052451
## How a cordova camera application works on android
This is basically how a cordova application works:
![image00](https
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113959660
@gregavola, is there any way you could upgrade to the latest cordova or
start using at least cordova-android 4.0.0.
there is a bug in lower versions
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113403640
thanks @dpolivy,
that's exactly the kind of review I was looking to get.
---
If your project is set up for it, you can reply to this emai
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113041333
@stevengill, I would appreciate the review.
@nikhilkh, this API is indeed specific to Android but I don't know what you
mean by "it looks
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/80#issuecomment-104222425
anyone interested in this option?
if so, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/97
CB-8804 implement check for saved result
Android uses intents to launch the camera activity on the device to capture
images, and on phones with low memory, the Cordova activity may
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-104157604
forget about it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-103346345
@agrieve could you please have another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-96914735
Implemented changes based on @agrieve's input, could you have another look?
---
If your project is set up for it, you can reply to this email and
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28956355
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +167,15 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-94953716
alright, rebased to master, should be only my changes now.
sorry about that, it still git's me sometimes
---
If your project is set up for it
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-94649473
Anyone had a chance to look at this yet?
I would appreciate any comments that help improve this PR
---
If your project is set up for it, you can
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/80#issuecomment-94647452
I rebased this pull request to the latest master, anyone care to check it
out?
would really appreciate it
---
If your project is set up for it, you
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/83
solves CB-8804
https://github.com/apache/cordova-plugin-camera#android-quirks
added action checkForSavedResult to be called from javascript in
ondeviceready.
this pull
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/80
feature CB-8777 Add option onlyGalleries
add Android only option to force getting pictures from only gallery type
applications on the device, blocking out remote drives and file
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-android/pull/171#issuecomment-88243999
great, thanks for that, makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27500998
--- Diff: framework/src/org/apache/cordova/CordovaWebViewImpl.java ---
@@ -500,6 +500,7 @@ public void onPageFinishedLoading(String url
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-android/pull/171
solves CB-8768 issue where onActivityResult gets called before onResume
after MainActivity gets killed
situation: one of the plugins launches startActivityForResult and the
Android OS
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-android/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/170#discussion_r27392930
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -314,10 +318,52 @@ public void startActivityForResult(Intent intent, int
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-android/pull/170
solves CB-8768 issue where onActivityResult gets called before onResume
after MainActivity gets killed
if one of the plugins launches startActivityForResult and the Android OS
decides to
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-android/pull/169
add state to outState before calling super
InstanceState was never really saved because super.onSaveInstanceState was
called before any state was added.
this pull request fixes
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/75
add more generic error messages, easier to distinguish in the callback
add more generic error messages, easier to distinguish in the callback
this makes it possible to show your
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/74
add option onlyGalleries to allow user to only select images from gallery
type apps
add option - __onlyGalleries__ : Android-only Allow getImage to only get
from gallery apps
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77273772
reduced the pull request to only fix the
https://issues.apache.org/jira/browse/CB-8235 issue
---
If your project is set up for it, you can reply to this
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77215024
I'll see what I can do
Op wo 4 mrt. 2015 om 17:28 schreef agrieve
> Change looks awesome! It's a bit much to pull in all a
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/65
Fix issue where android cordova app crashes on selecting images from dropbox
Cordova android apps would crash if you picked an image from a remote
system e.g. Drive, OneDrive, Mega
40 matches
Mail list logo
